Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
yiguolei merged PR #60530: URL: https://github.com/apache/doris/pull/60530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
github-actions[bot] commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3864130100 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
github-actions[bot] commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3864130372 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
hello-stephen commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3864123097 # BE Regression && UT Coverage Report Increment line coverage `90.62% (116/128)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60530_f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60530_f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.63% (25885/36135) | | Line Coverage | 54.25% (270457/498545) | | Region Coverage | 51.53% (224383/435481) | | Branch Coverage | 53.06% (96413/181693) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3863736473 # BE UT Coverage Report Increment line coverage `17.19% (22/128)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef_f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef_f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.53% (19370/36872) | | Line Coverage | 36.07% (180255/499773) | | Region Coverage | 32.44% (139843/431095) | | Branch Coverage | 33.45% (60538/180985) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3863603626 ClickBench: Total hot run time: 28.33 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef, data reload: false query1 0.050.050.04 query2 0.090.040.04 query3 0.250.090.09 query4 1.610.110.11 query5 0.260.250.25 query6 1.150.690.68 query7 0.030.020.03 query8 0.050.040.04 query9 0.560.480.49 query10 0.550.540.55 query11 0.140.100.09 query12 0.140.100.10 query13 0.630.610.62 query14 1.071.051.06 query15 0.880.870.88 query16 0.400.400.38 query17 1.131.131.13 query18 0.230.220.21 query19 2.011.962.05 query20 0.020.010.02 query21 15.47 0.270.14 query22 4.970.070.06 query23 15.73 0.300.10 query24 1.030.340.54 query25 0.080.070.09 query26 0.140.130.14 query27 0.100.060.05 query28 4.151.170.96 query29 12.56 3.963.16 query30 0.280.140.11 query31 2.820.620.40 query32 3.240.600.50 query33 3.173.233.28 query34 16.31 5.424.72 query35 4.804.884.80 query36 0.650.520.49 query37 0.110.060.06 query38 0.070.050.04 query39 0.040.020.03 query40 0.190.160.16 query41 0.090.040.03 query42 0.040.030.03 query43 0.040.040.03 Total cold run time: 97.33 s Total hot run time: 28.33 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3863579003 TPC-H: Total hot run time: 30857 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f5a95c95d37b6e3880462b6d6f2acaacfcf9c2ef, data reload: false -- Round 1 -- q1 17641 450642544254 q2 2053347 260 260 q3 10114 1298772 772 q4 10199 774 326 326 q5 7769224119411941 q6 224 179 149 149 q7 903 759 604 604 q8 9278139812061206 q9 4916467146184618 q10 6866194915481548 q11 501 318 296 296 q12 414 377 227 227 q13 17790 405932823282 q14 240 238 217 217 q15 890 801 815 801 q16 675 680 628 628 q17 715 769 566 566 q18 6690582861485828 q19 16061037654 654 q20 535 575 437 437 q21 2736196519931965 q22 379 328 278 278 Total cold run time: 103134 ms Total hot run time: 30857 ms - Round 2, with runtime_filter_mode=off - q1 4667451445444514 q2 282 372 268 268 q3 2381293524922492 q4 1463181614891489 q5 4697472145584558 q6 231 182 141 141 q7 2047191118021802 q8 2787238223962382 q9 7574742074547420 q10 2788298427202720 q11 516 478 436 436 q12 705 784 634 634 q13 3589401232623262 q14 267 287 259 259 q15 827 784 774 774 q16 633 693 645 645 q17 1090128013551280 q18 7620744573957395 q19 815 797 835 797 q20 1986203318671867 q21 4562418141034103 q22 588 525 497 497 Total cold run time: 52115 ms Total hot run time: 49735 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3863418308 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3863405889 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
hello-stephen commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3861595301 # BE Regression && UT Coverage Report Increment line coverage `90.16% (110/122)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60530_1a67c5b9bd45f0da6e527969095a7f5625f3fa8c_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60530_1a67c5b9bd45f0da6e527969095a7f5625f3fa8c_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 73.28% (26480/36135) | | Line Coverage | 56.35% (280906/498545) | | Region Coverage | 53.99% (235119/435471) | | Branch Coverage | 55.66% (101134/181691) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3861105852 # BE UT Coverage Report Increment line coverage `14.75% (18/122)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1a67c5b9bd45f0da6e527969095a7f5625f3fa8c_1a67c5b9bd45f0da6e527969095a7f5625f3fa8c/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1a67c5b9bd45f0da6e527969095a7f5625f3fa8c_1a67c5b9bd45f0da6e527969095a7f5625f3fa8c/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.54% (19373/36872) | | Line Coverage | 36.08% (180322/499773) | | Region Coverage | 32.42% (139779/431085) | | Branch Coverage | 33.46% (60556/180983) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3860734265 ClickBench: Total hot run time: 28.26 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1a67c5b9bd45f0da6e527969095a7f5625f3fa8c, data reload: false query1 0.050.040.04 query2 0.090.040.05 query3 0.250.090.09 query4 1.610.110.11 query5 0.280.250.24 query6 1.160.660.68 query7 0.030.030.03 query8 0.050.040.04 query9 0.570.510.51 query10 0.560.540.54 query11 0.140.100.10 query12 0.140.100.10 query13 0.620.620.63 query14 1.051.031.06 query15 0.870.860.87 query16 0.380.390.40 query17 1.131.141.12 query18 0.230.210.22 query19 2.112.032.08 query20 0.020.020.01 query21 15.39 0.280.16 query22 4.970.060.05 query23 15.84 0.290.10 query24 1.570.340.26 query25 0.120.060.05 query26 0.150.130.14 query27 0.090.050.06 query28 3.101.170.97 query29 12.54 3.883.14 query30 0.270.130.12 query31 2.810.630.40 query32 3.240.590.50 query33 3.203.213.21 query34 16.17 5.364.68 query35 4.824.804.81 query36 0.650.490.50 query37 0.110.080.06 query38 0.080.050.04 query39 0.050.030.03 query40 0.200.160.16 query41 0.080.040.03 query42 0.050.030.03 query43 0.040.040.03 Total cold run time: 96.88 s Total hot run time: 28.26 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3860656344 TPC-H: Total hot run time: 30216 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1a67c5b9bd45f0da6e527969095a7f5625f3fa8c, data reload: false -- Round 1 -- q1 17606 446743224322 q2 2025391 236 236 q3 10128 1325733 733 q4 10285 778 308 308 q5 8883224719161916 q6 241 177 147 147 q7 898 740 620 620 q8 9267136711391139 q9 4751466246924662 q10 6881195115391539 q11 544 308 293 293 q12 398 374 223 223 q13 17832 411032313231 q14 242 242 217 217 q15 908 824 812 812 q16 683 675 626 626 q17 970 881 447 447 q18 6570575356775677 q19 1433996 599 599 q20 504 485 390 390 q21 2535180917951795 q22 367 321 284 284 Total cold run time: 103951 ms Total hot run time: 30216 ms - Round 2, with runtime_filter_mode=off - q1 4421438643694369 q2 276 351 250 250 q3 2115268122372237 q4 1381174512841284 q5 4249417042024170 q6 216 180 137 137 q7 1830178616831683 q8 2848253525482535 q9 7462753474997499 q10 2938298626702670 q11 552 502 441 441 q12 673 733 649 649 q13 3949429435563556 q14 279 309 274 274 q15 872 800 794 794 q16 671 729 720 720 q17 1129137713681368 q18 8231788880397888 q19 865 954 865 865 q20 2086212020022002 q21 4838459341284128 q22 574 557 523 523 Total cold run time: 52455 ms Total hot run time: 50042 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3860061845 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3860057735 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
hello-stephen commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3859691653 # BE Regression && UT Coverage Report Increment line coverage `92.41% (73/79)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60530_1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60530_1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.71% (25912/36133) | | Line Coverage | 54.30% (270707/498516) | | Region Coverage | 51.61% (224722/435457) | | Branch Coverage | 53.17% (96610/181685) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3859124781 # BE UT Coverage Report Increment line coverage `16.46% (13/79)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a_1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a_1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.54% (19373/36870) | | Line Coverage | 36.08% (180305/499744) | | Region Coverage | 32.43% (139783/431071) | | Branch Coverage | 33.46% (60555/180977) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
yiguolei commented on code in PR #60530:
URL: https://github.com/apache/doris/pull/60530#discussion_r2773068507
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -2106,139 +2065,40 @@ Status DefaultValueColumnIterator::init(const
ColumnIteratorOptions& opts) {
// "NULL" is a special default value which means the default value is null.
if (_has_default_value) {
if (_default_value == "NULL") {
-_is_default_value_null = true;
+_default_value_field =
vectorized::Field::create_field(vectorized::Null {});
} else {
-_type_size = _type_info->size();
-_mem_value.resize(_type_size);
-Status s = Status::OK();
-// If char length is 10, but default value is 'a' , it's length is
1
-// not fill 0 to the ending, because segment iterator will shrink
the tail 0 char
-if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_VARCHAR ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_HLL ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_BITMAP ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_STRING ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_CHAR) {
-((Slice*)_mem_value.data())->size = _default_value.length();
-((Slice*)_mem_value.data())->data = _default_value.data();
-} else if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_ARRAY)
{
+if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_ARRAY) {
if (_default_value != "[]") {
return Status::NotSupported("Array default {} is
unsupported", _default_value);
} else {
-((Slice*)_mem_value.data())->size =
_default_value.length();
-((Slice*)_mem_value.data())->data = _default_value.data();
+_default_value_field =
+
vectorized::Field::create_field(vectorized::Array {});
+return Status::OK();
}
} else if (_type_info->type() ==
FieldType::OLAP_FIELD_TYPE_STRUCT) {
Review Comment:
compaction diable
table col1， col2
insert 1 1
alter table add column col3 char(10) default 'a'
insert 1,1,'b'
select * from table where col3 == 'a'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3858941558 ClickBench: Total hot run time: 28.56 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a, data reload: false query1 0.060.050.05 query2 0.100.050.05 query3 0.250.080.09 query4 1.610.110.11 query5 0.270.250.24 query6 1.170.670.68 query7 0.040.020.03 query8 0.060.040.03 query9 0.560.490.49 query10 0.550.540.56 query11 0.130.090.10 query12 0.140.100.10 query13 0.630.620.61 query14 1.091.041.05 query15 0.870.860.86 query16 0.400.390.39 query17 1.101.141.12 query18 0.220.210.21 query19 2.062.012.04 query20 0.020.010.01 query21 15.40 0.260.15 query22 5.280.060.05 query23 16.06 0.280.11 query24 1.441.390.64 query25 0.100.080.05 query26 0.140.140.13 query27 0.060.070.06 query28 4.731.150.96 query29 12.58 3.933.16 query30 0.290.130.11 query31 2.830.640.40 query32 3.240.600.50 query33 3.203.183.26 query34 16.10 5.404.71 query35 4.804.824.75 query36 0.650.500.49 query37 0.120.070.07 query38 0.080.040.04 query39 0.050.030.03 query40 0.190.160.17 query41 0.090.030.03 query42 0.050.030.03 query43 0.050.040.03 Total cold run time: 98.86 s Total hot run time: 28.56 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3858862887 TPC-H: Total hot run time: 30150 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1da48c8f59e2eff7bb3ac2ddc527bbe3ef045a8a, data reload: false -- Round 1 -- q1 17641 450343274327 q2 2078333 229 229 q3 10182 1259722 722 q4 10190 769 309 309 q5 7526214019111911 q6 197 180 147 147 q7 870 723 593 593 q8 9266133611171117 q9 4649461545184518 q10 6796194315501550 q11 494 325 281 281 q12 329 370 218 218 q13 17803 402831883188 q14 229 233 213 213 q15 883 830 795 795 q16 675 670 627 627 q17 689 758 572 572 q18 6486581859005818 q19 1254968 617 617 q20 494 487 380 380 q21 2465181717381738 q22 349 320 280 280 Total cold run time: 101545 ms Total hot run time: 30150 ms - Round 2, with runtime_filter_mode=off - q1 4330435843604358 q2 259 334 244 244 q3 2053267822912291 q4 1321172413001300 q5 4295431444724314 q6 201 172 135 135 q7 1822177716181618 q8 2432255725522552 q9 7543736975917369 q10 2877305825742574 q11 533 467 476 467 q12 721 755 611 611 q13 3910429436603660 q14 405 329 294 294 q15 869 788 916 788 q16 804 726 684 684 q17 1134133214101332 q18 8305790876887688 q19 854 816 841 816 q20 2224217519811981 q21 4823458642954295 q22 599 608 511 511 Total cold run time: 52314 ms Total hot run time: 49882 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3858727062 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3858434234 ClickBench: Total hot run time: 28.68 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 11361bc43588a84daf2be150f6d33ecd045fef26, data reload: false query1 0.060.050.06 query2 0.100.050.05 query3 0.270.090.09 query4 1.610.120.12 query5 0.280.260.25 query6 1.180.680.67 query7 0.040.030.03 query8 0.060.050.04 query9 0.560.500.49 query10 0.550.550.56 query11 0.150.100.10 query12 0.150.110.11 query13 0.630.620.62 query14 1.061.071.08 query15 0.880.870.88 query16 0.410.390.40 query17 1.151.111.11 query18 0.230.210.22 query19 2.102.012.05 query20 0.020.020.02 query21 15.39 0.270.15 query22 5.170.060.07 query23 15.88 0.300.12 query24 1.440.500.49 query25 0.120.070.05 query26 0.140.130.14 query27 0.060.070.07 query28 3.881.150.97 query29 12.55 3.963.18 query30 0.310.160.14 query31 2.820.670.41 query32 3.240.610.49 query33 3.273.183.26 query34 16.10 5.394.70 query35 4.814.804.81 query36 0.650.510.49 query37 0.120.070.06 query38 0.080.050.05 query39 0.040.030.03 query40 0.210.170.16 query41 0.090.040.04 query42 0.050.030.03 query43 0.040.040.03 Total cold run time: 97.95 s Total hot run time: 28.68 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3858383215 TPC-H: Total hot run time: 31008 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 11361bc43588a84daf2be150f6d33ecd045fef26, data reload: false -- Round 1 -- q1 17606 440342754275 q2 2045349 233 233 q3 10172 1339771 771 q4 10216 793 318 318 q5 8068220819431943 q6 249 177 144 144 q7 905 750 600 600 q8 9271138813051305 q9 4827464746794647 q10 6889194315681568 q11 530 316 294 294 q12 395 374 225 225 q13 17786 413932573257 q14 243 236 219 219 q15 892 809 806 806 q16 670 678 613 613 q17 948 883 467 467 q18 7196594665625946 q19 15731032686 686 q20 593 583 402 402 q21 2780202919861986 q22 373 341 303 303 Total cold run time: 104227 ms Total hot run time: 31008 ms - Round 2, with runtime_filter_mode=off - q1 4755455745654557 q2 269 360 261 261 q3 2327287624012401 q4 1577186714801480 q5 4749465144934493 q6 231 182 135 135 q7 1944186717791779 q8 2570238723532353 q9 7460764376627643 q10 2834310426742674 q11 530 456 451 451 q12 645 696 545 545 q13 3554404532293229 q14 276 302 261 261 q15 818 819 792 792 q16 652 694 649 649 q17 1090133213121312 q18 7665727272957272 q19 853 805 800 800 q20 1931206618821882 q21 4555425141144114 q22 551 530 500 500 Total cold run time: 51836 ms Total hot run time: 49583 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3857968158 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3857922200 TPC-H: Total hot run time: 31351 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2e5a5c16e841cf9cfb237bfc40c444786df11e07, data reload: false -- Round 1 -- q1 17609 437942764276 q2 2031350 261 261 q3 10107 1294716 716 q4 10215 901 328 328 q5 7514219318991899 q6 194 179 149 149 q7 889 720 584 584 q8 9254137411601160 q9 5383483848084808 q10 6848193415651565 q11 515 283 282 282 q12 358 377 224 224 q13 17830 409433033303 q14 248 244 218 218 q15 895 806 806 806 q16 684 702 624 624 q17 653 834 456 456 q18 7002653574506535 q19 12251037693 693 q20 432 397 265 265 q21 2919231619051905 q22 408 324 294 294 Total cold run time: 103213 ms Total hot run time: 31351 ms - Round 2, with runtime_filter_mode=off - q1 4543462046794620 q2 312 344 246 246 q3 2273287723602360 q4 1456185514361436 q5 4544458246654582 q6 230 179 138 138 q7 1982206917251725 q8 2583241024302410 q9 7494757574587458 q10 2897311627052705 q11 543 463 451 451 q12 688 706 598 598 q13 3861429235393539 q14 296 307 343 307 q15 916 812 799 799 q16 666 707 676 676 q17 1085129113111291 q18 7295739672537253 q19 828 814 827 814 q20 1962202218601860 q21 4554417641324132 q22 609 554 500 500 Total cold run time: 51617 ms Total hot run time: 49900 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3857666304 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3852546032 ClickBench: Total hot run time: 28.21 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit fa4318de3192a43d3efbce60f25bf04226134e20, data reload: false query1 0.050.040.05 query2 0.100.040.04 query3 0.250.090.09 query4 1.610.120.11 query5 0.280.260.25 query6 1.180.690.68 query7 0.030.020.02 query8 0.060.040.04 query9 0.570.500.50 query10 0.560.540.55 query11 0.150.090.10 query12 0.140.100.10 query13 0.630.630.62 query14 1.061.061.08 query15 0.880.860.86 query16 0.440.390.39 query17 1.121.111.15 query18 0.220.220.21 query19 2.122.002.02 query20 0.020.020.01 query21 15.41 0.250.15 query22 5.000.060.05 query23 15.71 0.290.11 query24 1.160.380.19 query25 0.100.080.06 query26 0.150.130.13 query27 0.080.090.05 query28 3.471.150.96 query29 12.58 3.883.14 query30 0.280.140.12 query31 2.820.640.40 query32 3.240.600.51 query33 3.313.303.22 query34 16.48 5.384.73 query35 4.824.844.75 query36 0.660.500.49 query37 0.110.070.06 query38 0.070.040.04 query39 0.040.030.03 query40 0.200.160.16 query41 0.090.040.04 query42 0.040.030.03 query43 0.040.030.04 Total cold run time: 97.33 s Total hot run time: 28.21 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
doris-robot commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3852433307 TPC-H: Total hot run time: 31324 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit fa4318de3192a43d3efbce60f25bf04226134e20, data reload: false -- Round 1 -- q1 17674 449743154315 q2 2050398 230 230 q3 10087 1331768 768 q4 10205 812 329 329 q5 7520221419111911 q6 217 185 146 146 q7 889 738 581 581 q8 9272146511351135 q9 5673489848184818 q10 6872195615571557 q11 510 293 292 292 q12 403 373 224 224 q13 17787 411832653265 q14 232 231 213 213 q15 900 839 800 800 q16 688 670 622 622 q17 647 759 533 533 q18 7412672066376637 q19 14601010623 623 q20 376 350 238 238 q21 2723213218131813 q22 362 322 274 274 Total cold run time: 103959 ms Total hot run time: 31324 ms - Round 2, with runtime_filter_mode=off - q1 4414432943524329 q2 268 329 248 248 q3 2126261622742274 q4 1347172012881288 q5 4267416842684168 q6 218 183 139 139 q7 1829180821771808 q8 2637251225262512 q9 7533754975667549 q10 2949299526052605 q11 555 468 454 454 q12 675 820 587 587 q13 3921450935613561 q14 297 301 292 292 q15 855 835 824 824 q16 670 767 833 767 q17 1164137913481348 q18 8111809180488048 q19 931 882 854 854 q20 2084211319861986 q21 4724451743904390 q22 613 583 508 508 Total cold run time: 52188 ms Total hot run time: 50539 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
yiguolei commented on code in PR #60530:
URL: https://github.com/apache/doris/pull/60530#discussion_r2767681092
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -2106,139 +2065,42 @@ Status DefaultValueColumnIterator::init(const
ColumnIteratorOptions& opts) {
// "NULL" is a special default value which means the default value is null.
if (_has_default_value) {
if (_default_value == "NULL") {
-_is_default_value_null = true;
+_default_value_field =
vectorized::Field::create_field(vectorized::Null {});
} else {
-_type_size = _type_info->size();
-_mem_value.resize(_type_size);
-Status s = Status::OK();
-// If char length is 10, but default value is 'a' , it's length is
1
-// not fill 0 to the ending, because segment iterator will shrink
the tail 0 char
-if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_VARCHAR ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_HLL ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_BITMAP ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_STRING ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_CHAR) {
-((Slice*)_mem_value.data())->size = _default_value.length();
-((Slice*)_mem_value.data())->data = _default_value.data();
-} else if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_ARRAY)
{
-if (_default_value != "[]") {
-return Status::NotSupported("Array default {} is
unsupported", _default_value);
-} else {
-((Slice*)_mem_value.data())->size =
_default_value.length();
-((Slice*)_mem_value.data())->data = _default_value.data();
-}
+if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_ARRAY &&
_default_value != "[]") {
+return Status::NotSupported("Array default {} is unsupported",
_default_value);
} else if (_type_info->type() ==
FieldType::OLAP_FIELD_TYPE_STRUCT) {
return Status::NotSupported("STRUCT default type is
unsupported");
} else if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_MAP) {
return Status::NotSupported("MAP default type is unsupported");
-} else {
-s = _type_info->from_string(_mem_value.data(), _default_value,
_precision, _scale);
-}
-if (!s.ok()) {
-return s;
}
+const auto t = _type_info->type();
+const auto serde = vectorized::DataTypeFactory::instance()
Review Comment:
// If char length is 10, but default value is 'a' , it's length is 1
// not fill 0 to the ending, because segment iterator will
shrink the tail 0 char
原来的注释得保留。
不过这里我有一个疑问，为什么这里不加 padding 呢？ 如果我add new column 有default 值是char
类型，此时我再发送一个查询，带新增这个列作为where 条件，此时predicate 有padding，但是default
生成的列没有padding，感觉就不对了
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -2106,139 +2065,42 @@ Status DefaultValueColumnIterator::init(const
ColumnIteratorOptions& opts) {
// "NULL" is a special default value which means the default value is null.
if (_has_default_value) {
if (_default_value == "NULL") {
-_is_default_value_null = true;
+_default_value_field =
vectorized::Field::create_field(vectorized::Null {});
} else {
-_type_size = _type_info->size();
-_mem_value.resize(_type_size);
-Status s = Status::OK();
-// If char length is 10, but default value is 'a' , it's length is
1
-// not fill 0 to the ending, because segment iterator will shrink
the tail 0 char
-if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_VARCHAR ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_HLL ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_BITMAP ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_STRING ||
-_type_info->type() == FieldType::OLAP_FIELD_TYPE_CHAR) {
-((Slice*)_mem_value.data())->size = _default_value.length();
-((Slice*)_mem_value.data())->data = _default_value.data();
-} else if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_ARRAY)
{
-if (_default_value != "[]") {
-return Status::NotSupported("Array default {} is
unsupported", _default_value);
-} else {
-((Slice*)_mem_value.data())->size =
_default_value.length();
-((Slice*)_mem_value.data())->data = _default_value.data();
-}
+if (_type_info->type() == FieldType::OLAP_FIELD_TYPE_ARRAY &&
_default_value != "[]") {
+return Status::NotSupported("Arr
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3851757279 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
Gabriel39 commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3851485192 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](test) Remove wrapper_field dependency from unit tests [doris]
hello-stephen commented on PR #60530: URL: https://github.com/apache/doris/pull/60530#issuecomment-3851479238 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
