Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
zzzxl1993 merged PR #60537: URL: https://github.com/apache/doris/pull/60537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
github-actions[bot] commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3857554088 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
github-actions[bot] commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3857554291 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
hello-stephen commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3854284858 # BE Regression && UT Coverage Report Increment line coverage `100.00% (4/4)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60537_3015bedd3edf3c04f3397574a962e697877597d1_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60537_3015bedd3edf3c04f3397574a962e697877597d1_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.64% (25880/36124) | | Line Coverage | 54.28% (270363/498092) | | Region Coverage | 51.71% (224876/434878) | | Branch Coverage | 53.20% (96603/181570) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
hello-stephen commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3853492620 # BE Regression && UT Coverage Report Increment line coverage `100.00% (4/4)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60537_3015bedd3edf3c04f3397574a962e697877597d1_merge/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60537_3015bedd3edf3c04f3397574a962e697877597d1_merge/report/index.html) | Category | Coverage | |---|| | Function Coverage | 71.64% (25879/36124) | | Line Coverage | 54.28% (270360/498092) | | Region Coverage | 51.71% (224855/434878) | | Branch Coverage | 53.20% (96596/181570) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
hello-stephen commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3853288206 # BE UT Coverage Report Increment line coverage `100.00% (4/4)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/3015bedd3edf3c04f3397574a962e697877597d1_3015bedd3edf3c04f3397574a962e697877597d1/increment_report/index.html) [Complete coverage report](http://coverage.selectdb-in.cc/coverage/3015bedd3edf3c04f3397574a962e697877597d1_3015bedd3edf3c04f3397574a962e697877597d1/report/index.html) | Category | Coverage | |---|| | Function Coverage | 52.59% (19385/36861) | | Line Coverage | 36.06% (180062/499280) | | Region Coverage | 32.44% (139635/430460) | | Branch Coverage | 33.43% (60454/180838) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
doris-robot commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3852941623 ClickBench: Total hot run time: 28.3 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3015bedd3edf3c04f3397574a962e697877597d1, data reload: false query1 0.050.040.04 query2 0.100.050.05 query3 0.250.080.08 query4 1.610.100.10 query5 0.260.240.26 query6 1.170.700.68 query7 0.030.020.03 query8 0.050.040.04 query9 0.590.500.51 query10 0.540.550.55 query11 0.130.100.09 query12 0.150.100.10 query13 0.640.620.61 query14 1.061.051.06 query15 0.880.860.87 query16 0.410.390.40 query17 1.111.141.13 query18 0.220.220.21 query19 2.132.012.04 query20 0.020.010.02 query21 15.42 0.260.15 query22 5.080.060.05 query23 15.86 0.280.11 query24 1.570.290.19 query25 0.110.060.05 query26 0.150.130.13 query27 0.050.050.05 query28 3.961.150.97 query29 12.59 3.893.21 query30 0.280.140.12 query31 2.810.630.40 query32 3.250.590.51 query33 3.233.293.22 query34 16.13 5.384.76 query35 4.804.794.74 query36 0.660.500.50 query37 0.110.070.07 query38 0.070.040.04 query39 0.050.030.03 query40 0.200.170.15 query41 0.100.030.02 query42 0.040.040.04 query43 0.040.030.04 Total cold run time: 97.96 s Total hot run time: 28.3 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
doris-robot commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3852815613 TPC-H: Total hot run time: 31091 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3015bedd3edf3c04f3397574a962e697877597d1, data reload: false -- Round 1 -- q1 17651 440742784278 q2 2020378 229 229 q3 10117 1295735 735 q4 10194 804 314 314 q5 7840221919111911 q6 228 174 145 145 q7 880 725 608 608 q8 9275139610521052 q9 5337484448164816 q10 6893197815681568 q11 524 293 303 293 q12 401 381 222 222 q13 17780 408032583258 q14 245 242 216 216 q15 921 827 804 804 q16 687 670 624 624 q17 650 763 562 562 q18 6911645064996450 q19 15121007632 632 q20 389 365 245 245 q21 2681203418521852 q22 357 322 277 277 Total cold run time: 103493 ms Total hot run time: 31091 ms - Round 2, with runtime_filter_mode=off - q1 4521434843504348 q2 258 336 255 255 q3 2126261022192219 q4 1375175913231323 q5 4334423843824238 q6 214 182 140 140 q7 1823181019281810 q8 2708252125142514 q9 7682755776657557 q10 2907304926642664 q11 576 499 455 455 q12 702 778 590 590 q13 3875442937083708 q14 291 328 284 284 q15 891 805 811 805 q16 686 707 697 697 q17 1123149014631463 q18 8385797377357735 q19 910 908 860 860 q20 2104212820122012 q21 4991429041324132 q22 591 554 502 502 Total cold run time: 53073 ms Total hot run time: 50311 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
zzzxl1993 commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3852078868 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [fix](topn) fix AcceptNullPredicate adding back all null rows instead of only those in original bitmap [doris]
Thearas commented on PR #60537: URL: https://github.com/apache/doris/pull/60537#issuecomment-3852065633 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
