subject:"Re\: \[PR\] \[fix\]\(variant\) fix the reading core caused by inserting nested column and scalar column in variant sub\-column \[doris\]"

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



eldenmoon merged PR #53083:
URL: https://github.com/apache/doris/pull/53083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3111875816

   # BE Regression && UT Coverage Report
   Increment line coverage `87.83% (101/115)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.13% (22060/27191) |
   | Line Coverage | 73.75% (227667/308710) |
   | Region Coverage   | 61.34% (189834/309480) |
   | Branch Coverage   | 65.11% (81892/125783) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



github-actions[bot] commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3111707980

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



github-actions[bot] commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3111707673

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3111707174

   run nonConcurrent


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3109771324

   # BE Regression && UT Coverage Report
   Increment line coverage `87.83% (101/115)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.13% (22061/27191) |
   | Line Coverage | 73.75% (227670/308710) |
   | Region Coverage   | 61.34% (189821/309480) |
   | Branch Coverage   | 65.10% (81891/125783) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3109326790

   # BE Regression && UT Coverage Report
   Increment line coverage `87.83% (101/115)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.13% (22059/27191) |
   | Line Coverage | 73.74% (227648/308710) |
   | Region Coverage   | 61.33% (189790/309480) |
   | Branch Coverage   | 65.10% (81887/125783) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3109213658

   # BE UT Coverage Report
   Increment line coverage `60.87% (70/115)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/4bb7de4cec7bc58b3a20875f9f69a430652e02cc_4bb7de4cec7bc58b3a20875f9f69a430652e02cc/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/4bb7de4cec7bc58b3a20875f9f69a430652e02cc_4bb7de4cec7bc58b3a20875f9f69a430652e02cc/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.55% (15945/27705) |
   | Line Coverage | 46.36% (143324/309181) |
   | Region Coverage   | 35.78% (107970/301758) |
   | Branch Coverage   | 38.32% (47664/124395) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3109076820

   
   
   ClickBench: Total hot run time: 33.36 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 4bb7de4cec7bc58b3a20875f9f69a430652e02cc, 
data reload: false
   
   query1   0.040.030.04
   query2   0.110.050.06
   query3   0.300.060.06
   query4   1.590.070.08
   query5   0.430.410.40
   query6   1.160.640.67
   query7   0.020.020.02
   query8   0.070.050.05
   query9   0.650.530.52
   query10  0.580.590.58
   query11  0.250.130.13
   query12  0.250.140.13
   query13  0.650.620.63
   query14  0.820.840.84
   query15  0.970.880.89
   query16  0.390.390.38
   query17  1.061.041.03
   query18  0.230.220.23
   query19  2.021.861.91
   query20  0.020.010.02
   query21  15.37   0.990.68
   query22  0.931.120.94
   query23  14.71   1.560.79
   query24  5.100.600.31
   query25  0.170.090.09
   query26  0.560.230.20
   query27  0.090.090.08
   query28  11.08   1.220.57
   query29  12.53   4.023.37
   query30  3.143.052.98
   query31  2.820.610.42
   query32  3.230.640.51
   query33  3.043.193.10
   query34  16.27   5.484.74
   query35  4.824.854.93
   query36  0.640.520.51
   query37  0.200.180.19
   query38  0.180.180.16
   query39  0.060.050.04
   query40  0.200.170.16
   query41  0.100.060.05
   query42  0.060.060.06
   query43  0.050.050.05
   Total cold run time: 106.96 s
   Total hot run time: 33.36 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3109054781

   
   
   TPC-DS: Total hot run time: 186821 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 4bb7de4cec7bc58b3a20875f9f69a430652e02cc, 
data reload: false
   
   query1   977 407 401 401
   query2   6520173917881739
   query3   6741227 220 220
   query4   26387   23307   23134   23134
   query5   4399617 496 496
   query6   310 224 214 214
   query7   4627502 295 295
   query8   289 229 230 229
   query9   8597287628842876
   query10  504 334 290 290
   query11  15747   15062   14809   14809
   query12  164 109 114 109
   query13  1645521 391 391
   query14  9268584858125812
   query15  212 195 165 165
   query16  7327615 461 461
   query17  1182706 582 582
   query18  1971410 304 304
   query19  189 184 172 172
   query20  129 119 116 116
   query21  220 128 116 116
   query22  4046419839623962
   query23  33784   33139   33062   33062
   query24  8162242323582358
   query25  550 473 397 397
   query26  1234264 156 156
   query27  2760499 348 348
   query28  4376218821662166
   query29  747 563 444 444
   query30  293 217 195 195
   query31  935 832 757 757
   query32  81  86  68  68
   query33  557 377 333 333
   query34  793 850 541 541
   query35  770 804 737 737
   query36  952 985 907 907
   query37  122 120 88  88
   query38  4126417840224022
   query39  1486142113861386
   query40  224 124 115 115
   query41  63  59  54  54
   query42  122 115 111 111
   query43  511 505 476 476
   query44  1330860 882 860
   query45  183 170 168 168
   query46  840 1046642 642
   query47  1777182817571757
   query48  403 439 349 349
   query49  727 477 381 381
   query50  639 694 410 410
   query51  5452539053965390
   query52  112 111 103 103
   query53  237 265 193 193
   query54  593 583 522 522
   query55  89  87  90  87
   query56  314 326 309 309
   query57  1186119111091109
   query58  276 267 277 267
   query59  2711283326012601
   query60  365 355 326 326
   query61  130 122 150 122
   query62  819 721 647 647
   query63  234 202 201 201
   query64  44141080780 780
   query65  4278414841724148
   query66  1148439 360 360
   query67  15859   15484   15277   15277
   query68  7948907 573 573
   query69  488 322 301 301
   query70  1211117710711071
   query71  440 386 314 314
   query72  5561465244344434
   query73  638 649 354 354
   query74  8865902089238923
   query75  3758309326462646
   query76  33941127794 794
   query77  787 388 322 322
   query78  990910158   92479247
   query79  4459821 588 588
   query80  646 529 478 478
   query81  462 265 224 224
   query82  584 136 110 110
   query83  290 243 236 236
   query84  294 101 85  85
   query85  777 360 317 317
   query86  340 312 294 294
   query87  4335444142754275
   query88  3177226922742269
   query89  448 315 278 278
   query90  1965227 227 227
   query91  141 138 108 108
   query92  85  73  66  66
   query93  2453964 629 629
   query94  687 386 302 302
   query95  395 314 303 303
   query96  483 582 282 282
   query97  2710276226362636
   query98  242 223 220 220
   query99  1445141812921292
   Total cold run time: 277632 ms
   Total hot run time: 186821 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3109014876

   
   
   TPC-H: Total hot run time: 33687 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 4bb7de4cec7bc58b3a20875f9f69a430652e02cc, 
data reload: false
   
   -- Round 1 --
   q1   17647   519750765076
   q2   1935282 175 175
   q3   10626   1272715 715
   q4   10327   1008510 510
   q5   9059237422952295
   q6   195 159 126 126
   q7   884 748 597 597
   q8   9327130010601060
   q9   7590502351035023
   q10  6888235819611961
   q11  477 296 267 267
   q12  336 353 220 220
   q13  17771   370930613061
   q14  231 225 220 220
   q15  559 491 477 477
   q16  416 414 386 386
   q17  600 856 383 383
   q18  7381726370397039
   q19  1076949 561 561
   q20  341 354 228 228
   q21  3688310323602360
   q22  10321008947 947
   Total cold run time: 108386 ms
   Total hot run time: 33687 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5132510150995099
   q2   247 321 223 223
   q3   2204264823112311
   q4   1337178513041304
   q5   4271447145574471
   q6   217 168 128 128
   q7   2059191417881788
   q8   2680262825552555
   q9   7372724174337241
   q10  3084324930583058
   q11  582 533 493 493
   q12  694 784 650 650
   q13  3583406333013301
   q14  279 298 291 291
   q15  522 481 448 448
   q16  441 478 473 473
   q17  1208178813971397
   q18  8023764175267526
   q19  842 821 968 821
   q20  1938199517971797
   q21  4719431741784178
   q22  10871030998 998
   Total cold run time: 52521 ms
   Total hot run time: 50551 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3108859378

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/4bb7de4cec7bc58b3a20875f9f69a430652e02cc_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/4bb7de4cec7bc58b3a20875f9f69a430652e02cc_4bb7de4cec7bc58b3a20875f9f69a430652e02cc_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.42% (1302/1619) |
   | Line Coverage | 65.77% (21797/33140) |
   | Region Coverage   | 67.05% (10948/16328) |
   | Branch Coverage   | 56.64% (5764/10176) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3108820601

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3108576331

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/0bcbe58d46ac730dbae88c0457a0943f3ab2d152_0bcbe58d46ac730dbae88c0457a0943f3ab2d152_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/0bcbe58d46ac730dbae88c0457a0943f3ab2d152_0bcbe58d46ac730dbae88c0457a0943f3ab2d152_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.42% (1302/1619) |
   | Line Coverage | 65.80% (21807/33140) |
   | Region Coverage   | 67.12% (10960/16328) |
   | Branch Coverage   | 56.65% (5765/10176) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3108348953

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



amorynan commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2225591489


##
be/src/cloud/schema_cloud_dictionary_cache.cpp:
##
@@ -86,7 +108,8 @@ Status process_dictionary(SchemaCloudDictionary& dict,
   const google::protobuf::RepeatedPtrField& 
items,
   const std::function& filter,
   const std::function& add_dict_key_fn,
-  RowsetMetaCloudPB* rowset_meta) {
+  RowsetMetaCloudPB* rowset_meta,
+  bool enable_variant_flatten_nested = false) {

Review Comment:
   done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2225488853


##
be/src/cloud/schema_cloud_dictionary_cache.cpp:
##
@@ -86,7 +108,8 @@ Status process_dictionary(SchemaCloudDictionary& dict,
   const google::protobuf::RepeatedPtrField& 
items,
   const std::function& filter,
   const std::function& add_dict_key_fn,
-  RowsetMetaCloudPB* rowset_meta) {
+  RowsetMetaCloudPB* rowset_meta,
+  bool enable_variant_flatten_nested = false) {

Review Comment:
   the flag is not used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-23 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3106544890

   run compile


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3105643417

   # FE UT Coverage Report
   Increment line coverage `  33.33% (2/6)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_ef44836a599ce25752e991cd49424a485ac21bc4/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_ef44836a599ce25752e991cd49424a485ac21bc4/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3105518112

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3105469608

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/ef44836a599ce25752e991cd49424a485ac21bc4_ef44836a599ce25752e991cd49424a485ac21bc4_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/ef44836a599ce25752e991cd49424a485ac21bc4_ef44836a599ce25752e991cd49424a485ac21bc4_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.42% (1302/1619) |
   | Line Coverage | 65.80% (21807/33140) |
   | Region Coverage   | 67.08% (10953/16328) |
   | Branch Coverage   | 56.68% (5768/10176) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3105395769

   run cloud_p0 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3103215142

   
   
   ClickBench: Total hot run time: 33.35 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit ef44836a599ce25752e991cd49424a485ac21bc4, 
data reload: false
   
   query1   0.040.030.02
   query2   0.110.060.05
   query3   0.290.070.07
   query4   1.600.090.09
   query5   0.430.400.40
   query6   1.160.660.65
   query7   0.030.020.02
   query8   0.070.050.05
   query9   0.670.520.53
   query10  0.590.600.58
   query11  0.260.140.14
   query12  0.250.140.13
   query13  0.640.630.63
   query14  0.800.840.84
   query15  0.980.890.89
   query16  0.380.380.38
   query17  1.041.071.05
   query18  0.240.210.22
   query19  1.951.831.84
   query20  0.010.020.01
   query21  15.36   0.990.66
   query22  0.931.110.90
   query23  14.69   1.510.80
   query24  5.300.560.32
   query25  0.170.100.08
   query26  0.550.220.18
   query27  0.090.090.08
   query28  11.10   1.150.56
   query29  12.56   4.193.41
   query30  3.123.043.01
   query31  2.820.630.42
   query32  3.240.610.51
   query33  3.103.123.27
   query34  16.64   5.414.73
   query35  4.844.864.81
   query36  0.630.510.50
   query37  0.210.190.18
   query38  0.170.160.16
   query39  0.050.040.05
   query40  0.200.170.17
   query41  0.100.060.05
   query42  0.050.050.05
   query43  0.050.060.05
   Total cold run time: 107.51 s
   Total hot run time: 33.35 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3103190083

   
   
   TPC-DS: Total hot run time: 187006 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit ef44836a599ce25752e991cd49424a485ac21bc4, 
data reload: false
   
   query1   984 387 404 387
   query2   6500166316421642
   query3   6744219 224 219
   query4   26550   23534   22985   22985
   query5   4342605 485 485
   query6   320 215 201 201
   query7   4636503 286 286
   query8   269 241 226 226
   query9   8579288028742874
   query10  447 334 280 280
   query11  15792   15003   15136   15003
   query12  165 119 116 116
   query13  1655516 406 406
   query14  9502589158855885
   query15  197 183 166 166
   query16  7468644 459 459
   query17  1196700 568 568
   query18  2002404 320 320
   query19  193 188 160 160
   query20  123 137 110 110
   query21  208 119 109 109
   query22  4164429140334033
   query23  34058   33017   32896   32896
   query24  8137238423562356
   query25  522 469 391 391
   query26  1241273 155 155
   query27  2755506 348 348
   query28  4320219421712171
   query29  737 563 446 446
   query30  286 221 184 184
   query31  953 806 742 742
   query32  87  74  76  74
   query33  532 361 329 329
   query34  798 845 515 515
   query35  813 819 737 737
   query36  967 992 902 902
   query37  123 98  82  82
   query38  4148413140634063
   query39  1479141614151415
   query40  223 124 114 114
   query41  63  56  55  55
   query42  118 112 115 112
   query43  491 487 465 465
   query44  1329846 852 846
   query45  177 167 164 164
   query46  848 996 635 635
   query47  1758184217511751
   query48  389 428 308 308
   query49  730 473 385 385
   query50  633 682 419 419
   query51  5514550254665466
   query52  111 115 100 100
   query53  231 255 186 186
   query54  581 585 529 529
   query55  92  85  90  85
   query56  318 310 301 301
   query57  1213121011571157
   query58  285 264 264 264
   query59  2526267624972497
   query60  359 343 362 343
   query61  166 153 152 152
   query62  800 727 666 666
   query63  230 204 201 201
   query64  44131134691 691
   query65  4253417941484148
   query66  1094436 338 338
   query67  15733   15680   15457   15457
   query68  8519898 561 561
   query69  476 312 286 286
   query70  1226116711091109
   query71  462 323 306 306
   query72  5754477349044773
   query73  762 674 357 357
   query74  8892902089398939
   query75  3992310827072707
   query76  37131131706 706
   query77  793 387 319 319
   query78  10065   997592619261
   query79  5710807 562 562
   query80  666 536 469 469
   query81  475 255 219 219
   query82  727 137 107 107
   query83  287 251 242 242
   query84  292 103 86  86
   query85  778 359 318 318
   query86  341 334 302 302
   query87  4376444042944294
   query88  2891223022402230
   query89  463 321 282 282
   query90  1960226 222 222
   query91  140 140 107 107
   query92  88  70  63  63
   query93  3162978 613 613
   query94  674 389 300 300
   query95  391 329 304 304
   query96  491 590 273 273
   query97  2678273626332633
   query98  229 218 212 212
   query99  1425138212831283
   Total cold run time: 281568 ms
   Total hot run time: 187006 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3103087927

   
   
   TPC-H: Total hot run time: 34066 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit ef44836a599ce25752e991cd49424a485ac21bc4, 
data reload: false
   
   -- Round 1 --
   q1   17707   534752285228
   q2   1926291 174 174
   q3   10624   1426718 718
   q4   10319   1011529 529
   q5   8754251123372337
   q6   184 162 130 130
   q7   913 763 598 598
   q8   9303133011221122
   q9   6899518251345134
   q10  6888235719591959
   q11  478 295 265 265
   q12  341 350 214 214
   q13  17779   368931003100
   q14  223 222 215 215
   q15  547 478 480 478
   q16  416 437 368 368
   q17  585 900 355 355
   q18  7565726870297029
   q19  1216993 569 569
   q20  338 348 232 232
   q21  3761314823202320
   q22  1035994 992 992
   Total cold run time: 107801 ms
   Total hot run time: 34066 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5142509850925092
   q2   245 338 217 217
   q3   2212263823182318
   q4   1339183413911391
   q5   4390456544094409
   q6   234 170 129 129
   q7   2072195019001900
   q8   2664268625892589
   q9   7297744172637263
   q10  3103323529512951
   q11  581 519 480 480
   q12  696 771 635 635
   q13  3580395233493349
   q14  298 307 293 293
   q15  526 495 495 495
   q16  451 501 441 441
   q17  1185162414061406
   q18  8211750675847506
   q19  854 749 778 749
   q20  1910198218671867
   q21  4782433742994299
   q22  1064103410111011
   Total cold run time: 52836 ms
   Total hot run time: 50790 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3102888935

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3102444790

   
   
   ClickBench: Total hot run time: 33.61 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 642ae7f022608911f8ba6a72f782f788d8e6fffa, 
data reload: false
   
   query1   0.030.030.03
   query2   0.110.060.05
   query3   0.320.070.06
   query4   1.610.090.08
   query5   0.410.410.40
   query6   1.160.640.66
   query7   0.020.010.02
   query8   0.060.050.05
   query9   0.650.530.52
   query10  0.580.580.57
   query11  0.250.140.13
   query12  0.260.130.12
   query13  0.640.630.62
   query14  0.850.830.86
   query15  0.990.920.89
   query16  0.380.380.38
   query17  1.041.041.05
   query18  0.240.220.22
   query19  1.981.891.93
   query20  0.020.010.01
   query21  15.36   1.030.67
   query22  0.941.100.99
   query23  14.69   1.500.79
   query24  5.000.610.32
   query25  0.160.100.09
   query26  0.590.220.19
   query27  0.090.090.09
   query28  11.08   1.170.58
   query29  12.52   4.063.40
   query30  3.143.033.03
   query31  2.820.600.43
   query32  3.240.610.51
   query33  3.043.193.21
   query34  16.66   5.504.73
   query35  4.884.864.89
   query36  0.650.530.51
   query37  0.200.180.18
   query38  0.180.160.16
   query39  0.040.040.04
   query40  0.200.180.17
   query41  0.100.050.05
   query42  0.060.050.05
   query43  0.060.050.04
   Total cold run time: 107.3 s
   Total hot run time: 33.61 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3102427212

   
   
   TPC-DS: Total hot run time: 186461 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 642ae7f022608911f8ba6a72f782f788d8e6fffa, 
data reload: false
   
   query1   990 396 409 396
   query2   6541169917091699
   query3   6742211 217 211
   query4   26348   23583   23147   23147
   query5   4352633 493 493
   query6   302 224 213 213
   query7   4638499 285 285
   query8   272 226 222 222
   query9   8627283828222822
   query10  473 330 290 290
   query11  15539   14975   14797   14797
   query12  164 114 110 110
   query13  1657533 423 423
   query14  8572585859195858
   query15  202 186 179 179
   query16  7400646 454 454
   query17  1190714 575 575
   query18  1982395 314 314
   query19  189 187 162 162
   query20  128 121 113 113
   query21  210 120 102 102
   query22  4123416939943994
   query23  33801   32804   32965   32804
   query24  8092234623732346
   query25  552 474 408 408
   query26  1234268 159 159
   query27  2752485 329 329
   query28  4368218821622162
   query29  744 558 455 455
   query30  286 218 190 190
   query31  912 828 723 723
   query32  83  74  75  74
   query33  556 370 340 340
   query34  801 821 503 503
   query35  796 825 733 733
   query36  950 1006901 901
   query37  118 106 87  87
   query38  4182410140024002
   query39  1489144114201420
   query40  219 124 118 118
   query41  59  57  57  57
   query42  122 108 109 108
   query43  515 490 451 451
   query44  1370856 842 842
   query45  181 171 165 165
   query46  845 998 627 627
   query47  1775181217411741
   query48  383 422 301 301
   query49  762 491 385 385
   query50  659 692 402 402
   query51  5461557354285428
   query52  110 110 101 101
   query53  236 271 189 189
   query54  594 600 522 522
   query55  95  88  85  85
   query56  322 307 314 307
   query57  1169118611411141
   query58  282 269 275 269
   query59  2473264925182518
   query60  347 339 328 328
   query61  127 126 129 126
   query62  767 707 670 670
   query63  230 195 192 192
   query64  44611095691 691
   query65  4263416842184168
   query66  1162404 358 358
   query67  15848   15353   15437   15353
   query68  6961891 548 548
   query69  485 314 284 284
   query70  1186115411391139
   query71  402 337 316 316
   query72  5400462846014601
   query73  640 561 353 353
   query74  8852907188718871
   query75  3130310726132613
   query76  31751130723 723
   query77  495 388 333 333
   query78  990910044   93579357
   query79  2101790 585 585
   query80  697 542 461 461
   query81  486 257 227 227
   query82  389 133 103 103
   query83  254 244 248 244
   query84  242 104 96  96
   query85  853 375 321 321
   query86  319 332 302 302
   query87  4396438542734273
   query88  2889224722182218
   query89  383 322 282 282
   query90  1816226 224 224
   query91  138 140 114 114
   query92  74  79  66  66
   query93  1137967 621 621
   query94  643 382 308 308
   query95  399 328 328 328
   query96  482 595 280 280
   query97  2675270926402640
   query98  245 217 204 204
   query99  1310140612881288
   Total cold run time: 269757 ms
   Total hot run time: 186461 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3102392806

   
   
   TPC-H: Total hot run time: 34067 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 642ae7f022608911f8ba6a72f782f788d8e6fffa, 
data reload: false
   
   -- Round 1 --
   q1   17674   526951525152
   q2   1927282 177 177
   q3   10600   1326701 701
   q4   10328   1020536 536
   q5   9043239923362336
   q6   205 160 126 126
   q7   879 741 599 599
   q8   9305147211311131
   q9   7012513851015101
   q10  6940238719811981
   q11  494 273 266 266
   q12  353 344 212 212
   q13  17790   368230533053
   q14  234 221 213 213
   q15  556 492 471 471
   q16  418 424 374 374
   q17  589 868 358 358
   q18  7376721671877187
   q19  10901095556 556
   q20  347 336 215 215
   q21  3979311223572357
   q22  1061990 965 965
   Total cold run time: 108200 ms
   Total hot run time: 34067 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5221511151465111
   q2   246 318 220 220
   q3   2162265223032303
   q4   1386179213721372
   q5   4464450345114503
   q6   223 172 131 131
   q7   2016192617481748
   q8   2659249625102496
   q9   7360736571267126
   q10  3163335328812881
   q11  563 523 496 496
   q12  691 803 635 635
   q13  3664412733423342
   q14  298 311 278 278
   q15  518 480 476 476
   q16  439 482 441 441
   q17  1172157213811381
   q18  8009774069256925
   q19  787 803 866 803
   q20  1915193817991799
   q21  4786441442084208
   q22  10821016983 983
   Total cold run time: 52824 ms
   Total hot run time: 49658 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3102305065

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/642ae7f022608911f8ba6a72f782f788d8e6fffa_642ae7f022608911f8ba6a72f782f788d8e6fffa_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/642ae7f022608911f8ba6a72f782f788d8e6fffa_642ae7f022608911f8ba6a72f782f788d8e6fffa_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.42% (1302/1619) |
   | Line Coverage | 65.81% (21808/33140) |
   | Region Coverage   | 67.07% (10952/16328) |
   | Branch Coverage   | 56.66% (5766/10176) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-22 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3102226055

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-21 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3095630098

   # BE Regression && UT Coverage Report
   Increment line coverage `85.33% (64/75)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_3bea7975e05c74a2a4faf479e15aa3411f4af9ef_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_3bea7975e05c74a2a4faf479e15aa3411f4af9ef_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.07% (22015/27156) |
   | Line Coverage | 73.70% (227287/308388) |
   | Region Coverage   | 61.33% (189434/308897) |
   | Branch Coverage   | 65.15% (81829/125609) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-21 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3095620523

   # BE UT Coverage Report
   Increment line coverage `65.33% (49/75)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/3bea7975e05c74a2a4faf479e15aa3411f4af9ef_3bea7975e05c74a2a4faf479e15aa3411f4af9ef/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/3bea7975e05c74a2a4faf479e15aa3411f4af9ef_3bea7975e05c74a2a4faf479e15aa3411f4af9ef/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.51% (15913/27672) |
   | Line Coverage | 46.32% (143075/308854) |
   | Region Coverage   | 35.80% (107832/301168) |
   | Branch Coverage   | 38.30% (47581/124217) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-20 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3095267264

   
   
   ClickBench: Total hot run time: 33.1 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 3bea7975e05c74a2a4faf479e15aa3411f4af9ef, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.04
   query3   0.240.080.07
   query4   1.620.120.11
   query5   0.430.400.41
   query6   1.170.660.66
   query7   0.030.020.02
   query8   0.050.040.04
   query9   0.600.530.53
   query10  0.570.580.57
   query11  0.160.120.11
   query12  0.150.120.12
   query13  0.640.610.61
   query14  0.800.810.82
   query15  0.930.890.88
   query16  0.390.400.40
   query17  1.061.061.06
   query18  0.240.220.22
   query19  1.971.871.82
   query20  0.010.010.02
   query21  15.40   0.960.56
   query22  0.771.300.79
   query23  14.71   1.400.64
   query24  6.412.080.88
   query25  0.520.150.18
   query26  0.500.170.14
   query27  0.060.060.05
   query28  10.48   0.950.44
   query29  12.59   3.983.32
   query30  3.183.123.08
   query31  2.830.590.40
   query32  3.250.550.48
   query33  3.113.093.06
   query34  15.95   5.394.82
   query35  4.884.874.88
   query36  0.690.510.49
   query37  0.100.070.08
   query38  0.070.050.06
   query39  0.040.030.04
   query40  0.200.160.16
   query41  0.100.030.04
   query42  0.050.040.03
   query43  0.050.040.04
   Total cold run time: 107.12 s
   Total hot run time: 33.1 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-20 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3095257196

   
   
   TPC-DS: Total hot run time: 191380 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 3bea7975e05c74a2a4faf479e15aa3411f4af9ef, 
data reload: false
   
   query1   1024415 432 415
   query2   6551172117161716
   query3   6765240 236 236
   query4   26393   23632   23167   23167
   query5   4515723 593 593
   query6   323 250 223 223
   query7   4640518 307 307
   query8   402 345 334 334
   query9   8635296628972897
   query10  519 360 326 326
   query11  15684   15011   14880   14880
   query12  195 133 135 133
   query13  1688577 468 468
   query14  9587600959905990
   query15  224 205 179 179
   query16  7676648 508 508
   query17  1261731 595 595
   query18  2042431 330 330
   query19  204 193 169 169
   query20  139 136 138 136
   query21  231 144 128 128
   query22  4344458445744574
   query23  34949   34296   33627   33627
   query24  8103236023862360
   query25  559 466 425 425
   query26  1253283 166 166
   query27  2710556 377 377
   query28  4445217121602160
   query29  765 575 464 464
   query30  298 233 208 208
   query31  963 889 818 818
   query32  100 85  84  84
   query33  585 403 358 358
   query34  821 864 552 552
   query35  845 854 766 766
   query36  998 1031915 915
   query37  129 112 97  97
   query38  4128415640744074
   query39  1514151314841484
   query40  242 147 133 133
   query41  105 101 100 100
   query42  133 121 122 121
   query43  509 530 481 481
   query44  1376888 888 888
   query45  187 191 179 179
   query46  865 1016655 655
   query47  1852185517931793
   query48  418 449 393 393
   query49  809 566 467 467
   query50  676 710 426 426
   query51  5698542455905424
   query52  125 118 111 111
   query53  249 284 211 211
   query54  612 628 558 558
   query55  96  93  93  93
   query56  364 354 340 340
   query57  1234124911691169
   query58  337 309 308 308
   query59  2633267125962596
   query60  384 375 359 359
   query61  152 149 148 148
   query62  803 736 687 687
   query63  250 209 223 209
   query64  43921071715 715
   query65  4279418441824182
   query66  1260594 496 496
   query67  16009   15851   15525   15525
   query68  8994897 536 536
   query69  509 355 318 318
   query70  1277116311671163
   query71  494 364 328 328
   query72  5832482049604820
   query73  788 694 378 378
   query74  9304912988688868
   query75  4215317726852685
   query76  37571140738 738
   query77  859 461 392 392
   query78  10210   10197   94409440
   query79  2956828 600 600
   query80  710 600 531 531
   query81  487 272 240 240
   query82  462 147 118 118
   query83  320 353 264 264
   query84  302 117 109 109
   query85  833 393 358 358
   query86  368 335 331 331
   query87  4488451543244324
   query88  3062240723842384
   query89  460 343 306 306
   query90  1955240 237 237
   query91  144 156 126 126
   query92  103 86  81  81
   query93  1728942 585 585
   query94  692 439 323 323
   query95  411 337 327 327
   query96  500 598 291 291
   query97  2806277226622662
   query98  252 237 226 226
   query99  1513144612851285
   Total cold run time: 283047 ms
   Total hot run time: 191380 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-20 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3095239535

   
   
   TPC-H: Total hot run time: 34896 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 3bea7975e05c74a2a4faf479e15aa3411f4af9ef, 
data reload: false
   
   -- Round 1 --
   q1   17668   534051805180
   q2   1950307 202 202
   q3   10440   1311731 731
   q4   10245   1034521 521
   q5   7643245023952395
   q6   200 178 141 141
   q7   973 798 625 625
   q8   9343136711261126
   q9   6995518951385138
   q10  6916240720062006
   q11  505 320 283 283
   q12  366 387 241 241
   q13  17791   373431123112
   q14  245 257 252 252
   q15  590 534 535 534
   q16  448 450 418 418
   q17  601 899 381 381
   q18  8149737873097309
   q19  1253999 602 602
   q20  363 357 238 238
   q21  4323323824752475
   q22  10821039986 986
   Total cold run time: 108089 ms
   Total hot run time: 34896 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5219520052375200
   q2   270 345 254 254
   q3   271923342334
   q4   1369185313681368
   q5   4628451145544511
   q6   233 193 133 133
   q7   2021196417891789
   q8   2667259426572594
   q9   7385738171707170
   q10  3121328928722872
   q11  580 521 506 506
   q12  678 783 655 655
   q13  3777398634823482
   q14  306 324 317 317
   q15  556 507 514 507
   q16  476 491 460 460
   q17  1243160514421442
   q18  8103773076167616
   q19  837 905 1083905
   q20  2033211419661966
   q21  5159485745634563
   q22  1162111010871087
   Total cold run time: 54045 ms
   Total hot run time: 51731 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-20 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3095131812

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/3bea7975e05c74a2a4faf479e15aa3411f4af9ef_3bea7975e05c74a2a4faf479e15aa3411f4af9ef_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/3bea7975e05c74a2a4faf479e15aa3411f4af9ef_3bea7975e05c74a2a4faf479e15aa3411f4af9ef_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.36% (1297/1614) |
   | Line Coverage | 65.70% (21704/33035) |
   | Region Coverage   | 67.06% (10914/16276) |
   | Branch Coverage   | 56.52% (5732/10142) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-20 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3095117954

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-18 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3089313523

   # BE Regression && UT Coverage Report
   Increment line coverage `85.33% (64/75)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_99f118a64695c03572bcda359f1b60af5a9aaf79_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_99f118a64695c03572bcda359f1b60af5a9aaf79_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.10% (21844/26936) |
   | Line Coverage | 73.67% (225954/306692) |
   | Region Coverage   | 61.41% (188741/307324) |
   | Branch Coverage   | 65.11% (81382/124989) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-18 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3089297921

   # BE UT Coverage Report
   Increment line coverage `65.33% (49/75)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/99f118a64695c03572bcda359f1b60af5a9aaf79_99f118a64695c03572bcda359f1b60af5a9aaf79/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/99f118a64695c03572bcda359f1b60af5a9aaf79_99f118a64695c03572bcda359f1b60af5a9aaf79/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.49% (15786/27457) |
   | Line Coverage | 46.26% (142093/307177) |
   | Region Coverage   | 35.72% (107012/299613) |
   | Branch Coverage   | 38.24% (47260/123603) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-18 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3088538070

   
   
   ClickBench: Total hot run time: 33.65 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 99f118a64695c03572bcda359f1b60af5a9aaf79, 
data reload: false
   
   query1   0.030.030.03
   query2   0.110.050.05
   query3   0.300.060.06
   query4   1.600.090.08
   query5   0.430.400.42
   query6   1.170.660.67
   query7   0.020.020.02
   query8   0.060.060.05
   query9   0.640.520.53
   query10  0.590.580.58
   query11  0.260.130.13
   query12  0.260.140.13
   query13  0.640.640.62
   query14  0.810.820.84
   query15  0.970.880.88
   query16  0.380.390.39
   query17  1.091.061.08
   query18  0.250.230.25
   query19  2.001.891.96
   query20  0.020.020.01
   query21  15.37   0.980.68
   query22  0.931.020.84
   query23  14.69   1.570.78
   query24  5.390.560.29
   query25  0.180.100.09
   query26  0.580.220.18
   query27  0.090.100.09
   query28  11.02   1.240.61
   query29  12.55   4.103.39
   query30  3.193.133.13
   query31  2.830.620.44
   query32  3.240.610.52
   query33  3.213.143.16
   query34  17.08   5.484.77
   query35  4.944.844.82
   query36  0.650.540.53
   query37  0.200.180.18
   query38  0.180.180.16
   query39  0.060.050.05
   query40  0.210.190.18
   query41  0.120.060.07
   query42  0.070.070.06
   query43  0.070.050.05
   Total cold run time: 108.48 s
   Total hot run time: 33.65 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-18 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3088485146

   
   
   TPC-DS: Total hot run time: 189691 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 99f118a64695c03572bcda359f1b60af5a9aaf79, 
data reload: false
   
   query1   1026400 422 400
   query2   6571181517141714
   query3   6761232 227 227
   query4   26297   23931   22935   22935
   query5   4387658 531 531
   query6   319 238 231 231
   query7   4657513 301 301
   query8   381 345 339 339
   query9   8662263926532639
   query10  515 359 286 286
   query11  15850   15317   14765   14765
   query12  171 124 115 115
   query13  1673547 421 421
   query14  9264601560356015
   query15  222 212 186 186
   query16  7325675 512 512
   query17  1248757 639 639
   query18  2019438 350 350
   query19  224 207 185 185
   query20  144 142 134 134
   query21  249 153 141 141
   query22  4097443340234023
   query23  34147   33299   33479   33299
   query24  8475247324362436
   query25  562 481 423 423
   query26  1238272 160 160
   query27  2725522 361 361
   query28  4338216421452145
   query29  771 594 449 449
   query30  307 235 208 208
   query31  948 901 813 813
   query32  81  84  76  76
   query33  581 398 366 366
   query34  803 874 535 535
   query35  819 859 781 781
   query36  1000995 927 927
   query37  116 105 87  87
   query38  4170429541484148
   query39  1563150714681468
   query40  232 139 127 127
   query41  109 104 103 103
   query42  134 119 114 114
   query43  533 523 516 516
   query44  1322837 847 837
   query45  191 186 181 181
   query46  853 1039646 646
   query47  1836188917901790
   query48  404 459 350 350
   query49  800 566 469 469
   query50  664 712 432 432
   query51  5579558453315331
   query52  125 114 109 109
   query53  248 278 206 206
   query54  612 592 533 533
   query55  96  86  85  85
   query56  330 343 321 321
   query57  1209124311861186
   query58  302 301 300 300
   query59  2683270726232623
   query60  374 353 346 346
   query61  162 154 151 151
   query62  822 754 674 674
   query63  257 217 223 217
   query64  43951092771 771
   query65  4311418542074185
   query66  1313645 504 504
   query67  15844   15774   15622   15622
   query68  8130901 544 544
   query69  498 325 294 294
   query70  1231119111191119
   query71  479 340 327 327
   query72  5244467146574657
   query73  709 582 369 369
   query74  9251926088448844
   query75  3835324127432743
   query76  36421230731 731
   query77  857 430 354 354
   query78  998510292   94819481
   query79  2294857 587 587
   query80  704 565 503 503
   query81  496 273 251 251
   query82  425 147 109 109
   query83  313 287 303 287
   query84  308 116 105 105
   query85  822 397 354 354
   query86  364 335 292 292
   query87  4565457744954495
   query88  3338235323572353
   query89  410 345 311 311
   query90  1942226 223 223
   query91  164 203 128 128
   query92  90  71  74  71
   query93  1201935 593 593
   query94  678 434 329 329
   query95  395 310 306 306
   query96  494 582 286 286
   query97  2739276726162616
   query98  245 223 215 215
   query99  1475144913141314
   Total cold run time: 277769 ms
   Total hot run time: 189691 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-18 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3088375166

   
   
   TPC-H: Total hot run time: 34498 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 99f118a64695c03572bcda359f1b60af5a9aaf79, 
data reload: false
   
   -- Round 1 --
   q1   17669   526354205263
   q2   1962298 201 201
   q3   10565   1428723 723
   q4   10324   1012518 518
   q5   8997237723492349
   q6   202 168 142 142
   q7   927 798 659 659
   q8   9347132211101110
   q9   6846514951325132
   q10  6912239419771977
   q11  489 305 273 273
   q12  356 365 235 235
   q13  17774   367431113111
   q14  231 237 233 233
   q15  586 534 520 520
   q16  430 436 393 393
   q17  591 873 368 368
   q18  7672738471507150
   q19  1252971 581 581
   q20  346 349 228 228
   q21  3730255123192319
   q22  1066106010131013
   Total cold run time: 108274 ms
   Total hot run time: 34498 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5203511651755116
   q2   267 343 241 241
   q3   2177268023052305
   q4   1362179013521352
   q5   4439442245044422
   q6   230 180 140 140
   q7   2064200418441844
   q8   2628258225452545
   q9   7361733272427242
   q10  3188334629492949
   q11  572 525 492 492
   q12  748 813 637 637
   q13  3670397733603360
   q14  327 330 279 279
   q15  549 533 499 499
   q16  467 510 436 436
   q17  1155155114081408
   q18  7800772276827682
   q19  853 888 815 815
   q20  2033205220132013
   q21  5098442143544354
   q22  1155104910081008
   Total cold run time: 53346 ms
   Total hot run time: 51139 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-18 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3087898327

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/99f118a64695c03572bcda359f1b60af5a9aaf79_99f118a64695c03572bcda359f1b60af5a9aaf79_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/99f118a64695c03572bcda359f1b60af5a9aaf79_99f118a64695c03572bcda359f1b60af5a9aaf79_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.36% (1297/1614) |
   | Line Coverage | 65.80% (21710/32992) |
   | Region Coverage   | 67.11% (10903/16247) |
   | Branch Coverage   | 56.69% (5734/10114) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-18 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3087688931

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3086498728

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/fdf2472dfda4232dd82612566853b15690712e8b_fdf2472dfda4232dd82612566853b15690712e8b_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/fdf2472dfda4232dd82612566853b15690712e8b_fdf2472dfda4232dd82612566853b15690712e8b_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.36% (1297/1614) |
   | Line Coverage | 65.76% (21697/32992) |
   | Region Coverage   | 67.07% (10897/16247) |
   | Branch Coverage   | 56.66% (5731/10114) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3086474910

   run compile


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3086463096

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3083718537

   # BE Regression && UT Coverage Report
   Increment line coverage `85.33% (64/75)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_e8914d59d3f8649441180d3ab910749f54038926_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_e8914d59d3f8649441180d3ab910749f54038926_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.12% (21861/26948) |
   | Line Coverage | 73.66% (226007/306842) |
   | Region Coverage   | 61.48% (188864/307179) |
   | Branch Coverage   | 65.08% (81272/124884) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3083706933

   # BE UT Coverage Report
   Increment line coverage `65.33% (49/75)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/e8914d59d3f8649441180d3ab910749f54038926_e8914d59d3f8649441180d3ab910749f54038926/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/e8914d59d3f8649441180d3ab910749f54038926_e8914d59d3f8649441180d3ab910749f54038926/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.46% (15783/27468) |
   | Line Coverage | 46.24% (142108/307312) |
   | Region Coverage   | 35.71% (106919/299448) |
   | Branch Coverage   | 38.24% (47224/123494) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3083106815

   
   
   ClickBench: Total hot run time: 33.25 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit e8914d59d3f8649441180d3ab910749f54038926, 
data reload: false
   
   query1   0.030.040.03
   query2   0.110.060.06
   query3   0.290.060.06
   query4   1.610.080.08
   query5   0.430.420.41
   query6   1.170.660.67
   query7   0.020.010.02
   query8   0.060.040.04
   query9   0.660.510.51
   query10  0.580.590.57
   query11  0.260.120.13
   query12  0.250.130.13
   query13  0.640.640.64
   query14  0.820.830.83
   query15  0.980.890.89
   query16  0.400.380.38
   query17  1.071.091.12
   query18  0.240.230.24
   query19  2.031.861.96
   query20  0.010.020.02
   query21  15.38   0.970.67
   query22  0.941.050.81
   query23  14.69   1.570.76
   query24  5.280.600.31
   query25  0.170.100.10
   query26  0.560.220.19
   query27  0.090.090.08
   query28  11.01   1.270.59
   query29  12.53   4.173.42
   query30  3.083.002.94
   query31  2.840.630.43
   query32  3.230.610.51
   query33  3.123.173.13
   query34  16.55   5.444.73
   query35  4.774.804.83
   query36  0.650.510.50
   query37  0.190.170.18
   query38  0.190.160.15
   query39  0.050.040.05
   query40  0.210.180.15
   query41  0.100.060.05
   query42  0.060.060.06
   query43  0.060.040.05
   Total cold run time: 107.41 s
   Total hot run time: 33.25 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3083091052

   
   
   TPC-DS: Total hot run time: 186159 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit e8914d59d3f8649441180d3ab910749f54038926, 
data reload: false
   
   query1   974 412 412 412
   query2   6513163916091609
   query3   6736214 214 214
   query4   26806   23761   23292   23292
   query5   4387583 451 451
   query6   301 225 212 212
   query7   4631501 294 294
   query8   276 223 223 223
   query9   8617259726052597
   query10  476 338 271 271
   query11  15787   15087   14786   14786
   query12  159 116 109 109
   query13  1665533 425 425
   query14  9123589558035803
   query15  214 196 177 177
   query16  7221627 481 481
   query17  1209736 605 605
   query18  2005415 305 305
   query19  200 200 171 171
   query20  126 116 116 116
   query21  212 126 110 110
   query22  4164436240794079
   query23  34220   33181   33143   33143
   query24  8454233823032303
   query25  517 458 387 387
   query26  1240266 142 142
   query27  2756525 346 346
   query28  4332212020952095
   query29  744 553 434 434
   query30  288 211 189 189
   query31  918 823 793 793
   query32  71  63  67  63
   query33  571 353 315 315
   query34  793 834 515 515
   query35  796 847 719 719
   query36  953 1013897 897
   query37  111 94  66  66
   query38  4217418340994099
   query39  1517145214531452
   query40  210 120 107 107
   query41  57  56  56  56
   query42  120 107 103 103
   query43  508 503 461 461
   query44  1307813 804 804
   query45  176 170 165 165
   query46  835 1016633 633
   query47  1797182117491749
   query48  391 438 308 308
   query49  745 467 381 381
   query50  667 707 420 420
   query51  5634549053095309
   query52  111 107 96  96
   query53  230 275 188 188
   query54  572 596 500 500
   query55  85  83  79  79
   query56  302 306 285 285
   query57  1204118911211121
   query58  257 260 272 260
   query59  2640272125142514
   query60  330 319 325 319
   query61  126 120 139 120
   query62  823 718 666 666
   query63  227 192 199 192
   query64  42781000648 648
   query65  4272418941994189
   query66  1145451 325 325
   query67  15803   15863   15328   15328
   query68  8106899 514 514
   query69  467 298 277 277
   query70  1213117010991099
   query71  459 330 302 302
   query72  5375474347174717
   query73  721 615 350 350
   query74  9195909287068706
   query75  3753318927112711
   query76  36911168704 704
   query77  783 373 291 291
   query78  994610181   93099309
   query79  2023829 577 577
   query80  635 512 463 463
   query81  485 254 224 224
   query82  476 127 98  98
   query83  292 285 245 245
   query84  296 103 80  80
   query85  781 360 328 328
   query86  335 301 280 280
   query87  4575444343184318
   query88  2910228522602260
   query89  396 319 298 298
   query90  1928214 214 214
   query91  143 138 110 110
   query92  74  61  56  56
   query93  1118942 577 577
   query94  672 407 291 291
   query95  380 294 286 286
   query96  501 582 280 280
   query97  2713286626582658
   query98  246 208 195 195
   query99  1438143613151315
   Total cold run time: 275278 ms
   Total hot run time: 186159 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3083045081

   
   
   TPC-H: Total hot run time: 34025 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit e8914d59d3f8649441180d3ab910749f54038926, 
data reload: false
   
   -- Round 1 --
   q1   17608   527651555155
   q2   1914282 178 178
   q3   10654   1340711 711
   q4   10337   1010508 508
   q5   8603245023162316
   q6   187 162 135 135
   q7   904 746 612 612
   q8   9311127911291129
   q9   7601503050555030
   q10  6902239119651965
   q11  480 300 281 281
   q12  342 346 206 206
   q13  17803   367431073107
   q14  233 230 218 218
   q15  529 470 470 470
   q16  421 426 375 375
   q17  589 860 375 375
   q18  7618714171057105
   q19  1243958 556 556
   q20  335 336 215 215
   q21  4221321724192419
   q22  10121059959 959
   Total cold run time: 108847 ms
   Total hot run time: 34025 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5327511251285112
   q2   246 324 221 221
   q3   2154264823192319
   q4   1364180713311331
   q5   4468451845034503
   q6   202 171 140 140
   q7   2048198017991799
   q8   2676259825862586
   q9   7394719072977190
   q10  3149332628732873
   q11  572 507 527 507
   q12  702 768 629 629
   q13  3596392334533453
   q14  301 327 292 292
   q15  529 469 493 469
   q16  456 502 436 436
   q17  1391154913811381
   q18  7794769676607660
   q19  812 817 947 817
   q20  1974198118081808
   q21  4871441843094309
   q22  1089979 991 979
   Total cold run time: 53115 ms
   Total hot run time: 50814 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-17 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3082849743

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077882577

   # BE Regression && UT Coverage Report
   Increment line coverage `84.72% (61/72)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_1586eb5feb0c655ba04f3502f171dda91a13bd6c_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_1586eb5feb0c655ba04f3502f171dda91a13bd6c_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 81.12% (21759/26822) |
   | Line Coverage | 73.73% (223681/303377) |
   | Region Coverage   | 61.41% (185973/302816) |
   | Branch Coverage   | 65.26% (79954/122524) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077843740

   # BE UT Coverage Report
   Increment line coverage `63.89% (46/72)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/1586eb5feb0c655ba04f3502f171dda91a13bd6c_1586eb5feb0c655ba04f3502f171dda91a13bd6c/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/1586eb5feb0c655ba04f3502f171dda91a13bd6c_1586eb5feb0c655ba04f3502f171dda91a13bd6c/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 57.56% (15740/27346) |
   | Line Coverage | 46.20% (140444/303986) |
   | Region Coverage   | 35.46% (104677/295158) |
   | Branch Coverage   | 38.10% (46170/121180) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077718728

   
   
   ClickBench: Total hot run time: 33.23 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 1586eb5feb0c655ba04f3502f171dda91a13bd6c, 
data reload: false
   
   query1   0.030.030.03
   query2   0.110.060.05
   query3   0.290.060.07
   query4   1.610.090.08
   query5   0.420.410.41
   query6   1.160.660.66
   query7   0.030.020.01
   query8   0.060.050.05
   query9   0.640.520.53
   query10  0.580.580.56
   query11  0.250.140.13
   query12  0.250.140.14
   query13  0.650.630.63
   query14  0.820.830.85
   query15  0.990.890.90
   query16  0.390.390.39
   query17  1.061.051.05
   query18  0.240.230.24
   query19  1.981.881.93
   query20  0.010.010.02
   query21  15.36   1.000.67
   query22  0.920.970.80
   query23  14.74   1.560.76
   query24  5.460.540.28
   query25  0.170.090.09
   query26  0.550.220.19
   query27  0.090.090.08
   query28  11.01   1.180.60
   query29  12.54   4.013.40
   query30  3.142.992.97
   query31  2.830.640.43
   query32  3.230.600.52
   query33  3.063.293.18
   query34  16.78   5.524.65
   query35  4.834.824.81
   query36  0.650.510.51
   query37  0.190.180.18
   query38  0.170.160.16
   query39  0.050.040.04
   query40  0.200.170.16
   query41  0.110.060.05
   query42  0.060.050.05
   query43  0.060.050.04
   Total cold run time: 107.77 s
   Total hot run time: 33.23 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077700317

   
   
   TPC-DS: Total hot run time: 186975 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 1586eb5feb0c655ba04f3502f171dda91a13bd6c, 
data reload: false
   
   query1   975 402 414 402
   query2   6522165616531653
   query3   6733211 205 205
   query4   26688   23284   23128   23128
   query5   4370583 421 421
   query6   300 210 202 202
   query7   4620486 286 286
   query8   278 238 218 218
   query9   8624263726402637
   query10  488 339 272 272
   query11  15706   15293   14846   14846
   query12  162 108 103 103
   query13  1641550 398 398
   query14  9513604759575957
   query15  207 192 183 183
   query16  7384625 450 450
   query17  1195739 583 583
   query18  1976389 287 287
   query19  229 195 166 166
   query20  121 116 112 112
   query21  215 128 108 108
   query22  4109411341334113
   query23  34286   33145   33168   33145
   query24  8552237024092370
   query25  526 461 425 425
   query26  1223267 151 151
   query27  2767510 333 333
   query28  4318214021092109
   query29  750 548 437 437
   query30  286 242 192 192
   query31  950 842 775 775
   query32  72  69  60  60
   query33  565 348 311 311
   query34  806 852 537 537
   query35  797 839 746 746
   query36  983 1005891 891
   query37  109 97  76  76
   query38  4149420140794079
   query39  1535145214431443
   query40  211 120 106 106
   query41  57  54  50  50
   query42  118 111 108 108
   query43  514 501 485 485
   query44  1300833 828 828
   query45  180 167 166 166
   query46  854 1022626 626
   query47  1764179917361736
   query48  401 420 307 307
   query49  723 466 385 385
   query50  633 695 417 417
   query51  5471546854955468
   query52  112 106 105 105
   query53  227 256 183 183
   query54  562 582 493 493
   query55  86  81  82  81
   query56  292 317 298 298
   query57  1206120011341134
   query58  272 257 250 250
   query59  2526272925052505
   query60  317 328 296 296
   query61  127 121 121 121
   query62  791 696 650 650
   query63  219 199 189 189
   query64  4289989 665 665
   query65  4286419941694169
   query66  1103407 382 382
   query67  16215   15589   15529   15529
   query68  7815873 519 519
   query69  477 302 277 277
   query70  1196111511011101
   query71  434 333 290 290
   query72  5540489148684868
   query73  687 656 351 351
   query74  8915920588908890
   query75  3362320626942694
   query76  32831201717 717
   query77  733 386 292 292
   query78  996610096   92279227
   query79  1598825 570 570
   query80  659 586 442 442
   query81  497 249 224 224
   query82  181 125 91  91
   query83  242 253 231 231
   query84  242 102 90  90
   query85  756 372 335 335
   query86  376 311 290 290
   query87  4463437644514376
   query88  2936233123402331
   query89  382 331 287 287
   query90  1924212 215 212
   query91  139 196 115 115
   query92  77  61  56  56
   query93  1442946 583 583
   query94  656 380 293 293
   query95  361 293 289 289
   query96  494 590 285 285
   query97  2739278126372637
   query98  227 210 207 207
   query99  1334142112631263
   Total cold run time: 273719 ms
   Total hot run time: 186975 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077672400

   # FE UT Coverage Report
   Increment line coverage `  33.33% (2/6)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_1586eb5feb0c655ba04f3502f171dda91a13bd6c/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/53083_1586eb5feb0c655ba04f3502f171dda91a13bd6c/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077646604

   
   
   TPC-H: Total hot run time: 34168 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 1586eb5feb0c655ba04f3502f171dda91a13bd6c, 
data reload: false
   
   -- Round 1 --
   q1   17645   536951715171
   q2   1922304 176 176
   q3   10622   1313716 716
   q4   10324   1014530 530
   q5   8933236823702368
   q6   210 157 131 131
   q7   913 752 588 588
   q8   9305131310881088
   q9   6982509150675067
   q10  6913237819691969
   q11  475 287 279 279
   q12  343 355 221 221
   q13  1   365431043104
   q14  242 239 217 217
   q15  571 482 471 471
   q16  420 451 381 381
   q17  600 867 356 356
   q18  7507728971657165
   q19  1237951 582 582
   q20  345 353 225 225
   q21  3921320924072407
   q22  10641023956 956
   Total cold run time: 108271 ms
   Total hot run time: 34168 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5230516751535153
   q2   246 333 219 219
   q3   2205272023082308
   q4   1396181013581358
   q5   4467451445484514
   q6   221 163 125 125
   q7   2090192219251922
   q8   2755250424942494
   q9   7360737672867286
   q10  3094335128722872
   q11  592 525 497 497
   q12  742 834 673 673
   q13  3635399234173417
   q14  274 301 273 273
   q15  529 497 479 479
   q16  461 507 456 456
   q17  1222160614041404
   q18  8011789573287328
   q19  784 817 1017817
   q20  1940197918491849
   q21  4809436743614361
   q22  1108101710381017
   Total cold run time: 53171 ms
   Total hot run time: 50822 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



amorynan commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2209600872


##
be/src/vec/common/schema_util.cpp:
##
@@ -292,23 +328,33 @@ void update_least_schema_internal(const 
std::map& subcolu
 path_set->insert(tuple_paths[i]);
 }
 }
+return Status::OK();
 }
 
-void update_least_common_schema(const std::vector& schemas,
-TabletSchemaSPtr& common_schema, int32_t 
variant_col_unique_id,
-std::set* path_set) {
+Status update_least_common_schema(const std::vector& schemas,
+  TabletSchemaSPtr& common_schema, int32_t 
variant_col_unique_id,
+  std::set* path_set) {
 // Types of subcolumns by path from all tuples.
 std::map subcolumns_types;
+
+// Collect all paths first to enable batch checking
+std::vector all_paths;
+
 for (const TabletSchemaSPtr& schema : schemas) {
 for (const TabletColumnPtr& col : schema->columns()) {
 // Get subcolumns of this variant
 if (col->has_path_info() && col->parent_unique_id() > 0 &&
 col->parent_unique_id() == variant_col_unique_id) {
 subcolumns_types[*col->path_info_ptr()].push_back(
 DataTypeFactory::instance().create_data_type(*col, 
col->is_nullable()));
+all_paths.push_back(*col->path_info_ptr());

Review Comment:
   I use same path group to check which can reduce the time complexity to o(n + 
m^2) and which is more reliable than hash. By the ways SipHash is so slow 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077514865

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/1586eb5feb0c655ba04f3502f171dda91a13bd6c_1586eb5feb0c655ba04f3502f171dda91a13bd6c_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/1586eb5feb0c655ba04f3502f171dda91a13bd6c_1586eb5feb0c655ba04f3502f171dda91a13bd6c_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 80.36% (1297/1614) |
   | Line Coverage | 65.77% (21697/32991) |
   | Region Coverage   | 67.07% (10897/16247) |
   | Branch Coverage   | 56.70% (5735/10114) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-16 Thread via GitHub



eldenmoon commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3077464976

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-15 Thread via GitHub



csun5285 commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2209173764


##
be/src/vec/common/schema_util.cpp:
##
@@ -292,23 +328,33 @@ void update_least_schema_internal(const 
std::map& subcolu
 path_set->insert(tuple_paths[i]);
 }
 }
+return Status::OK();
 }
 
-void update_least_common_schema(const std::vector& schemas,
-TabletSchemaSPtr& common_schema, int32_t 
variant_col_unique_id,
-std::set* path_set) {
+Status update_least_common_schema(const std::vector& schemas,
+  TabletSchemaSPtr& common_schema, int32_t 
variant_col_unique_id,
+  std::set* path_set) {
 // Types of subcolumns by path from all tuples.
 std::map subcolumns_types;
+
+// Collect all paths first to enable batch checking
+std::vector all_paths;
+
 for (const TabletSchemaSPtr& schema : schemas) {
 for (const TabletColumnPtr& col : schema->columns()) {
 // Get subcolumns of this variant
 if (col->has_path_info() && col->parent_unique_id() > 0 &&
 col->parent_unique_id() == variant_col_unique_id) {
 subcolumns_types[*col->path_info_ptr()].push_back(
 DataTypeFactory::instance().create_data_type(*col, 
col->is_nullable()));
+all_paths.push_back(*col->path_info_ptr());

Review Comment:
   这样是不是有点慢，用一个 std::unordered_map // 。相同的 path的hash 应该一样，不一样的说明 is_nested 或 
anonymous_array_level 不一样。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-15 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3076586441

   
   
   ClickBench: Total hot run time: 33.29 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 722fcd87a7a40421b75b0a5815f975230c7ac98d, 
data reload: false
   
   query1   0.040.040.03
   query2   0.110.060.05
   query3   0.290.060.07
   query4   1.600.090.07
   query5   0.440.400.42
   query6   1.160.660.65
   query7   0.020.020.01
   query8   0.060.050.05
   query9   0.670.520.53
   query10  0.570.610.57
   query11  0.260.130.13
   query12  0.260.130.13
   query13  0.650.640.64
   query14  0.800.820.84
   query15  0.980.890.89
   query16  0.380.390.38
   query17  1.101.041.12
   query18  0.240.230.23
   query19  2.031.911.95
   query20  0.020.010.01
   query21  15.36   0.960.65
   query22  0.921.010.80
   query23  14.78   1.580.75
   query24  5.180.590.30
   query25  0.160.100.09
   query26  0.560.230.18
   query27  0.090.090.09
   query28  11.06   1.150.57
   query29  12.53   4.053.40
   query30  3.123.033.01
   query31  2.850.620.43
   query32  3.250.600.51
   query33  3.193.213.18
   query34  16.86   5.464.76
   query35  4.844.774.79
   query36  0.640.520.52
   query37  0.220.180.18
   query38  0.170.160.15
   query39  0.050.050.04
   query40  0.200.180.17
   query41  0.110.060.06
   query42  0.060.050.05
   query43  0.060.050.04
   Total cold run time: 107.94 s
   Total hot run time: 33.29 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-15 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3076580281

   
   
   TPC-DS: Total hot run time: 185969 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 722fcd87a7a40421b75b0a5815f975230c7ac98d, 
data reload: false
   
   query1   1015396 421 396
   query2   6514167516841675
   query3   6737208 211 208
   query4   26620   24052   23179   23179
   query5   4390597 426 426
   query6   324 218 214 214
   query7   4631500 290 290
   query8   285 238 236 236
   query9   8584262526202620
   query10  475 330 275 275
   query11  15866   15024   14984   14984
   query12  154 108 108 108
   query13  1646527 403 403
   query14  9140621661606160
   query15  244 202 174 174
   query16  7603434 249 249
   query17  1341709 558 558
   query18  2001394 307 307
   query19  192 210 166 166
   query20  123 115 111 111
   query21  209 128 111 111
   query22  4121424341014101
   query23  34102   33120   33161   33120
   query24  8449242624112411
   query25  537 470 412 412
   query26  1220284 148 148
   query27  2743509 341 341
   query28  4307211020832083
   query29  714 594 443 443
   query30  298 228 198 198
   query31  944 831 781 781
   query32  76  66  61  61
   query33  554 352 283 283
   query34  847 844 521 521
   query35  619 643 552 552
   query36  964 997 922 922
   query37  128 105 77  77
   query38  4235413641244124
   query39  1469145016101450
   query40  216 118 106 106
   query41  59  59  52  52
   query42  118 108 113 108
   query43  513 499 475 475
   query44  1353832 820 820
   query45  180 169 166 166
   query46  879 1033658 658
   query47  1759179717611761
   query48  393 418 305 305
   query49  748 462 400 400
   query50  679 707 419 419
   query51  5584548553585358
   query52  111 108 103 103
   query53  225 263 192 192
   query54  577 575 512 512
   query55  88  79  83  79
   query56  340 301 282 282
   query57  1188121411181118
   query58  257 248 256 248
   query59  2600266925332533
   query60  331 350 306 306
   query61  127 121 121 121
   query62  805 702 668 668
   query63  226 195 198 195
   query64  42711174886 886
   query65  4291418141864181
   query66  1094428 327 327
   query67  16007   15595   15630   15595
   query68  7125895 536 536
   query69  525 323 294 294
   query70  1218113311901133
   query71  407 325 299 299
   query72  5549242451832424
   query73  742 772 354 354
   query74  9347910388458845
   query75  3235321927092709
   query76  32191180778 778
   query77  491 389 297 297
   query78  10855   11435   10284   10284
   query79  1469830 570 570
   query80  583 531 455 455
   query81  487 253 218 218
   query82  191 126 96  96
   query83  256 248 242 242
   query84  254 103 89  89
   query85  766 400 315 315
   query86  372 324 299 299
   query87  4450447543694369
   query88  2919227422722272
   query89  380 315 295 295
   query90  1816207 209 207
   query91  142 138 114 114
   query92  64  60  53  53
   query93  1122957 596 596
   query94  650 315 199 199
   query95  378 297 286 286
   query96  502 571 276 276
   query97  2676276126922692
   query98  225 212 214 212
   query99  1328140713091309
   Total cold run time: 273183 ms
   Total hot run time: 185969 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-15 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3076563346

   
   
   TPC-H: Total hot run time: 33703 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 722fcd87a7a40421b75b0a5815f975230c7ac98d, 
data reload: false
   
   -- Round 1 --
   q1   17681   527451895189
   q2   1943289 180 180
   q3   10595   1274714 714
   q4   10317   1007522 522
   q5   9308237223902372
   q6   209 160 133 133
   q7   919 758 614 614
   q8   9319130411081108
   q9   7044518651035103
   q10  6953238820132013
   q11  493 299 269 269
   q12  347 351 224 224
   q13  17774   369631323132
   q14  233 223 205 205
   q15  569 478 478 478
   q16  431 423 373 373
   q17  603 893 354 354
   q18  7577723271797179
   q19  1090970 585 585
   q20  356 335 230 230
   q21  3960324924242424
   q22  363 326 302 302
   Total cold run time: 108084 ms
   Total hot run time: 33703 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5221539152075207
   q2   245 326 220 220
   q3   2325265723112311
   q4   1339181313381338
   q5   4322448844914488
   q6   233 173 136 136
   q7   2009202017941794
   q8   2731257126192571
   q9   7264717073027170
   q10  3182327829552955
   q11  576 531 489 489
   q12  678 776 653 653
   q13  3634407234383438
   q14  291 306 273 273
   q15  523 476 477 476
   q16  455 492 442 442
   q17  1247163913871387
   q18  7981773969886988
   q19  887 825 954 825
   q20  1925199218121812
   q21  4877435342034203
   q22  626 583 555 555
   Total cold run time: 52571 ms
   Total hot run time: 49731 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-15 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3076514161

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/722fcd87a7a40421b75b0a5815f975230c7ac98d_722fcd87a7a40421b75b0a5815f975230c7ac98d_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/722fcd87a7a40421b75b0a5815f975230c7ac98d_722fcd87a7a40421b75b0a5815f975230c7ac98d_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.75% (1280/1605) |
   | Line Coverage | 65.60% (21586/32907) |
   | Region Coverage   | 66.92% (10841/16201) |
   | Branch Coverage   | 56.52% (5704/10092) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-15 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3076473275

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3068532311

   
   
   ClickBench: Total hot run time: 30.26 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 8f9e6ee3ee58650c16786e3a79f6812211a8b208, 
data reload: false
   
   query1   0.040.040.03
   query2   0.100.060.05
   query3   0.290.070.06
   query4   1.610.080.08
   query5   0.430.410.40
   query6   1.160.670.66
   query7   0.020.020.01
   query8   0.060.050.05
   query9   0.630.540.51
   query10  0.560.570.58
   query11  0.260.130.12
   query12  0.250.130.13
   query13  0.650.630.62
   query14  0.810.810.82
   query15  0.980.890.90
   query16  0.370.390.38
   query17  1.051.081.08
   query18  0.250.230.22
   query19  1.971.891.90
   query20  0.010.020.01
   query21  15.36   0.960.67
   query22  0.921.010.77
   query23  14.76   1.550.78
   query24  5.140.640.31
   query25  0.160.100.09
   query26  0.560.230.18
   query27  0.080.080.09
   query28  11.00   1.290.58
   query29  12.55   4.103.41
   query30  0.280.080.06
   query31  2.830.670.42
   query32  3.220.600.51
   query33  3.143.093.14
   query34  16.96   5.604.76
   query35  4.754.804.86
   query36  0.640.510.49
   query37  0.190.180.18
   query38  0.170.180.16
   query39  0.060.040.04
   query40  0.190.160.18
   query41  0.110.050.05
   query42  0.060.050.05
   query43  0.050.050.05
   Total cold run time: 104.68 s
   Total hot run time: 30.26 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3068514384

   
   
   TPC-DS: Total hot run time: 186455 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8f9e6ee3ee58650c16786e3a79f6812211a8b208, 
data reload: false
   
   query1   999 373 370 370
   query2   6514184317191719
   query3   6734212 213 212
   query4   25829   23852   23577   23577
   query5   4356573 443 443
   query6   304 216 200 200
   query7   4663487 280 280
   query8   262 225 211 211
   query9   8627261326412613
   query10  489 330 273 273
   query11  15754   15084   14723   14723
   query12  158 116 101 101
   query13  1656509 391 391
   query14  9207578358615783
   query15  201 197 161 161
   query16  7247643 473 473
   query17  1201694 580 580
   query18  1974388 291 291
   query19  185 175 166 166
   query20  120 125 110 110
   query21  210 119 104 104
   query22  4155437941084108
   query23  33975   32873   33129   32873
   query24  8451235823692358
   query25  507 448 376 376
   query26  1240265 143 143
   query27  2775500 334 334
   query28  4325210820762076
   query29  748 559 439 439
   query30  284 216 183 183
   query31  941 835 749 749
   query32  70  62  60  60
   query33  559 373 333 333
   query34  800 834 519 519
   query35  766 826 743 743
   query36  964 988 898 898
   query37  107 98  74  74
   query38  4134415440704070
   query39  1499149514211421
   query40  248 114 105 105
   query41  56  57  52  52
   query42  121 103 106 103
   query43  527 530 500 500
   query44  1303810 813 810
   query45  177 171 159 159
   query46  814 1005624 624
   query47  1841181517451745
   query48  384 410 317 317
   query49  729 482 392 392
   query50  640 699 413 413
   query51  5514565254045404
   query52  114 101 130 101
   query53  222 256 177 177
   query54  569 563 484 484
   query55  78  77  79  77
   query56  305 294 276 276
   query57  1186120011331133
   query58  261 248 260 248
   query59  2633269725352535
   query60  329 311 306 306
   query61  124 120 122 120
   query62  823 728 657 657
   query63  223 185 190 185
   query64  4292986 753 753
   query65  4272419741424142
   query66  1151426 381 381
   query67  15759   15891   15346   15346
   query68  7899863 508 508
   query69  460 316 262 262
   query70  1277113811061106
   query71  448 325 299 299
   query72  5583473047954730
   query73  646 629 348 348
   query74  8846919388668866
   query75  3446318027232723
   query76  32971127768 768
   query77  767 382 280 280
   query78  986810051   93059305
   query79  1607796 569 569
   query80  591 507 455 455
   query81  463 254 220 220
   query82  410 122 99  99
   query83  253 254 231 231
   query84  246 94  92  92
   query85  779 348 306 306
   query86  351 326 289 289
   query87  4455445344184418
   query88  2884228622702270
   query89  385 325 278 278
   query90  1922206 207 206
   query91  154 146 108 108
   query92  72  59  58  58
   query93  1065915 573 573
   query94  700 391 313 313
   query95  368 287 279 279
   query96  489 611 280 280
   query97  2698280926622662
   query98  234 204 210 204
   query99  1354139512671267
   Total cold run time: 271702 ms
   Total hot run time: 186455 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3068462081

   
   
   TPC-H: Total hot run time: 33121 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8f9e6ee3ee58650c16786e3a79f6812211a8b208, 
data reload: false
   
   -- Round 1 --
   q1   17627   525250675067
   q2   1931281 182 182
   q3   10622   1278700 700
   q4   10346   1022525 525
   q5   9111232524022325
   q6   201 154 128 128
   q7   917 750 593 593
   q8   9310151011011101
   q9   6874511050905090
   q10  6906238419701970
   q11  476 280 274 274
   q12  334 362 212 212
   q13  17774   369330623062
   q14  238 219 206 206
   q15  562 489 478 478
   q16  421 414 368 368
   q17  590 872 350 350
   q18  7730706772337067
   q19  1268942 559 559
   q20  326 337 219 219
   q21  3819321223472347
   q22  354 319 298 298
   Total cold run time: 107737 ms
   Total hot run time: 33121 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5132507352995073
   q2   246 332 219 219
   q3   2165270522872287
   q4   1360180013831383
   q5   4246447045554470
   q6   213 164 123 123
   q7   2061201518411841
   q8   2825258525052505
   q9   7330722672367226
   q10  3097329429172917
   q11  611 522 490 490
   q12  704 1035606 606
   q13  3527399133013301
   q14  296 313 294 294
   q15  520 486 468 468
   q16  454 491 438 438
   q17  1164153714001400
   q18  8086756777327567
   q19  794 875 1030875
   q20  1998202018341834
   q21  4766443642754275
   q22  669 602 567 567
   Total cold run time: 52264 ms
   Total hot run time: 50159 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3068312413

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/8f9e6ee3ee58650c16786e3a79f6812211a8b208_8f9e6ee3ee58650c16786e3a79f6812211a8b208_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/8f9e6ee3ee58650c16786e3a79f6812211a8b208_8f9e6ee3ee58650c16786e3a79f6812211a8b208_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.77% (1270/1592) |
   | Line Coverage | 65.43% (21304/32559) |
   | Region Coverage   | 66.92% (10784/16114) |
   | Branch Coverage   | 56.57% (5681/10042) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3068223064

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



amorynan commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3068220229

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



amorynan commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2204096118


##
regression-test/data/variant_p0/nested/load.out:
##
@@ -0,0 +1,448 @@
+-- This file is automatically generated. You should know what you did if you 
want to edit this
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a array  Yes false   \N  NONE
+v.nested.b array Yes false   \N  NONE
+v.nested.c array   Yes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":[{"a":1,"c":1.1},{"b":"1"}]}
+
+-- !sql_1 --
+[1, null]
+
+-- !sql_2 --
+[null, "1"]
+
+-- !sql_3 --
+[1.1, null]
+
+-- !sql_4 --
+[{"a":1,"c":1.1}, {"b":"1"}]
+
+-- !sql_8 --
+[1, null]  2
+
+-- !sql_9 --
+[null, 1]  2
+
+-- !sql_10 --
+[1, null]  2
+
+-- !sql_11 --
+["1", null]2
+
+-- !sql_12 --
+[null, "1"]2
+
+-- !sql_13 --
+["1.1", null]  2
+
+-- !sql_14 --
+[1, null]  2
+
+-- !sql_15 --
+[null, 1]  2
+
+-- !sql_16 --
+[1.1, null]2
+
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a array   Yes false   \N  NONE
+v.nested.b array Yes false   \N  NONE
+v.nested.c array Yes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":[{"a":1.0,"c":1.1},{"b":"1"}]}
+3  {"nested":[{"a":2.5,"b":"123.1"}]}
+4  {"nested":[{"a":2.5,"b":123.1}]}
+5  {"nested":[{"a":2.5,"c":"123.1"},{"b":"123.1"}]}
+6  {"nested":[{"a":2.5},{"b":123.1}]}
+7  {"nested":[{"a":2.5},{"c":123.1},{"b":"123.1"}]}
+
+-- !sql_1 --
+[1, null]
+[2.5]
+[2.5]
+[2.5, null]
+[2.5, null]
+[2.5, null, null]
+
+-- !sql_2 --
+[null, ""1""]
+[""123.1""]
+["123.1"]
+[null, ""123.1""]
+[null, "123.1"]
+[null, null, ""123.1""]
+
+-- !sql_3 --
+["1.1", null]
+\N
+\N
+[""123.1"", null]
+\N
+[null, "123.1", null]
+
+-- !sql_4 --
+[{"a":1.0,"c":1.1}, {"b":"1"}]
+[{"a":2.5,"b":"123.1"}]
+[{"a":2.5,"b":123.1}]
+[{"a":2.5,"c":"123.1"}, {"b":"123.1"}]
+[{"a":2.5}, {"b":123.1}]
+[{"a":2.5}, {"c":123.1}, {"b":"123.1"}]
+
+-- !sql_8 --
+[1, null]  2
+[2]1
+[2]1
+[2, null]  2
+[2, null]  2
+[2, null, null]3
+
+-- !sql_9 --
+[null, 1]  2
+[123]  1
+[123]  1
+[null, 123]2
+[null, 123]2
+[null, null, 123]  3
+
+-- !sql_10 --
+[1, null]  2
+\N \N
+\N \N
+[123, null]2
+\N \N
+[null, 123, null]  3
+
+-- !sql_11 --
+["1", null]2
+["2.5"]1
+["2.5"]1
+["2.5", null]  2
+["2.5", null]  2
+["2.5", null, null]3
+
+-- !sql_12 --
+[null, "1"]2
+["123.1"]  1
+["123.1"]  1
+[null, "123.1"]2
+[null, "123.1"]2
+[null, null, "123.1"]  3
+
+-- !sql_13 --
+["1.1", null]  2
+\N \N
+\N \N
+["123.1", null]2
+\N \N
+[null, "123.1", null]  3
+
+-- !sql_14 --
+[1, null]  2
+[2.5]  1
+[2.5]  1
+[2.5, null]2
+[2.5, null]2
+[2.5, null, null]  3
+
+-- !sql_15 --
+[null, 1]  2
+[123.1]1
+[123.1]1
+[null, 123.1]  2
+[null, 123.1]  2
+[null, null, 123.1]3
+
+-- !sql_16 --
+[1.1, null]2
+\N \N
+\N \N
+[123.1, null]  2
+\N \N
+[null, 123.1, null]3
+
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a double  Yes false   \N  NONE
+v.nested.b textYes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":{"a":2.5,"b":"123.1"}}
+
+-- !sql_1 --
+2.5
+
+-- !sql_2 --
+123.1
+
+-- !sql_3 --
+\N
+
+-- !sql_4 --
+{"a":2.5,"b":"123.1"}
+
+-- !sql_8 --
+\N \N
+
+-- !sql_9 --
+\N \N
+
+-- !sql_10 --
+\N \N
+
+-- !sql_11 --
+\N \N
+
+-- !sql_12 --
+\N \N
+
+-- !sql_13 --
+\N \N
+
+-- !sql_14 --
+\N \N
+
+-- !sql_15 --
+\N \N
+
+-- !sql_16 --
+\N \N
+
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a double  Yes false   \N  NONE
+v.nested.b jsonYes false   \N  NONE
+v.nested.c jsonYes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":{"a":2.5,"b":"123.1"}}
+3  {"nested":{"a":2.5,"b":123.1}}
+4  {"nested":{"a":2.5,"c":"123.1"}}
+5  {"nested":{"a":2.5,"c":123.1}}
+6  {"nested":{"a":2.5,"c":"123.1"}}
+7  {"nested":{"a":2.5,"b":"123.1","c":123.1}}
+
+-- !sql_1 --
+2.5
+2.5
+2.5
+2.5
+2.5
+2.5
+
+-- !sql_2 --
+"123.1"
+123.1
+\N
+\N
+\N
+"123.1"
+
+-- !sql_3 --
+\N
+\N
+"123.1"
+123.1
+"123.1"
+123.1
+
+-- !sql_4 --
+{"a":2.5,"b":"123.1"}
+{"a":2.5,"b":123.1}
+{"a":2.5,"c":"123.1"}
+{"a":2.5,"c":123.1}
+{"a":2.5,"c":"123.1"}
+{"a":2.5,"b":"123.1","c":123.1}
+
+-- !sql_8 --
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+
+-- !sql_9 --
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+
+-- !sql_10 --
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+
+-- !sql_11 --
+\N \N
+\N \N
+

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



amorynan commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2204090829


##
be/src/service/internal_service.cpp:
##
@@ -1211,8 +1211,11 @@ void 
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcControlle
 if (!schemas.empty() && st.ok()) {
 // merge all
 TabletSchemaSPtr merged_schema;
-
static_cast(vectorized::schema_util::get_least_common_schema(schemas, 
nullptr,
-   
merged_schema));
+st = vectorized::schema_util::get_least_common_schema(schemas, 
nullptr,
+  
merged_schema);
+if (!st.ok()) {
+LOG(WARNING) << "Failed to get least common schema: " << 
st.to_string();

Review Comment:
   done!



##
be/src/service/internal_service.cpp:
##
@@ -1248,8 +1251,11 @@ void 
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcControlle
 if (!tablet_schemas.empty()) {
 // merge all
 TabletSchemaSPtr merged_schema;
-
static_cast(vectorized::schema_util::get_least_common_schema(
-tablet_schemas, nullptr, merged_schema));
+st = 
vectorized::schema_util::get_least_common_schema(tablet_schemas, nullptr,
+  
merged_schema);
+if (!st.ok()) {
+LOG(WARNING) << "Failed to get least common schema: " 
<< st.to_string();

Review Comment:
   done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-14 Thread via GitHub



amorynan closed pull request #53073: [fix](variant) fix the reading core caused 
by inserting nested column and scalar column in variant sub-column
URL: https://github.com/apache/doris/pull/53073


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3067747209

   
   
   ClickBench: Total hot run time: 30.31 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 51ad94d1171c64f51a758dd9347ddf7c5ff1cfef, 
data reload: false
   
   query1   0.040.040.04
   query2   0.110.060.06
   query3   0.290.060.06
   query4   1.610.080.09
   query5   0.420.410.40
   query6   1.160.660.66
   query7   0.020.020.02
   query8   0.060.050.05
   query9   0.640.530.52
   query10  0.570.600.57
   query11  0.250.130.13
   query12  0.260.130.13
   query13  0.640.620.62
   query14  0.820.850.82
   query15  0.980.900.89
   query16  0.380.370.38
   query17  1.061.071.04
   query18  0.250.230.23
   query19  1.981.881.91
   query20  0.010.020.01
   query21  15.38   0.980.68
   query22  0.931.120.86
   query23  14.68   1.510.76
   query24  5.310.600.32
   query25  0.170.090.09
   query26  0.570.220.18
   query27  0.090.080.09
   query28  11.06   1.170.59
   query29  12.52   4.053.38
   query30  0.280.080.07
   query31  2.880.630.42
   query32  3.240.610.52
   query33  3.083.263.15
   query34  16.94   5.404.68
   query35  4.764.794.76
   query36  0.650.530.51
   query37  0.210.180.17
   query38  0.180.170.16
   query39  0.050.050.04
   query40  0.200.170.16
   query41  0.100.050.05
   query42  0.060.050.05
   query43  0.060.050.05
   Total cold run time: 104.95 s
   Total hot run time: 30.31 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3067736349

   
   
   TPC-DS: Total hot run time: 187382 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 51ad94d1171c64f51a758dd9347ddf7c5ff1cfef, 
data reload: false
   
   query1   1007394 404 394
   query2   6509176417471747
   query3   6747218 225 218
   query4   27000   23754   23244   23244
   query5   4362576 435 435
   query6   317 225 211 211
   query7   4626486 294 294
   query8   275 215 211 211
   query9   8622265726442644
   query10  457 316 279 279
   query11  15623   15145   14772   14772
   query12  152 106 105 105
   query13  1651530 407 407
   query14  9378598660985986
   query15  205 195 168 168
   query16  7613428 254 254
   query17  1337709 569 569
   query18  2012403 299 299
   query19  194 180 173 173
   query20  121 119 114 114
   query21  208 124 106 106
   query22  4010414140784078
   query23  33855   32977   33002   32977
   query24  8492231723742317
   query25  533 463 397 397
   query26  1236265 147 147
   query27  2771502 344 344
   query28  4304212720872087
   query29  760 544 446 446
   query30  284 219 191 191
   query31  931 835 755 755
   query32  77  68  64  64
   query33  550 341 284 284
   query34  807 852 532 532
   query35  596 645 568 568
   query36  918 999 886 886
   query37  116 103 81  81
   query38  4214418841964188
   query39  1475140613991399
   query40  219 117 105 105
   query41  59  57  51  51
   query42  134 114 113 113
   query43  529 506 479 479
   query44  1313830 824 824
   query45  178 172 166 166
   query46  853 1008639 639
   query47  1759178917141714
   query48  381 419 300 300
   query49  732 486 417 417
   query50  651 685 435 435
   query51  5504561054685468
   query52  105 107 95  95
   query53  223 252 189 189
   query54  577 569 497 497
   query55  81  81  82  81
   query56  298 298 290 290
   query57  1201119511281128
   query58  261 250 244 244
   query59  2546266927012669
   query60  339 328 320 320
   query61  129 127 124 124
   query62  788 722 663 663
   query63  234 194 201 194
   query64  45071288827 827
   query65  4223420141404140
   query66  1053431 320 320
   query67  15932   15483   15372   15372
   query68  7895879 516 516
   query69  503 308 275 275
   query70  1191114511191119
   query71  481 328 304 304
   query72  5467470247874702
   query73  653 632 359 359
   query74  9002907388108810
   query75  3277317526952695
   query76  33031125783 783
   query77  534 381 305 305
   query78  10790   11022   10295   10295
   query79  1815825 596 596
   query80  606 527 442 442
   query81  472 250 224 224
   query82  185 124 93  93
   query83  258 250 298 250
   query84  251 111 81  81
   query85  753 367 317 317
   query86  383 303 291 291
   query87  4429437042894289
   query88  3165227322632263
   query89  375 307 287 287
   query90  1966218 203 203
   query91  140 146 115 115
   query92  67  61  55  55
   query93  1799940 583 583
   query94  685 317 194 194
   query95  374 294 289 289
   query96  498 550 278 278
   query97  2670274826402640
   query98  229 211 203 203
   query99  1357136612911291
   Total cold run time: 274727 ms
   Total hot run time: 187382 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



doris-robot commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3067719491

   
   
   TPC-H: Total hot run time: 33963 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 51ad94d1171c64f51a758dd9347ddf7c5ff1cfef, 
data reload: false
   
   -- Round 1 --
   q1   17625   529251165116
   q2   1947296 183 183
   q3   10587   1321698 698
   q4   10313   1016520 520
   q5   8897314823842384
   q6   196 159 129 129
   q7   898 739 599 599
   q8   9322125610981098
   q9   6779511450545054
   q10  6870236219441944
   q11  473 301 276 276
   q12  335 335 214 214
   q13  17771   364831053105
   q14  232 223 212 212
   q15  555 474 481 474
   q16  416 437 370 370
   q17  623 881 384 384
   q18  7436718271157115
   q19  1273953 567 567
   q20  345 354 225 225
   q21  3859324529912991
   q22  357 316 305 305
   Total cold run time: 107109 ms
   Total hot run time: 33963 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   5115510150485048
   q2   241 320 216 216
   q3   2174267322402240
   q4   1391178613721372
   q5   4227459044684468
   q6   214 171 128 128
   q7   2081195717681768
   q8   2613254727142547
   q9   7401727772857277
   q10  3118327328782878
   q11  583 514 491 491
   q12  674 772 619 619
   q13  3628392833743374
   q14  282 337 311 311
   q15  531 505 459 459
   q16  464 482 455 455
   q17  1178155213821382
   q18  7774777974097409
   q19  768 799 814 799
   q20  1915196518301830
   q21  4655420843334208
   q22  609 586 521 521
   Total cold run time: 51636 ms
   Total hot run time: 49800 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3067655045

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/51ad94d1171c64f51a758dd9347ddf7c5ff1cfef_51ad94d1171c64f51a758dd9347ddf7c5ff1cfef_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/51ad94d1171c64f51a758dd9347ddf7c5ff1cfef_51ad94d1171c64f51a758dd9347ddf7c5ff1cfef_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.77% (1270/1592) |
   | Line Coverage | 65.43% (21304/32559) |
   | Region Coverage   | 66.92% (10783/16114) |
   | Branch Coverage   | 56.61% (5685/10042) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



eldenmoon commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3067587689

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2203745758


##
be/src/service/internal_service.cpp:
##
@@ -1211,8 +1211,11 @@ void 
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcControlle
 if (!schemas.empty() && st.ok()) {
 // merge all
 TabletSchemaSPtr merged_schema;
-
static_cast(vectorized::schema_util::get_least_common_schema(schemas, 
nullptr,
-   
merged_schema));
+st = vectorized::schema_util::get_least_common_schema(schemas, 
nullptr,
+  
merged_schema);
+if (!st.ok()) {
+LOG(WARNING) << "Failed to get least common schema: " << 
st.to_string();

Review Comment:
   st = XXX



##
be/src/service/internal_service.cpp:
##
@@ -1248,8 +1251,11 @@ void 
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcControlle
 if (!tablet_schemas.empty()) {
 // merge all
 TabletSchemaSPtr merged_schema;
-
static_cast(vectorized::schema_util::get_least_common_schema(
-tablet_schemas, nullptr, merged_schema));
+st = 
vectorized::schema_util::get_least_common_schema(tablet_schemas, nullptr,
+  
merged_schema);
+if (!st.ok()) {
+LOG(WARNING) << "Failed to get least common schema: " 
<< st.to_string();

Review Comment:
   handle status instead of print log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2203745604


##
be/src/service/internal_service.cpp:
##
@@ -1211,8 +1211,11 @@ void 
PInternalService::fetch_remote_tablet_schema(google::protobuf::RpcControlle
 if (!schemas.empty() && st.ok()) {
 // merge all
 TabletSchemaSPtr merged_schema;
-
static_cast(vectorized::schema_util::get_least_common_schema(schemas, 
nullptr,
-   
merged_schema));
+st = vectorized::schema_util::get_least_common_schema(schemas, 
nullptr,
+  
merged_schema);
+if (!st.ok()) {
+LOG(WARNING) << "Failed to get least common schema: " << 
st.to_string();

Review Comment:
   handle status instead of print log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2203743977


##
regression-test/data/variant_p0/nested/load.out:
##
@@ -0,0 +1,448 @@
+-- This file is automatically generated. You should know what you did if you 
want to edit this
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a array  Yes false   \N  NONE
+v.nested.b array Yes false   \N  NONE
+v.nested.c array   Yes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":[{"a":1,"c":1.1},{"b":"1"}]}
+
+-- !sql_1 --
+[1, null]
+
+-- !sql_2 --
+[null, "1"]
+
+-- !sql_3 --
+[1.1, null]
+
+-- !sql_4 --
+[{"a":1,"c":1.1}, {"b":"1"}]
+
+-- !sql_8 --
+[1, null]  2
+
+-- !sql_9 --
+[null, 1]  2
+
+-- !sql_10 --
+[1, null]  2
+
+-- !sql_11 --
+["1", null]2
+
+-- !sql_12 --
+[null, "1"]2
+
+-- !sql_13 --
+["1.1", null]  2
+
+-- !sql_14 --
+[1, null]  2
+
+-- !sql_15 --
+[null, 1]  2
+
+-- !sql_16 --
+[1.1, null]2
+
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a array   Yes false   \N  NONE
+v.nested.b array Yes false   \N  NONE
+v.nested.c array Yes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":[{"a":1.0,"c":1.1},{"b":"1"}]}
+3  {"nested":[{"a":2.5,"b":"123.1"}]}
+4  {"nested":[{"a":2.5,"b":123.1}]}
+5  {"nested":[{"a":2.5,"c":"123.1"},{"b":"123.1"}]}
+6  {"nested":[{"a":2.5},{"b":123.1}]}
+7  {"nested":[{"a":2.5},{"c":123.1},{"b":"123.1"}]}
+
+-- !sql_1 --
+[1, null]
+[2.5]
+[2.5]
+[2.5, null]
+[2.5, null]
+[2.5, null, null]
+
+-- !sql_2 --
+[null, ""1""]
+[""123.1""]
+["123.1"]
+[null, ""123.1""]
+[null, "123.1"]
+[null, null, ""123.1""]
+
+-- !sql_3 --
+["1.1", null]
+\N
+\N
+[""123.1"", null]
+\N
+[null, "123.1", null]
+
+-- !sql_4 --
+[{"a":1.0,"c":1.1}, {"b":"1"}]
+[{"a":2.5,"b":"123.1"}]
+[{"a":2.5,"b":123.1}]
+[{"a":2.5,"c":"123.1"}, {"b":"123.1"}]
+[{"a":2.5}, {"b":123.1}]
+[{"a":2.5}, {"c":123.1}, {"b":"123.1"}]
+
+-- !sql_8 --
+[1, null]  2
+[2]1
+[2]1
+[2, null]  2
+[2, null]  2
+[2, null, null]3
+
+-- !sql_9 --
+[null, 1]  2
+[123]  1
+[123]  1
+[null, 123]2
+[null, 123]2
+[null, null, 123]  3
+
+-- !sql_10 --
+[1, null]  2
+\N \N
+\N \N
+[123, null]2
+\N \N
+[null, 123, null]  3
+
+-- !sql_11 --
+["1", null]2
+["2.5"]1
+["2.5"]1
+["2.5", null]  2
+["2.5", null]  2
+["2.5", null, null]3
+
+-- !sql_12 --
+[null, "1"]2
+["123.1"]  1
+["123.1"]  1
+[null, "123.1"]2
+[null, "123.1"]2
+[null, null, "123.1"]  3
+
+-- !sql_13 --
+["1.1", null]  2
+\N \N
+\N \N
+["123.1", null]2
+\N \N
+[null, "123.1", null]  3
+
+-- !sql_14 --
+[1, null]  2
+[2.5]  1
+[2.5]  1
+[2.5, null]2
+[2.5, null]2
+[2.5, null, null]  3
+
+-- !sql_15 --
+[null, 1]  2
+[123.1]1
+[123.1]1
+[null, 123.1]  2
+[null, 123.1]  2
+[null, null, 123.1]3
+
+-- !sql_16 --
+[1.1, null]2
+\N \N
+\N \N
+[123.1, null]  2
+\N \N
+[null, 123.1, null]3
+
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a double  Yes false   \N  NONE
+v.nested.b textYes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":{"a":2.5,"b":"123.1"}}
+
+-- !sql_1 --
+2.5
+
+-- !sql_2 --
+123.1
+
+-- !sql_3 --
+\N
+
+-- !sql_4 --
+{"a":2.5,"b":"123.1"}
+
+-- !sql_8 --
+\N \N
+
+-- !sql_9 --
+\N \N
+
+-- !sql_10 --
+\N \N
+
+-- !sql_11 --
+\N \N
+
+-- !sql_12 --
+\N \N
+
+-- !sql_13 --
+\N \N
+
+-- !sql_14 --
+\N \N
+
+-- !sql_15 --
+\N \N
+
+-- !sql_16 --
+\N \N
+
+-- !sql_desc --
+k  bigint  Yes true\N  
+v  variant Yes false   \N  NONE
+v.nested.a double  Yes false   \N  NONE
+v.nested.b jsonYes false   \N  NONE
+v.nested.c jsonYes false   \N  NONE
+
+-- !sql_0 --
+1  {"nested":{"a":2.5,"b":"123.1"}}
+3  {"nested":{"a":2.5,"b":123.1}}
+4  {"nested":{"a":2.5,"c":"123.1"}}
+5  {"nested":{"a":2.5,"c":123.1}}
+6  {"nested":{"a":2.5,"c":"123.1"}}
+7  {"nested":{"a":2.5,"b":"123.1","c":123.1}}
+
+-- !sql_1 --
+2.5
+2.5
+2.5
+2.5
+2.5
+2.5
+
+-- !sql_2 --
+"123.1"
+123.1
+\N
+\N
+\N
+"123.1"
+
+-- !sql_3 --
+\N
+\N
+"123.1"
+123.1
+"123.1"
+123.1
+
+-- !sql_4 --
+{"a":2.5,"b":"123.1"}
+{"a":2.5,"b":123.1}
+{"a":2.5,"c":"123.1"}
+{"a":2.5,"c":123.1}
+{"a":2.5,"c":"123.1"}
+{"a":2.5,"b":"123.1","c":123.1}
+
+-- !sql_8 --
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+
+-- !sql_9 --
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+
+-- !sql_10 --
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+\N \N
+
+-- !sql_11 --
+\N \N
+\N \N

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2203741072


##
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##
@@ -2460,6 +2460,11 @@ private boolean createOlapTable(Database db, 
CreateTableStmt stmt) throws UserEx
 
 boolean variantEnableFlattenNested  = false;
 try {
+// session variable: disable_variant_flatten_nested = true
+// table property: variant_enable_flatten_nested = true we should 
throw error
+if (ctx.getSessionVariable().getDisableVariantFlattenNested()) {
+throw new DdlException("Disable to create table with `VARIANT` 
type column enable flatten nested");

Review Comment:
   the message is not clear



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-13 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2203740940


##
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##
@@ -2460,6 +2460,11 @@ private boolean createOlapTable(Database db, 
CreateTableStmt stmt) throws UserEx
 
 boolean variantEnableFlattenNested  = false;
 try {
+// session variable: disable_variant_flatten_nested = true
+// table property: variant_enable_flatten_nested = true we should 
throw error
+if (ctx.getSessionVariable().getDisableVariantFlattenNested()) {
+throw new DdlException("Disable to create table with `VARIANT` 
type column enable flatten nested");

Review Comment:
   Disable to create table with `VARIANT` type, need to set 
`disable_variant_flatten_nested` = false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-10 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2199534152


##
regression-test/suites/variant_p0/nested2.groovy:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance

Review Comment:
   add nested目录，把nested2.groovy 改成load.groovy, 增加sql目录，sql目录放.sql文件



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-10 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2199525297


##
regression-test/suites/variant_p0/nested2.groovy:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance

Review Comment:
   case拆成load.groovy 和sql目录



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-10 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2199385595


##
gensrc/thrift/AgentService.thrift:
##
@@ -48,7 +48,7 @@ struct TTabletSchema {
 // col unique id for row store column
 20: optional list row_store_col_cids
 21: optional i64 row_store_page_size = 16384
-22: optional bool variant_enable_flatten_nested = false 
+22: optional bool variant_enable_flatten_nested = false // deprecated

Review Comment:
   it's not deprecated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-10 Thread via GitHub



eldenmoon commented on code in PR #53083:
URL: https://github.com/apache/doris/pull/53083#discussion_r2199384795


##
regression-test/suites/variant_p0/nested2.groovy:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   you need to test the conflict 



##
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##
@@ -776,21 +776,10 @@ public static Boolean 
analyzeDisableAutoCompaction(Map propertie
 }
 
 public static Boolean analyzeVariantFlattenNested(Map 
properties) throws AnalysisException {
-if (properties == null || properties.isEmpty()) {

Review Comment:
   better add a config（default false）， if poc need this



##
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##
@@ -776,21 +776,10 @@ public static Boolean 
analyzeDisableAutoCompaction(Map propertie
 }
 
 public static Boolean analyzeVariantFlattenNested(Map 
properties) throws AnalysisException {
-if (properties == null || properties.isEmpty()) {

Review Comment:
   test need to enable the config(session var), see 
`disable_inverted_index_v1_for_variant`



##
regression-test/suites/variant_p0/nested2.groovy:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   add structure confict cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-10 Thread via GitHub



hello-stephen commented on PR #53083:
URL: https://github.com/apache/doris/pull/53083#issuecomment-3060106966

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column [doris]

2025-07-10 Thread via GitHub



hello-stephen commented on PR #53073:
URL: https://github.com/apache/doris/pull/53073#issuecomment-3057721239

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting 
information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it 
now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and 
after the optimization?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

94 matches

Mail list logo