Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2590294484 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2585330176 ClickBench: Total hot run time: 31.54 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 1fcca4dc41aaa2b27e8a15ea8da27f6afbdfb5f0, data reload: false query1 0.040.030.03 query2 0.080.030.03 query3 0.230.070.07 query4 1.610.110.10 query5 0.430.420.41 query6 1.160.650.65 query7 0.020.020.01 query8 0.040.040.03 query9 0.590.520.51 query10 0.550.570.55 query11 0.140.100.11 query12 0.140.110.10 query13 0.600.590.59 query14 2.822.792.75 query15 0.890.820.82 query16 0.380.380.37 query17 1.070.961.07 query18 0.230.210.21 query19 1.941.881.99 query20 0.010.010.01 query21 15.39 0.920.59 query22 0.750.780.72 query23 15.27 1.370.57 query24 3.071.161.16 query25 0.120.160.09 query26 0.260.150.14 query27 0.060.050.05 query28 14.00 1.521.06 query29 12.58 3.963.26 query30 0.240.090.07 query31 2.830.590.38 query32 3.240.560.46 query33 3.123.133.05 query34 16.74 5.074.50 query35 4.504.474.47 query36 0.630.490.49 query37 0.100.060.06 query38 0.050.040.03 query39 0.030.020.03 query40 0.170.140.12 query41 0.080.030.02 query42 0.050.030.02 query43 0.040.030.03 Total cold run time: 106.29 s Total hot run time: 31.54 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2585330172 TeamCity be ut coverage result: Function Coverage: 39.87% (10422/26143) Line Coverage: 30.66% (87844/286554) Region Coverage: 29.67% (44716/150718) Branch Coverage: 26.12% (22794/87278) Coverage Report: http://coverage.selectdb-in.cc/coverage/1fcca4dc41aaa2b27e8a15ea8da27f6afbdfb5f0_1fcca4dc41aaa2b27e8a15ea8da27f6afbdfb5f0/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2585328466 TPC-DS: Total hot run time: 194200 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 1fcca4dc41aaa2b27e8a15ea8da27f6afbdfb5f0, data reload: false query1 1305966 949 949 query2 6340232324392323 query3 10958 485646874687 query4 33030 23985 23003 23003 query5 4665590 435 435 query6 298 194 191 191 query7 3980490 323 323 query8 317 265 233 233 query9 9019266026672660 query10 487 301 241 241 query11 18297 15435 15141 15141 query12 155 105 104 104 query13 1623506 375 375 query14 11212 649177756491 query15 212 202 191 191 query16 7930633 465 465 query17 1496791 598 598 query18 2095422 331 331 query19 242 196 169 169 query20 121 116 116 116 query21 206 124 106 106 query22 4679456944794479 query23 34085 34650 33407 33407 query24 6374227123002271 query25 460 449 406 406 query26 751 255 155 155 query27 2048463 330 330 query28 5495252025042504 query29 550 533 414 414 query30 215 194 152 152 query31 1018884 855 855 query32 76 60 58 58 query33 493 368 298 298 query34 757 847 517 517 query35 813 819 757 757 query36 10351052950 950 query37 129 99 74 74 query38 4161412341174117 query39 1507146414551455 query40 198 125 110 110 query41 54 51 52 51 query42 123 107 106 106 query43 520 541 501 501 query44 1370814 817 814 query45 192 197 162 162 query46 873 1063658 658 query47 1924191818391839 query48 410 401 328 328 query49 723 491 396 396 query50 637 653 391 391 query51 7273694970096949 query52 102 105 98 98 query53 241 263 193 193 query54 499 495 430 430 query55 82 82 76 76 query56 255 251 246 246 query57 1202120911371137 query58 240 247 232 232 query59 3302342231953195 query60 283 263 249 249 query61 123 122 115 115 query62 843 855 727 727 query63 228 196 194 194 query64 32751046677 677 query65 3265325332383238 query66 705 438 321 321 query67 16486 15791 15428 15428 query68 7726698 507 507 query69 488 282 260 260 query70 1249114710941094 query71 446 278 250 250 query72 6236388238203820 query73 659 747 354 354 query74 10456 884385788578 query75 4066311926232623 query76 37241176773 773 query77 773 451 267 267 query78 10370 10181 94069406 query79 4407764 582 582 query80 756 521 423 423 query81 498 266 233 233 query82 571 158 121 121 query83 203 166 147 147 query84 282 97 72 72 query85 830 340 295 295 query86 350 308 294 294 query87 4460445045024450 query88 3964216421042104 query89 438 326 297 297 query90 1916187 183 183 query91 129 136 116 116 query92 65 58 56 56 query93 1830820 523 523 query94 656 410 308 308 query95 323 252 247 247 query96 496 611 279 279 query97 2880294428072807 query98 214 202 192 192 query99 1619146913471347 Total cold run time: 297142 ms Total hot run time: 194200 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2585324397 TPC-H: Total hot run time: 32651 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 1fcca4dc41aaa2b27e8a15ea8da27f6afbdfb5f0, data reload: false -- Round 1 -- q1 17575 614960706070 q2 2051301 169 169 q3 10432 1294749 749 q4 10253 879 440 440 q5 8292219619991999 q6 209 183 153 153 q7 924 775 595 595 q8 9234137511281128 q9 5208496749194919 q10 6778229918421842 q11 464 275 253 253 q12 346 348 221 221 q13 17784 370529962996 q14 233 245 221 221 q15 568 512 502 502 q16 623 660 588 588 q17 595 868 329 329 q18 7158670164716471 q19 2420951 548 548 q20 295 317 173 173 q21 2861214019761976 q22 364 335 309 309 Total cold run time: 104667 ms Total hot run time: 32651 ms - Round 2, with runtime_filter_mode=off - q1 6344622361976197 q2 233 322 230 230 q3 2281270223052305 q4 1401183613811381 q5 4352476548324765 q6 191 176 143 143 q7 2107195418491849 q8 2630280527212721 q9 7408736373837363 q10 3080321127412741 q11 587 547 494 494 q12 690 791 566 566 q13 3510376133153315 q14 308 286 287 286 q15 577 495 526 495 q16 651 688 652 652 q17 1249176712381238 q18 7766760174007400 q19 805 907 1144907 q20 2016206718881888 q21 5594502549584958 q22 626 593 568 568 Total cold run time: 54406 ms Total hot run time: 52462 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2585295882 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2564196406 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563979422 TeamCity be ut coverage result: Function Coverage: 39.40% (10287/26112) Line Coverage: 30.01% (85921/286337) Region Coverage: 29.12% (43869/150661) Branch Coverage: 25.56% (22288/87212) Coverage Report: http://coverage.selectdb-in.cc/coverage/55e6a2e9b55fb8c30c2243338af3806765942533_55e6a2e9b55fb8c30c2243338af3806765942533/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563977610 ClickBench: Total hot run time: 31.36 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 55e6a2e9b55fb8c30c2243338af3806765942533, data reload: false query1 0.040.030.05 query2 0.070.030.03 query3 0.240.070.06 query4 1.630.110.11 query5 0.430.430.42 query6 1.150.650.65 query7 0.020.020.02 query8 0.040.030.03 query9 0.600.510.50 query10 0.570.590.55 query11 0.150.100.10 query12 0.140.120.11 query13 0.610.600.61 query14 2.852.752.74 query15 0.890.840.82 query16 0.390.370.39 query17 1.011.011.04 query18 0.230.210.22 query19 1.931.772.05 query20 0.010.010.01 query21 15.39 0.880.58 query22 0.760.920.57 query23 15.27 1.500.57 query24 2.600.961.86 query25 0.200.190.21 query26 0.240.140.14 query27 0.050.050.05 query28 14.10 1.481.04 query29 12.54 3.903.27 query30 0.250.090.07 query31 2.830.610.39 query32 3.230.550.46 query33 3.163.113.11 query34 16.86 5.194.50 query35 4.514.534.51 query36 0.660.500.49 query37 0.090.060.06 query38 0.040.040.04 query39 0.040.020.02 query40 0.170.130.13 query41 0.080.020.02 query42 0.040.020.02 query43 0.030.030.03 Total cold run time: 106.14 s Total hot run time: 31.36 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563974392 TPC-DS: Total hot run time: 196368 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 55e6a2e9b55fb8c30c2243338af3806765942533, data reload: false query1 1293982 918 918 query2 6520231923172317 query3 6 470048804700 query4 32890 23698 23491 23491 query5 3778597 466 466 query6 271 189 186 186 query7 4004527 311 311 query8 309 234 229 229 query9 9622273727242724 query10 453 308 236 236 query11 18084 15404 15255 15255 query12 152 110 106 106 query13 1565513 395 395 query14 9152674475196744 query15 251 217 188 188 query16 8410650 463 463 query17 1592791 606 606 query18 2134412 341 341 query19 219 200 167 167 query20 131 117 116 116 query21 202 131 110 110 query22 4577439043844384 query23 35535 34325 9 9 query24 6613229523382295 query25 493 437 399 399 query26 1136284 159 159 query27 2464476 391 391 query28 5847248624432443 query29 709 545 424 424 query30 206 180 151 151 query31 982 910 838 838 query32 87 65 55 55 query33 497 348 311 311 query34 776 857 532 532 query35 829 835 781 781 query36 10161085958 958 query37 118 100 74 74 query38 4167423342334233 query39 1544148414721472 query40 218 120 101 101 query41 46 50 46 46 query42 114 102 100 100 query43 535 525 495 495 query44 1364869 846 846 query45 181 177 170 170 query46 890 1068656 656 query47 1996197019531953 query48 382 415 335 335 query49 763 472 382 382 query50 625 669 399 399 query51 7267725473317254 query52 100 104 95 95 query53 228 255 194 194 query54 471 496 421 421 query55 83 87 80 80 query56 272 261 247 247 query57 1250124911781178 query58 245 228 221 221 query59 3341325931643164 query60 284 270 248 248 query61 111 124 115 115 query62 928 829 749 749 query63 231 191 187 187 query64 43071062742 742 query65 3343323832443238 query66 783 401 326 326 query67 16819 15830 15546 15546 query68 9916774 509 509 query69 480 288 257 257 query70 1217116711651165 query71 427 299 262 262 query72 6291384138763841 query73 648 746 361 361 query74 10031 921290509050 query75 4468310626562656 query76 54641192778 778 query77 1045345 273 273 query78 10170 10204 94289428 query79 4150871 591 591 query80 725 537 433 433 query81 473 267 220 220 query82 222 160 124 124 query83 201 165 142 142 query84 329 86 72 72 query85 734 374 301 301 query86 358 298 308 298 query87 4627452542444244 query88 387221942194 query89 441 332 300 300 query90 2086186 190 186 query91 132 141 104 104 query92 62 52 52 52 query93 3070855 517 517 query94 724 386 290 290 query95 325 262 258 258 query96 489 613 289 289 query97 2742281526922692 query98 219 213 199 199 query99 1673157114861486 Total cold run time: 304732 ms Total hot run time: 196368 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563966989 TPC-H: Total hot run time: 32699 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 55e6a2e9b55fb8c30c2243338af3806765942533, data reload: false -- Round 1 -- q1 17584 619460366036 q2 2053308 178 178 q3 10775 1233727 727 q4 10198 856 436 436 q5 7508217520012001 q6 203 185 148 148 q7 900 746 609 609 q8 9250139111861186 q9 5359499649604960 q10 6786231718611861 q11 493 281 257 257 q12 351 362 222 222 q13 17773 357729892989 q14 228 230 213 213 q15 567 500 492 492 q16 630 612 586 586 q17 585 861 329 329 q18 7122651164456445 q19 2013970 548 548 q20 299 310 194 194 q21 2823220919721972 q22 362 340 310 310 Total cold run time: 103862 ms Total hot run time: 32699 ms - Round 2, with runtime_filter_mode=off - q1 6278620961706170 q2 238 326 227 227 q3 2242265823402340 q4 1411182513321332 q5 4340477247934772 q6 185 186 146 146 q7 2058201018161816 q8 2654279126922692 q9 7344730273767302 q10 3077336127632763 q11 578 496 482 482 q12 678 746 633 633 q13 3377380631133113 q14 294 311 274 274 q15 584 536 503 503 q16 645 682 653 653 q17 1277175012521252 q18 7715746173777377 q19 817 113710931093 q20 2024201619041904 q21 5721522049304930 q22 592 616 594 594 Total cold run time: 54129 ms Total hot run time: 52368 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563914740 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563626485 TeamCity be ut coverage result: Function Coverage: 39.40% (10289/26112) Line Coverage: 30.01% (85914/286277) Region Coverage: 29.13% (43869/150614) Branch Coverage: 25.57% (22288/87174) Coverage Report: http://coverage.selectdb-in.cc/coverage/9d5dc10b514cfba4259ad6ad7fca7c71b0942a6e_9d5dc10b514cfba4259ad6ad7fca7c71b0942a6e/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563608527 ClickBench: Total hot run time: 31.32 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 9d5dc10b514cfba4259ad6ad7fca7c71b0942a6e, data reload: false query1 0.030.030.04 query2 0.080.030.03 query3 0.240.070.06 query4 1.620.100.10 query5 0.450.400.40 query6 1.160.660.65 query7 0.020.020.01 query8 0.040.030.04 query9 0.550.520.50 query10 0.590.590.55 query11 0.140.100.11 query12 0.140.100.10 query13 0.610.600.60 query14 2.812.772.79 query15 0.900.820.84 query16 0.380.390.39 query17 1.071.061.07 query18 0.230.210.20 query19 1.991.772.02 query20 0.010.010.01 query21 15.36 0.880.58 query22 0.760.780.63 query23 15.33 1.380.53 query24 3.270.961.17 query25 0.260.140.08 query26 0.240.140.14 query27 0.070.040.04 query28 13.30 1.581.05 query29 12.63 3.903.26 query30 0.260.090.06 query31 2.830.620.37 query32 3.220.560.49 query33 3.183.203.15 query34 16.70 5.094.53 query35 4.554.484.49 query36 0.620.480.48 query37 0.100.070.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.170.130.12 query41 0.080.030.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 106.13 s Total hot run time: 31.32 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563604670 TPC-DS: Total hot run time: 190518 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9d5dc10b514cfba4259ad6ad7fca7c71b0942a6e, data reload: false query1 970 377 390 377 query2 6511250525442505 query3 6710216 215 215 query4 33688 23673 23361 23361 query5 4354652 501 501 query6 296 206 193 193 query7 4641523 315 315 query8 303 246 237 237 query9 9606274527262726 query10 465 299 272 272 query11 18311 15396 15594 15396 query12 166 109 105 105 query13 1680548 415 415 query14 11675 678373636783 query15 235 197 187 187 query16 8300634 452 452 query17 1620775 576 576 query18 2113430 287 287 query19 213 174 144 144 query20 114 121 113 113 query21 200 122 99 99 query22 4388449142014201 query23 35048 33117 33492 33117 query24 6421221822332218 query25 441 430 373 373 query26 1070258 151 151 query27 2033496 332 332 query28 5340243324102410 query29 550 549 426 426 query30 224 181 149 149 query31 1008934 795 795 query32 92 62 56 56 query33 498 339 298 298 query34 774 875 500 500 query35 812 832 745 745 query36 10111024957 957 query37 123 99 70 70 query38 4135438141194119 query39 1486144814291429 query40 208 119 105 105 query41 49 49 44 44 query42 119 101 100 100 query43 540 543 515 515 query44 1339806 821 806 query45 191 180 170 170 query46 890 1066639 639 query47 1875190318551855 query48 384 412 344 344 query49 782 474 374 374 query50 685 681 389 389 query51 6991703070287028 query52 102 102 90 90 query53 227 254 185 185 query54 490 500 399 399 query55 85 78 83 78 query56 257 270 242 242 query57 1207115210941094 query58 237 225 226 225 query59 3243320931313131 query60 268 261 251 251 query61 108 105 104 104 query62 865 802 732 732 query63 244 191 186 186 query64 4445985 653 653 query65 3265317332403173 query66 1048422 337 337 query67 16112 15838 15589 15589 query68 9421774 510 510 query69 491 299 257 257 query70 1236114011031103 query71 441 294 241 241 query72 5651387537983798 query73 673 812 360 360 query74 9783940392219221 query75 4626324226182618 query76 54901260815 815 query77 1003384 271 271 query78 10002 10304 98029802 query79 3619927 589 589 query80 724 540 421 421 query81 478 277 230 230 query82 345 150 116 116 query83 193 241 141 141 query84 279 91 69 69 query85 740 351 301 301 query86 360 309 285 285 query87 4653442444684424 query88 3295221722032203 query89 444 330 297 297 query90 2121190 189 189 query91 128 138 102 102 query92 68 55 57 55 query93 2113878 513 513 query94 655 405 295 295 query95 333 269 253 253 query96 505 665 286 286 query97 2762284226972697 query98 234 203 200 200 query99 1639157314131413 Total cold run time: 298386 ms Total hot run time: 190518 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563595778 TPC-H: Total hot run time: 32789 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 9d5dc10b514cfba4259ad6ad7fca7c71b0942a6e, data reload: false -- Round 1 -- q1 17594 614560496049 q2 2046313 162 162 q3 10409 1324727 727 q4 10209 872 438 438 q5 7522227420302030 q6 206 182 149 149 q7 910 744 622 622 q8 9239141612101210 q9 5200505450025002 q10 6765233218801880 q11 476 274 263 263 q12 347 366 226 226 q13 17788 360929812981 q14 240 237 214 214 q15 568 498 483 483 q16 651 627 576 576 q17 574 874 332 332 q18 7068658163606360 q19 1634997 583 583 q20 321 323 185 185 q21 3062220720022002 q22 360 335 315 315 Total cold run time: 103189 ms Total hot run time: 32789 ms - Round 2, with runtime_filter_mode=off - q1 6288622362606223 q2 243 331 233 233 q3 2230266823412341 q4 1431182013341334 q5 4426478349364783 q6 193 175 143 143 q7 2120202217851785 q8 2627283726762676 q9 7329725072287228 q10 3061333528202820 q11 584 532 507 507 q12 634 758 597 597 q13 3348383331573157 q14 306 316 293 293 q15 572 496 492 492 q16 637 690 640 640 q17 1204173512301230 q18 7809740271027102 q19 819 114810381038 q20 1912197718891889 q21 5617512448644864 q22 602 601 547 547 Total cold run time: 53992 ms Total hot run time: 51922 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563555244 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2563364329 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2548949774 ClickBench: Total hot run time: 32.52 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit de8451ba13307a712d282850d246db34b34899fc, data reload: false query1 0.040.030.03 query2 0.070.030.03 query3 0.240.080.08 query4 1.600.110.11 query5 0.420.390.39 query6 1.140.640.66 query7 0.020.020.02 query8 0.040.030.03 query9 0.560.510.51 query10 0.550.580.55 query11 0.150.110.11 query12 0.150.100.11 query13 0.610.600.61 query14 2.712.872.78 query15 0.910.840.82 query16 0.390.370.38 query17 1.060.981.02 query18 0.230.210.20 query19 1.941.781.83 query20 0.020.010.01 query21 15.37 0.580.57 query22 3.032.741.59 query23 17.01 0.840.76 query24 3.681.601.24 query25 0.250.190.09 query26 0.540.130.13 query27 0.050.040.04 query28 9.821.101.06 query29 12.59 3.263.26 query30 0.250.060.06 query31 2.880.400.36 query32 3.270.460.46 query33 2.972.993.06 query34 16.52 4.504.54 query35 4.554.484.50 query36 0.720.470.48 query37 0.090.060.06 query38 0.050.040.04 query39 0.040.020.02 query40 0.160.130.13 query41 0.080.020.03 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 106.83 s Total hot run time: 32.52 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2548933890 TPC-DS: Total hot run time: 191119 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit de8451ba13307a712d282850d246db34b34899fc, data reload: false query1 993 408 388 388 query2 6518211620942094 query3 6721226 212 212 query4 33983 23523 23425 23425 query5 4439465 468 465 query6 285 206 202 202 query7 4625299 319 299 query8 313 250 234 234 query9 9347269626962696 query10 486 258 254 254 query11 18112 15270 15261 15261 query12 164 104 110 104 query13 1696452 436 436 query14 9836765672237223 query15 294 177 183 177 query16 8216449 489 449 query17 1822590 567 567 query18 2153305 338 305 query19 370 150 147 147 query20 115 114 110 110 query21 213 108 103 103 query22 4391430141324132 query23 34438 33840 33926 33840 query24 11581 242925122429 query25 693 397 382 382 query26 1769157 155 155 query27 2782273 275 273 query28 7990245224132413 query29 1028427 431 427 query30 293 150 151 150 query31 1010811 821 811 query32 103 60 82 60 query33 776 301 289 289 query34 982 554 528 528 query35 886 748 733 733 query36 1108948 934 934 query37 277 77 77 77 query38 4371418241654165 query39 1465144114201420 query40 283 101 98 98 query41 49 43 42 42 query42 115 101 104 101 query43 529 503 480 480 query44 1275811 806 806 query45 176 168 170 168 query46 1149715 706 706 query47 1944184118641841 query48 412 331 323 323 query49 1292398 397 397 query50 800 384 390 384 query51 7255715772617157 query52 99 93 89 89 query53 261 182 186 182 query54 1196424 412 412 query55 97 79 79 79 query56 260 257 254 254 query57 1246113911521139 query58 232 216 247 216 query59 3276313330483048 query60 268 248 255 248 query61 108 107 104 104 query62 892 675 688 675 query63 216 188 193 188 query64 5047703 669 669 query65 3296318232273182 query66 1426308 307 307 query67 15821 15615 15467 15467 query68 4995566 591 566 query69 419 253 264 253 query70 1155114011631140 query71 335 252 250 250 query72 6410405740834057 query73 760 367 368 367 query74 10460 896689748966 query75 3428265426942654 query76 2969112610911091 query77 553 285 277 277 query78 10377 952393829382 query79 2373610 619 610 query80 1020417 422 417 query81 540 238 232 232 query82 918 119 119 119 query83 283 148 146 146 query84 239 77 73 73 query85 1305317 310 310 query86 406 305 300 300 query87 4737449244084408 query88 4088221321792179 query89 406 292 297 292 query90 2213222 190 190 query91 138 112 105 105 query92 63 52 53 52 query93 1801551 557 551 query94 1133298 305 298 query95 367 256 254 254 query96 638 281 288 281 query97 2782266327142663 query98 216 211 197 197 query99 1520134413081308 Total cold run time: 304711 ms Total hot run time: 191119 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2548902000 TPC-H: Total hot run time: 40379 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit de8451ba13307a712d282850d246db34b34899fc, data reload: false -- Round 1 -- q1 17611 759773407340 q2 2051176 175 175 q3 10537 115411611154 q4 10231 827 717 717 q5 7594276627662766 q6 238 147 146 146 q7 1020635 618 618 q8 9238189719751897 q9 6733645664846456 q10 6972235923882359 q11 471 263 277 263 q12 417 225 221 221 q13 1 301330473013 q14 233 207 211 207 q15 573 536 524 524 q16 648 576 589 576 q17 1032563 534 534 q18 7260662667536626 q19 13421023942 942 q20 494 189 183 183 q21 4043333933983339 q22 384 331 323 323 Total cold run time: 106899 ms Total hot run time: 40379 ms - Round 2, with runtime_filter_mode=off - q1 7277726572677265 q2 335 225 246 225 q3 2963290531192905 q4 2185187418431843 q5 5631573756795679 q6 229 140 144 140 q7 2180176618991766 q8 3428353335303530 q9 9029902889938993 q10 3629353335573533 q11 604 510 490 490 q12 802 634 596 596 q13 12129 320431713171 q14 310 292 286 286 q15 570 524 519 519 q16 676 653 641 641 q17 1832162615861586 q18 8429771377237713 q19 1744158215441544 q20 2100179818071798 q21 5445527853605278 q22 644 553 602 553 Total cold run time: 72171 ms Total hot run time: 60054 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2548695549 run performence -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2548696457 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
github-actions[bot] commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543114981 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543080162 TeamCity be ut coverage result: Function Coverage: 39.26% (10274/26172) Line Coverage: 29.83% (85287/285941) Region Coverage: 28.86% (43719/151503) Branch Coverage: 25.32% (22122/87380) Coverage Report: http://coverage.selectdb-in.cc/coverage/de8451ba13307a712d282850d246db34b34899fc_de8451ba13307a712d282850d246db34b34899fc/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543068105 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543048979 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-254305 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2542952611 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2542843610 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2542819208 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
zclllyybb commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1884180249
##
be/src/vec/functions/function_date_or_datetime_computation.cpp:
##
@@ -21,24 +21,53 @@
namespace doris::vectorized {
-using FunctionAddSeconds =
FunctionDateOrDateTimeComputation>;
-using FunctionAddMinutes =
FunctionDateOrDateTimeComputation>;
-using FunctionAddHours =
FunctionDateOrDateTimeComputation>;
-using FunctionAddDays =
FunctionDateOrDateTimeComputation>;
-using FunctionAddWeeks =
FunctionDateOrDateTimeComputation>;
-using FunctionAddMonths =
FunctionDateOrDateTimeComputation>;
-using FunctionAddQuarters =
FunctionDateOrDateTimeComputation>;
-using FunctionAddYears =
FunctionDateOrDateTimeComputation>;
-
-using FunctionSubSeconds =
FunctionDateOrDateTimeComputation>;
-using FunctionSubMinutes =
FunctionDateOrDateTimeComputation>;
-using FunctionSubHours =
FunctionDateOrDateTimeComputation>;
-using FunctionSubDays =
FunctionDateOrDateTimeComputation>;
-using FunctionSubWeeks =
FunctionDateOrDateTimeComputation>;
-using FunctionSubMonths =
FunctionDateOrDateTimeComputation>;
-using FunctionSubQuarters =
+using FunctionDatetimeAddSeconds =
+FunctionDateOrDateTimeComputation>;
+using FunctionDatetimeAddMinutes =
+FunctionDateOrDateTimeComputation>;
+using FunctionDatetimeAddHours =
FunctionDateOrDateTimeComputation>;
+using FunctionDatetimeAddDays =
FunctionDateOrDateTimeComputation>;
+using FunctionDatetimeAddWeeks =
FunctionDateOrDateTimeComputation>;
+using FunctionDatetimeAddMonths =
+FunctionDateOrDateTimeComputation>;
+using FunctionDatetimeAddQuarters =
+FunctionDateOrDateTimeComputation>;
+using FunctionDatetimeAddYears =
FunctionDateOrDateTimeComputation>;
+
+using FunctionAddSeconds =
FunctionDateOrDateTimeComputation>;
Review Comment:
also add type for these
##
be/src/vec/functions/function_date_or_datetime_computation.h:
##
@@ -89,7 +89,15 @@ extern ResultType date_time_add(const Arg& t, Int64 delta,
bool& is_null) {
template
\
struct CLASS {
\
using ReturnType = std::conditional_t<
\
-date_cast::IsV1(), DataTypeDateTime,
\
+date_cast::IsV1(),
\
Review Comment:
make sure this pr's content has relative information
##
be/src/vec/functions/array/function_array_apply.cpp:
##
@@ -64,6 +64,8 @@ class FunctionArrayApply : public IFunction {
size_t get_number_of_arguments() const override { return 3; }
ColumnNumbers get_arguments_that_are_always_constant() const override {
return {1, 2}; }
+bool dont_append_return_type_name_when_register_function() const override
{ return true; }
Review Comment:
use `has_return_type_in_signature` as name and use the opposite in values
and usages
##
be/src/vec/functions/simple_function_factory.h:
##
@@ -183,17 +196,19 @@ class SimpleFunctionFactory {
: arg.type->get_family_name());
}
}
+key_str.append(remove_nullable(return_type)->get_family_name());
auto iter = function_creators.find(key_str);
Review Comment:
add comment here, why the return type check is active here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2541477582 TeamCity be ut coverage result: Function Coverage: 39.27% (10277/26172) Line Coverage: 29.83% (85277/285922) Region Coverage: 28.86% (43724/151490) Branch Coverage: 25.32% (22119/87370) Coverage Report: http://coverage.selectdb-in.cc/coverage/76abb9a47c1e651e7c5a6858cf47089b2cf6e847_76abb9a47c1e651e7c5a6858cf47089b2cf6e847/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2541311561 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2540557819 TeamCity be ut coverage result: Function Coverage: 39.27% (10277/26171) Line Coverage: 29.84% (85294/285811) Region Coverage: 28.87% (43720/151448) Branch Coverage: 25.32% (22119/87342) Coverage Report: http://coverage.selectdb-in.cc/coverage/2c93a9b138e2cf40b39b9bba6afa41065258fa22_2c93a9b138e2cf40b39b9bba6afa41065258fa22/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2540536301 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2540485156 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
github-actions[bot] commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1883214966
##
be/test/vec/function/function_time_test.cpp:
##
@@ -15,6 +15,7 @@
// specific language governing permissions and limitations
// under the License.
+#include
Review Comment:
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
```cpp
#include
^
```
##
be/test/vec/function/function_test_util.h:
##
@@ -214,7 +214,8 @@ void check_vec_table_function(TableFunction* fn, const
InputTypeSet& input_types
// A DataSet with a constant column can only have one row of data
template
Status check_function(const std::string& func_name, const InputTypeSet&
input_types,
Review Comment:
warning: function 'check_function' has cognitive complexity of 58 (threshold
50) [readability-function-cognitive-complexity]
```cpp
Status check_function(const std::string& func_name, const InputTypeSet&
input_types,
^
```
Additional context
**be/test/vec/function/function_test_util.h:225:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (size_t i = 0; i < descs.size(); ++i) {
^
```
**be/test/vec/function/function_test_util.h:231:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
?
((DataTypeNullable*)(desc.data_type.get()))->get_nested_type()
^
```
**be/test/vec/function/function_test_util.h:233:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
for (int j = 0; j < row_size; j++) {
^
```
**be/test/vec/function/function_test_util.h:237:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (desc.is_const) {
^
```
**be/test/vec/function/function_test_util.h:248:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (size_t i = 0; i < descs.size(); ++i) {
^
```
**be/test/vec/function/function_test_util.h:252:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (desc.is_const) {
^
```
**be/test/vec/function/function_test_util.h:256:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/test/vec/function/function_test_util.h:262:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
auto return_type = nullable ?
make_nullable(std::make_shared())
^
```
**be/test/vec/function/function_test_util.h:266:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (expect_not_found_function) {
^
```
**be/test/vec/function/function_test_util.h:273:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if constexpr (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:275:** +1, nesting level
increased to 1
```cpp
} else if constexpr (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:277:** +1, nesting level
increased to 1
```cpp
} else if constexpr (std::is_same_v ||
^
```
**be/test/vec/function/function_test_util.h:280:** +1, nesting level
increased to 1
```cpp
} else if constexpr (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:282:** +1, nesting level
increased to 1
```cpp
} else if (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:284:** +1, nesting level
increased to 1
```cpp
} else if (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:286:** +1, nesting level
increased to 1
```cpp
} else if (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:288:** +1, nesting level
increased to 1
```cpp
} else if (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:290:** +1, nesting level
increased to 1
```cpp
} else if (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:292:** +1, nesting level
increased to 1
```cpp
} else if (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:294:** +1, nesting level
increased to 1
```cpp
} else if (std::is_same_v) {
^
```
**be/test/vec/function/function_test_util.h:296:** +1, nesting level
increased to 1
```cpp
} else {
^
```
**be/test/vec/function/function_test_util.h:310:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (expect_fail) {
^
```
**be/test/vec/function/function_te
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2540464081 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
github-actions[bot] commented on code in PR #45159: URL: https://github.com/apache/doris/pull/45159#discussion_r1883184550 ## be/src/vec/functions/function_string.h: ## @@ -17,6 +17,7 @@ #pragma once +#include Review Comment: warning: 'glog/logging.h' file not found [clang-diagnostic-error] ```cpp #include ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2540425299 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
feiniaofeiafei commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1881506335
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ToDateV2.java:
##
@@ -67,4 +69,19 @@ public List getSignatures() {
public R accept(ExpressionVisitor visitor, C context) {
return visitor.visitToDateV2(this, context);
}
+
+@Override
+public boolean isPositive() {
+return true;
+}
+
+@Override
+public int getMonotonicFunctionChildIndex() {
+return 0;
+}
+
+@Override
+public Expression withConstantArgs(Expression literal) {
+return new Date(literal);
Review Comment:
why don't return new ToDateV2(literal)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
feiniaofeiafei commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1881505719
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ToDate.java:
##
@@ -70,4 +72,19 @@ public List getSignatures() {
public R accept(ExpressionVisitor visitor, C context) {
return visitor.visitToDate(this, context);
}
+
+@Override
+public boolean isPositive() {
+return true;
+}
+
+@Override
+public int getMonotonicFunctionChildIndex() {
+return 0;
+}
+
+@Override
+public Expression withConstantArgs(Expression literal) {
+return new Date(literal);
Review Comment:
why don't return new ToDate(literal)? maybe adding Monotonic of Datev2,
ToDate, ToDateV2 need some tests in partition prune. Can we choose to not add
Monotonic for Datev2, ToDate, ToDateV2 in this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1881349445
##
be/src/vec/functions/function.h:
##
@@ -299,6 +299,10 @@ class FunctionBuilderImpl : public IFunctionBuilder {
ColumnNumbers get_arguments_that_are_always_constant() const override {
return {}; }
+// if a function's get_variadic_argument_types() not override and
get_return_type_impl()
+// result is not compile time be sure, the function should override return
true
+virtual bool dont_append_return_type_name_when_register_function() {
return false; }
Review Comment:
the `register_function()` arg `Creator& ptr` is a FunctionBuilder so cant
impl it in IFunctionBase it move to IFunctionBuilder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
zclllyybb commented on code in PR #45159:
URL: https://github.com/apache/doris/pull/45159#discussion_r1877224039
##
be/src/vec/functions/simple_function_factory.h:
##
@@ -158,19 +167,21 @@ class SimpleFunctionFactory {
FunctionBasePtr get_function(const std::string& name, const
ColumnsWithTypeAndName& arguments,
const DataTypePtr& return_type, const
FunctionAttr& attr = {},
int be_version =
BeExecVersionManager::get_newest_version()) {
-std::string key_str = name;
+std::string key_str, ori_name = name;
Review Comment:
split definition. use `origin_name`
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Date.java:
##
Review Comment:
add regression-test about null
##
be/src/vec/functions/simple_function_factory.h:
##
@@ -158,19 +167,21 @@ class SimpleFunctionFactory {
FunctionBasePtr get_function(const std::string& name, const
ColumnsWithTypeAndName& arguments,
const DataTypePtr& return_type, const
FunctionAttr& attr = {},
int be_version =
BeExecVersionManager::get_newest_version()) {
-std::string key_str = name;
+std::string key_str, ori_name = name;
Review Comment:
add comment on these two var
##
gensrc/script/doris_builtins_functions.py:
##
Review Comment:
revert this
##
be/src/vec/functions/function.h:
##
@@ -299,6 +299,10 @@ class FunctionBuilderImpl : public IFunctionBuilder {
ColumnNumbers get_arguments_that_are_always_constant() const override {
return {}; }
+// if a function's get_variadic_argument_types() not override and
get_return_type_impl()
+// result is not compile time be sure, the function should override return
true
+virtual bool dont_append_return_type_name_when_register_function() {
return false; }
Review Comment:
impl it in `IFunctionBase`, so we can do check in function factory.
if not possible, add comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2526172504 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2526082537 TPC-H: Total hot run time: 39869 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ccad421c5072729e13a277000d4e9236994c607b, data reload: false -- Round 1 -- q1 17624 749372877287 q2 2042179 162 162 q3 10769 107112151071 q4 10514 728 756 728 q5 7596271226732673 q6 237 147 147 147 q7 984 611 607 607 q8 9232188019241880 q9 6592650164556455 q10 6988231023252310 q11 462 262 241 241 q12 426 221 229 221 q13 17757 301830213018 q14 247 223 208 208 q15 570 548 529 529 q16 639 579 583 579 q17 970 576 556 556 q18 7143669465796579 q19 13371066965 965 q20 458 181 179 179 q21 4041315731863157 q22 375 317 318 317 Total cold run time: 107003 ms Total hot run time: 39869 ms - Round 2, with runtime_filter_mode=off - q1 7254727372327232 q2 327 229 229 229 q3 2862279229162792 q4 2047180518261805 q5 5659564656425642 q6 228 142 144 142 q7 2241183618081808 q8 3366355834913491 q9 9009904990949049 q10 3594352235283522 q11 605 511 499 499 q12 817 639 612 612 q13 11381 321832133213 q14 322 286 275 275 q15 577 530 519 519 q16 693 649 655 649 q17 1861160715981598 q18 8259766376037603 q19 1685157115231523 q20 2093186718381838 q21 5578544753865386 q22 655 563 567 563 Total cold run time: 71113 ms Total hot run time: 59990 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2526132104 ClickBench: Total hot run time: 33.24 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ccad421c5072729e13a277000d4e9236994c607b, data reload: false query1 0.030.030.06 query2 0.070.030.04 query3 0.230.080.07 query4 1.610.100.11 query5 0.430.440.40 query6 1.150.640.65 query7 0.020.010.01 query8 0.040.030.03 query9 0.580.510.50 query10 0.570.540.57 query11 0.130.100.10 query12 0.140.110.11 query13 0.600.610.58 query14 2.742.812.87 query15 0.900.820.82 query16 0.390.390.40 query17 1.051.041.02 query18 0.220.210.20 query19 1.901.851.95 query20 0.010.010.01 query21 15.37 0.610.60 query22 2.302.502.01 query23 16.88 1.130.79 query24 2.991.271.78 query25 0.270.240.13 query26 0.480.140.14 query27 0.060.040.04 query28 9.811.101.08 query29 12.56 3.283.27 query30 0.250.060.06 query31 2.880.380.37 query32 3.280.470.46 query33 2.973.063.09 query34 16.83 4.464.50 query35 4.504.484.47 query36 0.660.480.50 query37 0.090.060.06 query38 0.050.030.04 query39 0.030.020.02 query40 0.170.130.13 query41 0.080.020.02 query42 0.040.020.02 query43 0.030.030.03 Total cold run time: 105.39 s Total hot run time: 33.24 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2526124629 TPC-DS: Total hot run time: 197769 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ccad421c5072729e13a277000d4e9236994c607b, data reload: false query1 1250964 948 948 query2 6230208020392039 query3 10951 443944044404 query4 67345 28907 23662 23662 query5 4949470 468 468 query6 423 193 188 188 query7 5473310 305 305 query8 325 250 247 247 query9 8617263226272627 query10 418 249 244 244 query11 17068 15200 15974 15200 query12 156 111 103 103 query13 1455447 431 431 query14 9929743373937393 query15 214 174 187 174 query16 7068457 477 457 query17 1421563 569 563 query18 1774308 296 296 query19 201 148 148 148 query20 121 118 111 111 query21 211 103 97 97 query22 4756469546844684 query23 34865 34428 34470 34428 query24 5463249125552491 query25 523 382 383 382 query26 652 155 159 155 query27 1837279 288 279 query28 4539248424532453 query29 691 412 426 412 query30 208 157 151 151 query31 1036864 839 839 query32 65 53 56 53 query33 462 277 281 277 query34 952 506 534 506 query35 907 785 762 762 query36 1102971 964 964 query37 121 71 76 71 query38 4481435143804351 query39 1521147714681468 query40 198 103 97 97 query41 42 43 42 42 query42 114 97 102 97 query43 536 495 488 488 query44 1248826 833 826 query45 184 173 170 170 query46 1171737 725 725 query47 2066194919161916 query48 423 306 323 306 query49 717 416 392 392 query50 834 398 397 397 query51 7343706270767062 query52 95 83 87 83 query53 252 178 179 178 query54 509 400 405 400 query55 78 74 73 73 query56 277 244 249 244 query57 1263110011371100 query58 224 225 217 217 query59 3165308729702970 query60 289 253 261 253 query61 133 123 128 123 query62 785 670 702 670 query63 222 197 193 193 query64 1339674 669 669 query65 3308319832463198 query66 691 301 296 296 query67 15941 15675 15737 15675 query68 3723592 587 587 query69 425 255 246 246 query70 1176111810481048 query71 387 252 245 245 query72 6377407840834078 query73 765 350 354 350 query74 10204 906789648964 query75 3385266426592659 query76 1839112811261126 query77 461 273 265 265 query78 10531 960295099509 query79 1612587 593 587 query80 1020428 434 428 query81 483 231 245 231 query82 1240120 116 116 query83 159 148 154 148 query84 282 68 69 68 query85 930 296 298 296 query86 330 292 307 292 query87 4771458246964582 query88 3734215821272127 query89 423 302 286 286 query90 2035185 190 185 query91 137 100 106 100 query92 61 49 48 48 query93 1922558 557 557 query94 760 294 282 282 query95 365 247 244 244 query96 617 278 273 273 query97 2895266626752666 query98 226 188 195 188 query99 1603129713051297 Total cold run time: 318105 ms Total hot run time: 197769 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2526070190 TeamCity be ut coverage result: Function Coverage: 38.99% (10174/26092) Line Coverage: 29.65% (84356/284532) Region Coverage: 28.71% (43296/150786) Branch Coverage: 25.21% (21915/86932) Coverage Report: http://coverage.selectdb-in.cc/coverage/ccad421c5072729e13a277000d4e9236994c607b_ccad421c5072729e13a277000d4e9236994c607b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2525955014 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2525954760 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
