Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
zhannngchen merged PR #41636: URL: https://github.com/apache/doris/pull/41636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2530799485 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2526714510 TeamCity be ut coverage result: Function Coverage: 38.49% (10009/26004) Line Coverage: 29.50% (83911/28) Region Coverage: 28.60% (43127/150785) Branch Coverage: 25.20% (21927/87012) Coverage Report: http://coverage.selectdb-in.cc/coverage/f3ee6b036ebd9b5a8d656a6e4f38984a24aa398a_f3ee6b036ebd9b5a8d656a6e4f38984a24aa398a/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2526676003 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2523414201 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2519344850 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2517098592 TeamCity be ut coverage result: Function Coverage: 38.47% (10008/26012) Line Coverage: 29.52% (83925/284290) Region Coverage: 28.62% (43127/150686) Branch Coverage: 25.21% (21918/86944) Coverage Report: http://coverage.selectdb-in.cc/coverage/3d587b1dffc0e807efd8ebd9bfe5f9699ea8c584_3d587b1dffc0e807efd8ebd9bfe5f9699ea8c584/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2517017258 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2516732573 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2516732478 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on code in PR #41636:
URL: https://github.com/apache/doris/pull/41636#discussion_r1869079721
##
be/src/olap/compaction.cpp:
##
@@ -1045,6 +1072,12 @@ Status CompactionMixin::modify_rowsets() {
tablet()->delete_expired_stale_rowset();
}
+if (compaction_type() == ReaderType::READER_CUMULATIVE_COMPACTION &&
Review Comment:
@zhannngchen done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2516719404 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
zhannngchen commented on code in PR #41636:
URL: https://github.com/apache/doris/pull/41636#discussion_r1867721573
##
be/src/olap/compaction.cpp:
##
@@ -1045,6 +1072,12 @@ Status CompactionMixin::modify_rowsets() {
tablet()->delete_expired_stale_rowset();
}
+if (compaction_type() == ReaderType::READER_CUMULATIVE_COMPACTION &&
Review Comment:
use config `config::enable_delete_bitmap_merge_on_compaction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2510720757 TeamCity be ut coverage result: Function Coverage: 38.41% (9995/26022) Line Coverage: 29.45% (83697/284184) Region Coverage: 28.57% (43064/150722) Branch Coverage: 25.19% (21889/86884) Coverage Report: http://coverage.selectdb-in.cc/coverage/0b6b024275fb42b4e0f7c290cd2b62c2e6ca1559_0b6b024275fb42b4e0f7c290cd2b62c2e6ca1559/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2510688058 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2507037889 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2503968750 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2490890766 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2490711929 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2490628525 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2449006033 TeamCity be ut coverage result: Function Coverage: 37.92% (9850/25975) Line Coverage: 29.19% (82094/281203) Region Coverage: 28.44% (42349/148886) Branch Coverage: 25.02% (21520/86002) Coverage Report: http://coverage.selectdb-in.cc/coverage/e5717fb37a1e403b361eda8caed85ba0759385a5_e5717fb37a1e403b361eda8caed85ba0759385a5/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2448976627 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2448972633 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2440430290 TeamCity be ut coverage result: Function Coverage: 37.46% (9717/25938) Line Coverage: 28.73% (80602/280525) Region Coverage: 28.16% (41679/148021) Branch Coverage: 24.72% (21179/85682) Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2440339379 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2406990797 TeamCity be ut coverage result: Function Coverage: 37.40% (9660/25828) Line Coverage: 28.67% (80153/279566) Region Coverage: 28.10% (41446/147493) Branch Coverage: 24.71% (21115/85450) Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2406884860 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2406419669 TeamCity be ut coverage result: Function Coverage: 37.41% (9662/25829) Line Coverage: 28.68% (80163/279529) Region Coverage: 28.11% (41457/147479) Branch Coverage: 24.71% (2/85440) Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2406381080 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2404432747 TeamCity be ut coverage result: Function Coverage: 37.41% (9663/25828) Line Coverage: 28.69% (80188/279504) Region Coverage: 28.12% (41459/147427) Branch Coverage: 24.72% (21116/85414) Coverage Report: http://coverage.selectdb-in.cc/coverage/73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142_73d9c5a3fda0ff0d36b8b4a2a8bd20b99e46d142/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
BiteThet commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2404199263 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
github-actions[bot] commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2403825653 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
doris-robot commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2403819168 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [improve](mow) merge and remove old version of delete bitmap when cumulative compaction is done on local mode [doris]
hust-hhb commented on PR #41636: URL: https://github.com/apache/doris/pull/41636#issuecomment-2403819419 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
