Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
BiteThet merged PR #42445: URL: https://github.com/apache/doris/pull/42445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2488237068 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
doris-robot commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2488324993 TPC-H: Total hot run time: 40271 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8acb29ae438731fc4018126b4f1e1a8dfd49ca23, data reload: false -- Round 1 -- q1 17595 747574037403 q2 2037173 169 169 q3 10596 110711361107 q4 10579 740 749 740 q5 7613274726942694 q6 244 146 146 146 q7 996 631 614 614 q8 9247187419071874 q9 6545639363946393 q10 6993231223522312 q11 462 263 265 263 q12 432 222 226 222 q13 17781 307230863072 q14 242 214 214 214 q15 576 533 521 521 q16 657 596 587 587 q17 975 542 529 529 q18 7135681967616761 q19 1334949 1044949 q20 465 181 184 181 q21 4040340332023202 q22 394 318 326 318 Total cold run time: 106938 ms Total hot run time: 40271 ms - Round 2, with runtime_filter_mode=off - q1 7400740273787378 q2 332 230 233 230 q3 2930290530332905 q4 2059182818771828 q5 5672571757095709 q6 230 141 139 139 q7 2251182818431828 q8 3446362135633563 q9 8971890489428904 q10 3629359635833583 q11 615 516 513 513 q12 814 611 626 611 q13 10418 324432423242 q14 322 280 278 278 q15 585 512 521 512 q16 694 659 640 640 q17 1862164316161616 q18 8417786575887588 q19 1761148215611482 q20 2116189219101892 q21 5719557055075507 q22 657 633 590 590 Total cold run time: 70900 ms Total hot run time: 60538 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
doris-robot commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2488351423 TPC-DS: Total hot run time: 196768 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8acb29ae438731fc4018126b4f1e1a8dfd49ca23, data reload: false query1 1221928 972 928 query2 6246223021622162 query3 10946 409042714090 query4 67402 28766 23741 23741 query5 4985490 447 447 query6 411 194 203 194 query7 5534298 291 291 query8 320 221 220 220 query9 8948269326722672 query10 457 254 253 253 query11 17352 15510 15801 15510 query12 154 105 108 105 query13 1519415 421 415 query14 10383 779372627262 query15 200 181 201 181 query16 7077425 464 425 query17 1049564 544 544 query18 1772282 296 282 query19 189 150 141 141 query20 117 109 111 109 query21 230 101 100 100 query22 4640435441614161 query23 34545 33999 34155 33999 query24 5348249123882388 query25 480 390 371 371 query26 646 150 152 150 query27 1689289 277 277 query28 4350244423972397 query29 671 412 412 412 query30 214 143 144 143 query31 981 776 819 776 query32 79 60 58 58 query33 461 286 275 275 query34 919 501 522 501 query35 842 723 715 715 query36 1101978 946 946 query37 122 76 74 74 query38 4429427542954275 query39 1465142914351429 query40 203 106 104 104 query41 48 48 47 47 query42 118 100 99 99 query43 555 514 496 496 query44 1137811 830 811 query45 184 178 167 167 query46 1138697 709 697 query47 1922184518421842 query48 420 312 322 312 query49 760 414 447 414 query50 803 385 407 385 query51 7248705371117053 query52 102 92 87 87 query53 258 178 179 178 query54 513 408 386 386 query55 76 78 73 73 query56 250 240 238 238 query57 1314117111651165 query58 218 217 223 217 query59 3325341132823282 query60 251 244 245 244 query61 125 104 112 104 query62 762 701 701 701 query63 221 188 182 182 query64 1389692 629 629 query65 3316322632113211 query66 710 314 309 309 query67 16192 15627 15715 15627 query68 4125576 562 562 query69 425 253 261 253 query70 1204111411281114 query71 365 253 261 253 query72 6500406440494049 query73 761 362 352 352 query74 10374 895490128954 query75 3429272426972697 query76 1686101410601014 query77 479 296 284 284 query78 10509 954394889488 query79 1925594 608 594 query80 1097424 442 424 query81 545 227 229 227 query82 219 122 126 122 query83 185 153 152 152 query84 284 69 67 67 query85 990 298 290 290 query86 416 302 293 293 query87 4804471647004700 query88 407621992199 query89 427 298 299 298 query90 2066192 187 187 query91 132 104 107 104 query92 67 50 49 49 query93 2529549 547 547 query94 944 303 308 303 query95 344 243 246 243 query96 639 279 285 279 query97 2884270926932693 query98 222 192 203 192 query99 2034132513061306 Total cold run time: 319738 ms Total hot run time: 196768 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
doris-robot commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2488366123 ClickBench: Total hot run time: 32.07 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8acb29ae438731fc4018126b4f1e1a8dfd49ca23, data reload: false query1 0.040.030.03 query2 0.070.040.03 query3 0.230.090.08 query4 1.610.100.10 query5 0.440.400.41 query6 1.160.670.66 query7 0.030.020.01 query8 0.040.030.04 query9 0.560.520.50 query10 0.560.540.57 query11 0.140.100.10 query12 0.140.110.11 query13 0.600.600.60 query14 2.792.712.78 query15 0.880.840.83 query16 0.410.380.40 query17 1.071.011.03 query18 0.200.190.21 query19 1.851.882.02 query20 0.010.010.01 query21 15.36 0.580.57 query22 2.542.881.38 query23 16.91 1.000.87 query24 2.891.450.86 query25 0.310.060.20 query26 0.370.150.13 query27 0.050.050.04 query28 10.51 1.091.07 query29 12.53 3.193.17 query30 0.250.060.06 query31 2.870.400.38 query32 3.260.460.47 query33 2.973.013.17 query34 16.90 4.504.52 query35 4.584.524.52 query36 0.680.490.49 query37 0.090.060.06 query38 0.050.040.03 query39 0.030.030.02 query40 0.150.120.12 query41 0.070.020.02 query42 0.030.020.02 query43 0.030.030.04 Total cold run time: 106.26 s Total hot run time: 32.07 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2488306261 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
zclllyybb commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2488234664 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
zclllyybb commented on code in PR #42445: URL: https://github.com/apache/doris/pull/42445#discussion_r1843227989 ## result.csv: ## Review Comment: dont upload this file ## tools/ssb-tools/bin/ssb-dbgen-linux.tar.gz: ## Review Comment: dont upload this file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2476952543
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11841887840";) output.
shellcheck errors
```
'shellcheck ' found no issues.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
+++ tools/tpcds-tools/bin/run-tpcds-queries.sh
@@ -136,7 +136,7 @@
fi
if ! grep_output=$(grep " Value: " <<<"${output}" 2>&1); then
grep_status=$?
-# shellcheck disable=SC2292
+# shellcheck disable=SC2292
if [ "${grep_status}" -eq 2 ]; then
printf "%s\n" "${grep_output}" >&2
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2476961903
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11841952838";) output.
shellcheck errors
```
'shellcheck ' found no issues.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
+++ tools/tpcds-tools/bin/run-tpcds-queries.sh
@@ -136,7 +136,7 @@
fi
if ! grep_output=$(grep " Value: " <<<"${output}" 2>&1); then
grep_status=$?
-# shellcheck disable=SC2292
+# shellcheck disable=SC2292
if [ "${grep_status}" -eq 2 ]; then
printf "%s\n" "${grep_output}" >&2
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2476930727
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11841722832";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 141:
if [ $grep_status -eq 2 ]; then
^^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
^--^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ "${grep_status}" -eq 2 ]]; then
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 143:
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-- SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 145:
elif [ $grep_status -eq 1 ]; then
^^ SC2292 (style): Prefer [[ ]] over [ ]
for tests in Bash/Ksh.
^--^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
elif [[ "${grep_status}" -eq 1 ]]; then
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 146:
printf "Warning: No match for 'Value: ' found in the output of
the query for variable '%s'.\n" "$k" >&2
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
printf "Warning: No match for 'Value: ' found in the output of
the query for variable '%s'.\n" "${k}" >&2
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 153:
printf "Error: awk command failed while processing the grep output
for variable '%s'.\n" "$k" >&2
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
printf "Error: awk command failed while processing the grep output
for variable '%s'.\n" "${k}" >&2
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 158:
printf "Warning: No value found for variable '%s'. The 'Value:'
might be missing or empty.\n" "$k" >&2
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
printf "Warning: No value found for variable '%s'. The 'Value:'
might be missing or empty.\n" "${k}" >&2
In tools/tpch-tools/bin/run-tpch-queries.sh line 137:
if [ $grep_status -eq 2 ]; then
^^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
^--^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ "${grep_status}" -eq 2 ]]; then
In tools/tpch-tools/bin/run-tpch-queries.sh line 139:
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
zclllyybb commented on code in PR #42445:
URL: https://github.com/apache/doris/pull/42445#discussion_r1839332050
##
tools/ssb-tools/bin/run-ssb-queries.sh:
##
@@ -120,19 +123,31 @@ for i in '1.1' '1.2' '1.3' '2.1' '2.2' '2.3' '3.1' '3.2'
'3.3' '3.4' '4.1' '4.2'
hot2=0
echo -ne "q${i}\t" | tee -a result.csv
start=$(date +%s%3N)
-mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out
2>"${RESULT_DIR}"/result"${i}".log
+if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments \
+<"${QUERIES_DIR}/q${i}.sql" >"${RESULT_DIR}/result${i}.out"
2>"${RESULT_DIR}/result${i}.log"; then
Review Comment:
maybe don't use the log file, just printing the errmsg to console is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2470936039
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11801106371";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 141:
if [ $grep_status -eq 2 ]; then
^^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
^--^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ "${grep_status}" -eq 2 ]]; then
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 143:
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-- SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 145:
elif [ $grep_status -eq 1 ]; then
^^ SC2292 (style): Prefer [[ ]] over [ ]
for tests in Bash/Ksh.
^--^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
elif [[ "${grep_status}" -eq 1 ]]; then
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 146:
printf "Warning: No match for 'Value: ' found in the output of
the query for variable '%s'.\n" "$k" >&2
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
printf "Warning: No match for 'Value: ' found in the output of
the query for variable '%s'.\n" "${k}" >&2
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 153:
printf "Error: awk command failed while processing the grep output
for variable '%s'.\n" "$k" >&2
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
printf "Error: awk command failed while processing the grep output
for variable '%s'.\n" "${k}" >&2
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 158:
printf "Warning: No value found for variable '%s'. The 'Value:'
might be missing or empty.\n" "$k" >&2
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
printf "Warning: No value found for variable '%s'. The 'Value:'
might be missing or empty.\n" "${k}" >&2
In tools/tpch-tools/bin/run-tpch-queries.sh line 137:
if [ $grep_status -eq 2 ]; then
^^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
^--^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ "${grep_status}" -eq 2 ]]; then
In tools/tpch-tools/bin/run-tpch-queries.sh line 139:
printf "Error: grep command failed with status %d while
processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
^--^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2466817912
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11767137905";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ssb-tools/bin/create-ssb-tables.sh line 148:
printf "%s scale is NOT supported currently\n" "$SCALE_FACTOR"
^---^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
printf "%s scale is NOT supported currently\n" "${SCALE_FACTOR}"
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 106:
printf "Error: Failed to drop the database %s.\n" "$DB" >&2
^-^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
printf "Error: Failed to drop the database %s.\n" "${DB}" >&2
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 111:
printf "Error: Failed to create the database %s.\n" "$DB" >&2
^-^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
printf "Error: Failed to create the database %s.\n" "${DB}" >&2
For more information:
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' found no issues.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2466815009
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11767066067";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ssb-tools/bin/create-ssb-tables.sh line 111:
if [ "${SCALE_FACTOR}" -eq 1 ]; then
^-- SC1009 (info): The mentioned syntax error was in this if expression.
^-- SC1073 (error): Couldn't parse this then
clause. Fix to allow more checks.
In tools/ssb-tools/bin/create-ssb-tables.sh line 123:
# shellcheck disable=SC2292
^-- SC1123 (error): ShellCheck directives are only valid in front of
complete compound commands, like 'if', not e.g. individual 'elif' branches.
In tools/ssb-tools/bin/create-ssb-tables.sh line 124:
elif [ "${SCALE_FACTOR}" -eq 100 ]; then
^-- SC1072 (error): Unexpected keyword/token. Fix any mentioned
problems and try again.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 115:
if [ "${SCALE_FACTOR}" -eq 1 ]; then
^-- SC1009 (info): The mentioned syntax error was in this if expression.
^-- SC1073 (error): Couldn't parse this then
clause. Fix to allow more checks.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 121:
# shellcheck disable=SC2292
^-- SC1123 (error): ShellCheck directives are only valid in front of
complete compound commands, like 'if', not e.g. individual 'elif' branches.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 122:
elif [ "${SCALE_FACTOR}" -eq 100 ]; then
^-- SC1072 (error): Unexpected keyword/token. Fix any mentioned
problems and try again.
In tools/tpch-tools/bin/create-tpch-tables.sh line 112:
if [ "${SCALE_FACTOR}" -eq 1 ]; then
^-- SC1009 (info): The mentioned syntax error was in this if expression.
^-- SC1073 (error): Couldn't parse this then
clause. Fix to allow more checks.
In tools/tpch-tools/bin/create-tpch-tables.sh line 119:
# shellcheck disable=SC2292
^-- SC1123 (error): ShellCheck directives are only valid in front of
complete compound commands, like 'if', not e.g. individual 'elif' branches.
In tools/tpch-tools/bin/create-tpch-tables.sh line 120:
elif [ "${SCALE_FACTOR}" -eq 100 ]; then
^-- SC1072 (error): Unexpected keyword/token. Fix any mentioned
problems and try again.
For more information:
https://www.shellcheck.net/wiki/SC1123 -- ShellCheck directives are only
va...
https://www.shellcheck.net/wiki/SC1072 -- Unexpected keyword/token. Fix
any...
https://www.shellcheck.net/wiki/SC1073 -- Couldn't parse this then clause.
...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' found no issues.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2453992396
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11659900500";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In build.sh line 297:
local submodule_path=$1
^-^ SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 298:
local submodule_name=$2
^-^ SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 299:
local archive_url=$3
^--^ SC2317 (info): Command appears to be unreachable.
Check usage (or ignore if invoked indirectly).
In build.sh line 301:
set +e
^^ SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
In build.sh line 302:
cd "${DORIS_HOME}"
^^ SC2317 (info): Command appears to be unreachable.
Check usage (or ignore if invoked indirectly).
In build.sh line 303:
echo "Update ${submodule_name} submodule ..."
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
In build.sh line 304:
git submodule update --init --recursive "${submodule_path}"
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
In build.sh line 305:
exit_code=$?
^--^ SC2317 (info): Command appears to be unreachable. Check
usage (or ignore if invoked indirectly).
In build.sh line 306:
if [[ "${exit_code}" -eq 0 ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
^^ SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 307:
cd "${submodule_path}"
^^ SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 308:
submodule_commit_id=$(git rev-parse HEAD)
^-- SC2317 (info): Command appears to be unreachable. Check usage
(or ignore if invoked indirectly).
^^ SC2317 (info): Command
appears to be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 309:
cd -
^--^ SC2317 (info): Command appears to be unreachable. Check usage
(or ignore if invoked indirectly).
In build.sh line 310:
expect_submodule_commit_id=$(git ls-tree HEAD "${submodule_path}" |
awk '{print $3}')
^-- SC2317 (info): Command appears to be unreachable. Check usage
(or ignore if invoked indirectly).
^-- SC2317 (info): Command appears to
be unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 311:
echo "Current commit ID of ${submodule_name} submodule:
${submodule_commit_id}, expected is ${expect_submodule_commit_id}"
^-- SC2317 (info): Command appears to be unreachable. Check usage
(or ignore if invoked indirectly).
In build.sh line 313:
set -e
^^ SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
In build.sh line 314:
if [[ "${exit_code}" -ne 0 ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
^^ SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 315:
set +e
^^ SC2317 (info): Command appears to be unreachable. Check usage
(or ignore if invoked indirectly).
In build.sh line 317:
submodule_commit=$(git ls-tree HEAD "${submodule_path}" | awk
'{print $3}')
^-- SC2317 (info): Command appears to be unreachable. Check usage
(or ignore if invoked indirectly).
^-- SC2317 (info): Command appears to be
unreachable. Check usage (or ignore if invoked indirectly).
In build.sh line 318:
exit_code=$?
^--^ SC2317 (info): Command appears to be unreachable. Check
usage (or ignore if invoked indirectly).
In build.sh line 319:
if [[ "${exit_code}" = "0" ]]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage
(or ignore if invoked indirectly).
^---
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2447332675
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11595211828";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 150:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
echo "Error: Failed to execute the SQL command: $@" >&2
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 130:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 143:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 156:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
echo "Error: Failed to execute the SQL command: $@" >&2
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 106:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 141:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 151:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 157:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 163:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpch-tools/bin/run-tpch-queries.sh line 184:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
m
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437507426
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11517053429";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
echo "Error: Failed to execute the SQL command: $@"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
echo "Error: Failed to execute the SQL command: $@"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437446833
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11516581952";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
echo "Error: Failed to execute the SQL command: '$@'"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
echo "Error: Failed to execute the SQL command: '$@'"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437445707
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11516572292";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
echo "Error: Failed to execute the SQL command: '$@'"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
echo "Error: Failed to execute the SQL command: '$@'"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437372335
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11515982463";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
echo "Error: Failed to execute the SQL command: '$@'"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
echo "Error: Failed to execute the SQL command: '$@'"
^-- SC2145 (error):
Argument mixes string and array. Use * or separate argument.
In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;',
not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
mycmd;', not indirectly with $?.
In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
if [[ $? -ne 0 ]]; then
^-- SC2181 (style): Check exit code directly with e.g. 'if !
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
doris-robot commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2435519710 TPC-H: Total hot run time: 41199 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c5cd0a2f20559cbf3fcd531ad1c397fc428a2f3a, data reload: false -- Round 1 -- q1 17595 741873107310 q2 2020275 272 272 q3 12111 107211321072 q4 10579 843 801 801 q5 7759307029512951 q6 237 148 145 145 q7 1004617 615 615 q8 9342195019481948 q9 6585646563876387 q10 7077240524522405 q11 448 239 245 239 q12 405 206 217 206 q13 17767 302130363021 q14 254 206 217 206 q15 563 509 513 509 q16 634 593 582 582 q17 964 561 512 512 q18 7231675966796679 q19 1342105410281028 q20 486 185 185 185 q21 4200312831903128 q22 10641006998 998 Total cold run time: 109667 ms Total hot run time: 41199 ms - Round 2, with runtime_filter_mode=off - q1 7248723572657235 q2 331 241 233 233 q3 3022292629382926 q4 2078185018611850 q5 5737579557715771 q6 232 153 152 152 q7 2185184717821782 q8 3355356434483448 q9 8885883288458832 q10 3593354735683547 q11 599 482 492 482 q12 846 650 597 597 q13 9590321531603160 q14 303 265 273 265 q15 583 524 519 519 q16 700 645 632 632 q17 1843161516021602 q18 8313792677087708 q19 1702160614941494 q20 2121186218451845 q21 5688541254385412 q22 1117104810891048 Total cold run time: 70071 ms Total hot run time: 60540 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
doris-robot commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2435564025 ClickBench: Total hot run time: 31.87 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c5cd0a2f20559cbf3fcd531ad1c397fc428a2f3a, data reload: false query1 0.030.040.04 query2 0.080.040.03 query3 0.220.060.06 query4 1.630.110.10 query5 0.410.390.40 query6 1.170.650.67 query7 0.020.010.02 query8 0.040.030.03 query9 0.580.510.50 query10 0.550.530.55 query11 0.150.110.10 query12 0.140.110.11 query13 0.610.590.59 query14 2.752.712.72 query15 0.890.810.83 query16 0.390.380.37 query17 1.021.061.07 query18 0.210.200.21 query19 1.981.902.00 query20 0.020.010.01 query21 15.37 0.590.58 query22 2.801.851.42 query23 17.26 0.920.93 query24 3.160.571.29 query25 0.230.200.08 query26 0.440.120.14 query27 0.050.040.04 query28 10.59 1.101.08 query29 12.58 3.313.28 query30 0.240.060.05 query31 2.860.390.37 query32 3.280.460.46 query33 2.963.053.02 query34 17.07 4.464.48 query35 4.434.444.50 query36 0.660.470.50 query37 0.080.060.06 query38 0.050.030.03 query39 0.040.020.03 query40 0.160.130.13 query41 0.070.020.02 query42 0.030.030.02 query43 0.040.030.03 Total cold run time: 107.34 s Total hot run time: 31.87 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
doris-robot commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2435550225 TPC-DS: Total hot run time: 191587 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c5cd0a2f20559cbf3fcd531ad1c397fc428a2f3a, data reload: false query1 840 419 416 416 query2 6229213520802080 query3 8684191 212 191 query4 34774 23876 23507 23507 query5 4782457 437 437 query6 300 185 174 174 query7 4211313 312 312 query8 286 240 223 223 query9 9472269726722672 query10 451 250 247 247 query11 18298 15312 15098 15098 query12 153 97 101 97 query13 1560423 398 398 query14 8994684571376845 query15 245 173 188 173 query16 7821507 484 484 query17 1413592 582 582 query18 2096311 314 311 query19 260 167 165 165 query20 128 113 115 113 query21 208 106 110 106 query22 4561459845654565 query23 35053 34491 33981 33981 query24 11031 277427712771 query25 632 416 393 393 query26 1212160 169 160 query27 2336278 296 278 query28 7542245024182418 query29 846 428 421 421 query30 268 162 157 157 query31 1055786 811 786 query32 95 55 56 55 query33 768 278 285 278 query34 945 507 518 507 query35 1022899 871 871 query36 1095945 968 945 query37 135 73 74 73 query38 4304419942994199 query39 1482141513961396 query40 205 104 100 100 query41 49 47 48 47 query42 114 105 103 103 query43 541 496 478 478 query44 1213810 820 810 query45 187 168 166 166 query46 1113716 716 716 query47 1893184618291829 query48 431 328 331 328 query49 895 395 412 395 query50 811 407 397 397 query51 7136695669806956 query52 106 93 94 93 query53 257 182 180 180 query54 1149428 414 414 query55 82 78 79 78 query56 273 244 262 244 query57 1321120911601160 query58 215 197 196 196 query59 3143298031262980 query60 271 237 242 237 query61 101 101 99 99 query62 816 680 662 662 query63 213 189 187 187 query64 3961637 625 625 query65 3338321632253216 query66 720 300 301 300 query67 16035 15725 15713 15713 query68 4721551 569 551 query69 420 261 259 259 query70 1234116111761161 query71 325 263 263 263 query72 6298401040004000 query73 774 374 361 361 query74 10094 900689388938 query75 3415264526802645 query76 2800915 1018915 query77 378 271 265 265 query78 10501 958495579557 query79 1815593 600 593 query80 1098442 432 432 query81 581 241 239 239 query82 635 119 116 116 query83 233 132 137 132 query84 250 66 71 66 query85 1258300 286 286 query86 372 307 305 305 query87 4770473745684568 query88 3246221321952195 query89 410 298 285 285 query90 1963188 193 188 query91 133 101 101 101 query92 61 46 47 46 query93 2049535 543 535 query94 737 281 293 281 query95 345 249 252 249 query96 627 281 290 281 query97 2918268527252685 query98 211 199 187 187 query99 1587130813141308 Total cold run time: 298435 ms Total hot run time: 191587 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2435397580
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/11501010617";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In create-clickbench-table.sh line 27:
cd "$ROOT"
^---^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
cd "${ROOT}"
In create-clickbench-table.sh line 43:
-n $0 \
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-n "$0" \
In create-clickbench-table.sh line 47:
eval set -- "$OPTS"
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
eval set -- "${OPTS}"
In create-clickbench-table.sh line 50:
if [ $# == 0 ]; then
^-^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Did you mean:
if [[ $# == 0 ]]; then
In create-clickbench-table.sh line 73:
exit
^--^ SC2317 (info): Command appears to be unreachable. Check usage (or
ignore if invoked indirectly).
In create-clickbench-table.sh line 79:
if ! $CMD; then
^--^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
if ! ${CMD}; then
In create-clickbench-table.sh line 80:
echo "$NAME is missing. This script depends on mysql to create tables in
Doris."
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
echo "${NAME} is missing. This script depends on mysql to create tables
in Doris."
In create-clickbench-table.sh line 87:
source $CURDIR/conf/doris-cluster.conf
^-^ SC1091 (info): Not following:
./conf/doris-cluster.conf: openBinaryFile: does not exist (No such file or
directory)
^-^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^-^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
source "${CURDIR}"/conf/doris-cluster.conf
In create-clickbench-table.sh line 88:
echo "FE_HOST: $FE_HOST"
^--^ SC2154 (warning): FE_HOST is referenced but not
assigned.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "FE_HOST: ${FE_HOST}"
In create-clickbench-table.sh line 89:
echo "FE_QUERY_PORT: $FE_QUERY_PORT"
^^ SC2154 (warning): FE_QUERY_PORT is
referenced but not assigned.
^^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo "FE_QUERY_PORT: ${FE_QUERY_PORT}"
In create-clickbench-table.sh line 90:
echo "USER: $USER"
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
echo "USER: ${USER}"
In create-clickbench-table.sh line 91:
echo "PASSWORD: $PASSWORD"
^---^ SC2154 (warning): PASSWORD is referenced but not
assigned.
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "PASSWORD: ${PASSWORD}"
In create-clickbench-table.sh line 92:
echo "DB: $DB"
^-^ SC2154 (warning): DB is referenced but not assigned.
^-^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
echo "DB: ${DB}"
In create-clickbench-table.sh line 94:
OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -e "CREATE DATABASE IF
NOT EXISTS $DB")
^--^ SC2086 (info): Double quote to prevent globbing
and word splitting.
^--^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
^---^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^---^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^^ SC2250 (style): Prefer
putting braces arou
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
cat-with-cat commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2435412880 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]
doris-robot commented on PR #42445: URL: https://github.com/apache/doris/pull/42445#issuecomment-2435395916 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
