Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-15 Thread via GitHub 


morningman merged PR #61141:
URL: https://github.com/apache/doris/pull/61141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-15 Thread via GitHub 


github-actions[bot] commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4064673262

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-15 Thread via GitHub 


github-actions[bot] commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4064673120

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-14 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4060564760

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_bf1ad3d764d2b089ec1435f890a471878f85e803_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_bf1ad3d764d2b089ec1435f890a471878f85e803_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.58% (26225/36635) |
   | Line Coverage | 54.37% (275439/506625) |
   | Region Coverage   | 51.61% (228602/442967) |
   | Branch Coverage   | 53.05% (98441/185567) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4058904075

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_bf1ad3d764d2b089ec1435f890a471878f85e803_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_bf1ad3d764d2b089ec1435f890a471878f85e803_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.59% (26228/36635) |
   | Line Coverage | 54.38% (275482/506625) |
   | Region Coverage   | 51.61% (228616/442967) |
   | Branch Coverage   | 53.06% (98462/185567) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4058782136

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_bf1ad3d764d2b089ec1435f890a471878f85e803_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_bf1ad3d764d2b089ec1435f890a471878f85e803_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.60% (26231/36635) |
   | Line Coverage | 54.39% (275536/506625) |
   | Region Coverage   | 51.62% (228643/442967) |
   | Branch Coverage   | 53.07% (98476/185567) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4058521324

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/bf1ad3d764d2b089ec1435f890a471878f85e803_bf1ad3d764d2b089ec1435f890a471878f85e803/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/bf1ad3d764d2b089ec1435f890a471878f85e803_bf1ad3d764d2b089ec1435f890a471878f85e803/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.70% (19725/37430) |
   | Line Coverage | 36.28% (184429/508347) |
   | Region Coverage   | 32.45% (142413/438919) |
   | Branch Coverage   | 33.61% (62206/185085) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4058052056

   
   
   TPC-DS: Total hot run time: 168660 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit bf1ad3d764d2b089ec1435f890a471878f85e803, 
data reload: false
   
   query5   4327657 513 513
   query6   333 230 208 208
   query7   4213478 271 271
   query8   342 265 234 234
   query9   8673273427022702
   query10  482 387 349 349
   query11  6979510248654865
   query12  193 127 124 124
   query13  1279486 362 362
   query14  5746369934783478
   query14_12843280427782778
   query15  200 201 178 178
   query16  985 476 461 461
   query17  966 740 619 619
   query18  2447456 353 353
   query19  221 211 205 205
   query20  136 132 127 127
   query21  218 133 116 116
   query22  13271   14278   14997   14278
   query23  16262   16132   15764   15764
   query23_115716   15633   15749   15633
   query24  7933161212151215
   query24_11228122012351220
   query25  567 502 441 441
   query26  1251262 201 201
   query27  2713469 299 299
   query28  4472185818721858
   query29  797 564 469 469
   query30  296 225 196 196
   query31  1011929 850 850
   query32  80  74  66  66
   query33  508 331 281 281
   query34  885 877 528 528
   query35  634 684 595 595
   query36  11071124960 960
   query37  138 97  81  81
   query38  2913293728132813
   query39  862 827 821 821
   query39_1792 793 801 793
   query40  231 152 132 132
   query41  63  59  61  59
   query42  263 252 257 252
   query43  243 245 211 211
   query44  
   query45  197 184 180 180
   query46  869 983 604 604
   query47  2138220020582058
   query48  323 309 225 225
   query49  638 482 384 384
   query50  678 277 210 210
   query51  4051408440374037
   query52  259 267 254 254
   query53  294 339 279 279
   query54  322 266 256 256
   query55  90  84  82  82
   query56  315 316 303 303
   query57  1936196017081708
   query58  281 278 268 268
   query59  2754300227502750
   query60  337 335 326 326
   query61  154 189 148 148
   query62  631 588 538 538
   query63  308 272 270 270
   query64  5000127310031003
   query65  
   query66  1470464 353 353
   query67  24335   24364   24189   24189
   query68  
   query69  402 308 284 284
   query70  983 948 883 883
   query71  332 311 309 309
   query72  2805270824352435
   query73  533 536 308 308
   query74  9605957893669366
   query75  2846277424802480
   query76  22821013679 679
   query77  381 407 302 302
   query78  10904   11129   10491   10491
   query79  1909768 570 570
   query80  1526627 541 541
   query81  552 263 220 220
   query82  981 146 121 121
   query83  339 259 243 243
   query84  297 120 103 103
   query85  919 490 477 477
   query86  415 314 292 292
   query87  3124312130693069
   query88  3498262526352625
   query89  418 367 343 343
   query90  2012183 170 170
   query91  164 163 138 138
   query92  77  75  68  68
   query93  960 830 496 496
   query94  646 313 301 301
   query95  585 403 305 305
   query96  655 501 232 232
   query97  2436246024172417
   query98  239 219 225 219
   query99  10041011955 955
   Total cold run time: 250583 ms
   Total hot run time: 168660 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4058003679

   
   
   TPC-H: Total hot run time: 26867 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit bf1ad3d764d2b089ec1435f890a471878f85e803, 
data reload: false
   
   -- Round 1 --
   orders   Doris   NULLNULL0   0   0   NULL0   
NULLNULL2023-12-26 18:27:23 2023-12-26 18:42:55 NULLutf-8   
NULLNULL
   
   q1   17705   451643394339
   q2   q3  10711   796 554 554
   q4   4729366 264 264
   q5   8213119510351035
   q6   236 174 147 147
   q7   826 835 683 683
   q8   10657   151512991299
   q9   6750480447584758
   q10  6324191116481648
   q11  456 259 245 245
   q12  696 590 460 460
   q13  18110   293121752175
   q14  233 228 223 223
   q15  q16 740 805 671 671
   q17  728 838 452 452
   q18  5903549351845184
   q19  1124982 627 627
   q20  533 481 369 369
   q21  4634197414591459
   q22  397 345 275 275
   Total cold run time: 99705 ms
   Total hot run time: 26867 ms
   
   - Round 2, with runtime_filter_mode=off -
   orders   Doris   NULLNULL15000   42  6422171781  
NULL22778155NULLNULL2023-12-26 18:27:23 2023-12-26 
18:42:55 NULLutf-8   NULLNULL
   
   q1   4730461645434543
   q2   q3  3919437338673867
   q4   897 1194763 763
   q5   4064437043704370
   q6   181 173 140 140
   q7   1760171315861586
   q8   2530271925882588
   q9   7478748573407340
   q10  3727398436743674
   q11  534 441 426 426
   q12  510 606 492 492
   q13  2840325123632363
   q14  292 310 278 278
   q15  q16 738 804 704 704
   q17  1160130614421306
   q18  7219683365366536
   q19  885 909 929 909
   q20  2060226720472047
   q21  4059345833193319
   q22  442 449 365 365
   Total cold run time: 50025 ms
   Total hot run time: 47616 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4057552232

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/bf1ad3d764d2b089ec1435f890a471878f85e803_bf1ad3d764d2b089ec1435f890a471878f85e803_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/bf1ad3d764d2b089ec1435f890a471878f85e803_bf1ad3d764d2b089ec1435f890a471878f85e803_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.24% (1798/2269) |
   | Line Coverage | 64.53% (32283/50026) |
   | Region Coverage   | 65.44% (16165/24702) |
   | Branch Coverage   | 55.83% (8607/15416) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


morningman commented on code in PR #61141:
URL: https://github.com/apache/doris/pull/61141#discussion_r2933230218


##
be/src/exec/sink/writer/vjdbc_table_writer.cpp:
##
@@ -15,67 +15,100 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include "exec/sink/writer/vjdbc_table_writer.h"
+#include "vjdbc_table_writer.h"
 
 #include 
 #include 
 
 #include 
 
-#include "core/binary_cast.hpp"
+#include "common/logging.h"
 #include "core/block/block.h"
 #include "exprs/vexpr.h"
 #include "exprs/vexpr_context.h"
+#include "runtime/runtime_state.h"
+#include "util/jdbc_utils.h"
 
 namespace doris {
 
-JdbcConnectorParam VJdbcTableWriter::create_connect_param(const 
doris::TDataSink& t_sink) {
+std::map 
VJdbcTableWriter::_build_writer_params(const TDataSink& t_sink) {
 const TJdbcTableSink& t_jdbc_sink = t_sink.jdbc_table_sink;
+std::map params;
 
-JdbcConnectorParam jdbc_param;
-
-jdbc_param.catalog_id = t_jdbc_sink.jdbc_table.catalog_id;
-jdbc_param.jdbc_url = t_jdbc_sink.jdbc_table.jdbc_url;
-jdbc_param.user = t_jdbc_sink.jdbc_table.jdbc_user;
-jdbc_param.passwd = t_jdbc_sink.jdbc_table.jdbc_password;
-jdbc_param.driver_class = t_jdbc_sink.jdbc_table.jdbc_driver_class;
-jdbc_param.driver_path = t_jdbc_sink.jdbc_table.jdbc_driver_url;
-jdbc_param.driver_checksum = t_jdbc_sink.jdbc_table.jdbc_driver_checksum;
-jdbc_param.resource_name = t_jdbc_sink.jdbc_table.jdbc_resource_name;
-jdbc_param.table_type = t_jdbc_sink.table_type;
-jdbc_param.query_string = t_jdbc_sink.insert_sql;
-jdbc_param.table_name = t_jdbc_sink.jdbc_table.jdbc_table_name;
-jdbc_param.use_transaction = t_jdbc_sink.use_transaction;
-jdbc_param.connection_pool_min_size = 
t_jdbc_sink.jdbc_table.connection_pool_min_size;
-jdbc_param.connection_pool_max_size = 
t_jdbc_sink.jdbc_table.connection_pool_max_size;
-jdbc_param.connection_pool_max_wait_time = 
t_jdbc_sink.jdbc_table.connection_pool_max_wait_time;
-jdbc_param.connection_pool_max_life_time = 
t_jdbc_sink.jdbc_table.connection_pool_max_life_time;
-jdbc_param.connection_pool_keep_alive = 
t_jdbc_sink.jdbc_table.connection_pool_keep_alive;
-
-return jdbc_param;
+params["jdbc_url"] = t_jdbc_sink.jdbc_table.jdbc_url;
+params["jdbc_user"] = t_jdbc_sink.jdbc_table.jdbc_user;
+params["jdbc_password"] = t_jdbc_sink.jdbc_table.jdbc_password;
+params["jdbc_driver_class"] = t_jdbc_sink.jdbc_table.jdbc_driver_class;
+// Resolve jdbc_driver_url to absolute file:// URL
+std::string driver_url;
+auto resolve_st =
+
JdbcUtils::resolve_driver_url(t_jdbc_sink.jdbc_table.jdbc_driver_url, 
&driver_url);
+if (!resolve_st.ok()) {
+LOG(WARNING) << "Failed to resolve JDBC driver URL: " << 
resolve_st.to_string();
+driver_url = t_jdbc_sink.jdbc_table.jdbc_driver_url;
+}
+params["jdbc_driver_url"] = driver_url;
+
+params["jdbc_driver_checksum"] = 
t_jdbc_sink.jdbc_table.jdbc_driver_checksum;
+params["insert_sql"] = t_jdbc_sink.insert_sql;
+params["use_transaction"] = t_jdbc_sink.use_transaction ? "true" : "false";
+params["catalog_id"] = std::to_string(t_jdbc_sink.jdbc_table.catalog_id);
+params["connection_pool_min_size"] =
+std::to_string(t_jdbc_sink.jdbc_table.connection_pool_min_size);
+params["connection_pool_max_size"] =
+std::to_string(t_jdbc_sink.jdbc_table.connection_pool_max_size);
+params["connection_pool_max_wait_time"] =
+
std::to_string(t_jdbc_sink.jdbc_table.connection_pool_max_wait_time);
+params["connection_pool_max_life_time"] =
+
std::to_string(t_jdbc_sink.jdbc_table.connection_pool_max_life_time);
+params["connection_pool_keep_alive"] =
+t_jdbc_sink.jdbc_table.connection_pool_keep_alive ? "true" : 
"false";
+
+return params;
 }
 
 VJdbcTableWriter::VJdbcTableWriter(const TDataSink& t_sink,
const VExprContextSPtrs& output_expr_ctxs,
std::shared_ptr dep,
std::shared_ptr fin_dep)
 : AsyncResultWriter(output_expr_ctxs, dep, fin_dep),
-  JdbcConnector(create_connect_param(t_sink)) {}
+  _writer_params(_build_writer_params(t_sink)),
+  _use_transaction(t_sink.jdbc_table_sink.use_transaction) {}
+
+Status VJdbcTableWriter::open(RuntimeState* state, RuntimeProfile* 
operator_profile) {
+_writer = std::make_unique(
+state, _vec_output_expr_ctxs, 
"org/apache/doris/jdbc/JdbcJniWriter", _writer_params);
+return _writer->open();
+}
 
 Status VJdbcTableWriter::write(RuntimeState* state, Block& block) {
 Block output_block;
 RETURN_IF_ERROR(_projection_block(block, &output_block));
-auto num_rows = output_block.rows();
-
-uint32_t start_send_row = 0;
-uint32_t num_row_sent = 0;
-while (start_send_row < num_rows) {
-RETU

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


morningman commented on code in PR #61141:
URL: https://github.com/apache/doris/pull/61141#discussion_r2933228842


##
be/src/exec/scan/jdbc_scanner.cpp:
##
@@ -45,16 +43,48 @@ JdbcScanner::JdbcScanner(RuntimeState* state, 
doris::JDBCScanLocalState* local_s
   _tuple_desc(nullptr),
   _table_type(table_type),
   _is_tvf(is_tvf) {
-_init_profile(local_state->_scanner_profile);
 _has_prepared = false;
 }
 
+std::map JdbcScanner::_build_jdbc_params(
+const TupleDescriptor* tuple_desc) {
+const JdbcTableDescriptor* jdbc_table =
+static_cast(tuple_desc->table_desc());
+
+std::map params;
+params["jdbc_url"] = jdbc_table->jdbc_url();
+params["jdbc_user"] = jdbc_table->jdbc_user();
+params["jdbc_password"] = jdbc_table->jdbc_passwd();
+params["jdbc_driver_class"] = jdbc_table->jdbc_driver_class();
+// Resolve jdbc_driver_url to absolute file:// URL
+// FE sends just the JAR filename; we need to resolve it to a full path.
+std::string driver_url;
+auto resolve_st = 
JdbcUtils::resolve_driver_url(jdbc_table->jdbc_driver_url(), &driver_url);
+if (!resolve_st.ok()) {
+LOG(WARNING) << "Failed to resolve JDBC driver URL: " << 
resolve_st.to_string();
+driver_url = jdbc_table->jdbc_driver_url();
+}
+params["jdbc_driver_url"] = driver_url;
+params["query_sql"] = _query_string;
+params["catalog_id"] = std::to_string(jdbc_table->jdbc_catalog_id());
+params["table_type"] = _odbc_table_type_to_string(_table_type);
+params["connection_pool_min_size"] = 
std::to_string(jdbc_table->connection_pool_min_size());
+params["connection_pool_max_size"] = 
std::to_string(jdbc_table->connection_pool_max_size());
+params["connection_pool_max_wait_time"] =
+std::to_string(jdbc_table->connection_pool_max_wait_time());
+params["connection_pool_max_life_time"] =
+std::to_string(jdbc_table->connection_pool_max_life_time());
+params["connection_pool_keep_alive"] =
+jdbc_table->connection_pool_keep_alive() ? "true" : "false";
+return params;
+}

Review Comment:
   fixed



##
be/src/util/jdbc_utils.cpp:
##
@@ -0,0 +1,57 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "util/jdbc_utils.h"
+
+#include 
+
+#include "common/config.h"
+
+namespace doris {
+
+Status JdbcUtils::resolve_driver_url(const std::string& url, std::string* 
result_url) {
+// Already a full URL (e.g. "file:///path/to/driver.jar" or "hdfs://...")

Review Comment:
   fixed



##
be/src/format/table/jdbc_jni_reader.cpp:
##
@@ -0,0 +1,222 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "jdbc_jni_reader.h"
+
+#include 
+
+#include "core/block/block.h"
+#include "core/column/column_nullable.h"
+#include "core/data_type/data_type_nullable.h"
+#include "core/data_type/data_type_string.h"
+#include "core/types.h"
+#include "exprs/function/simple_function_factory.h"
+#include "format/jni/jni_data_bridge.h"
+#include "runtime/descriptors.h"
+#include "util/jdbc_utils.h"
+
+namespace doris {
+#include "common/compile_check_begin.h"
+
+JdbcJniReader::JdbcJniReader(const std::vector& 
file_slot_descs,
+ RuntimeState* state, RuntimeProfile* profile,
+ const std::map& 
jdbc_params)
+: JniReader(
+  file_slot_descs, state, profile, 
"o

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-13 Thread via GitHub 


morningman commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4057340113

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-12 Thread via GitHub 


github-actions[bot] commented on code in PR #61141:
URL: https://github.com/apache/doris/pull/61141#discussion_r2928879923


##
be/src/exec/sink/writer/vjdbc_table_writer.cpp:
##
@@ -15,67 +15,100 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include "exec/sink/writer/vjdbc_table_writer.h"
+#include "vjdbc_table_writer.h"
 
 #include 
 #include 
 
 #include 
 
-#include "core/binary_cast.hpp"
+#include "common/logging.h"
 #include "core/block/block.h"
 #include "exprs/vexpr.h"
 #include "exprs/vexpr_context.h"
+#include "runtime/runtime_state.h"
+#include "util/jdbc_utils.h"
 
 namespace doris {
 
-JdbcConnectorParam VJdbcTableWriter::create_connect_param(const 
doris::TDataSink& t_sink) {
+std::map 
VJdbcTableWriter::_build_writer_params(const TDataSink& t_sink) {
 const TJdbcTableSink& t_jdbc_sink = t_sink.jdbc_table_sink;
+std::map params;
 
-JdbcConnectorParam jdbc_param;
-
-jdbc_param.catalog_id = t_jdbc_sink.jdbc_table.catalog_id;
-jdbc_param.jdbc_url = t_jdbc_sink.jdbc_table.jdbc_url;
-jdbc_param.user = t_jdbc_sink.jdbc_table.jdbc_user;
-jdbc_param.passwd = t_jdbc_sink.jdbc_table.jdbc_password;
-jdbc_param.driver_class = t_jdbc_sink.jdbc_table.jdbc_driver_class;
-jdbc_param.driver_path = t_jdbc_sink.jdbc_table.jdbc_driver_url;
-jdbc_param.driver_checksum = t_jdbc_sink.jdbc_table.jdbc_driver_checksum;
-jdbc_param.resource_name = t_jdbc_sink.jdbc_table.jdbc_resource_name;
-jdbc_param.table_type = t_jdbc_sink.table_type;
-jdbc_param.query_string = t_jdbc_sink.insert_sql;
-jdbc_param.table_name = t_jdbc_sink.jdbc_table.jdbc_table_name;
-jdbc_param.use_transaction = t_jdbc_sink.use_transaction;
-jdbc_param.connection_pool_min_size = 
t_jdbc_sink.jdbc_table.connection_pool_min_size;
-jdbc_param.connection_pool_max_size = 
t_jdbc_sink.jdbc_table.connection_pool_max_size;
-jdbc_param.connection_pool_max_wait_time = 
t_jdbc_sink.jdbc_table.connection_pool_max_wait_time;
-jdbc_param.connection_pool_max_life_time = 
t_jdbc_sink.jdbc_table.connection_pool_max_life_time;
-jdbc_param.connection_pool_keep_alive = 
t_jdbc_sink.jdbc_table.connection_pool_keep_alive;
-
-return jdbc_param;
+params["jdbc_url"] = t_jdbc_sink.jdbc_table.jdbc_url;
+params["jdbc_user"] = t_jdbc_sink.jdbc_table.jdbc_user;
+params["jdbc_password"] = t_jdbc_sink.jdbc_table.jdbc_password;
+params["jdbc_driver_class"] = t_jdbc_sink.jdbc_table.jdbc_driver_class;
+// Resolve jdbc_driver_url to absolute file:// URL
+std::string driver_url;
+auto resolve_st =
+
JdbcUtils::resolve_driver_url(t_jdbc_sink.jdbc_table.jdbc_driver_url, 
&driver_url);
+if (!resolve_st.ok()) {
+LOG(WARNING) << "Failed to resolve JDBC driver URL: " << 
resolve_st.to_string();
+driver_url = t_jdbc_sink.jdbc_table.jdbc_driver_url;
+}
+params["jdbc_driver_url"] = driver_url;
+
+params["jdbc_driver_checksum"] = 
t_jdbc_sink.jdbc_table.jdbc_driver_checksum;
+params["insert_sql"] = t_jdbc_sink.insert_sql;
+params["use_transaction"] = t_jdbc_sink.use_transaction ? "true" : "false";
+params["catalog_id"] = std::to_string(t_jdbc_sink.jdbc_table.catalog_id);
+params["connection_pool_min_size"] =
+std::to_string(t_jdbc_sink.jdbc_table.connection_pool_min_size);
+params["connection_pool_max_size"] =
+std::to_string(t_jdbc_sink.jdbc_table.connection_pool_max_size);
+params["connection_pool_max_wait_time"] =
+
std::to_string(t_jdbc_sink.jdbc_table.connection_pool_max_wait_time);
+params["connection_pool_max_life_time"] =
+
std::to_string(t_jdbc_sink.jdbc_table.connection_pool_max_life_time);
+params["connection_pool_keep_alive"] =
+t_jdbc_sink.jdbc_table.connection_pool_keep_alive ? "true" : 
"false";
+
+return params;
 }
 
 VJdbcTableWriter::VJdbcTableWriter(const TDataSink& t_sink,
const VExprContextSPtrs& output_expr_ctxs,
std::shared_ptr dep,
std::shared_ptr fin_dep)
 : AsyncResultWriter(output_expr_ctxs, dep, fin_dep),
-  JdbcConnector(create_connect_param(t_sink)) {}
+  _writer_params(_build_writer_params(t_sink)),
+  _use_transaction(t_sink.jdbc_table_sink.use_transaction) {}
+
+Status VJdbcTableWriter::open(RuntimeState* state, RuntimeProfile* 
operator_profile) {
+_writer = std::make_unique(
+state, _vec_output_expr_ctxs, 
"org/apache/doris/jdbc/JdbcJniWriter", _writer_params);
+return _writer->open();
+}
 
 Status VJdbcTableWriter::write(RuntimeState* state, Block& block) {
 Block output_block;
 RETURN_IF_ERROR(_projection_block(block, &output_block));
-auto num_rows = output_block.rows();
-
-uint32_t start_send_row = 0;
-uint32_t num_row_sent = 0;
-while (start_send_row < num_rows) {
-

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-12 Thread via GitHub 


zhangstar333 commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4052389348

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4042574792

   # BE Regression && UT Coverage Report
   Increment line coverage `68.69% (645/939)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_a6ddc62957a577bb74ad04f5243f26d63442e154_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_a6ddc62957a577bb74ad04f5243f26d63442e154_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 73.24% (26789/36577) |
   | Line Coverage | 56.54% (285552/505018) |
   | Region Coverage   | 53.79% (237543/441604) |
   | Branch Coverage   | 55.56% (102735/184893) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4042192197

   # BE UT Coverage Report
   Increment line coverage `2.55% (24/940)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/a6ddc62957a577bb74ad04f5243f26d63442e154_a6ddc62957a577bb74ad04f5243f26d63442e154/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/a6ddc62957a577bb74ad04f5243f26d63442e154_a6ddc62957a577bb74ad04f5243f26d63442e154/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.58% (19643/37355) |
   | Line Coverage | 36.18% (183252/506559) |
   | Region Coverage   | 32.37% (141602/437456) |
   | Branch Coverage   | 33.51% (61756/184317) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4041417467

   
   
   TPC-DS: Total hot run time: 152762 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit a6ddc62957a577bb74ad04f5243f26d63442e154, 
data reload: false
   
   query5   4323631 495 495
   query6   331 230 206 206
   query7   4218463 269 269
   query8   356 245 234 234
   query9   8723272626852685
   query10  523 399 340 340
   query11  7362593256065606
   query12  181 131 133 131
   query13  1284439 369 369
   query14  5774376635773577
   query14_12830283128282828
   query15  210 195 176 176
   query16  998 487 440 440
   query17  938 724 612 612
   query18  2435449 359 359
   query19  220 212 184 184
   query20  135 134 131 131
   query21  229 149 128 128
   query22  4885500946054605
   query23  16411   16087   15690   15690
   query23_115997   15888   15859   15859
   query24  7583168313011301
   query24_11265123912861239
   query25  608 488 426 426
   query26  1273271 154 154
   query27  3065491 304 304
   query28  4531184018481840
   query29  865 550 466 466
   query30  312 247 208 208
   query31  1343128812131213
   query32  80  73  69  69
   query33  516 330 278 278
   query34  954 921 557 557
   query35  642 669 597 597
   query36  11161107954 954
   query37  129 95  80  80
   query38  2912294929082908
   query39  902 864 854 854
   query39_1831 830 831 830
   query40  230 150 133 133
   query41  64  61  60  60
   query42  298 303 311 303
   query43  242 256 226 226
   query44  
   query45  202 187 179 179
   query46  891 962 595 595
   query47  2104218220732073
   query48  312 319 221 221
   query49  632 452 376 376
   query50  669 274 214 214
   query51  4135414640624062
   query52  283 293 280 280
   query53  288 330 281 281
   query54  297 299 282 282
   query55  93  86  81  81
   query56  311 343 308 308
   query57  1355134412971297
   query58  299 279 267 267
   query59  1331149813761376
   query60  345 337 310 310
   query61  149 148 146 146
   query62  635 571 538 538
   query63  309 271 272 271
   query64  51541287996 996
   query65  
   query66  1460459 354 354
   query67  16349   16428   16304   16304
   query68  
   query69  393 314 277 277
   query70  990 975 955 955
   query71  337 318 293 293
   query72  2736270824182418
   query73  527 552 321 321
   query74  9956991397969796
   query75  2843274624392439
   query76  22891041651 651
   query77  351 381 300 300
   query78  11097   11389   10613   10613
   query79  1140795 606 606
   query80  1349637 533 533
   query81  557 293 243 243
   query82  1179159 117 117
   query83  341 265 245 245
   query84  294 129 97  97
   query85  939 482 441 441
   query86  425 306 302 302
   query87  3204309329982998
   query88  3504261426322614
   query89  418 363 344 344
   query90  2051172 163 163
   query91  160 158 138 138
   query92  73  76  73  73
   query93  905 826 499 499
   query94  648 311 290 290
   query95  606 342 317 317
   query96  630 506 224 224
   query97  2503251624352435
   query98  246 220 224 220
   query99  10141007919 919
   Total cold run time: 233875 ms
   Total hot run time: 152762 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4041345842

   
   
   TPC-H: Total hot run time: 27731 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a6ddc62957a577bb74ad04f5243f26d63442e154, 
data reload: false
   
   -- Round 1 --
   
   q1   17629   451743394339
   q2   q3  10724   792 515 515
   q4   4718363 258 258
   q5   7938120310221022
   q6   228 174 145 145
   q7   806 865 660 660
   q8   10433   145313291329
   q9   6218473447404734
   q10  6383189916501650
   q11  476 259 243 243
   q12  740 561 461 461
   q13  18057   292621872187
   q14  236 224 210 210
   q15  932 825 831 825
   q16  759 718 668 668
   q17  708 860 412 412
   q18  6130542653235323
   q19  1314978 593 593
   q20  492 508 383 383
   q21  4530192815151515
   q22  391 315 259 259
   Total cold run time: 99842 ms
   Total hot run time: 27731 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   4705452147154521
   q2   q3  3877437138293829
   q4   842 1184779 779
   q5   4086435843404340
   q6   182 174 140 140
   q7   1814166815451545
   q8   2544272925492549
   q9   7417743574697435
   q10  3803395235493549
   q11  502 441 413 413
   q12  488 568 452 452
   q13  2879307023432343
   q14  278 287 272 272
   q15  838 802 809 802
   q16  716 788 752 752
   q17  1191145013651365
   q18  7247691465946594
   q19  826 853 901 853
   q20  2046216620462046
   q21  4082343033323332
   q22  474 421 414 414
   Total cold run time: 50837 ms
   Total hot run time: 48325 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


morningman commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4040910386

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


morningman commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4040864911

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4037321142

   
   
   TPC-DS: Total hot run time: 153441 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 1f9242c726dcac9e638f78c53f8e6517723bd932, 
data reload: false
   
   query5   4333632 524 524
   query6   343 230 203 203
   query7   4207476 263 263
   query8   355 258 227 227
   query9   8742276827992768
   query10  543 423 338 338
   query11  7380588455565556
   query12  188 129 122 122
   query13  1284471 347 347
   query14  5674386735753575
   query14_12832287028632863
   query15  211 195 179 179
   query16  979 487 443 443
   query17  877 725 620 620
   query18  2437450 348 348
   query19  219 239 173 173
   query20  136 131 125 125
   query21  220 148 122 122
   query22  4927504046164616
   query23  16779   16226   16019   16019
   query23_115980   15923   15784   15784
   query24  7529171212991299
   query24_11315131314511313
   query25  562 474 425 425
   query26  1263291 147 147
   query27  2756481 298 298
   query28  4511185718741857
   query29  871 576 476 476
   query30  314 249 210 210
   query31  1348128512261226
   query32  89  71  71  71
   query33  555 328 280 280
   query34  920 907 581 581
   query35  637 693 593 593
   query36  10551152963 963
   query37  134 92  87  87
   query38  3025293228772877
   query39  894 875 855 855
   query39_1830 829 819 819
   query40  228 154 136 136
   query41  62  59  58  58
   query42  302 312 295 295
   query43  239 251 227 227
   query44  
   query45  199 188 184 184
   query46  880 1003618 618
   query47  2110213020532053
   query48  331 321 226 226
   query49  623 477 390 390
   query50  684 296 224 224
   query51  4146411940264026
   query52  287 299 279 279
   query53  295 333 285 285
   query54  303 274 263 263
   query55  96  95  83  83
   query56  323 320 302 302
   query57  1364135112591259
   query58  285 286 272 272
   query59  1353148112601260
   query60  341 344 319 319
   query61  141 141 179 141
   query62  646 581 547 547
   query63  310 277 278 277
   query64  50891247985 985
   query65  
   query66  1457450 350 350
   query67  16322   16426   16252   16252
   query68  
   query69  403 301 284 284
   query70  10411010952 952
   query71  339 302 303 302
   query72  2856268024732473
   query73  539 585 343 343
   query74  10040   991297989798
   query75  2873278024922492
   query76  22981033689 689
   query77  366 395 330 330
   query78  11140   11433   10637   10637
   query79  1161804 615 615
   query80  1476641 572 572
   query81  569 286 248 248
   query82  1259152 120 120
   query83  350 275 253 253
   query84  303 131 118 118
   query85  1161578 522 522
   query86  439 310 296 296
   query87  3137312130513051
   query88  3649267826762676
   query89  431 372 357 357
   query90  1896182 177 177
   query91  168 154 135 135
   query92  81  71  74  71
   query93  921 828 499 499
   query94  653 317 299 299
   query95  602 411 314 314
   query96  635 527 229 229
   query97  2482248424882484
   query98  236 222 221 221
   query99  1004993 909 909
   Total cold run time: 234016 ms
   Total hot run time: 153441 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected].

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4037268375

   
   
   TPC-H: Total hot run time: 27749 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 1f9242c726dcac9e638f78c53f8e6517723bd932, 
data reload: false
   
   -- Round 1 --
   
   q1   17638   456443294329
   q2   q3  10726   794 525 525
   q4   4722368 253 253
   q5   8138118910211021
   q6   223 173 147 147
   q7   846 841 667 667
   q8   10646   145313771377
   q9   6730503348234823
   q10  6706193716671667
   q11  474 265 241 241
   q12  760 577 471 471
   q13  18087   291922022202
   q14  242 230 210 210
   q15  930 800 820 800
   q16  764 732 686 686
   q17  716 867 429 429
   q18  6101545751425142
   q19  1152998 611 611
   q20  496 502 396 396
   q21  4576191414851485
   q22  371 323 267 267
   Total cold run time: 101044 ms
   Total hot run time: 27749 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   4732468847674688
   q2   q3  3901438638393839
   q4   848 1170789 789
   q5   4073436743274327
   q6   188 178 139 139
   q7   1780169515281528
   q8   2483275725772577
   q9   7605752272897289
   q10  3796409236893689
   q11  521 425 408 408
   q12  483 607 488 488
   q13  2773320223752375
   q14  292 300 264 264
   q15  853 828 829 828
   q16  746 769 761 761
   q17  1183151213981398
   q18  7342704667446744
   q19  879 865 888 865
   q20  2106217120532053
   q21  3972350034023402
   q22  467 421 382 382
   Total cold run time: 51023 ms
   Total hot run time: 48833 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-11 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4037009360

   # FE UT Coverage Report
   Increment line coverage `  0.00% (0/95)` :tada:
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_1f9242c726dcac9e638f78c53f8e6517723bd932/fe_increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_1f9242c726dcac9e638f78c53f8e6517723bd932/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4036835623

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/1f9242c726dcac9e638f78c53f8e6517723bd932_1f9242c726dcac9e638f78c53f8e6517723bd932_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/1f9242c726dcac9e638f78c53f8e6517723bd932_1f9242c726dcac9e638f78c53f8e6517723bd932_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.45% (1798/2263) |
   | Line Coverage | 64.72% (32284/49881) |
   | Region Coverage   | 65.69% (16168/24611) |
   | Branch Coverage   | 56.13% (8621/15360) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


morningman commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4036733139

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4036520415

   # BE UT Coverage Report
   Increment line coverage `2.56% (24/937)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/12a2d5e91b183c5e4f486f848768c9ac767de5d7_12a2d5e91b183c5e4f486f848768c9ac767de5d7/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/12a2d5e91b183c5e4f486f848768c9ac767de5d7_12a2d5e91b183c5e4f486f848768c9ac767de5d7/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.60% (19650/37357) |
   | Line Coverage | 36.21% (183358/506437) |
   | Region Coverage   | 32.38% (141655/437431) |
   | Branch Coverage   | 33.52% (61770/184289) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4036378012

   
   
   TPC-DS: Total hot run time: 153463 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 12a2d5e91b183c5e4f486f848768c9ac767de5d7, 
data reload: false
   
   query5   4336635 529 529
   query6   329 233 201 201
   query7   4212470 262 262
   query8   330 245 229 229
   query9   8735276827002700
   query10  514 378 370 370
   query11  7408590156705670
   query12  184 131 131 131
   query13  1273455 347 347
   query14  5563387536243624
   query14_13114279128032791
   query15  211 195 179 179
   query16  994 473 448 448
   query17  896 713 623 623
   query18  2435451 348 348
   query19  214 208 186 186
   query20  136 131 130 130
   query21  222 146 123 123
   query22  5070497550374975
   query23  16645   16101   15969   15969
   query23_115782   15754   15566   15566
   query24  7891167112421242
   query24_11220119512351195
   query25  553 458 400 400
   query26  1243260 146 146
   query27  2780461 282 282
   query28  4437185118391839
   query29  888 554 468 468
   query30  313 243 207 207
   query31  1338129412061206
   query32  94  71  72  71
   query33  500 320 273 273
   query34  924 929 578 578
   query35  635 698 595 595
   query36  1066110410201020
   query37  127 97  83  83
   query38  3002299328762876
   query39  929 867 831 831
   query39_1827 841 803 803
   query40  226 152 130 130
   query41  67  59  58  58
   query42  295 302 293 293
   query43  252 256 219 219
   query44  
   query45  190 192 187 187
   query46  867 984 627 627
   query47  2148211920572057
   query48  306 317 228 228
   query49  634 459 375 375
   query50  674 269 203 203
   query51  4101409140614061
   query52  285 291 282 282
   query53  287 338 283 283
   query54  289 270 258 258
   query55  93  86  81  81
   query56  318 316 317 316
   query57  1364132612831283
   query58  285 283 272 272
   query59  1355147413661366
   query60  330 338 322 322
   query61  148 143 158 143
   query62  626 591 541 541
   query63  312 276 273 273
   query64  5028126710001000
   query65  
   query66  1448468 354 354
   query67  16475   16397   16320   16320
   query68  
   query69  383 314 292 292
   query70  1018997 965 965
   query71  342 313 308 308
   query72  2735276926612661
   query73  548 545 331 331
   query74  9943995497609760
   query75  2853276824662466
   query76  21531043669 669
   query77  362 387 307 307
   query78  11263   11556   10731   10731
   query79  1146800 608 608
   query80  1560639 572 572
   query81  577 277 263 263
   query82  1031149 118 118
   query83  351 259 249 249
   query84  303 119 98  98
   query85  1194490 432 432
   query86  409 297 297 297
   query87  3184310830153015
   query88  3552267026392639
   query89  435 372 341 341
   query90  1885174 177 174
   query91  169 168 134 134
   query92  82  71  70  70
   query93  1059821 502 502
   query94  635 311 300 300
   query95  587 330 318 318
   query96  636 510 228 228
   query97  2463249124402440
   query98  235 233 223 223
   query99  10081022921 921
   Total cold run time: 234531 ms
   Total hot run time: 153463 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4036327977

   
   
   TPC-H: Total hot run time: 27874 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 12a2d5e91b183c5e4f486f848768c9ac767de5d7, 
data reload: false
   
   -- Round 1 --
   
   q1   16699   454943234323
   q2   q3  10317   752 512 512
   q4   4649359 266 266
   q5   7648121510251025
   q6   173 173 147 147
   q7   805 843 678 678
   q8   9419144713401340
   q9   4774474247224722
   q10  6265192016451645
   q11  447 273 232 232
   q12  696 586 469 469
   q13  18076   294021862186
   q14  230 230 224 224
   q15  902 802 823 802
   q16  724 729 686 686
   q17  732 844 411 411
   q18  6060539853135313
   q19  11161004598 598
   q20  500 494 385 385
   q21  4422185716421642
   q22  430 311 268 268
   Total cold run time: 95084 ms
   Total hot run time: 27874 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   4708456945284528
   q2   q3  3857430238033803
   q4   869 1219806 806
   q5   4068440343724372
   q6   182 175 142 142
   q7   1759163714991499
   q8   2496269325592559
   q9   7862741274357412
   q10  3757400935473547
   q11  528 436 419 419
   q12  475 587 443 443
   q13  2854310423342334
   q14  275 307 263 263
   q15  822 836 804 804
   q16  697 764 709 709
   q17  1165144113371337
   q18  7271684168596841
   q19  940 910 906 906
   q20  2082220019861986
   q21  3947348333763376
   q22  491 432 376 376
   Total cold run time: 51105 ms
   Total hot run time: 48462 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4036322389

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/12a2d5e91b183c5e4f486f848768c9ac767de5d7_12a2d5e91b183c5e4f486f848768c9ac767de5d7_cloud/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/12a2d5e91b183c5e4f486f848768c9ac767de5d7_12a2d5e91b183c5e4f486f848768c9ac767de5d7_cloud/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 79.45% (1798/2263) |
   | Line Coverage | 64.69% (32267/49881) |
   | Region Coverage   | 65.62% (16150/24611) |
   | Branch Coverage   | 56.02% (8604/15360) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


morningman commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4036120659

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


hello-stephen commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4035734553

   # BE Regression && UT Coverage Report
   Increment line coverage `41.56% (389/936)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_aac5584d5bc1dee37413233c543552d3a406fee2_merge/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/61141_aac5584d5bc1dee37413233c543552d3a406fee2_merge/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 71.56% (26177/36579) |
   | Line Coverage | 54.33% (274308/504898) |
   | Region Coverage   | 51.46% (227241/441545) |
   | Branch Coverage   | 52.99% (97956/184857) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4035415552

   # BE UT Coverage Report
   Increment line coverage `2.56% (24/937)` :tada:
   
   [Increment coverage 
report](http://coverage.selectdb-in.cc/coverage/aac5584d5bc1dee37413233c543552d3a406fee2_aac5584d5bc1dee37413233c543552d3a406fee2/increment_report/index.html)
   [Complete coverage 
report](http://coverage.selectdb-in.cc/coverage/aac5584d5bc1dee37413233c543552d3a406fee2_aac5584d5bc1dee37413233c543552d3a406fee2/report/index.html)
   | Category  | Coverage   |
   |---||
   | Function Coverage | 52.60% (19650/37357) |
   | Line Coverage | 36.20% (183350/506437) |
   | Region Coverage   | 32.38% (141617/437397) |
   | Branch Coverage   | 33.52% (61766/184281) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4035320110

   
   
   TPC-DS: Total hot run time: 153143 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit aac5584d5bc1dee37413233c543552d3a406fee2, 
data reload: false
   
   query5   4346638 528 528
   query6   324 223 205 205
   query7   4220469 278 278
   query8   354 262 241 241
   query9   8705273127642731
   query10  540 382 369 369
   query11  7435578856045604
   query12  183 131 128 128
   query13  1267475 352 352
   query14  5777380635743574
   query14_12832280127962796
   query15  211 193 177 177
   query16  980 479 469 469
   query17  894 724 618 618
   query18  2451449 371 371
   query19  223 212 185 185
   query20  138 133 129 129
   query21  230 143 130 130
   query22  4967500147004700
   query23  16648   16026   15704   15704
   query23_115908   15842   15903   15842
   query24  7097168012761276
   query24_11291128713081287
   query25  716 541 475 475
   query26  1257279 170 170
   query27  2754482 293 293
   query28  4431184818721848
   query29  872 559 487 487
   query30  312 247 207 207
   query31  1338127412181218
   query32  86  71  78  71
   query33  496 333 280 280
   query34  928 935 558 558
   query35  638 660 597 597
   query36  10961090947 947
   query37  132 96  86  86
   query38  2963288328762876
   query39  900 858 836 836
   query39_1828 823 810 810
   query40  228 150 140 140
   query41  64  61  61  61
   query42  296 299 308 299
   query43  245 252 220 220
   query44  
   query45  194 191 184 184
   query46  892 997 610 610
   query47  2098211520512051
   query48  302 317 223 223
   query49  634 472 379 379
   query50  678 277 226 226
   query51  4100409540664066
   query52  294 299 287 287
   query53  287 331 295 295
   query54  296 278 268 268
   query55  91  92  82  82
   query56  322 327 305 305
   query57  1342135912391239
   query58  293 277 279 277
   query59  1377142912871287
   query60  354 345 315 315
   query61  157 142 150 142
   query62  631 586 545 545
   query63  308 278 281 278
   query64  5102128210051005
   query65  
   query66  1451475 360 360
   query67  16360   16326   16361   16326
   query68  
   query69  374 313 283 283
   query70  1004957 982 957
   query71  343 316 313 313
   query72  2815269424672467
   query73  548 565 324 324
   query74  9961990197799779
   query75  2880272824862486
   query76  21191019681 681
   query77  368 382 308 308
   query78  11247   11518   10662   10662
   query79  1261792 599 599
   query80  1580640 541 541
   query81  585 287 246 246
   query82  974 149 121 121
   query83  356 264 246 246
   query84  289 121 99  99
   query85  1211475 439 439
   query86  410 335 298 298
   query87  3152310530093009
   query88  3582265526532653
   query89  414 370 342 342
   query90  1878174 186 174
   query91  167 160 136 136
   query92  79  77  69  69
   query93  1238843 508 508
   query94  629 306 285 285
   query95  592 391 316 316
   query96  638 510 231 231
   query97  2526247024602460
   query98  231 218 216 216
   query99  1019997 912 912
   Total cold run time: 234275 ms
   Total hot run time: 153143 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected].

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


doris-robot commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4035279198

   
   
   TPC-H: Total hot run time: 27932 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit aac5584d5bc1dee37413233c543552d3a406fee2, 
data reload: false
   
   -- Round 1 --
   
   q1   16943   444843244324
   q2   q3  10374   764 516 516
   q4   4707365 264 264
   q5   7616116910301030
   q6   175 176 147 147
   q7   813 902 666 666
   q8   9407148012951295
   q9   4845471547344715
   q10  6245188916601660
   q11  463 275 241 241
   q12  737 571 462 462
   q13  18043   295921892189
   q14  223 226 226 226
   q15  945 804 807 804
   q16  762 725 679 679
   q17  716 881 393 393
   q18  6041548152525252
   q19  1211982 604 604
   q20  488 488 398 398
   q21  4439183117751775
   q22  360 364 292 292
   Total cold run time: 95553 ms
   Total hot run time: 27932 ms
   
   - Round 2, with runtime_filter_mode=off -
   
   q1   4801453945814539
   q2   q3  3842436738393839
   q4   868 1190758 758
   q5   4012442642964296
   q6   177 179 149 149
   q7   1805167715231523
   q8   2484270425302530
   q9   7343738374147383
   q10  3792407836053605
   q11  504 429 421 421
   q12  482 571 424 424
   q13  2738330522982298
   q14  297 286 277 277
   q15  908 820 786 786
   q16  724 773 716 716
   q17  1117144414101410
   q18  7265675468356754
   q19  867 856 894 856
   q20  2121222520452045
   q21  3950348033643364
   q22  471 457 389 389
   Total cold run time: 50568 ms
   Total hot run time: 48362 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [refactor](jdbc) Unify JDBC scanning into FileQueryScanNode/JniReader framework [doris]

2026-03-10 Thread via GitHub 


morningman commented on PR #61141:
URL: https://github.com/apache/doris/pull/61141#issuecomment-4035071547

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]