Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
Gabriel39 merged PR #42978: URL: https://github.com/apache/doris/pull/42978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
github-actions[bot] commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2463950973 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
github-actions[bot] commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2463951015 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
doris-robot commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2459191493 TeamCity be ut coverage result: Function Coverage: 37.89% (9851/25998) Line Coverage: 29.05% (81924/282014) Region Coverage: 28.28% (42198/149232) Branch Coverage: 24.85% (21407/86132) Coverage Report: http://coverage.selectdb-in.cc/coverage/12c7e5287ac0ff1db3aa8e02fc89a07bde306563_12c7e5287ac0ff1db3aa8e02fc89a07bde306563/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
Mryange commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2459091992 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
doris-robot commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2458671946 TeamCity be ut coverage result: Function Coverage: 37.87% (9839/25980) Line Coverage: 29.02% (81801/281838) Region Coverage: 28.27% (42159/149155) Branch Coverage: 24.85% (21391/86096) Coverage Report: http://coverage.selectdb-in.cc/coverage/12c7e5287ac0ff1db3aa8e02fc89a07bde306563_12c7e5287ac0ff1db3aa8e02fc89a07bde306563/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
Mryange commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2458572595 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
doris-robot commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2456169533 TeamCity be ut coverage result: Function Coverage: 37.81% (9823/25980) Line Coverage: 28.98% (81701/281929) Region Coverage: 28.22% (42120/149240) Branch Coverage: 24.80% (21369/86166) Coverage Report: http://coverage.selectdb-in.cc/coverage/12c7e5287ac0ff1db3aa8e02fc89a07bde306563_12c7e5287ac0ff1db3aa8e02fc89a07bde306563/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
Mryange commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2456065189 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
Mryange commented on code in PR #42978:
URL: https://github.com/apache/doris/pull/42978#discussion_r1827363338
##
be/src/vec/functions/function_cast.h:
##
@@ -428,7 +429,6 @@ struct ConvertImpl {
for (size_t i = 0; i < size; ++i) {
(*vec_null_map_to)[i] = !TimeCast::try_parse_time(
vec_from[i], vec_to[i],
context->state()->timezone_obj());
-vec_to[i] *= (1000 * 1000);
Review Comment:
TimeCast::try_parse_time handles this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
HappenLee commented on code in PR #42978:
URL: https://github.com/apache/doris/pull/42978#discussion_r1825662367
##
be/src/vec/functions/function_cast.h:
##
@@ -428,7 +429,6 @@ struct ConvertImpl {
for (size_t i = 0; i < size; ++i) {
(*vec_null_map_to)[i] = !TimeCast::try_parse_time(
vec_from[i], vec_to[i],
context->state()->timezone_obj());
-vec_to[i] *= (1000 * 1000);
Review Comment:
why delete the code？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
doris-robot commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2451508256 TeamCity be ut coverage result: Function Coverage: 37.82% (9822/25969) Line Coverage: 28.98% (81596/281527) Region Coverage: 28.26% (42145/149117) Branch Coverage: 24.84% (21382/86074) Coverage Report: http://coverage.selectdb-in.cc/coverage/12c7e5287ac0ff1db3aa8e02fc89a07bde306563_12c7e5287ac0ff1db3aa8e02fc89a07bde306563/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [refine](time) use TimeValue to refine repetitive logic and remove unused code. [doris]
Mryange commented on PR #42978: URL: https://github.com/apache/doris/pull/42978#issuecomment-2451448379 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
