[GitHub] [druid-website] vogievetsky opened a new pull request #86: Autobuild

2020-06-30 Thread GitBox
vogievetsky opened a new pull request #86: URL: https://github.com/apache/druid-website/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[druid-website] branch asf-site updated (005a07c -> a43729c)

2020-06-30 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/druid-website.git. from 005a07c Autobuild (#85) new 7369e58 Autobuild new 875a1d0 restore files new a43729c

[GitHub] [druid] vogievetsky commented on a change in pull request #10100: Web console: allow link overrides for docs, and more

2020-06-30 Thread GitBox
vogievetsky commented on a change in pull request #10100: URL: https://github.com/apache/druid/pull/10100#discussion_r447435710 ## File path: web-console/src/links.ts ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [druid] jp707049 commented on issue #10078: How to use environment variables in runtime.properties?

2020-06-30 Thread GitBox
jp707049 commented on issue #10078: URL: https://github.com/apache/druid/issues/10078#issuecomment-651590132 Hi, - I tried using `-Ddruid.host=$DRUID_HOST` in jvm.config but it did not work. Instead the service set the `host=$DRUID_HOST` instead of using value. - I did a

[GitHub] [druid] kanibs commented on pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

2020-06-30 Thread GitBox
kanibs commented on pull request #9764: URL: https://github.com/apache/druid/pull/9764#issuecomment-651582330 Hey @suneet-s, Thanks for the suggestions. I have updated the pull request accordingly. Also, as per your suggestion, I have used static import of `assert` and

[GitHub] [druid-website] vogievetsky merged pull request #86: Autobuild

2020-06-30 Thread GitBox
vogievetsky merged pull request #86: URL: https://github.com/apache/druid-website/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] FrankChen021 commented on issue #10066: web interface ingesting function module tasks use standard UTC time

2020-06-30 Thread GitBox
FrankChen021 commented on issue #10066: URL: https://github.com/apache/druid/issues/10066#issuecomment-651719690 When a task is being created, druid gets the UTC TIME instead of local time based on `-Duser.timezone` property and stores that time as a UTC STRING into meta storage for that

[GitHub] [druid] clintropolis commented on a change in pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #10082: URL: https://github.com/apache/druid/pull/10082#discussion_r447520607 ## File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] maytasm commented on issue #9906: Stack overflow with SELECT ARRAY ['Hello', NULL]

2020-06-30 Thread GitBox
maytasm commented on issue #9906: URL: https://github.com/apache/druid/issues/9906#issuecomment-651639084 I took a look at this issue. I believe this is a Calcite bug. This bug on Calcite was fixed in Calcite 1.23.0 The bug is https://issues.apache.org/jira/browse/CALCITE-3845 I

[GitHub] [druid] samarthjain commented on pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
samarthjain commented on pull request #9422: URL: https://github.com/apache/druid/pull/9422#issuecomment-651975447 Thanks for reviewing, @jihoonson . Will merge after CI passes. This is an automated message from the Apache

[GitHub] [druid] wjhypo commented on pull request #9810: Add segment pruning for hash based shard spec

2020-06-30 Thread GitBox
wjhypo commented on pull request #9810: URL: https://github.com/apache/druid/pull/9810#issuecomment-651992994 @jihoonson @clintropolis Thanks for reviewing! I've fixed the conflicts. This is an automated message from the

[GitHub] [druid] lgtm-com[bot] commented on pull request #10097: Do not echo back username on auth failure

2020-06-30 Thread GitBox
lgtm-com[bot] commented on pull request #10097: URL: https://github.com/apache/druid/pull/10097#issuecomment-651982169 This pull request **fixes 1 alert** when merging 567402357dc8ecff9053a756db69cf063a9d523e into fc555980e8cadc61fcb8cee9d6dadec9cf0e0496 - [view on

[GitHub] [druid] gianm opened a new pull request #10104: Join filter pre-analysis simplifications and sanity checks.

2020-06-30 Thread GitBox
gianm opened a new pull request #10104: URL: https://github.com/apache/druid/pull/10104 - At pre-analysis time, only compute pre-analysis for the innermost root query, since this is the one that will run on the join that involves the base datasource. Previously, pre-analyses were

[GitHub] [druid] suneet-s closed issue #8885: Enable static imports in tests

2020-06-30 Thread GitBox
suneet-s closed issue #8885: URL: https://github.com/apache/druid/issues/8885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] suneet-s merged pull request #9764: Enabling Static Imports for Unit Testing DSLs (#331)

2020-06-30 Thread GitBox
suneet-s merged pull request #9764: URL: https://github.com/apache/druid/pull/9764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (c01fd56 -> 84290a2)

2020-06-30 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from c01fd56 Web console: allow link overrides for docs, and more (#10100) add 84290a2 Enabling Static Imports for

[GitHub] [druid] lgtm-com[bot] commented on pull request #10097: Do not echo back username on auth failure

2020-06-30 Thread GitBox
lgtm-com[bot] commented on pull request #10097: URL: https://github.com/apache/druid/pull/10097#issuecomment-652047647 This pull request **fixes 1 alert** when merging e330690801671a0e966b44a5732335b1e0d9e95d into c01fd561825286a9bc3b3c14d3d63eb93af5 - [view on

[GitHub] [druid] a2l007 opened a new pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
a2l007 opened a new pull request #10105: URL: https://github.com/apache/druid/pull/10105 With #10070 , `druid.server.maxSize` is no longer just a soft limit on the total segment size that can be assigned to a historical. If this property is set to the default value of 0 for a historical,

[GitHub] [druid] clintropolis commented on pull request #10070: Fix balancer strategy

2020-06-30 Thread GitBox
clintropolis commented on pull request #10070: URL: https://github.com/apache/druid/pull/10070#issuecomment-652065443 > I feel we should mention this in the release notes since it modifies the default behavior for druid.server.maxSize. For clusters having historicals with this property

[GitHub] [druid] clintropolis commented on a change in pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r447986966 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] [druid] clintropolis commented on a change in pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r447987561 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] [druid] clintropolis commented on a change in pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #10082: URL: https://github.com/apache/druid/pull/10082#discussion_r447991275 ## File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] jihoonson commented on a change in pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
jihoonson commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448001966 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

[GitHub] [druid] a2l007 commented on pull request #10070: Fix balancer strategy

2020-06-30 Thread GitBox
a2l007 commented on pull request #10070: URL: https://github.com/apache/druid/pull/10070#issuecomment-652068807 I agree. However, the docs give an impression that it maybe okay to set this to the default value, although it isn't. Have tried to fix this in the linked PR.

[GitHub] [druid] a2l007 commented on pull request #10070: Fix balancer strategy

2020-06-30 Thread GitBox
a2l007 commented on pull request #10070: URL: https://github.com/apache/druid/pull/10070#issuecomment-652063436 I feel we should mention this in the release notes since it modifies the default behavior for `druid.server.maxSize`. For clusters having historicals with this property set to

[druid] branch master updated (fc55598 -> c01fd56)

2020-06-30 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from fc55598 Remove payload field from table sys.segment (#9883) add c01fd56 Web console: allow link overrides

[GitHub] [druid] ccaominh merged pull request #10100: Web console: allow link overrides for docs, and more

2020-06-30 Thread GitBox
ccaominh merged pull request #10100: URL: https://github.com/apache/druid/pull/10100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] samarthjain merged pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
samarthjain merged pull request #9422: URL: https://github.com/apache/druid/pull/9422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[druid] branch master updated (84290a2 -> 2c1b458)

2020-06-30 Thread samarth
This is an automated email from the ASF dual-hosted git repository. samarth pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 84290a2 Enabling Static Imports for Unit Testing DSLs (#331) (#9764) add 2c1b458 Prevent unknown complex

[GitHub] [druid] samarthjain closed issue #9421: Unknown complex types break Druid SQL

2020-06-30 Thread GitBox
samarthjain closed issue #9421: URL: https://github.com/apache/druid/issues/9421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] clintropolis commented on a change in pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r447987561 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] [druid] samarthjain commented on a change in pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
samarthjain commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448046112 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] [druid] surekhasaharan commented on pull request #9717: remove DruidLeaderClient.goAsync(..) that does not follow redirect. Replace its usage by DruidLeaderClient.go(..) with InputStreamFullR

2020-06-30 Thread GitBox
surekhasaharan commented on pull request #9717: URL: https://github.com/apache/druid/pull/9717#issuecomment-652089695 @himanshug While we are improving the usability of code coverage checks, it seems this PR is still failing with the more lenient checks. ``` Diff coverage

[GitHub] [druid] clintropolis commented on a change in pull request #9422: Handle unknown complex types

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #9422: URL: https://github.com/apache/druid/pull/9422#discussion_r448048763 ## File path: processing/src/main/java/org/apache/druid/segment/column/UnknownTypeComplexColumn.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the

[GitHub] [druid] clintropolis commented on pull request #10106: Add validation for authorizer name

2020-06-30 Thread GitBox
clintropolis commented on pull request #10106: URL: https://github.com/apache/druid/pull/10106#issuecomment-652127956 >It prevents special characters from being used in the authorizer name so that the authorizer can not be abused to access files on the overlord. Could you elaborate

[GitHub] [druid] gianm edited a comment on pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
gianm edited a comment on pull request #10105: URL: https://github.com/apache/druid/pull/10105#issuecomment-652136504 What was the behavior change that happened in #10070? I looked at that patch's description, and I read the diff in the docs here, and it isn't clear to me what

[GitHub] [druid] gianm commented on pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
gianm commented on pull request #10105: URL: https://github.com/apache/druid/pull/10105#issuecomment-652136504 What was the behavior change that happened in #10070? I looked at that patch, and I read the diff in the docs here, and it isn't clear to me what changed.

[GitHub] [druid] jihoonson commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-30 Thread GitBox
jihoonson commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652097170 The test coverage check now complains about these classes: ``` -- | lines |

[GitHub] [druid] suneet-s opened a new pull request #10106: Add validation for authorizer name

2020-06-30 Thread GitBox
suneet-s opened a new pull request #10106: URL: https://github.com/apache/druid/pull/10106 ### Description This PR fixes an issue flagged by LGTM. It prevents special characters from being used in the authorizer name so that the authorizer can not be abused to access files on the

[GitHub] [druid] clintropolis commented on a change in pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #10105: URL: https://github.com/apache/druid/pull/10105#discussion_r448066624 ## File path: docs/configuration/index.md ## @@ -1370,7 +1370,7 @@ These Historical configurations can be defined in the `historical/runtime.proper

[GitHub] [druid] clintropolis commented on a change in pull request #10096: Update web address to datasketches.apache.org

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #10096: URL: https://github.com/apache/druid/pull/10096#discussion_r448075103 ## File path: docs/development/extensions-core/datasketches-theta.md ## @@ -23,7 +23,7 @@ title: "DataSketches Theta Sketch module" --> -This

[druid] branch master updated (2c1b458 -> 7b4edc9)

2020-06-30 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 2c1b458 Prevent unknown complex types from breaking DruidSchema refresh (#9422) add 7b4edc9 Update web

[GitHub] [druid] clintropolis merged pull request #10096: Update web address to datasketches.apache.org

2020-06-30 Thread GitBox
clintropolis merged pull request #10096: URL: https://github.com/apache/druid/pull/10096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] gianm commented on issue #1926: groupBy sorting behaves not as expected with granularity != 'all'

2020-06-30 Thread GitBox
gianm commented on issue #1926: URL: https://github.com/apache/druid/issues/1926#issuecomment-652143637 Hi @alflennik, the native granularities are indeed somewhat more optimized. This is something that I expect will not be true in the future as we bring more optimization to the

[GitHub] [druid] a2l007 edited a comment on pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
a2l007 edited a comment on pull request #10105: URL: https://github.com/apache/druid/pull/10105#issuecomment-652146731 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] clintropolis opened a new pull request #10107: update links datasketches.github.io to datasketches.apache.org

2020-06-30 Thread GitBox
clintropolis opened a new pull request #10107: URL: https://github.com/apache/druid/pull/10107 Follow-up to #10096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [druid] a2l007 commented on pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
a2l007 commented on pull request #10105: URL: https://github.com/apache/druid/pull/10105#issuecomment-652146731 @gianm Prior to that patch, coordinator could assign segments to historicals even if the balancer couldn't find a valid move for a segment. This means that even if

[GitHub] [druid] gianm commented on pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
gianm commented on pull request #10105: URL: https://github.com/apache/druid/pull/10105#issuecomment-652149734 I see. That older behavior sounds like a bug that got fixed, but perhaps people were relying on the buggy behavior. So I agree it would be good to call it out. Thanks for

[GitHub] [druid] alflennik commented on issue #1926: groupBy sorting behaves not as expected with granularity != 'all'

2020-06-30 Thread GitBox
alflennik commented on issue #1926: URL: https://github.com/apache/druid/issues/1926#issuecomment-652156022 @gianm Thanks for the reply! After thinking on it a while I figured out a good way in my system to make a time-based dimension available for the unusual situations that demand it

[GitHub] [druid] clintropolis merged pull request #10087: Filter on metrics doc

2020-06-30 Thread GitBox
clintropolis merged pull request #10087: URL: https://github.com/apache/druid/pull/10087 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[druid] branch master updated (5faa897 -> d3497a6)

2020-06-30 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 5faa897 Join filter pre-analysis simplifications and sanity checks. (#10104) add d3497a6 Filter on metrics

[GitHub] [druid] Fullstop000 opened a new issue #10108: DruidSegmentReader uses wrong timestampSpec column

2020-06-30 Thread GitBox
Fullstop000 opened a new issue #10108: URL: https://github.com/apache/druid/issues/10108 ### Affected Version 0.17.0 ### Description When using auto-compaction, I found some compaction tasks fail due to errors below: ``` 648 java.lang.ClassCastException:

[GitHub] [druid] suneet-s commented on pull request #10106: Add validation for authorizer name

2020-06-30 Thread GitBox
suneet-s commented on pull request #10106: URL: https://github.com/apache/druid/pull/10106#issuecomment-652170871 > > It prevents special characters from being used in the authorizer name so that the authorizer can not be abused to access files on the overlord. > > Could you

[GitHub] [druid] clintropolis opened a new pull request #10109: fixes for ranger docs

2020-06-30 Thread GitBox
clintropolis opened a new pull request #10109: URL: https://github.com/apache/druid/pull/10109 Fixes some doc errors from #9579. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] clintropolis commented on a change in pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-30 Thread GitBox
clintropolis commented on a change in pull request #10082: URL: https://github.com/apache/druid/pull/10082#discussion_r448109639 ## File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] gianm edited a comment on issue #1926: groupBy sorting behaves not as expected with granularity != 'all'

2020-06-30 Thread GitBox
gianm edited a comment on issue #1926: URL: https://github.com/apache/druid/issues/1926#issuecomment-652143637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [druid] jon-wei merged pull request #10104: Join filter pre-analysis simplifications and sanity checks.

2020-06-30 Thread GitBox
jon-wei merged pull request #10104: URL: https://github.com/apache/druid/pull/10104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (7b4edc9 -> 5faa897)

2020-06-30 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 7b4edc9 Update web address to datasketches.apache.org (#10096) add 5faa897 Join filter pre-analysis

[GitHub] [druid] gianm commented on pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
gianm commented on pull request #10105: URL: https://github.com/apache/druid/pull/10105#issuecomment-652148057 > @gianm Prior to that patch, coordinator could assign segments to historicals even if the balancer couldn't find a valid move for a segment. This means that even if

[GitHub] [druid] a2l007 commented on pull request #10105: Clarify change in behavior for druid.server.maxSize

2020-06-30 Thread GitBox
a2l007 commented on pull request #10105: URL: https://github.com/apache/druid/pull/10105#issuecomment-652149255 > > @gianm Prior to that patch, coordinator could assign segments to historicals even if the balancer couldn't find a valid move for a segment. This means that even if

[GitHub] [druid] gianm commented on a change in pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-30 Thread GitBox
gianm commented on a change in pull request #10082: URL: https://github.com/apache/druid/pull/10082#discussion_r448076264 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -112,6 +114,30 @@