[GitHub] gianm commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask

2018-07-27 Thread GitBox
gianm commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask URL: https://github.com/apache/incubator-druid/pull/6065#discussion_r205929239 ## File path:

[GitHub] gianm opened a new pull request #6067: FinalizingFieldAccessPostAggregator: Fix serde.

2018-07-27 Thread GitBox
gianm opened a new pull request #6067: FinalizingFieldAccessPostAggregator: Fix serde. URL: https://github.com/apache/incubator-druid/pull/6067 Fixes #6063. This is an automated message from the Apache Git Service. To

[GitHub] b-slim closed pull request #4776: Fix ClassNotFoundException in druid-kerberos extension

2018-07-27 Thread GitBox
b-slim closed pull request #4776: Fix ClassNotFoundException in druid-kerberos extension URL: https://github.com/apache/incubator-druid/pull/4776 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jon-wei opened a new pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask

2018-07-27 Thread GitBox
jon-wei opened a new pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask URL: https://github.com/apache/incubator-druid/pull/6065 If I define a CombiningFirehose with a IngestSegmentFirehose delegate in an IndexTask: ``` "firehose" : {

[GitHub] gianm commented on issue #6063: FinalizingFieldAccessPostAggregator cannot be deserialized once it gets decorated

2018-07-27 Thread GitBox
gianm commented on issue #6063: FinalizingFieldAccessPostAggregator cannot be deserialized once it gets decorated URL: https://github.com/apache/incubator-druid/issues/6063#issuecomment-408575833 FinalizingFieldAccessPostAggregator is documented, so I think we should fix it. I'll do a

[GitHub] josephglanville commented on issue #6066: Sorting rows when rollup is disabled

2018-07-28 Thread GitBox
josephglanville commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-408593384 This is especially useful in cases where no metrics are specified and all rows are dimensions only as leaving roll-up enabled in

[GitHub] leventov opened a new pull request #6062: Fix a bug in GroupByQueryEngine

2018-07-27 Thread GitBox
leventov opened a new pull request #6062: Fix a bug in GroupByQueryEngine URL: https://github.com/apache/incubator-druid/pull/6062 It was potentially missing many unaggregated buffers. This is an automated message from the

[GitHub] leventov commented on issue #6027: Make Parser.parseToMap() to return a mutable Map

2018-07-27 Thread GitBox
leventov commented on issue #6027: Make Parser.parseToMap() to return a mutable Map URL: https://github.com/apache/incubator-druid/pull/6027#issuecomment-408565906 If Spark updates Kryo (BTW I cannot even find on what version it depends), and Spark cluster users update Spark, this change

[GitHub] jihoonson commented on issue #5566: Applying doubleSum over doubleFirst aggregations in nested groupBy fails

2018-07-27 Thread GitBox
jihoonson commented on issue #5566: Applying doubleSum over doubleFirst aggregations in nested groupBy fails URL: https://github.com/apache/incubator-druid/issues/5566#issuecomment-408567669 Hi all, `DoubleFirstAggregator` returns `SerializedPair`s which is the intermediate

[GitHub] leventov opened a new issue #6064: Duplicate DataSegmentTest

2018-07-27 Thread GitBox
leventov opened a new issue #6064: Duplicate DataSegmentTest URL: https://github.com/apache/incubator-druid/issues/6064 Seems that `io.druid.timeline.DataSegmentTest` is duplicated in druid-api and druid-server modules. This

[GitHub] hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410013932 @jihoonson, Yes, I am interested in this. Do we have scripts ready for all these java commands or for just

[GitHub] jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410022159 @hpandeycodeit we have the scripts for all Druid components. Please check `${DRUID_HOME}/bin` directory. > And

[GitHub] asdf2014 opened a new pull request #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-01 Thread GitBox
asdf2014 opened a new pull request #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090 Try to fix issues [#6024](https://github.com/apache/incubator-druid/issues/6024)

[GitHub] gianm commented on issue #5938: URL encode datasources, task ids, authenticator names.

2018-08-01 Thread GitBox
gianm commented on issue #5938: URL encode datasources, task ids, authenticator names. URL: https://github.com/apache/incubator-druid/pull/5938#issuecomment-409604350 @himanshug, re: > looks like most of the fixes are in the calls to makeWorkerUrl(..), is it possible to put the fix

[GitHub] josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410030450 One thing that has become apparent is the `StringInputRowParser` is a bit of a bad citizen. It extends

[GitHub] hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410037251 @jihoonson , The scripts are there but doesn't look like it's working: For eg: $./broker.sh

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207381285 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@

[GitHub] gianm commented on issue #6017: Logging of invalid queries

2018-08-02 Thread GitBox
gianm commented on issue #6017: Logging of invalid queries URL: https://github.com/apache/incubator-druid/issues/6017#issuecomment-410080968 Sounds like a good idea -- the main challenge is probably that right now, the request logger expects to get a valid Query object, but we could add a

[GitHub] vogievetsky commented on issue #1835: Schema differences of GroupBy vs TopN/TimeSeries return data should be not be present

2018-08-02 Thread GitBox
vogievetsky commented on issue #1835: Schema differences of GroupBy vs TopN/TimeSeries return data should be not be present URL: https://github.com/apache/incubator-druid/issues/1835#issuecomment-410032064 I ed this issue back in the day but since then groupBy v2 drastically improved

[GitHub] pdeva closed issue #1598: upgrading from 0.6 to 0.7 will result in corruption of existing segment in realtime node

2018-08-02 Thread GitBox
pdeva closed issue #1598: upgrading from 0.6 to 0.7 will result in corruption of existing segment in realtime node URL: https://github.com/apache/incubator-druid/issues/1598 This is an automated message from the Apache Git

[GitHub] pdeva closed issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup

2018-08-02 Thread GitBox
pdeva closed issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup URL: https://github.com/apache/incubator-druid/issues/1816 This is an automated message from the Apache Git Service. To respond to

[GitHub] vogievetsky commented on issue #1449: Allow sorting by timestamp

2018-08-02 Thread GitBox
vogievetsky commented on issue #1449: Allow sorting by timestamp URL: https://github.com/apache/incubator-druid/issues/1449#issuecomment-410036629 This is now possible with GroupBy v2 (and in Druid SQL) @gianm please confirm and close.

[GitHub] jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410051112 It should work. Would you please check your broker logs?

[GitHub] gianm commented on issue #6097: Possible performance issue during DruidSchema metadata refresh

2018-08-02 Thread GitBox
gianm commented on issue #6097: Possible performance issue during DruidSchema metadata refresh URL: https://github.com/apache/incubator-druid/issues/6097#issuecomment-410063021 Hi @egor-ryashin, There have been some improvements to the refreshing mechanism in later versions (try

[GitHub] vogievetsky commented on issue #1836: MapCache needs re-written

2018-08-02 Thread GitBox
vogievetsky commented on issue #1836: MapCache needs re-written URL: https://github.com/apache/incubator-druid/issues/1836#issuecomment-410031205 Did https://github.com/apache/incubator-druid/pull/3028 address this? This is

[GitHub] vogievetsky commented on issue #1711: null exception from filter with Query-Time Lookup

2018-08-02 Thread GitBox
vogievetsky commented on issue #1711: null exception from filter with Query-Time Lookup URL: https://github.com/apache/incubator-druid/issues/1711#issuecomment-410034795 Jonathan! Long time no see! I remember when this was filed... good times. @fjy I believe this was resolved (as noted

[GitHub] vogievetsky commented on issue #1560: convertSpec tool completely broken

2018-08-02 Thread GitBox
vogievetsky commented on issue #1560: convertSpec tool completely broken URL: https://github.com/apache/incubator-druid/issues/1560#issuecomment-410036215 Is this still an issue? This is an automated message from the Apache

[GitHub] vogievetsky commented on issue #6094: Introduce SystemSchema tables (#5989)

2018-08-02 Thread GitBox
vogievetsky commented on issue #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#issuecomment-410038602 so excited about this one! This is an automated message from the

[GitHub] egor-ryashin opened a new issue #6097: Possible performance issue during DruidSchema metadata refresh

2018-08-02 Thread GitBox
egor-ryashin opened a new issue #6097: Possible performance issue during DruidSchema metadata refresh URL: https://github.com/apache/incubator-druid/issues/6097 `Druid Broker 0.11.0` with `druid.sql.enable=true` produces much more garbage than usual, profiling shows a lot of `Object[]`

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207370256 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@

[GitHub] hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410098043 @jihoonson, I am getting "Not Enough direct memory" error: ``` 1) Not enough direct memory.

[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410030450 One thing that has become apparent is the `StringInputRowParser` is a bit of a bad citizen. It extends

[GitHub] vogievetsky commented on issue #6096: Windows Ubuntu Bash and Task Directory Name

2018-08-02 Thread GitBox
vogievetsky commented on issue #6096: Windows Ubuntu Bash and Task Directory Name URL: https://github.com/apache/incubator-druid/issues/6096#issuecomment-410030657 I think it is a good point about directory names and should be considered for the project @gianm does it make sense to avoid

[GitHub] vogievetsky commented on issue #1692: Why Deep storage No data?but realtime node can find 3413610 num data

2018-08-02 Thread GitBox
vogievetsky commented on issue #1692: Why Deep storage No data?but realtime node can find 3413610 num data URL: https://github.com/apache/incubator-druid/issues/1692#issuecomment-410035126 @zengzhihai110 can this issue be closed?

[GitHub] gianm commented on issue #6076: Mutual TLS support

2018-08-02 Thread GitBox
gianm commented on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-410063706 @jon-wei, thanks, I think it is really valuable especially as we add more features to the feature. (I heard you like features so we put features in your

[GitHub] vogievetsky commented on issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup

2018-08-02 Thread GitBox
vogievetsky commented on issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup URL: https://github.com/apache/incubator-druid/issues/1816#issuecomment-410033063 This issue is super pretty old and does not look actionable (Who even knows where to get Druid 0.8.1

[GitHub] gianm commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
gianm commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410039394 IMO the speed hit on ingestion is acceptable. It is small, and performance is not really worse than the rollup case. Adding sorting will

[GitHub] vogievetsky commented on issue #1204: Define granularities in UTC

2018-08-02 Thread GitBox
vogievetsky commented on issue #1204: Define granularities in UTC URL: https://github.com/apache/incubator-druid/issues/1204#issuecomment-410039263 Is this still an issue after https://github.com/apache/incubator-druid/pull/4611 ?

[GitHub] jihoonson closed issue #5934: eccn

2018-08-02 Thread GitBox
jihoonson closed issue #5934: eccn URL: https://github.com/apache/incubator-druid/issues/5934 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to

[GitHub] gianm commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
gianm commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410052884 > I'm guessing Druid does the rollup by sorting the dimensions in the order in the ingestion spec, which would indicate that dimension

[GitHub] vogievetsky commented on issue #1827: JsonConfigurator does not escape quoted options

2018-08-02 Thread GitBox
vogievetsky commented on issue #1827: JsonConfigurator does not escape quoted options URL: https://github.com/apache/incubator-druid/issues/1827#issuecomment-410032588 Does https://github.com/apache/incubator-druid/pull/2033 address this?

[GitHub] mistercrunch commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
mistercrunch commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410043357 I'm guessing Druid does the rollup by sorting the dimensions in the order in the ingestion spec, which would indicate that

[GitHub] gianm commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
gianm commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410045743 Yeah -- StringInputRowParser is a bit of a special snowflake. Maybe doing this feature is the motivation we need to rethink how

[GitHub] clintropolis commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
clintropolis commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410053497 @gianm Cool, I'll go ahead and make a PR as soon as I get some tests finished up. I'm not certain the cause of slower group-by

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207370004 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/IntFormMetrics.java ## @@ -0,0

[GitHub] hpandeycodeit edited a comment on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit edited a comment on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410037251 @jihoonson , The scripts are there but doesn't look like it's working: For eg:

[GitHub] chengchengpei commented on a change in pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei commented on a change in pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#discussion_r207408616 ## File path:

[GitHub] chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] clintropolis commented on issue #6066: Sorting rows when rollup is disabled

2018-08-03 Thread GitBox
clintropolis commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410153475 I ran some additional benchmarks after realizing that the generated rows from previous benchmarks were rows with no opportunity for

[GitHub] asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410119637 Hi, @jihoonson . Yep, that's right. :+1: Perhaps something in this

[GitHub] clintropolis edited a comment on issue #6066: Sorting rows when rollup is disabled

2018-08-03 Thread GitBox
clintropolis edited a comment on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410153475 I ran some additional benchmarks after realizing that the generated rows from previous benchmarks were rows with no

[GitHub] asdf2014 edited a comment on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
asdf2014 edited a comment on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410119637 Hi, @jihoonson . Yep, that's right. :+1: Perhaps something in

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 The changes validate that baseDataSource is not a

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 The changes validate that baseDataSource is not a

[GitHub] asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410121501 @jihoonson Okay, I keep those changes, and patch them to get the job

[GitHub] jacktomcat closed issue #6098: Inconsistencies in the result of the quantile aggregator

2018-08-02 Thread GitBox
jacktomcat closed issue #6098: Inconsistencies in the result of the quantile aggregator URL: https://github.com/apache/incubator-druid/issues/6098 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-03 Thread GitBox
asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410165818 Hi, @jihoonson . After patching these changes, I found the same

[GitHub] asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-03 Thread GitBox
asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410170672 BTW, when i tried to use `ExpectedException` instead of

[GitHub] dyanarose opened a new issue #6100: DOCS: ingestion spec documentation should be expanded

2018-08-03 Thread GitBox
dyanarose opened a new issue #6100: DOCS: ingestion spec documentation should be expanded URL: https://github.com/apache/incubator-druid/issues/6100 - The dataSchema would be much clearer if an example of the raw data was included. - The importance of the metric spec would be

[GitHub] asdf2014 commented on issue #6099: Inconsistencies in the result of the quantile aggregator

2018-08-03 Thread GitBox
asdf2014 commented on issue #6099: Inconsistencies in the result of the quantile aggregator URL: https://github.com/apache/incubator-druid/issues/6099#issuecomment-410201965 Hi, @jacktomcat . This result is obtained because the quantile aggregator uses an approximate algorithm called

[GitHub] clintropolis commented on issue #6066: Sorting rows when rollup is disabled

2018-08-03 Thread GitBox
clintropolis commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410183701 Ok, so I had to know, so I went ahead and did benchmarks if we do the other way and sort at persist time. no rollup

[GitHub] asdf2014 commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-03 Thread GitBox
asdf2014 commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410184869 Hi, @hpandeycodeit . I also encountered this situation. There is

[GitHub] aryaflow commented on issue #5221: Support Hadoop batch ingestion for druid-azure-extensions

2018-08-03 Thread GitBox
aryaflow commented on issue #5221: Support Hadoop batch ingestion for druid-azure-extensions URL: https://github.com/apache/incubator-druid/pull/5221#issuecomment-410241234 @hoesler hadoop-azure is not added by default. But it's needed.

[GitHub] robertervin opened a new issue #6101: Druid InDimFilter Fails on Empty Values

2018-08-03 Thread GitBox
robertervin opened a new issue #6101: Druid InDimFilter Fails on Empty Values URL: https://github.com/apache/incubator-druid/issues/6101 ### Use Case: We dynamically build Druid queries by allowing the user to filter the UI. Sometimes this results in the user filtering out all options

[GitHub] aryaflow commented on issue #5221: Support Hadoop batch ingestion for druid-azure-extensions

2018-08-03 Thread GitBox
aryaflow commented on issue #5221: Support Hadoop batch ingestion for druid-azure-extensions URL: https://github.com/apache/incubator-druid/pull/5221#issuecomment-410234843 Thanks for the feature. I tried this in a cluster and succeeded to make it work... but I had to add wasb to

[GitHub] bohemia420 commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files

2018-08-03 Thread GitBox
bohemia420 commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files URL: https://github.com/apache/incubator-druid/issues/5150#issuecomment-410239779 is this resolved? @amalakar how did u remove avro converter? @gianm how does one change

[GitHub] chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-03 Thread GitBox
chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-410242447 @jihoonson NP. How can I become committer?

[GitHub] aoeiuvb opened a new issue #6102: "Cannot have same delimiter and list delimiter of \u0001"

2018-08-03 Thread GitBox
aoeiuvb opened a new issue #6102: "Cannot have same delimiter and list delimiter of \u0001" URL: https://github.com/apache/incubator-druid/issues/6102 When I used hadoop to absorb data, I used DelimitedParser to parse the row. The delimiter I set was **\u0001**, but the following error

[GitHub] leventov commented on a change in pull request #5957: Renamed GenericColumnSerializer to ColumnSerializer; 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixe

2018-08-03 Thread GitBox
leventov commented on a change in pull request #5957: Renamed GenericColumnSerializer to ColumnSerializer; 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixed a bug in SingleStringInputDimensionSelector; misc refinements URL:

[GitHub] leventov commented on a change in pull request #5957: Renamed GenericColumnSerializer to ColumnSerializer; 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixe

2018-08-03 Thread GitBox
leventov commented on a change in pull request #5957: Renamed GenericColumnSerializer to ColumnSerializer; 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixed a bug in SingleStringInputDimensionSelector; misc refinements URL:

[GitHub] himanshug commented on issue #6066: Sorting rows when rollup is disabled

2018-08-03 Thread GitBox
himanshug commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410326897 @clintropolis if you do end up further benchmarking sorting at persist time, then you can also consider reordering the dimensions from

[GitHub] yuppie-flu opened a new pull request #6070: Use JUnit TemporaryFolder rule instead of system temp folder

2018-07-30 Thread GitBox
yuppie-flu opened a new pull request #6070: Use JUnit TemporaryFolder rule instead of system temp folder URL: https://github.com/apache/incubator-druid/pull/6070 This should help to avoid transient failures, mentioned in #6013

[GitHub] gianm commented on issue #5903: Druid allows adding empty string dataSources (it shouldn't)

2018-07-30 Thread GitBox
gianm commented on issue #5903: Druid allows adding empty string dataSources (it shouldn't) URL: https://github.com/apache/incubator-druid/issues/5903#issuecomment-408942682 Fixed by #5785. This is an automated message from

[GitHub] gianm closed pull request #6059: CompactionTask: Reject empty intervals on construction.

2018-07-30 Thread GitBox
gianm closed pull request #6059: CompactionTask: Reject empty intervals on construction. URL: https://github.com/apache/incubator-druid/pull/6059 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] gianm closed issue #5903: Druid allows adding empty string dataSources (it shouldn't)

2018-07-30 Thread GitBox
gianm closed issue #5903: Druid allows adding empty string dataSources (it shouldn't) URL: https://github.com/apache/incubator-druid/issues/5903 This is an automated message from the Apache Git Service. To respond to the

[GitHub] chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-408943015 how to add WIP tag? This is

[GitHub] gianm commented on a change in pull request #6062: Fix a bug in GroupByQueryEngine

2018-07-30 Thread GitBox
gianm commented on a change in pull request #6062: Fix a bug in GroupByQueryEngine URL: https://github.com/apache/incubator-druid/pull/6062#discussion_r206202261 ## File path: processing/src/main/java/io/druid/query/groupby/GroupByQueryEngine.java ## @@ -178,37 +178,33

[GitHub] gianm commented on issue #6069: BUG: intermediate persist directories are not cleaned up

2018-07-30 Thread GitBox
gianm commented on issue #6069: BUG: intermediate persist directories are not cleaned up URL: https://github.com/apache/incubator-druid/issues/6069#issuecomment-408912020 Hi @varaga, The MiddleManager processes themselves are meant to clean up these directories when tasks exit.

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 the following two tests failed: Tests in error:

[GitHub] gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206212482 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java ##

[GitHub] gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206212950 ## File path: processing/src/main/java/io/druid/collections/spatial/Node.java ## @@ -56,7

[GitHub] gianm edited a comment on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder

2018-07-30 Thread GitBox
gianm edited a comment on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder URL: https://github.com/apache/incubator-druid/pull/6070#issuecomment-408925522 Hi @yuppie-flu, there seems to be some problem with the new forbidden-api check: ``` [ERROR] Failed

[GitHub] chengchengpei opened a new issue #6071: DerivativeDataSourceMetadata allows adding empty string baseDataSource

2018-07-30 Thread GitBox
chengchengpei opened a new issue #6071: DerivativeDataSourceMetadata allows adding empty string baseDataSource URL: https://github.com/apache/incubator-druid/issues/6071 similar to https://github.com/apache/incubator-druid/issues/5903. `baseDataSource` should not be empty string. I

[GitHub] gianm commented on issue #6036: use S3 as a backup storage for hdfs deep storage

2018-07-30 Thread GitBox
gianm commented on issue #6036: use S3 as a backup storage for hdfs deep storage URL: https://github.com/apache/incubator-druid/pull/6036#issuecomment-408899333 >Agreed. Earlier I tried to load primary and secondary deep storage extensions inside composite-deep-storage module and found it

[GitHub] gianm commented on issue #6058: Remove some unnecessary task storage internal APIs.

2018-07-30 Thread GitBox
gianm commented on issue #6058: Remove some unnecessary task storage internal APIs. URL: https://github.com/apache/incubator-druid/pull/6058#issuecomment-408899571 @asdf2014 I will fix them and re-push. Anything that makes the CI failure message more useful sounds great 

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206301783 ## File path:

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206301554 ## File path:

[GitHub] jihoonson commented on issue #6061: skip travis on doc only changes

2018-07-30 Thread GitBox
jihoonson commented on issue #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061#issuecomment-408976290 @clintropolis it sounds good. This is an automated message from the Apache

[GitHub] jihoonson commented on issue #5492: Native parallel batch indexing without shuffle

2018-07-30 Thread GitBox
jihoonson commented on issue #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#issuecomment-409004658 @drcrallen do you have further comments? This is an automated

[GitHub] jihoonson commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-07-30 Thread GitBox
jihoonson commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-409010765 @josephglanville, thanks for the comment. It sounds good to me. I also agree to support Reader for realtime ingestion too.

[GitHub] Caroline1000 opened a new pull request #6073: Query gran0730

2018-07-30 Thread GitBox
Caroline1000 opened a new pull request #6073: Query gran0730 URL: https://github.com/apache/incubator-druid/pull/6073 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206272902 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java

[GitHub] jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206277090 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206304373 ## File path:

[GitHub] chengchengpei opened a new pull request #6075: validate non-empty String baseDataSource in MaterializedViewSuperviso…

2018-07-30 Thread GitBox
chengchengpei opened a new pull request #6075: validate non-empty String baseDataSource in MaterializedViewSuperviso… URL: https://github.com/apache/incubator-druid/pull/6075 re: https://github.com/apache/incubator-druid/issues/6074 I am working on this.

[GitHub] leventov commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
leventov commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206274500 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java

[GitHub] jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206274914 ## File path: processing/src/main/java/io/druid/collections/spatial/Node.java ## @@

[GitHub] jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-408966069 Hi @chengchengpei, thank you for the contribution! I've added `WIP` tag.

[GitHub] jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206319063 ## File path:

[GitHub] chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-408974324 @jihoonson Hi, Thanks. It seems that the failed tests are not related to my change. most of them

  1   2   3   4   5   6   7   8   9   10   >