[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r434745199 ## File path: processing/src/main/java/org/apache/druid/query/expression/RegexpLikeExprMacro.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r428831347 ## File path: processing/src/main/java/org/apache/druid/query/expression/RegexpLikeExprMacro.java ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache

[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r428827872 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java ## @@ -7300,6 +7301,74 @@ public void testRegexpExtract() throws Exception

[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r428782343 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java ## @@ -291,15 +294,15 @@ public OperatorBuilder

[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r428782087 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java ## @@ -430,36 +434,64 @@ public void inferOperandTypes(

[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r428780412 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java ## @@ -291,15 +294,15 @@ public OperatorBuilder

[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r428758597 ## File path: docs/querying/sql.md ## @@ -322,17 +322,18 @@ String functions accept strings, and return a type appropriate to the function.

[GitHub] [druid] gianm commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

gianm commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r428757383 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java ## @@ -291,15 +294,15 @@ public OperatorBuilder