[GitHub] [druid] suneet-s commented on issue #9560: Instructions to run integration tests against quickstart
suneet-s commented on issue #9560: Instructions to run integration tests against quickstart URL: https://github.com/apache/druid/pull/9560#issuecomment-604225864 I don't see it in the list of tests run by the "other" test job. I think it's excluded because of this in the config `-DexcludedGroups=batch-index` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] suneet-s commented on issue #9560: Instructions to run integration tests against quickstart
suneet-s commented on issue #9560: Instructions to run integration tests against quickstart URL: https://github.com/apache/druid/pull/9560#issuecomment-604221332 The `ITCompactionTaskTest` was excluded in the other integration test run - https://travis-ci.org/github/apache/druid/jobs/667053767?utm_medium=notification_source=github_status, so I reverted the change that explicitly excludes that test group and added more javadocs. The `ITIndexerTest` was run coorectly - https://travis-ci.org/github/apache/druid/jobs/667053761?utm_medium=notification_source=github_status This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] suneet-s commented on issue #9560: Instructions to run integration tests against quickstart
suneet-s commented on issue #9560: Instructions to run integration tests against quickstart URL: https://github.com/apache/druid/pull/9560#issuecomment-604167731 > > @suneet-s You should also exclude the new group QUICKSTART_COMPATIBLE from travis "other integration test". > > I feel like that "other integration test" instead of doing exclude should just do include > > Actually, I think this might be wrong. The test is assigned to 2 groups. So if I exclude 1/2 groups, I think it might exclude the test. Need to check locally if that's the case. So much TestNG magic I'm learning about in this PR @maytasm3 I tried this locally, and it appears to run the test. `mvn clean verify -P int-tests-config-file -Dit.test=ITCompactionTaskTest -DexcludedGroups=quickstart-compatible` I'll look at the results of this travis run to make sure that ITCompactionTaskTest is actually run in this change This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] suneet-s commented on issue #9560: Instructions to run integration tests against quickstart
suneet-s commented on issue #9560: Instructions to run integration tests against quickstart URL: https://github.com/apache/druid/pull/9560#issuecomment-604119377 > @suneet-s You should also exclude the new group QUICKSTART_COMPATIBLE from travis "other integration test". > I feel like that "other integration test" instead of doing exclude should just do include Actually, I think this might be wrong. The test is assigned to 2 groups. So if I exclude 1/2 groups, I think it might exclude the test. Need to check locally if that's the case. So much TestNG magic I'm learning about in this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] suneet-s commented on issue #9560: Instructions to run integration tests against quickstart
suneet-s commented on issue #9560: Instructions to run integration tests against quickstart URL: https://github.com/apache/druid/pull/9560#issuecomment-603903816 @maytasm3 Yes - debuggability and speed. I was trying to debug the integration tests. Unfortunately the docker environment is spun up and down as part of the integration tests, so it's hard to debug that environment. It's also quicker for me to test against since I usually have quickstart of a few different versions of druid on my dev machine. This makes it easier for me to verify that the integration test I'm adding fails for a new version, but works with my fix. Also spinning up the docker environment can take some time, so I found it faster to point my tests to an already running quickstart This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
