[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346617966 ## File path: core/src/main/java/org/apache/druid/data/input/Firehose.java ## @@ -74,13 +74,13

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346619475 ## File path: core/src/main/java/org/apache/druid/data/input/InputRowListPlusJson.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344919111 ## File path: core/src/main/java/org/apache/druid/data/input/Unformattable.java ## @@ -0,0 +1,40

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344918837 ## File path: core/src/main/java/org/apache/druid/data/input/Formattable.java ## @@ -0,0 +1,39

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r344423212 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FirehoseToInputSourceReaderAdaptor.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343346519 ## File path: core/src/main/java/org/apache/druid/data/input/impl/TimestampSpec.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343351095 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/TaskToolbox.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343349303 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopDruidIndexerConfig.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343377888 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343378240 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343935241 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343366132 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343921764 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343340884 ## File path: core/src/test/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptorTest.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343922643 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r342782214 ## File path: core/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343928317 ## File path: core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343935145 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343419111 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FileSource.java ## @@ -0,0

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343942960 ## File path: core/src/main/java/org/apache/druid/java/util/common/FileUtils.java ## @@ -306,6

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343881013 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvInputFormat.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343935199 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopFirehoseFactory.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343410250 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JSONParseSpec.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343936612 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343932828 ## File path: core/src/main/java/org/apache/druid/data/input/impl/SplitIteratingReader.java ##

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343948330 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343908366 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvReaderTest.java ## @@ -0,0

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343425624 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FirehoseToInputSourceReaderAdaptor.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343414360 ## File path: core/src/main/java/org/apache/druid/data/input/SplitSource.java ## @@ -0,0 +1,111

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343380177 ## File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343956499 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343425515 ## File path: core/src/main/java/org/apache/druid/data/input/impl/FirehoseToInputSourceReaderAdaptor.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343906675 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvReader.java ## @@ -0,0

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343937356 ## File path: core/src/test/java/org/apache/druid/data/input/impl/JsonReaderTest.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343924073 ## File path: core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343950067 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343956969 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343948966 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343940070 ## File path: core/src/test/java/org/apache/druid/data/input/impl/CsvInputFormatTest.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343934796 ## File path: core/src/test/java/org/apache/druid/data/input/impl/NoopInputSource.java ## @@

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343955244 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r343934419 ## File path: core/src/test/java/org/apache/druid/data/input/impl/SplitIteratingReaderTest.java