[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-04-08 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-480939628 @peferron > top songs by unique viewers Yes. > additional aggregations could be computed at the same time Yes, with a

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-21 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-475121316 @peferron Thank you for your response and for performing a test with an HLL aggregator. The intent of my statements in the

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-13 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-472630425 And, I should point out that for the current implementation of "TopN" if any of the weight parameters are negative, the aggregations MUST be

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-13 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469548325 @gianm I think we may have some confusion here. FIS uses `Identity` for the object and `Comparable` for the weight parameter. And the

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-13 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469548325 @gianm I think we may have some confusion here. FIS uses `Identity` for the object and `Comparable` for the weight parameter. And the

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-12 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-472185432 @gianm @leventov Perhaps it is "well-known" amongst the Druid developers, but I think the Druid team is taking a serious risk with

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-12 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-472185432 Perhaps it is "well-known" amongst the Druid developers, but I think the Druid team is taking a serious risk with Druid's reputation. Druid's

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-06 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-470366530 > getting the top song titles by number of unique listeners over the past week @peferron Now that is very interesting! The current FIS

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-05 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469439146 ### Objective - Improve the current internal heuristic algorithm for "TopN" with streaming algorithms including DataSketches [Frequent Items

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-05 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469439146 ### Objective - Improve the current internal heuristic algorithm for "TopN" with streaming algorithms including DataSketches [Frequent Items

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-04 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469548325 @gianm I think we may have some confusion here. FIS does not depend on `Comparable` at all, only `Identity`. And the weights are positive

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-04 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469548325 @gianm I think we may have some confusion here. FIS does not depend on `Comparable` at all, only `Identity`. And the weights are positive