surekhasaharan commented on issue #8810: Make submit task API similar to
supervisor API
URL: https://github.com/apache/incubator-druid/pull/8810#issuecomment-553598612
> > Yeah, i looked at that, it thinks `dataSchema` can be null
[here](https://github.com/apache/incubator-druid/pull/8810/files#diff-0ce554adcd07cc3ea613b457eb800164R208)
because of test cases, where null is passed for `dataSchema`, though those
tests pass a valid `ingestionSchema`, and it's already checked in
[here](https://github.com/apache/incubator-druid/pull/8810/files#diff-0ce554adcd07cc3ea613b457eb800164R133).
Not sure how to make lgtm ignore that or fix otherwise.
>
> You can fix it by making a non-null `IndexIngestionSpec` first and then
using it in the constructor.
>
> Also, this PR changes only `IndexTask`. Are you going to change
`ParallelIndexSupervisorTask` in a follow-up pr?
Yes, want to change `ParallelIndexSupervisorTask` as well in this PR,
working on it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
