[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip
option for exec-maven-plugin
URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r220042872
##
File path: distribution/pom.xml
##
@@ -46,142 +46,107 @@
--clean
-
-
-
-org.codehaus.mojo
-exec-maven-plugin
-
-
-pull-deps
-package
-
-exec
-
-
-java
-
--classpath
-
-
-Ddruid.extensions.loadList=[]
-
-Ddruid.extensions.directory=${project.build.directory}/extensions
-
-
-Ddruid.extensions.hadoopDependenciesDir=${project.build.directory}/hadoop-dependencies
-
-org.apache.druid.cli.Main
-tools
-pull-deps
---clean
---defaultVersion
-${project.parent.version}
--l
-
${settings.localRepository}
--h
-
org.apache.hadoop:hadoop-client:${hadoop.compile.version}
--c
-
org.apache.druid.extensions:druid-avro-extensions
--c
-
org.apache.druid.extensions:druid-datasketches
--c
-
org.apache.druid.extensions:druid-hdfs-storage
--c
-
org.apache.druid.extensions:druid-histogram
--c
-
org.apache.druid.extensions:druid-kafka-eight
--c
-
org.apache.druid.extensions:druid-kafka-extraction-namespace
--c
-
org.apache.druid.extensions:druid-kafka-indexing-service
--c
-
org.apache.druid.extensions:druid-lookups-cached-global
--c
-
org.apache.druid.extensions:druid-lookups-cached-single
--c
-
org.apache.druid.extensions:druid-protobuf-extensions
--c
-
org.apache.druid.extensions:mysql-metadata-storage
--c
-
org.apache.druid.extensions:postgresql-metadata-storage
--c
-
org.apache.druid.extensions:druid-kerberos
--c
-
org.apache.druid.extensions:druid-s3-extensions
--c
-
org.apache.druid.extensions:druid-stats
--c
-
org.apache.druid.extensions:druid-examples
--c
-
org.apache.druid.extensions:simple-client-sslcontext
--c
-
org.apache.druid.extensions:druid-basic-security
-
${druid.distribution.pulldeps.opts}
-
-
-
-
-mysql-tarball
-package
-
-exec
-
-
-tar
-
--C
-
${project.build.directory}/extensions
--czvf
-
-
${project.build.directory}/mysql-metadata-storage-${project.parent.version}.tar.gz
-
-mysql-metadata-storage
-
-
-
-
-
-
-org.apache.maven.plugins
-maven-assembly-plugin
-
-
-distro-assembly
-package
-
-single
-
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r214085872 ## File path: docs/content/development/build.md ## @@ -13,16 +13,18 @@ Building Druid requires the following: To do so, run these commands: -``` +```bash git clone g...@github.com:druid-io/druid.git cd druid -mvn clean package +mvn clean package -Pdist ``` This will compile the project and create the Druid binary distribution tar under `distribution/target/druid-VERSION-bin.tar.gz`. -This will also create a tarball that contains `mysql-metadata-storage` extension under +The difference between `mvn clean package` and `mvn clean package -Pdist` is that Review comment: Hi, @jihoonson . Sorry for the delayed reply, this has been patched, PTAL. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r211067084 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ + Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r211067078 ## File path: docs/content/development/build.md ## @@ -22,7 +22,7 @@ mvn clean package This will compile the project and create the Druid binary distribution tar under `distribution/target/druid-VERSION-bin.tar.gz`. -This will also create a tarball that contains `mysql-metadata-storage` extension under +After adding `-Pdist` option, this will also create a tarball that contains `mysql-metadata-storage` extension under Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r211067076 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ + +dist + +false + +tar Review comment: Added. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r211066550 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ + +dist + +false + +tar Review comment: Okay. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r211066546 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ + Review comment: Okay, i got it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r210788802 ## File path: docs/content/development/build.md ## @@ -22,7 +22,7 @@ mvn clean package This will compile the project and create the Druid binary distribution tar under `distribution/target/druid-VERSION-bin.tar.gz`. -This will also create a tarball that contains `mysql-metadata-storage` extension under +After adding `-Pdist` option, this will also create a tarball that contains `mysql-metadata-storage` extension under Review comment: Okay, i will improve this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r210788731 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ + Review comment: Do you mean that the `bundle-contrib-exts` part should also be included in the `dist` profile? Or should we include all the `build` plugins, such as the `maven-assembly-plugin` and `license-maven-plugin` plugins? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin
asdf2014 commented on a change in pull request #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r210787456 ## File path: distribution/pom.xml ## @@ -174,6 +83,111 @@ + +dist + +false + +tar Review comment: Sure, we also can use `-Dtar` to execute this plugin. In addition, if we used both of `name` and `value` tags, then only `-Dtar=dist` will be in effect. ```xml tar dist ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
