gianm closed pull request #6153: Fix race in testCheckpointForUnknownTaskGroup() of KafkaSupervisorTest URL: https://github.com/apache/incubator-druid/pull/6153
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java b/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java index b49af3714a4..36f3d733d6f 100644 --- a/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java +++ b/extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java @@ -70,8 +70,8 @@ import io.druid.segment.indexing.granularity.UniformGranularitySpec; import io.druid.segment.realtime.FireDepartment; import io.druid.server.metrics.DruidMonitorSchedulerConfig; -import io.druid.server.metrics.NoopServiceEmitter; import io.druid.server.metrics.ExceptionCapturingServiceEmitter; +import io.druid.server.metrics.NoopServiceEmitter; import org.apache.curator.test.TestingCluster; import org.apache.kafka.clients.producer.KafkaProducer; import org.apache.kafka.clients.producer.ProducerRecord; @@ -2183,7 +2183,11 @@ public void testCheckpointForUnknownTaskGroup() throws InterruptedException verifyAll(); - Assert.assertNotNull(serviceEmitter.getStackTrace()); + while (serviceEmitter.getStackTrace() == null) { + Thread.sleep(100); + } + + Assert.assertTrue(serviceEmitter.getStackTrace().startsWith("io.druid.java.util.common.ISE: WTH?! cannot find")); Assert.assertEquals( "WTH?! cannot find taskGroup [0] among all taskGroups [{}]", serviceEmitter.getExceptionMessage() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org