Re: [PR] Improve extensibility of MSQ Dart engine via extensions (druid)
kfaraz merged PR #19127: URL: https://github.com/apache/druid/pull/19127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Improve extensibility of MSQ Dart engine via extensions (druid)
kfaraz commented on PR #19127: URL: https://github.com/apache/druid/pull/19127#issuecomment-4066249899 The flaky `CompactionSupervisorTest` is already being addressed here #19157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Improve extensibility of MSQ Dart engine via extensions (druid)
kfaraz commented on code in PR #19127:
URL: https://github.com/apache/druid/pull/19127#discussion_r2938090577
##
server/src/main/java/org/apache/druid/discovery/DruidNodeDiscoveryProvider.java:
##
@@ -62,14 +63,24 @@ public abstract class DruidNodeDiscoveryProvider
* Get DruidNodeDiscovery instance to discover nodes that announce given
service in its metadata.
*/
public DruidNodeDiscovery getForService(String serviceName)
+ {
+return getForServiceAndRoles(
+serviceName,
+DruidNodeDiscoveryProvider.SERVICE_TO_NODE_TYPES.get(serviceName)
+);
+ }
+
+ /**
+ * Get DruidNodeDiscovery instance to discover nodes of a specific role that
+ * announce the given service in their metadata.
+ */
+ public DruidNodeDiscovery getForServiceAndRoles(String serviceName,
Set nodeRolesToWatch)
{
return serviceDiscoveryMap.computeIfAbsent(
serviceName,
Review Comment:
Thanks for catching this! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Improve extensibility of MSQ Dart engine via extensions (druid)
gianm commented on code in PR #19127:
URL: https://github.com/apache/druid/pull/19127#discussion_r2932738912
##
server/src/main/java/org/apache/druid/discovery/DruidNodeDiscoveryProvider.java:
##
@@ -62,14 +63,24 @@ public abstract class DruidNodeDiscoveryProvider
* Get DruidNodeDiscovery instance to discover nodes that announce given
service in its metadata.
*/
public DruidNodeDiscovery getForService(String serviceName)
+ {
+return getForServiceAndRoles(
+serviceName,
+DruidNodeDiscoveryProvider.SERVICE_TO_NODE_TYPES.get(serviceName)
+);
+ }
+
+ /**
+ * Get DruidNodeDiscovery instance to discover nodes of a specific role that
+ * announce the given service in their metadata.
+ */
+ public DruidNodeDiscovery getForServiceAndRoles(String serviceName,
Set nodeRolesToWatch)
{
return serviceDiscoveryMap.computeIfAbsent(
serviceName,
Review Comment:
Shouldn't the key of this map now be a combination of `serviceName` and
`nodeRolesToWatch`? Otherwise, if this method is called more than once for the
same service with different roles, the subsequent callers won't get the correct
roles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
