Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-17 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1568904980 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-17 Thread via GitHub
zachjsh merged PR #16190: URL: https://github.com/apache/druid/pull/16190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-16 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1567570396 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566594802 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -122,6 +126,7 @@

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566576116 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamEndSequenceNumbers.java: ## @@ -0,0 +1,183 @@ +/* + *

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566575886 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566575647 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamStartSequenceNumbers.java: ## @@ -0,0 +1,220 @@ +/* + *

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566575482 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamStartSequenceNumbers.java: ## @@ -0,0 +1,220 @@ +/* + *

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566574921 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566575304 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-15 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1566575090 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-12 Thread via GitHub
abhishekrb19 commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1562694558 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-12 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1563017112 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-12 Thread via GitHub
abhishekrb19 commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1562793256 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-12 Thread via GitHub
abhishekrb19 commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1562674637 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-09 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1557907260 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-05 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1554346513 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamStartSequenceNumbers.java: ## @@ -0,0 +1,158 @@ +/* + *

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-02 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1548924208 ## extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaDataSourceMetadataTest.java: ## @@ -203,19 +462,60

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-02 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1548910010 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamStartSequenceNumbers.java: ## @@ -0,0 +1,158 @@ +/* + *

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-02 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1548909835 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamEndSequenceNumbers.java: ## @@ -0,0 +1,126 @@ +/* + *

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-03-31 Thread via GitHub
abhishekagarwal87 commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1545980952 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java: ## @@ -444,4 +447,56 @@ public