Re: [PR] Restore context flag for window functions (druid)
cryptoe merged PR #16229: URL: https://github.com/apache/druid/pull/16229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
Re: [PR] Restore context flag for window functions (druid)
cryptoe commented on PR #16229: URL: https://github.com/apache/druid/pull/16229#issuecomment-2033898071 Since this is STS blocker, going ahead with merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
Re: [PR] Restore context flag for window functions (druid)
cryptoe commented on PR #16229: URL: https://github.com/apache/druid/pull/16229#issuecomment-2033897524 Changes LGTM. Though I would love a UT on the MSQ side which fails in case the flag is not set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
