Re: [PR] Upgrade Kubernetes clients and related dependencies in `kubernetes-overlord-extensions` and `druid-kubernetes-extensions` (druid)
capistrant merged PR #19071: URL: https://github.com/apache/druid/pull/19071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upgrade Kubernetes clients and related dependencies in `kubernetes-overlord-extensions` and `druid-kubernetes-extensions` (druid)
gianm commented on code in PR #19071: URL: https://github.com/apache/druid/pull/19071#discussion_r2907486768 ## extensions-core/kubernetes-overlord-extensions/pom.xml: ## @@ -139,12 +142,17 @@ com.squareup.okhttp3 okhttp - 4.12.0 + 5.3.2 Review Comment: It's possibly an artifact of the two different extensions being developed separately. Agree it would be good to standardize on a single k8s client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upgrade Kubernetes clients and related dependencies in `kubernetes-overlord-extensions` and `druid-kubernetes-extensions` (druid)
capistrant commented on code in PR #19071: URL: https://github.com/apache/druid/pull/19071#discussion_r2881312672 ## extensions-core/kubernetes-overlord-extensions/pom.xml: ## @@ -139,12 +142,17 @@ com.squareup.okhttp3 okhttp - 4.12.0 + 5.3.2 Review Comment: ok, after a song and dance it seems like getting aligned on okhttp 5.3.2 is doable by bumping the kubernetes client for both k8s extensions. It sure would be nice if we had a single client that we used for k8s instead of both io.kubernetes + fabric8. Maybe if all goes well with this fabric8 bump we can shed the okhttp and native jdk http clients plus use fabric8 in both k8s related extensions. Would probably save a lot of annoyances in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upgrade Kubernetes clients and related dependencies in `kubernetes-overlord-extensions` and `druid-kubernetes-extensions` (druid)
capistrant commented on code in PR #19071: URL: https://github.com/apache/druid/pull/19071#discussion_r2879632302 ## extensions-core/kubernetes-overlord-extensions/pom.xml: ## @@ -139,12 +142,17 @@ com.squareup.okhttp3 okhttp - 4.12.0 + 5.3.2 Review Comment: eh maybe I spoke too soon on that io.kubernetes update being simple... that might force a bunch of other major dep updates as part of the dependency enforcer. I will maybe go back to the drawing board on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
