Re: [PR] Upload Druid container logs for debugging docker-tests (druid)
kfaraz closed pull request #19126: Upload Druid container logs for debugging docker-tests URL: https://github.com/apache/druid/pull/19126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upload Druid container logs for debugging docker-tests (druid)
kfaraz commented on code in PR #19126:
URL: https://github.com/apache/druid/pull/19126#discussion_r2917268426
##
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/DruidContainerResource.java:
##
@@ -154,7 +154,7 @@ public void beforeStart(EmbeddedDruidCluster cluster)
);
// Mount directories used by this container for easier debugging with
service logs
-this.containerDirectory = cluster.getTestFolder().getOrCreateFolder(name);
+this.containerDirectory = new File("druid-container-logs", name);
Review Comment:
Used the test class name to aid in quickly identifying the containers for
each test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Upload Druid container logs for debugging docker-tests (druid)
kfaraz commented on code in PR #19126: URL: https://github.com/apache/druid/pull/19126#discussion_r2917265531 ## .github/workflows/unit-and-integration-tests-unified.yml: ## @@ -60,7 +60,7 @@ jobs: uses: ./.github/workflows/docker-tests.yml actions-timeline: -needs: [unit-tests, docker-tests] +needs: [unit-tets, docker-tests] Review Comment: fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upload Druid container logs for debugging docker-tests (druid)
kfaraz commented on code in PR #19126:
URL: https://github.com/apache/druid/pull/19126#discussion_r2916875972
##
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/DruidContainerResource.java:
##
@@ -154,7 +154,7 @@ public void beforeStart(EmbeddedDruidCluster cluster)
);
// Mount directories used by this container for easier debugging with
service logs
-this.containerDirectory = cluster.getTestFolder().getOrCreateFolder(name);
+this.containerDirectory = new File("druid-container-logs", name);
Review Comment:
Currently, we don't exactly support running embedded tests concurrently
(mostly due to the port bindings which are likely to have conflicts when
running multiple clusters without the port properties overridden).
But I guess, we can use a unique `clusterId` here to avoid conflicts. Let me
see if I can add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Upload Druid container logs for debugging docker-tests (druid)
kfaraz commented on code in PR #19126: URL: https://github.com/apache/druid/pull/19126#discussion_r2916846245 ## .github/workflows/unit-and-integration-tests-unified.yml: ## @@ -60,7 +60,7 @@ jobs: uses: ./.github/workflows/docker-tests.yml actions-timeline: -needs: [unit-tests, docker-tests] +needs: [unit-tets, docker-tests] Review Comment: ```suggestion needs: [unit-tests, docker-tests] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upload Druid container logs for debugging docker-tests (druid)
jtuglu1 commented on code in PR #19126:
URL: https://github.com/apache/druid/pull/19126#discussion_r2916847354
##
.github/workflows/unit-and-integration-tests-unified.yml:
##
@@ -60,7 +60,7 @@ jobs:
uses: ./.github/workflows/docker-tests.yml
actions-timeline:
-needs: [unit-tests, docker-tests]
+needs: [unit-tets, docker-tests]
Review Comment:
lgtm pending this update
##
embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/DruidContainerResource.java:
##
@@ -154,7 +154,7 @@ public void beforeStart(EmbeddedDruidCluster cluster)
);
// Mount directories used by this container for easier debugging with
service logs
-this.containerDirectory = cluster.getTestFolder().getOrCreateFolder(name);
+this.containerDirectory = new File("druid-container-logs", name);
Review Comment:
I assume this won't race with other concurrent container resources writing
logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Upload Druid container logs for debugging docker-tests (druid)
kfaraz commented on PR #19126: URL: https://github.com/apache/druid/pull/19126#issuecomment-4037527565 Upload of container logs seems to be working fine here: https://github.com/apache/druid/actions/runs/22942396318/job/66586668877?pr=19126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
