Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)
TestBoost commented on PR #15557: URL: https://github.com/apache/druid/pull/15557#issuecomment-2033192292 Thank you so much for letting me know!!! I can close this pull request now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)
TestBoost closed pull request #15557: only create `sqlSegmentsMetadataManager` once to speed up test URL: https://github.com/apache/druid/pull/15557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)
kfaraz commented on PR #15557: URL: https://github.com/apache/druid/pull/15557#issuecomment-1978028220 @TestBoost , taking another look at this test class, I realize that it might not be needed at all. I have created #16044 to merge this test into the bigger one instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)
TestBoost commented on PR #15557: URL: https://github.com/apache/druid/pull/15557#issuecomment-1925151449 Thank you very much for pointing out! We don't find any other tests like this in server module and other modules in druid as of now. But there are other test classes that require splitting tests that utilize the same variables/resources into different test classes to make tests faster. I don't know if it's suitable. And I also applied the changes as you said in this pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)
kfaraz commented on PR #15557: URL: https://github.com/apache/druid/pull/15557#issuecomment-1857192079 Thanks for the response, @TestBoost . - Since all the changes seem small and are in the same vein, it would be better to have a single PR that is updating all the tests in a single module (e.g. the module touched in this PR is `server`), if not the entire Druid project. - It would be nice to know what is the overall time benefit that you are gaining by these changes. - For the current PR in particular, it makes sense for `derbyConnectorRule` and `jsonMapper` to be static but not the the test target `sqlSegmentsMetadataManager` as we explicitly want it to be freshly created in every test. This is true even when the metadata manager state doesn't seem to be altered in a particular test. - For #15533, I have left a comment on that PR itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
Re: [PR] only create `sqlSegmentsMetadataManager` once to speed up test (druid)
TestBoost commented on PR #15557: URL: https://github.com/apache/druid/pull/15557#issuecomment-1856533952 Hi, To clarify, this is not a bot account. We recently developed a new tool for transforming test classes to speed up testing by reducing the number of times test fixtures (setup and teardown methods) are run, by essentially making them run at the class level instead of at the method level (between every test method). Using our tool, we were able to transform other test classes within this project, including the one from #15533, but we had the mindset of sending pull requests for a few at a time as to not overwhelm. If you would prefer that we send many or all at once, we can try that. If you have any feedback on this approach or what we could do better, we would be happy to change things accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
