Re: [PR] provide a response description for supervisor status api (druid)

2024-04-02 Thread via GitHub


github-actions[bot] closed pull request #15031: provide a response description 
for supervisor status api
URL: https://github.com/apache/druid/pull/15031


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2024-04-02 Thread via GitHub


github-actions[bot] commented on PR #15031:
URL: https://github.com/apache/druid/pull/15031#issuecomment-2033314153

   This pull request/issue has been closed due to lack of activity. If you 
think that
   is incorrect, or the pull request requires review, you can revive the PR at 
any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2024-03-04 Thread via GitHub


github-actions[bot] commented on PR #15031:
URL: https://github.com/apache/druid/pull/15031#issuecomment-1977713649

   This pull request has been marked as stale due to 60 days of inactivity.
   It will be closed in 4 weeks if no further activity occurs. If you think
   that's incorrect or this pull request should instead be reviewed, please 
simply
   write any comment. Even if closed, you can still revive the PR at any time or
   discuss it on the d...@druid.apache.org list.
   Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379357907


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 

Review Comment:
   Instead of a nested table, consider creating a separate table for 
`activeTasks` properties. 
   
   Also, the Map interface should probably be in code font.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379357907


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 

Review Comment:
   Instead of a nested table, consider creating a separate table for 
`activeTasks` properties. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379352929


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 
+|`publishingTasks`|Array of Object|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|
+|`latestOffsets`|Map < String, Integer >|The lastest offset consumed from the 
stream by partition.|
+|`minimumLag`|Map < String, Integer >|The number of messages pending to read 
from stream by partition.|
+|`aggregateLag`|Integer|The sum of minimum lags (see above) across all 
partitions.|
+|`offsetLastUpdated`|String|Contains the timestamp of when the stream offsets 
were last inspected.|
+|`suspended`|Boolean|True if the supervisor is in a SUSPENDED state.|
+|`healthy`|Boolean|True if the supervisor and its tasks are currently healthy.|
+|`state`|String|Overall state of the supervisor. |
+|`detailedState`|String|Current stage of processing for the supervisor.|
+|`recentErrors`|Array of String|Errors reported recently by supervisor managed 
tasks.|

Review Comment:
   ```suggestion
   |`recentErrors`|Array of strings|Errors reported recently by supervisor 
managed tasks.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379349504


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 
+|`publishingTasks`|Array of Object|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|
+|`latestOffsets`|Map < String, Integer >|The lastest offset consumed from the 
stream by partition.|
+|`minimumLag`|Map < String, Integer >|The number of messages pending to read 
from stream by partition.|
+|`aggregateLag`|Integer|The sum of minimum lags (see above) across all 
partitions.|
+|`offsetLastUpdated`|String|Contains the timestamp of when the stream offsets 
were last inspected.|
+|`suspended`|Boolean|True if the supervisor is in a SUSPENDED state.|

Review Comment:
   ```suggestion
   |`suspended`|Boolean|True if the supervisor is in a `SUSPENDED` state.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379350082


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 
+|`publishingTasks`|Array of Object|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|
+|`latestOffsets`|Map < String, Integer >|The lastest offset consumed from the 
stream by partition.|
+|`minimumLag`|Map < String, Integer >|The number of messages pending to read 
from stream by partition.|
+|`aggregateLag`|Integer|The sum of minimum lags (see above) across all 
partitions.|
+|`offsetLastUpdated`|String|Contains the timestamp of when the stream offsets 
were last inspected.|
+|`suspended`|Boolean|True if the supervisor is in a SUSPENDED state.|
+|`healthy`|Boolean|True if the supervisor and its tasks are currently healthy.|
+|`state`|String|Overall state of the supervisor. |
+|`detailedState`|String|Current stage of processing for the supervisor.|

Review Comment:
   ```suggestion
   |`detailedState`|String|Current stage of processing for the supervisor.|
   ```
   Should this say "state" instead of "stage"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379348792


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 
+|`publishingTasks`|Array of Object|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|
+|`latestOffsets`|Map < String, Integer >|The lastest offset consumed from the 
stream by partition.|
+|`minimumLag`|Map < String, Integer >|The number of messages pending to read 
from stream by partition.|
+|`aggregateLag`|Integer|The sum of minimum lags (see above) across all 
partitions.|
+|`offsetLastUpdated`|String|Contains the timestamp of when the stream offsets 
were last inspected.|

Review Comment:
   ```suggestion
   |`offsetLastUpdated`|String|The timestamp of when the stream offsets were 
last inspected.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379344948


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 
+|`publishingTasks`|Array of Object|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|
+|`latestOffsets`|Map < String, Integer >|The lastest offset consumed from the 
stream by partition.|
+|`minimumLag`|Map < String, Integer >|The number of messages pending to read 
from stream by partition.|

Review Comment:
   ```suggestion
   |`minimumLag`|`Map < String, Integer >`|The number of messages pending to 
read from the stream by partition.|
   ```
   Should the Map interface be in code font?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379344948


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 
+|`publishingTasks`|Array of Object|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|
+|`latestOffsets`|Map < String, Integer >|The lastest offset consumed from the 
stream by partition.|
+|`minimumLag`|Map < String, Integer >|The number of messages pending to read 
from stream by partition.|

Review Comment:
   ```suggestion
   |`minimumLag`|Map < String, Integer >|The number of messages pending to read 
from stream by partition.|
   ```
   ```suggestion
   |`minimumLag`|`Map < String, Integer >`|The number of messages pending to 
read from the stream by partition.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379343076


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|
+|`activeTasks`|Array of Object|Lists the tasks that are reading from the 
stream, each with: 
`startTime`StringTask start 
time.`remainingTime`IntegerThe time 
remaining in the reading state`currentOffsets`Map < 
String , Integer >The list of partitions that the task is reading from 
with the latest offset consumed from each.`lag`Map < 
String , Integer >The number of messages pending to read from each 
partition. | 
+|`publishingTasks`|Array of Object|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|

Review Comment:
   ```suggestion
   |`publishingTasks`|Array of objects|Lists the tasks that are publishing 
segments to Deep Storage and awaiting handoff confirmation. For detailed 
structure see `activeTasks` above.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379339340


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|
+|`durationSeconds`|Integer|Seconds that each task spends reading before moving 
to a publishing state.|

Review Comment:
   ```suggestion
   |`durationSeconds`|Integer|The number of seconds that each task spends 
reading before moving to a publishing state.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379338752


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|
+|`replicas`|Integer|Number of replicas being used per task for high 
availability where 1 means no redundancy.|

Review Comment:
   ```suggestion
   |`replicas`|Integer|The number of replicas being used per task for high 
availability where 1 means no redundancy.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379335886


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|
+|`partitions`|Integer|Number of partitions in the source stream.|

Review Comment:
   ```suggestion
   |`partitions`|Integer|The number of partitions in the source stream.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379335691


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:
+
+|Property|Type|Description|
+|---|---|---|
+|`dataSource`|String|The target datasource.|
+|`stream`|String|Name of the topic or stream that the ingestion is reading 
from.|

Review Comment:
   ```suggestion
   |`stream`|String|The name of the topic or stream that the ingestion is 
reading from.|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



Re: [PR] provide a response description for supervisor status api (druid)

2023-11-01 Thread via GitHub


ektravel commented on code in PR #15031:
URL: https://github.com/apache/druid/pull/15031#discussion_r1379335197


##
docs/api-reference/supervisor-api.md:
##
@@ -1311,6 +1311,29 @@ Host: http://ROUTER_IP:ROUTER_PORT
   ```
 
 
+ Response Description 
+The response `payload` contains the following structure:

Review Comment:
   ```suggestion
   
   The response `payload` contains the following properties:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org