techdocsmith commented on code in PR #17634:
URL: https://github.com/apache/druid/pull/17634#discussion_r1919140276
##
docs/querying/aggregations.md:
##
@@ -485,7 +485,7 @@ Aggregator applicable only at query time. Aggregates
results using [Druid expres
| `finalize` | The finalize expression which can only refer to a single input
variable, `o`. This expression is used to perform any final transformation of
the output of the `fold` or `combine` expressions. If not set, then the value
is not transformed. | No |
| `initialValue` | The initial value of the accumulator for the `fold` (and
`combine`, if `InitialCombineValue` is null) expression. | Yes |
| `initialCombineValue` | The initial value of the accumulator for the
`combine` expression. | No. Default `initialValue`. |
-| `isNullUnlessAggregated` | Indicates that the default output value should be
`null` if the aggregator does not process any rows. If true, the value is
`null`, if false, the result of running the expressions with initial values is
used instead. | No. Defaults to the value of
`druid.generic.useDefaultValueForNull`. |
+| `isNullUnlessAggregated` | Indicates that the default output value should be
`null` if the aggregator does not process any rows. If true, the value is
`null`, if false, the result of running the expressions with initial values is
used instead. | No. Defaults to `true`. |
Review Comment:
```suggestion
| `isNullUnlessAggregated` | Sets the default output value to `null` when
the aggregator does not process any rows. If true, the value is `null`. If
false, Druid computes the value as the result of running the expressions with
initial values. | No. Defaults to `true`. |
```
nit awkward passive.
##
docs/development/extensions-core/approximate-histograms.md:
##
@@ -226,9 +226,7 @@ For performance and accuracy reasons, we recommend avoiding
aggregation of histo
### Null handling
-If `druid.generic.useDefaultValueForNull` is false, null values will be
tracked in the `missingValueCount` field of the histogram.
-
-If `druid.generic.useDefaultValueForNull` is true, null values will be added
to the histogram as the default 0.0 value.
+Null values will be tracked in the `missingValueCount` field of the histogram.
Review Comment:
```suggestion
Druid tracks null values in the `missingValueCount` field of the histogram.
```
Nit: avoid future tense
##
docs/querying/math-expr.md:
##
@@ -162,7 +162,7 @@ See javadoc of java.lang.Math for detailed explanation for
each function.
|remainder|remainder(x, y) returns the remainder operation on two arguments as
prescribed by the IEEE 754 standard|
|rint|rint(x) returns value that is closest in value to x and is equal to a
mathematical integer|
|round|round(x, y) returns the value of the x rounded to the y decimal places.
While x can be an integer or floating-point number, y must be an integer. The
type of the return value is specified by that of x. y defaults to 0 if omitted.
When y is negative, x is rounded on the left side of the y decimal points. If x
is `NaN`, x returns 0. If x is infinity, x will be converted to the nearest
finite double. |
-|safe_divide|safe_divide(x,y) returns the division of x by y if y is not equal
to 0. In case y is 0 it returns `null` or 0 if
`druid.generic.useDefaultValueForNull=true` (legacy mode) |
+|safe_divide|safe_divide(x,y) returns the division of x by y if y is not equal
to 0. In case y is 0 it returns `null`|
Review Comment:
```suggestion
|safe_divide|safe_divide(x,y) returns the division of x by y if y is not
equal to 0. Returns 0 if y is `null` |
```
nit
##
docs/querying/math-expr.md:
##
@@ -315,8 +315,8 @@ Supported features:
* string functions: the concatenation operator (`+`) and `concat` function are
supported for string and numeric types
* other: `parse_long` is supported for numeric and string types
-## Logical operator modes
-In Druid 28.0 and later, `druid.expressions.useStrictBooleans=true` is set by
default. Logical operations treat `null` values as "unknown" for SQL compatible
behavior. _All boolean output functions_ will output 'homogeneous' `LONG` typed
boolean values of `1` for `true` and `0` for `false`.
+## Logical operator behavior
+Logical operations treat `null` values as "unknown" for SQL compatible
behavior. _All boolean output functions_ will output `LONG` typed boolean
values of `1` for `true` and `0` for `false`.
Review Comment:
```suggestion
Logical operations treat `null` values as "unknown" for SQL compatible
behavior. _All boolean output functions_ output `LONG` typed boolean values of
`1` for `true` and `0` for `false`.
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache
