[GitHub] [incubator-echarts] pissang commented on issue #11324: Add log axis for radar charts

pissang commented on issue #11324: Add log axis for radar charts URL: https://github.com/apache/incubator-echarts/pull/11324#issuecomment-539708434 Hi @zifix . Sorry for the late reply. I was on a vacation. I think what you explained is reasonable. Thanks a lot!

[GitHub] [incubator-echarts] pissang commented on issue #11324: Add log axis for radar charts

pissang commented on issue #11324: Add log axis for radar charts URL: https://github.com/apache/incubator-echarts/pull/11324#issuecomment-536295635 Great! There is one last thing I think needs to be changed. The `axisType` is better to be renamed to `type` to be same with other axis

[GitHub] [incubator-echarts] pissang commented on issue #11324: Add log axis for radar charts

pissang commented on issue #11324: Add log axis for radar charts URL: https://github.com/apache/incubator-echarts/pull/11324#issuecomment-535756485 Hi @zifix I meant not to commit these two distribution files. Not delete them.

[GitHub] [incubator-echarts] pissang commented on issue #11324: Add log axis for radar charts

pissang commented on issue #11324: Add log axis for radar charts URL: https://github.com/apache/incubator-echarts/pull/11324#issuecomment-535556006 Thanks. I've commented on the code. And please remove the distribution file. It will block us to merge your PR.