This is an automated email from the ASF dual-hosted git repository. deqingli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/master by this push: new bc492ba modify development environment judgement in the sankeylayout.js when calculate the x position of the node bc492ba is described below commit bc492ba8847b90778a982b5bb4ba2b9d0371f428 Author: deqingli <annong...@gmail.com> AuthorDate: Wed Apr 11 15:38:58 2018 +0800 modify development environment judgement in the sankeylayout.js when calculate the x position of the node --- src/chart/sankey/sankeyLayout.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/chart/sankey/sankeyLayout.js b/src/chart/sankey/sankeyLayout.js index a71000b..a280414 100644 --- a/src/chart/sankey/sankeyLayout.js +++ b/src/chart/sankey/sankeyLayout.js @@ -130,11 +130,13 @@ function computeNodeBreadths(nodes, edges, nodeWidth, width) { } for (var i = 0; i < remainEdges.length; i++) { - if (remainEdges[i] === 1 && __DEV__) { - throw new Error('Sankey is a DAG, the original data has cycle!'); - } + if (__DEV__) { + if (remainEdges[i] === 1) { + throw new Error('Sankey is a DAG, the original data has cycle!'); + } + } } - + moveSinksRight(nodes, x); kx = (width - nodeWidth) / (x - 1); -- To stop receiving notification emails like this one, please contact deqin...@apache.org. --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org