vorburger merged pull request #1342:
URL: https://github.com/apache/fineract/pull/1342
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 961435e Update dependency
vorburger commented on pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#issuecomment-696892087
@rrpawar96 is this still a work in progress, or something that you would
like to be reviewed and merged when OK? If so, then click the Ready for Review
button above, to
vorburger commented on pull request #1320:
URL: https://github.com/apache/fineract/pull/1320#issuecomment-696880382
Self merged documentation only PR after (almost) 2 weeks of no reaction from
any other committer.
This is
vorburger merged pull request #1320:
URL: https://github.com/apache/fineract/pull/1320
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new f73f5ef Change OAuth doc in apiLive.htm
vorburger commented on pull request #1303:
URL: https://github.com/apache/fineract/pull/1303#issuecomment-696888447
This appears to be the back-port of #1297 to 1.4.0 for FINERACT-1136 .. but
1.4.0 has meanwhile sailed without this. @fynmanoj @vidakovic do you want to
just close this PR,
vorburger commented on pull request #1303:
URL: https://github.com/apache/fineract/pull/1303#issuecomment-696890882
@avikganguly01 do you know more about this?
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new c269843 Update dependency
vorburger merged pull request #1341:
URL: https://github.com/apache/fineract/pull/1341
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
renovate-bot closed pull request #1343:
URL: https://github.com/apache/fineract/pull/1343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vorburger commented on pull request #1301:
URL: https://github.com/apache/fineract/pull/1301#issuecomment-696890545
@fynmanoj what is this PR for? I'm confused about how this one relates to
#1297 and #1303 re. FINERACT-1120 and FINERACT-1136 .. or did you mean to but
just forgot to
vorburger commented on pull request #1302:
URL: https://github.com/apache/fineract/pull/1302#issuecomment-696890781
@avikganguly01 do you know more about this?
This is an automated message from the Apache Git Service.
To
vorburger commented on pull request #1301:
URL: https://github.com/apache/fineract/pull/1301#issuecomment-696890744
@avikganguly01 do you know more about this?
This is an automated message from the Apache Git Service.
To
vorburger commented on pull request #1302:
URL: https://github.com/apache/fineract/pull/1302#issuecomment-696890416
@fynmanoj what is this PR for? I'm confused about how this one relates to
#1297 and #1303 re. FINERACT-1120 and FINERACT-1136 .. or did you mean to but
just forgot to
renovate-bot opened a new pull request #1343:
URL: https://github.com/apache/fineract/pull/1343
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [org.mock-server:mockserver-junit-jupiter](http://www.mock-server.com) |
patch | `5.11.0` ->
vorburger commented on a change in pull request #1184:
URL: https://github.com/apache/fineract/pull/1184#discussion_r492927273
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountInterestRateChartReadPlatformServiceImpl.java
vorburger commented on pull request #1179:
URL: https://github.com/apache/fineract/pull/1179#issuecomment-696893220
@ptuomola did you still want to review this PR one of these days?
This is an automated message from the
vorburger commented on pull request #1343:
URL: https://github.com/apache/fineract/pull/1343#issuecomment-696918717
#1341 dupe
This is an automated message from the Apache Git Service.
To respond to the message, please log
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492522178
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/domain/CreditBureauToken.java
##
@@ -0,0 +1,121 @@
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492522601
##
File path: fineract-provider/config/swagger/fineract-input.yaml
##
@@ -0,0 +1,37 @@
+openapi: 3.0.3
Review comment:
No, So it has been
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492522694
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReportsReadPlatformServiceImpl.java
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492518373
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReportsReadPlatformServiceImpl.java
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492518909
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReportsReadPlatformServiceImpl.java
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492518552
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReportsReadPlatformServiceImpl.java
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492519326
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReportsReadPlatformServiceImpl.java
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492519683
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReportsReadPlatformServiceImpl.java
renovate-bot opened a new pull request #1342:
URL: https://github.com/apache/fineract/pull/1342
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [org.flywaydb:flyway-core](org/flywaydb/flyway-core) | patch | `6.5.6` ->
`6.5.7` |
---
vorburger commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r492973111
##
File path:
fineract-provider/src/main/java/org/apache/fineract/useradministration/api/RolesApiResourceSwagger.java
##
@@ -24,7 +24,7 @@
/**
*
thesmallstar commented on pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#issuecomment-696935962
@SubhamPramanik thank you for the PR, I see a checkstyle error in your
code, that means address_line_1 that you made does not match the required regex
it should.
SubhamPramanik commented on a change in pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#discussion_r493073446
##
File path:
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##
@@ -437,6 +550,19 @@ private
vorburger commented on pull request #1344:
URL: https://github.com/apache/fineract/pull/1344#issuecomment-696941435
> I got this issue in the email thread
Which email thread? :smile:
> no jira Ticket:
It would be great to create a JIRA issue, describing the problem,
SubhamPramanik commented on a change in pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#discussion_r493073780
##
File path:
fineract-provider/src/main/java/org/apache/fineract/interoperation/api/InteropApiResource.java
##
@@ -373,4 +374,29 @@ public
vorburger commented on pull request #1251:
URL: https://github.com/apache/fineract/pull/1251#issuecomment-696929477
@thesmallstar hope your exams went well! Whenever you have time to pick this
up, we appreciate your contributions, very much!
thesmallstar opened a new pull request #1344:
URL: https://github.com/apache/fineract/pull/1344
I got this issue in the email thread, no jira Ticket:
The report
thesmallstar commented on pull request #1344:
URL: https://github.com/apache/fineract/pull/1344#issuecomment-696944033
My bad :P
Let me quickly make a jira ticket for this explaining the entire issue.
This is
thesmallstar commented on pull request #1251:
URL: https://github.com/apache/fineract/pull/1251#issuecomment-696933182
@vorburger yes already working on it!
This is an automated message from the Apache Git Service.
To
thesmallstar commented on pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#issuecomment-696944678
Thanks for the review, Let us not merge this yet, I will complete the
remaining files :)
I agree It wont take much effort, and it makes more sense to get this
thesmallstar commented on pull request #1344:
URL: https://github.com/apache/fineract/pull/1344#issuecomment-696944880
+1 for the integration test as well.
This is an automated message from the Apache Git Service.
To
vorburger commented on a change in pull request #1184:
URL: https://github.com/apache/fineract/pull/1184#discussion_r492927273
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountInterestRateChartReadPlatformServiceImpl.java
ptuomola merged pull request #1340:
URL: https://github.com/apache/fineract/pull/1340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger commented on pull request #1344:
URL: https://github.com/apache/fineract/pull/1344#issuecomment-696941435
> I got this issue in the email thread
Which email thread? :smile:
> no jira Ticket:
It would be great to create a JIRA issue, describing the problem,
thesmallstar commented on pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#issuecomment-696944678
Thanks for the review, Let us not merge this yet, I will complete the
remaining files :)
I agree It wont take much effort, and it makes more sense to get this
github-actions[bot] commented on pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#issuecomment-696453111
This pull request seems to be stale. Are you still planning to work on it?
We will automatically close it in 30 days.
vorburger commented on pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#issuecomment-696892087
@rrpawar96 is this still a work in progress, or something that you would
like to be reviewed and merged when OK? If so, then click the Ready for Review
button above, to
renovate-bot closed pull request #1343:
URL: https://github.com/apache/fineract/pull/1343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vorburger commented on pull request #1301:
URL: https://github.com/apache/fineract/pull/1301#issuecomment-696890545
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
thesmallstar commented on pull request #1344:
URL: https://github.com/apache/fineract/pull/1344#issuecomment-696944033
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
percyashu commented on a change in pull request #1184:
URL: https://github.com/apache/fineract/pull/1184#discussion_r493177869
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountInterestRateChartReadPlatformServiceImpl.java
vorburger commented on pull request #1302:
URL: https://github.com/apache/fineract/pull/1302#issuecomment-696890416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rrpawar96 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r492518373
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditBureauReportsReadPlatformServiceImpl.java
vorburger commented on pull request #1303:
URL: https://github.com/apache/fineract/pull/1303#issuecomment-696888447
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vorburger merged pull request #1341:
URL: https://github.com/apache/fineract/pull/1341
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
thesmallstar commented on pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#issuecomment-696935962
@SubhamPramanik thank you for the PR, I see a checkstyle error in your
code, that means address_line_1 that you made does not match the required regex
it should.
vorburger merged pull request #1342:
URL: https://github.com/apache/fineract/pull/1342
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SubhamPramanik commented on a change in pull request #1330:
URL: https://github.com/apache/fineract/pull/1330#discussion_r493073446
##
File path:
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##
@@ -437,6 +550,19 @@ private
vorburger commented on pull request #1179:
URL: https://github.com/apache/fineract/pull/1179#issuecomment-696893220
@ptuomola did you still want to review this PR one of these days?
This is an automated message from the
thesmallstar commented on pull request #1251:
URL: https://github.com/apache/fineract/pull/1251#issuecomment-696933182
@vorburger yes already working on it!
This is an automated message from the Apache Git Service.
To
xurror merged pull request #16:
URL: https://github.com/apache/fineract-cn-payroll/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vorburger commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r492973111
##
File path:
fineract-provider/src/main/java/org/apache/fineract/useradministration/api/RolesApiResourceSwagger.java
##
@@ -24,7 +24,7 @@
/**
*
xurror merged pull request #15:
URL: https://github.com/apache/fineract-cn-payroll/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vorburger commented on pull request #1343:
URL: https://github.com/apache/fineract/pull/1343#issuecomment-696918717
#1341 dupe
This is an automated message from the Apache Git Service.
To respond to the message, please log
percyashu commented on a change in pull request #1184:
URL: https://github.com/apache/fineract/pull/1184#discussion_r493177869
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountInterestRateChartReadPlatformServiceImpl.java
vorburger merged pull request #1320:
URL: https://github.com/apache/fineract/pull/1320
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger commented on pull request #1320:
URL: https://github.com/apache/fineract/pull/1320#issuecomment-696880382
Self merged documentation only PR after (almost) 2 weeks of no reaction from
any other committer.
This is
vorburger commented on pull request #1251:
URL: https://github.com/apache/fineract/pull/1251#issuecomment-696929477
@thesmallstar hope your exams went well! Whenever you have time to pick this
up, we appreciate your contributions, very much!
66 matches
Mail list logo
