[GitHub] [fineract] Charulathakarthikeyan commented on pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

[GitBox]

Charulathakarthikeyan commented on pull request #1113:
URL: https://github.com/apache/fineract/pull/1113#issuecomment-697192707


   I recommitted this code with new id contac...@habile.in to avoid this
   issue. And also I made PR using that id .
   
   On Sat, Sep 19, 2020 at 12:32 PM Michael Vorburger ⛑️ <
   notificati...@github.com> wrote:
   
   > @Charulathakarthikeyan  are you
   > still interested in getting this merged? You have to git rebase it, resolve
   > merge conflicts, and make sure that it passes the build on Travis CI. We
   > won't be able to do this for you, so you have to follow up on this if you
   > want us to review and merge. The pill request will automatically get closed
   > if you continue to ignore it.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   
   
   -- 
   *Regards ,*
   *Charulatha Karthikeyan *
   *Software Developer  |* Habile technologies
   www.habiletechnologies.com | (m) : +918939798772
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] Charulathakarthikeyan commented on pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

[GitBox]

Charulathakarthikeyan commented on pull request #1113:
URL: https://github.com/apache/fineract/pull/1113#issuecomment-675314439


   Hi,
   I solved the conflict , occurred in one API which is
   "ProvisioningEntriesApiResource" on  Jul 15, 2020 and made my commit on
   that day .
   
   On Thu, Aug 13, 2020 at 10:59 PM edcable  wrote:
   
   > @Charulathakarthikeyan  Have
   > you been able to address the merge conflicts? I sent an email to your
   > colleagues as well.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   
   
   -- 
   *Regards ,*
   *Charulatha Karthikeyan *
   *Software Developer  |* Habile technologies
   www.habiletechnologies.com | (m) : +918939798772
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] Charulathakarthikeyan commented on pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

[GitBox]

Charulathakarthikeyan commented on pull request #1113:
URL: https://github.com/apache/fineract/pull/1113#issuecomment-658039571


   okay ,i'll recommit it .
   
   On Tue, Jul 14, 2020 at 3:32 AM Michael Vorburger ⛑️ <
   notificati...@github.com> wrote:
   
   > @Charulathakarthikeyan  we
   > can't skip out commits in your PR for you.. You have to do this, if you
   > would like your contribution to get code reviewed and merged.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   
   
   -- 
   *Regards ,*
   *Charulatha Karthikeyan *
   *Software Developer  |* Habile technologies
   www.habiletechnologies.com | (m) : +918939798772
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] Charulathakarthikeyan commented on pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

[GitBox]

Charulathakarthikeyan commented on pull request #1113:
URL: https://github.com/apache/fineract/pull/1113#issuecomment-654035748


   Hi
Yes., that imports belongs to another commit , can you please skip out
   those imports .
   
   On Sat, Jul 4, 2020, 7:19 PM Awasum Yannick 
   wrote:
   
   > *@awasum* commented on this pull request.
   > --
   >
   > In
   > 
fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/api/ProvisioningEntriesApiResource.java
   > :
   >
   > > @@ -18,15 +18,15 @@
   >   */
   >  package org.apache.fineract.accounting.provisioning.api;
   >
   > -import io.swagger.annotations.Api;
   > -import io.swagger.annotations.ApiImplicitParam;
   > -import io.swagger.annotations.ApiImplicitParams;
   > -import io.swagger.annotations.ApiOperation;
   > -import io.swagger.annotations.ApiParam;
   > -import io.swagger.annotations.ApiResponse;
   > -import io.swagger.annotations.ApiResponses;
   > -import io.swagger.annotations.SwaggerDefinition;
   > -import io.swagger.annotations.Tag;
   > +import io.swagger.v3.oas.annotations.Operation;
   > +import io.swagger.v3.oas.annotations.Parameter;
   > +import io.swagger.v3.oas.annotations.media.ArraySchema;
   > +import io.swagger.v3.oas.annotations.media.Content;
   >
   > Are we sure all of these changes are in this PR because of the this
   > feature or it was added by mistake from another commit?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org