[GitHub] [fineract] awasum commented on a change in pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

[GitBox]

awasum commented on a change in pull request #1113:
URL: https://github.com/apache/fineract/pull/1113#discussion_r449774780



##
File path: 
fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/api/ProvisioningEntriesApiResource.java
##
@@ -18,15 +18,15 @@
  */
 package org.apache.fineract.accounting.provisioning.api;
 
-import io.swagger.annotations.Api;
-import io.swagger.annotations.ApiImplicitParam;
-import io.swagger.annotations.ApiImplicitParams;
-import io.swagger.annotations.ApiOperation;
-import io.swagger.annotations.ApiParam;
-import io.swagger.annotations.ApiResponse;
-import io.swagger.annotations.ApiResponses;
-import io.swagger.annotations.SwaggerDefinition;
-import io.swagger.annotations.Tag;
+import io.swagger.v3.oas.annotations.Operation;
+import io.swagger.v3.oas.annotations.Parameter;
+import io.swagger.v3.oas.annotations.media.ArraySchema;
+import io.swagger.v3.oas.annotations.media.Content;

Review comment:
   Are we sure all of these changes are in this PR because of the this 
feature or it was added by mistake from another commit?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [fineract] awasum commented on a change in pull request #1113: Need an option to filter provisioning entries by date, Fineract-462

[GitBox]

awasum commented on a change in pull request #1113:
URL: https://github.com/apache/fineract/pull/1113#discussion_r449774704



##
File path: 
fineract-provider/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java
##
@@ -349,5 +349,37 @@ public String schema() {
 return 
this.loanProductProvisioningEntryDataPaginationHelper.fetchPage(this.jdbcTemplate,
 sqlCountRows, sqlBuilder.toString(),
 whereClauseItemsitems, mapper);
 }
+@Override
+   public Page 
retrieveAllProvisioningEntriesByDate(Integer offset, Integer limit,
+   String filterDate) {
+   Date filterdate = null;
+   if (filterDate != null) {
+   try {
+   SimpleDateFormat format = new 
SimpleDateFormat("dd  ", Locale.ENGLISH);

Review comment:
   Using Locale.ENGLISH? What if the user sent a different language? I 
think there is a locale param been sent on almost all request in 
Fineract..Maybe use that? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org