[GitHub] [fineract] ptuomola commented on pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)

2020-08-19 Thread GitBox
ptuomola commented on pull request #1242: URL: https://github.com/apache/fineract/pull/1242#issuecomment-677025303 @thesmallstar Thanks for your reply! I think it's all just a matter of preference and what you're used to seeing :-) But I think consistency is more important than

[GitHub] [fineract] ptuomola commented on pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)

2020-08-12 Thread GitBox
ptuomola commented on pull request #1242: URL: https://github.com/apache/fineract/pull/1242#issuecomment-672779492 Looking at this, the changes seem to fall into a couple of different categories: - ones where it makes sense - e.g. is_active to isActive - ones where it in my