[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-10-26 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-716391290 Closing this one to keep the PRs list clean, will reopen with the update soon. Cannot find any free time in the last few days.

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-10-11 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-706775829 Thanks for the review working on the changes. This is an automated message from the Apache Git Service.

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-10-09 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-706177011 @vorburger sorry for the delay, I should get this done by coming Monday. I will have ended all my submissions by Sunday :) -Thanks Manthan

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-10-09 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-706177011 @vorburger sorry for the delay, I should get this done by coming Monday. I will have ended all my submissions by Sunday :) -Thanks Manthan

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-29 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-701044752 Will be looking into this, and other issues this week end :) This is an automated message from the

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-22 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-696944678 Thanks for the review, Let us not merge this yet, I will complete the remaining files :) I agree It wont take much effort, and it makes more sense to get this

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-22 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-696944678 Thanks for the review, Let us not merge this yet, I will complete the remaining files :) I agree It wont take much effort, and it makes more sense to get this

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691527360 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691527360 @vorburger sorry for the delay, I am in between of my college mid-semester exams, I will continue working as soon as I am done with it(hopefully no sooner than 19th

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-691527360 @vorburger sorry for the delay, I am in between of my college mid-semester exams, I will continue working as soon as I am done with it(hopefully no sooner than 19th

[GitHub] [fineract] thesmallstar commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-08-27 Thread GitBox
thesmallstar commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-682100056 @vorburger @ptuomola @xurror @awasum can you review this one? This is an automated message from the