[GitHub] [fineract] thesmallstar commented on pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle

2020-05-20 Thread GitBox
thesmallstar commented on pull request #906: URL: https://github.com/apache/fineract/pull/906#issuecomment-631446842 Thank for the quick response :D, on it :) This is an automated message from the Apache Git Service. To

[GitHub] [fineract] thesmallstar commented on pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle

2020-05-20 Thread GitBox
thesmallstar commented on pull request #906: URL: https://github.com/apache/fineract/pull/906#issuecomment-631440458 @vorburger Just a to make sure, LOG.error("Runtime exception occurred in importEntity function",ex); Is this the expected explanation? If not do I need to dive

[GitHub] [fineract] thesmallstar commented on pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle

2020-05-19 Thread GitBox
thesmallstar commented on pull request #906: URL: https://github.com/apache/fineract/pull/906#issuecomment-631030301 @vorburger whoops, I missed that from the last message, Updating it. This is an automated message from the

[GitHub] [fineract] thesmallstar commented on pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle

2020-05-19 Thread GitBox
thesmallstar commented on pull request #906: URL: https://github.com/apache/fineract/pull/906#issuecomment-631027214 The build has passed on Travis I am not sure why is this still yellow? https://travis-ci.org/github/apache/fineract/builds/688892634

[GitHub] [fineract] thesmallstar commented on pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle

2020-05-19 Thread GitBox
thesmallstar commented on pull request #906: URL: https://github.com/apache/fineract/pull/906#issuecomment-630927838 @vorburger This build should pass, in the file MultiException the printStacktrace method was overridden and a custom print-stream/writer was used for specific logging

[GitHub] [fineract] thesmallstar commented on pull request #906: [WIP] FINERACT-942 Remove use of printStackTrace and added checkstyle

2020-05-18 Thread GitBox
thesmallstar commented on pull request #906: URL: https://github.com/apache/fineract/pull/906#issuecomment-630504716 @vorburger there are many instances where printStacktrace is used in a non-test file, for that case should I comment or remove the line only? Or Am I expected to follow the