[GitHub] [fineract] vorburger commented on pull request #926: FINERACT-977

2020-06-01 Thread GitBox
vorburger commented on pull request #926: URL: https://github.com/apache/fineract/pull/926#issuecomment-637068084 #960 @maektwain FYI you don't actually have to open a new PR, you can just "force push" (next time) This is an

[GitHub] [fineract] vorburger commented on pull request #926: FINERACT-977

2020-06-01 Thread GitBox
vorburger commented on pull request #926: URL: https://github.com/apache/fineract/pull/926#issuecomment-636826609 @maektwain LGTM but as previously requested, all commits must be squashed into 1 please. This is an automated

[GitHub] [fineract] vorburger commented on pull request #926: FINERACT-977

2020-05-31 Thread GitBox
vorburger commented on pull request #926: URL: https://github.com/apache/fineract/pull/926#issuecomment-636496559 @maektwain respectfully pinging you re. this, after 1 week. Are you planning to wrap this up? This is an autom

[GitHub] [fineract] vorburger commented on pull request #926: FINERACT-977

2020-05-22 Thread GitBox
vorburger commented on pull request #926: URL: https://github.com/apache/fineract/pull/926#issuecomment-632895537 *@maektwain* Java expressions evaluation respects parentheses (and && || Precedenc), so it first checks "fixedEmiAmount != null" and if that is false, it does not evaluate

[GitHub] [fineract] vorburger commented on pull request #926: FINERACT-977

2020-05-22 Thread GitBox
vorburger commented on pull request #926: URL: https://github.com/apache/fineract/pull/926#issuecomment-632875104 @nnatarajan following along the code review conversation in this Pull Request could interest you. This is an a