[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-08-02 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux
URL: 
https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409910802
 
 
   Ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-08-01 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux
URL: 
https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409693391
 
 
   Did you check all the previous comments on the PR thread? Run npm audit and 
see if you dont get vulnerability issues. What version of NodeJS, Angular CLI 
and NPM are you using? Make sure to reaad the complete comment log on Github 
not just on Email. @pembemiriam 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-07-31 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux
URL: 
https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-409467380
 
 
   @pembemiriam Have u fixed the vulnerabilities in this latest commit?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-07-28 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux
URL: 
https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-408590498
 
 
   Can you address these @pembemiriam ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-07-28 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux
URL: 
https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-408590461
 
 
   Upon running npm audit, I get the following:
   

   
  === npm audit security report === 
   

   
   # Run  npm install --save-dev karma@2.0.5  to resolve 12 vulnerabilities
   SEMVER WARNING: Recommended action is a potentially breaking change
   
┌───┬──┐
   │ Low   │ Regular Expression Denial of Service   
  │
   
├───┼──┤
   │ Package   │ debug  
  │
   
├───┼──┤
   │ Dependency of │ karma [dev]
  │
   
├───┼──┤
   │ Path  │ karma > socket.io > debug  
  │
   
├───┼──┤
   │ More info │ https://nodesecurity.io/advisories/534 
  │
   
└───┴──┘
   
   
   
┌───┬──┐
   │ Low   │ Regular Expression Denial of Service   
  │
   
├───┼──┤
   │ Package   │ debug  
  │
   
├───┼──┤
   │ Dependency of │ karma [dev]
  │
   
├───┼──┤
   │ Path  │ karma > socket.io > engine.io > debug  
  │
   
├───┼──┤
   │ More info │ https://nodesecurity.io/advisories/534 
  │
   
└───┴──┘
   
   
   
┌───┬──┐
   │ Low   │ Regular Expression Denial of Service   
  │
   
├───┼──┤
   │ Package   │ debug  
  │
   
├───┼──┤
   │ Dependency of │ karma [dev]
  │
   
├───┼──┤
   │ Path  │ karma > socket.io > socket.io-adapter > debug  
  │
   
├───┼──┤
   │ More info │ https://nodesecurity.io/advisories/534 
  │
   
└───┴──┘
   
   
   
┌───┬──┐
   │ Low   │ Regular Expression Denial of Service   
  │
   
├───┼──┤
   │ Package   │ debug  
  │
   
├───┼──┤
   │ Dependency of │ karma [dev]
  │
   
├───┼──┤
   │ Path  │ karma > socket.io > socket.io-client > debug   
  │
   
├───┼──┤
   │ More info │ https://nodesecurity.io/advisories/534 
  │
   
└───┴──┘
   
   
   
┌───┬──┐
   │ Low   │ Regular Expression Denial of Service   
  │
   
├───┼──┤
   │ Package   │ debug  
  │
   
├───┼──┤
   │ Dependency of │ karma [dev]
  │
   
├───┼──┤
   │ Path  │ k

[GitHub] awasum commented on issue #2: fixed issues due to angular redux

2018-07-28 Thread GitBox
awasum commented on issue #2: fixed issues due to angular redux
URL: 
https://github.com/apache/fineract-cn-group-finance/pull/2#issuecomment-408590377
 
 
   Hey @pembemiriam , Running npm i, shows some vulnerabilities:
   
   
![image](https://user-images.githubusercontent.com/15528032/43354376-6c5ab370-9243-11e8-8543-a1a9765c3cca.png)
   
   
   added 1252 packages from 1471 contributors and audited 6893 packages in 
98.587s
   found 28 vulnerabilities (10 low, 12 moderate, 6 high)
 run `npm audit fix` to fix them, or `npm audit` for details
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services