[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015724 What is the purpose of the Event domain object?

[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015289 You need to run your tests. SMSConfigurationTest doesn't compile. TestEmailService doesn't pass.

[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes

myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Hey Ebenezeer this is a long list, so I'm going to break it up into one comment per item. If we need