[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes
myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015724 What is the purpose of the Event domain object? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes
myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415015289 You need to run your tests. SMSConfigurationTest doesn't compile. TestEmailService doesn't pass. TestSMSService doesn't pass. All tests should compile and run. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] myrle-krantz commented on issue #5: Unit and component Tests, Rest and command updates and Bug Fixes
myrle-krantz commented on issue #5: Unit and component Tests,Rest and command updates and Bug Fixes URL: https://github.com/apache/fineract-cn-notifications/pull/5#issuecomment-415014208 Hey Ebenezeer this is a long list, so I'm going to break it up into one comment per item. If we need to discuss any of the items that will be easier. First item: You need to run the rat tests. At least three files are missing their headers, and there may be other problems. To do this run: ./gradlew rat This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
