adamsaghy merged PR #3859:
URL: https://github.com/apache/fineract/pull/3859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
alberto-art3ch commented on code in PR #3859:
URL: https://github.com/apache/fineract/pull/3859#discussion_r1568886897
##
fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java:
##
@@ -85,7 +87,13 @@ public Loan
adamsaghy commented on code in PR #3859:
URL: https://github.com/apache/fineract/pull/3859#discussion_r1560640556
##
fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java:
##
@@ -85,7 +87,13 @@ public Loan execute(Loan
adamsaghy commented on PR #3859:
URL: https://github.com/apache/fineract/pull/3859#issuecomment-2049194852
@alberto-art3ch I dont see any testing!
Please consider writing unit tests to cover this new behaviour!
The test should check whether properly handled the CANCELLATION if there is
adamsaghy commented on code in PR #3859:
URL: https://github.com/apache/fineract/pull/3859#discussion_r1560640556
##
fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java:
##
@@ -85,7 +87,13 @@ public Loan execute(Loan