This is an automated email from the ASF dual-hosted git repository. trohrmann pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push: new fee61e1 [FLINK-14168][runtime] Remove unused BootstrapTools#generateTaskManagerConfiguration fee61e1 is described below commit fee61e1c4ff08ff956735247c8fbd08239c9487d Author: zhuzhu.zz <zhuzhu...@alibaba-inc.com> AuthorDate: Tue Sep 24 16:30:29 2019 +0800 [FLINK-14168][runtime] Remove unused BootstrapTools#generateTaskManagerConfiguration This closes #9755. --- .../runtime/clusterframework/BootstrapTools.java | 37 ---------------------- 1 file changed, 37 deletions(-) diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java b/flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java index da22671..75de581 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java @@ -23,8 +23,6 @@ import org.apache.flink.configuration.ConfigConstants; import org.apache.flink.configuration.ConfigOption; import org.apache.flink.configuration.Configuration; import org.apache.flink.configuration.CoreOptions; -import org.apache.flink.configuration.JobManagerOptions; -import org.apache.flink.configuration.TaskManagerOptions; import org.apache.flink.runtime.akka.AkkaUtils; import org.apache.flink.util.NetUtils; @@ -53,7 +51,6 @@ import java.util.Map; import scala.Some; import scala.Tuple2; -import scala.concurrent.duration.FiniteDuration; import static org.apache.flink.configuration.ConfigOptions.key; @@ -269,40 +266,6 @@ public class BootstrapTools { } /** - * Generate a task manager configuration. - * @param baseConfig Config to start from. - * @param jobManagerHostname Job manager host name. - * @param jobManagerPort Port of the job manager. - * @param numSlots Number of slots to configure. - * @param registrationTimeout Timeout for registration - * @return TaskManager configuration - */ - public static Configuration generateTaskManagerConfiguration( - Configuration baseConfig, - String jobManagerHostname, - int jobManagerPort, - int numSlots, - FiniteDuration registrationTimeout) { - - Configuration cfg = cloneConfiguration(baseConfig); - - if (jobManagerHostname != null && !jobManagerHostname.isEmpty()) { - cfg.setString(JobManagerOptions.ADDRESS, jobManagerHostname); - } - - if (jobManagerPort > 0) { - cfg.setInteger(JobManagerOptions.PORT, jobManagerPort); - } - - cfg.setString(TaskManagerOptions.REGISTRATION_TIMEOUT, registrationTimeout.toString()); - if (numSlots != -1){ - cfg.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, numSlots); - } - - return cfg; - } - - /** * Writes a Flink YAML config file from a Flink Configuration object. * @param cfg The Flink config * @param file The File to write to