Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-19 Thread via GitHub


taiyang-li commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3552115899

   > @rui-mo @zhztheplayer Could you please help review this? @taiyang-li 
@lgbo-ustc @zzcclp could you confirm whether the changes here have any impact 
on the ClickHouse backend?
   
   CH backend changes are ok to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-15 Thread via GitHub


FelixYBW commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3537456245

   We need a through clean up of timestamp and timezone support in Gluten 
sometime later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-15 Thread via GitHub


liujiayi771 commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3537201074

   > Spark3.5 added TIMESTAMP_NTZ data type. @rui-mo does velox support it? 
have we enabled the UT for for?
   
   This PR only modified the Substrait mapping, reserving the corresponding 
mapping type for future support of timestamp_ntz, the UT cannot be emabled yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-15 Thread via GitHub


FelixYBW commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3537115133

   Spark3.5 added TIMESTAMP_NTZ data type. @rui-mo does velox support it? have 
we enabled the UT for for?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-15 Thread via GitHub


FelixYBW merged PR #11074:
URL: https://github.com/apache/incubator-gluten/pull/11074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-13 Thread via GitHub


liujiayi771 commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3530455369

   @rui-mo @zhztheplayer Could you please help review this? @taiyang-li 
@lgbo-ustc @zzcclp could you confirm whether the changes here have any impact 
on the ClickHouse backend?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-13 Thread via GitHub


github-actions[bot] commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3526597241

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-12 Thread via GitHub


github-actions[bot] commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3525692864

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-12 Thread via GitHub


github-actions[bot] commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3525673338

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-12 Thread via GitHub


github-actions[bot] commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3525162197

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-12 Thread via GitHub


github-actions[bot] commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3525125415

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [CORE] Use Substrait timestamp_tz for Spark TimestampType to preserve timezone-aware semantics [incubator-gluten]

2025-11-12 Thread via GitHub


github-actions[bot] commented on PR #11074:
URL: 
https://github.com/apache/incubator-gluten/pull/11074#issuecomment-3524948232

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]