Re: [PR] [GLUTEN-11145][VL] Iceberg supports Spark4.0 [incubator-gluten]

2025-11-24 Thread via GitHub 


jinchengchenghh commented on code in PR #11146:
URL: 
https://github.com/apache/incubator-gluten/pull/11146#discussion_r2555941598


##
backends-velox/src-iceberg-spark40/test/java/org/apache/gluten/IcebergTestShims.java:
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gluten;
+
+import org.apache.spark.rdd.RDD;
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
+import org.apache.spark.sql.SparkSession;
+import org.apache.spark.sql.catalyst.InternalRow;
+import org.apache.spark.sql.types.StructType;
+
+public class IcebergTestShims {
+
+  public static Dataset internalCreateDataFrame(
+  SparkSession spark, RDD rdd, StructType schema, boolean 
isStreaming) {
+return ((org.apache.spark.sql.classic.SparkSession) spark)

Review Comment:
   Need to cast to org.apache.spark.sql.classic.SparkSession



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-11145][VL] Iceberg supports Spark4.0 [incubator-gluten]

2025-11-24 Thread via GitHub 


jinchengchenghh commented on code in PR #11146:
URL: 
https://github.com/apache/incubator-gluten/pull/11146#discussion_r2555937599


##
backends-velox/src-iceberg10/test/java/org/apache/iceberg/spark/SparkTestBase.java:
##
@@ -55,7 +55,7 @@
 import java.util.concurrent.atomic.AtomicReference;
 
 import scala.Option;
-import scala.collection.JavaConversions;
+import scala.jdk.CollectionConverters;

Review Comment:
   Because scala 2.12 and 2.13 compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-11145][VL] Iceberg supports Spark4.0 [incubator-gluten]

2025-11-24 Thread via GitHub 


github-actions[bot] commented on PR #11146:
URL: 
https://github.com/apache/incubator-gluten/pull/11146#issuecomment-3570315047

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-11145][VL] Iceberg supports Spark4.0 [incubator-gluten]

2025-11-21 Thread via GitHub 


jinchengchenghh commented on code in PR #11146:
URL: 
https://github.com/apache/incubator-gluten/pull/11146#discussion_r2550105329


##
.github/workflows/velox_backend_x86.yml:
##
@@ -1344,6 +1344,7 @@ jobs:
   export PATH=$JAVA_HOME/bin:$PATH
   java -version
   $MVN_CMD clean test -Pspark-4.0 -Pscala-2.13 -Pjava-17 
-Pbackends-velox \
+  -Piceberg

Review Comment:
   ok, Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [GLUTEN-11145][VL] Iceberg supports Spark4.0 [incubator-gluten]

2025-11-21 Thread via GitHub 


zhouyuan commented on code in PR #11146:
URL: 
https://github.com/apache/incubator-gluten/pull/11146#discussion_r2550101823


##
.github/workflows/velox_backend_x86.yml:
##
@@ -1344,6 +1344,7 @@ jobs:
   export PATH=$JAVA_HOME/bin:$PATH
   java -version
   $MVN_CMD clean test -Pspark-4.0 -Pscala-2.13 -Pjava-17 
-Pbackends-velox \
+  -Piceberg

Review Comment:
   missed ' \'



##
.github/workflows/velox_backend_x86.yml:
##
@@ -1344,6 +1344,7 @@ jobs:
   export PATH=$JAVA_HOME/bin:$PATH
   java -version
   $MVN_CMD clean test -Pspark-4.0 -Pscala-2.13 -Pjava-17 
-Pbackends-velox \
+  -Piceberg

Review Comment:
   missed `' \'`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]