Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_11_24) [incubator-gluten]

2025-11-25 Thread via GitHub


zhouyuan commented on code in PR #11168:
URL: 
https://github.com/apache/incubator-gluten/pull/11168#discussion_r2559846579


##
.github/workflows/velox_backend_x86.yml:
##
@@ -610,7 +610,7 @@ jobs:
 
--extra-conf=spark.celeborn.client.eagerlyCreateInputStream.threads=4 \
 --benchmark-type=ds --error-on-memleak \
 --off-heap-size=16g -s=1.0 --threads=16 --iterations=1
-  if [ "${{ matrix.writer }}" = "sort" ]; then
+  if false; then # TODO: fix celeborn rss sort issue
 GLUTEN_IT_JVM_ARGS=-Xmx16G sbin/gluten-it.sh queries-compare \

Review Comment:
   cc @marin-ma 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_11_24) [incubator-gluten]

2025-11-25 Thread via GitHub


zhouyuan commented on code in PR #11168:
URL: 
https://github.com/apache/incubator-gluten/pull/11168#discussion_r2559217405


##
.github/workflows/velox_backend_x86.yml:
##
@@ -610,7 +610,7 @@ jobs:
 
--extra-conf=spark.celeborn.client.eagerlyCreateInputStream.threads=4 \
 --benchmark-type=ds --error-on-memleak \
 --off-heap-size=16g -s=1.0 --threads=16 --iterations=1
-  if [ "${{ matrix.writer }}" = "sort" ]; then
+  if false; then # TODO: fix celeborn rss sort issue
 GLUTEN_IT_JVM_ARGS=-Xmx16G sbin/gluten-it.sh queries-compare \

Review Comment:
   @kerwin-zk ran into similar issue as 
https://github.com/apache/incubator-gluten/pull/11105 
   it seems when running q72 the worker starts to fail, is this also due to the 
disk space issue? 
   
https://github.com/apache/incubator-gluten/actions/runs/19638873977/job/56279716156
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_11_24) [incubator-gluten]

2025-11-25 Thread via GitHub


FelixYBW merged PR #11168:
URL: https://github.com/apache/incubator-gluten/pull/11168


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_11_24) [incubator-gluten]

2025-11-24 Thread via GitHub


FelixYBW commented on PR #11168:
URL: 
https://github.com/apache/incubator-gluten/pull/11168#issuecomment-3573414426

   > # TODO: fix celeborn rss sort issue
   
   @zhouyuan Is there a PR for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_11_24) [incubator-gluten]

2025-11-24 Thread via GitHub


github-actions[bot] commented on PR #11168:
URL: 
https://github.com/apache/incubator-gluten/pull/11168#issuecomment-3573106473

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]