Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3775131295 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3775102907 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3624718982 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3546047600 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
JkSelf commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2536675240
##
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarBuildSideRelation.scala:
##
@@ -133,6 +148,85 @@ case class ColumnarBuildSideRelation(
override def asReadOnlyCopy(): ColumnarBuildSideRelation = this
+ private var hashTableData: Long = 0L
+
+ def buildHashTable(
+ broadCastContext: BroadcastHashJoinContext): (Long,
ColumnarBuildSideRelation) =
+synchronized {
+ if (hashTableData == 0) {
+val runtime = Runtimes.contextInstance(
+ BackendsApiManager.getBackendName,
+ "ColumnarBuildSideRelation#buildHashTable")
+val jniWrapper = ColumnarBatchSerializerJniWrapper.create(runtime)
+val serializeHandle: Long = {
+ val allocator = ArrowBufferAllocators.contextInstance()
+ val cSchema = ArrowSchema.allocateNew(allocator)
+ val arrowSchema = SparkArrowUtil.toArrowSchema(
+SparkShimLoader.getSparkShims.structFromAttributes(output),
+SQLConf.get.sessionLocalTimeZone)
+ ArrowAbiUtil.exportSchema(allocator, arrowSchema, cSchema)
+ val handle = jniWrapper
+.init(cSchema.memoryAddress())
+ cSchema.close()
+ handle
+}
+
+val batchArray = new ArrayBuffer[Long]
+
+var batchId = 0
+while (batchId < batches.size) {
+ batchArray.append(jniWrapper.deserialize(serializeHandle,
batches(batchId)))
+ batchId += 1
+}
+
+logDebug(
+ s"BHJ value size: " +
+s"${broadCastContext.buildHashTableId} = ${batches.length}")
+
+val (keys, newOutput) = if (newBuildKeys.isEmpty) {
+ (
+broadCastContext.buildSideJoinKeys.asJava,
+broadCastContext.buildSideStructure.asJava
+ )
+} else {
+ (
+newBuildKeys.asJava,
+output.asJava
+ )
+}
+
+val joinKey = keys.asScala
+ .map {
+key =>
+ val attr = ConverterUtils.getAttrFromExpr(key)
+ ConverterUtils.genColumnNameWithExprId(attr)
+ }
+ .mkString(",")
+
+// Build the hash table
+hashTableData = HashJoinBuilder
+ .nativeBuild(
+broadCastContext.buildHashTableId,
+batchArray.toArray,
+joinKey,
+broadCastContext.substraitJoinType.ordinal(),
+broadCastContext.hasMixedFiltCondition,
+broadCastContext.isExistenceJoin,
+SubstraitUtil.toNameStruct(newOutput).toByteArray,
+broadCastContext.isNullAwareAntiJoin
+ )
+
+jniWrapper.close(serializeHandle)
+(hashTableData, this)
+ } else {
+(HashJoinBuilder.cloneHashTable(hashTableData), null)
+ }
+}
+
+ def reset(): Unit = synchronized {
+hashTableData = 0
Review Comment:
We will release the real data by calling
https://github.com/apache/incubator-gluten/pull/8931/files#diff-1c998fbcdc31d781f6bbe45f4b6fdd3e29925b6c9187849bb3ab2f7867148199R109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3545811729 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3545706552 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3545451355 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3545360128 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3545342895 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3545140679 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3544832528 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3544773135 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zjuwangg commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2532560012
##
cpp/velox/jni/JniHashTable.h:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include
+#include "memory/ColumnarBatch.h"
+#include "memory/VeloxMemoryManager.h"
+#include "operators/hashjoin/HashTableBuilder.h"
+#include "utils/ObjectStore.h"
+#include "velox/exec/HashTable.h"
+
+namespace gluten {
+
+inline static JavaVM* vm = nullptr;
+
+static std::unique_ptr hashTableObjStore = ObjectStore::create();
Review Comment:
Should hashTableObjStore also be `inline static`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3539656535 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3532827012 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3532629921 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3532431187 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3532264844 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3532225722 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3532215162 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3531431290 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3531195507 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3531144776 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3531095971 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3530936241 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3530767819 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3530532199 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3530500133 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3525722193 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3519709171 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3431390504 > But let's find a way to avoid replacing the file SQLExecution.scala which is a hot path and extremely important for Spark. @JkSelf Just to clarify the concern still exists but it no longer blocks th PR. I believe in the final version the SQL execution code can be handled well for this feature. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
WangGuangxin commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2450194723
##
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarBuildSideRelation.scala:
##
@@ -133,6 +148,85 @@ case class ColumnarBuildSideRelation(
override def asReadOnlyCopy(): ColumnarBuildSideRelation = this
+ private var hashTableData: Long = 0L
+
+ def buildHashTable(
+ broadCastContext: BroadcastHashJoinContext): (Long,
ColumnarBuildSideRelation) =
+synchronized {
+ if (hashTableData == 0) {
+val runtime = Runtimes.contextInstance(
+ BackendsApiManager.getBackendName,
+ "ColumnarBuildSideRelation#buildHashTable")
+val jniWrapper = ColumnarBatchSerializerJniWrapper.create(runtime)
+val serializeHandle: Long = {
+ val allocator = ArrowBufferAllocators.contextInstance()
+ val cSchema = ArrowSchema.allocateNew(allocator)
+ val arrowSchema = SparkArrowUtil.toArrowSchema(
+SparkShimLoader.getSparkShims.structFromAttributes(output),
+SQLConf.get.sessionLocalTimeZone)
+ ArrowAbiUtil.exportSchema(allocator, arrowSchema, cSchema)
+ val handle = jniWrapper
+.init(cSchema.memoryAddress())
+ cSchema.close()
+ handle
+}
+
+val batchArray = new ArrayBuffer[Long]
+
+var batchId = 0
+while (batchId < batches.size) {
+ batchArray.append(jniWrapper.deserialize(serializeHandle,
batches(batchId)))
+ batchId += 1
+}
+
+logDebug(
+ s"BHJ value size: " +
+s"${broadCastContext.buildHashTableId} = ${batches.length}")
+
+val (keys, newOutput) = if (newBuildKeys.isEmpty) {
+ (
+broadCastContext.buildSideJoinKeys.asJava,
+broadCastContext.buildSideStructure.asJava
+ )
+} else {
+ (
+newBuildKeys.asJava,
+output.asJava
+ )
+}
+
+val joinKey = keys.asScala
+ .map {
+key =>
+ val attr = ConverterUtils.getAttrFromExpr(key)
+ ConverterUtils.genColumnNameWithExprId(attr)
+ }
+ .mkString(",")
+
+// Build the hash table
+hashTableData = HashJoinBuilder
+ .nativeBuild(
+broadCastContext.buildHashTableId,
+batchArray.toArray,
+joinKey,
+broadCastContext.substraitJoinType.ordinal(),
+broadCastContext.hasMixedFiltCondition,
+broadCastContext.isExistenceJoin,
+SubstraitUtil.toNameStruct(newOutput).toByteArray,
+broadCastContext.isNullAwareAntiJoin
+ )
+
+jniWrapper.close(serializeHandle)
+(hashTableData, this)
+ } else {
+(HashJoinBuilder.cloneHashTable(hashTableData), null)
+ }
+}
+
+ def reset(): Unit = synchronized {
+hashTableData = 0
Review Comment:
When we invalid a `buildHashTableId`, why we only set `hashTableData` = 0,
but leaving the real data still in `gluten::hashTableObjStore`?
##
backends-velox/src/main/scala/org/apache/gluten/execution/VeloxBroadcastBuildSideCache.scala:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gluten.execution
+
+import org.apache.gluten.backendsapi.velox.VeloxBackendSettings
+import org.apache.gluten.vectorized.HashJoinBuilder
+
+import org.apache.spark.SparkEnv
+import org.apache.spark.broadcast.Broadcast
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.execution.ColumnarBuildSideRelation
+import org.apache.spark.sql.execution.joins.BuildSideRelation
+import org.apache.spark.sql.execution.unsafe.UnsafeColumnarBuildSideRelation
+
+import com.github.benmanes.caffeine.cache.{Cache, Caffeine, RemovalCause,
RemovalListener}
+
+import java.util.concurrent.TimeUnit
+
+case class BroadcastHashTable(pointer: Long, relation: BuildSideRelation)
+
+/**
+ * `VeloxBroadcastBuildSideCache` is used for controlling to build bhj hash
table once.
+ *
+ * The complicated part is due to reuse exchange, where multiple BHJ IDs
cor
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3427218905 > I'll temporarily disable this test and address it in a follow-up PR. Thanks. No problem. I don't have issues with this part. Maybe cc more people to see if they have concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3311015548 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
WangGuangxin commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2340646115
##
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##
@@ -306,6 +308,29 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
rightNode,
getJoinOutputType(leftNode, rightNode, joinType));
+ } else if (
+ sJoin.has_advanced_extension() &&
+ SubstraitParser::configSetInOptimization(sJoin.advanced_extension(),
"isBHJ=")) {
+std::string hashTableId = sJoin.hashtableid();
+void* hashTableAddress = nullptr;
+try {
+ hashTableAddress =
ObjectStore::retrieve(getJoin(hashTableId)).get();
Review Comment:
Can you point out where to assign the hash table to ObjectStore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3310794434 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
JkSelf commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3310747995 > I understand it's a huge effort, appreciate for that @JkSelf. > > But let's find a way to avoid replacing the file `SQLExecution.scala` which is a hot path and extremely important for Spark. > > I expected [the approach](https://github.com/apache/incubator-gluten/pull/8931#discussion_r2287365279) in my comment might work and let me know if having any issue with it. @zhztheplayer You're right, this PR is quite large. The SQLExecution change is only needed to fix GlutenInjectRuntimeFilterSuite. I'll temporarily disable this test and address it in a follow-up PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
weixiuli commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2352092648
##
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##
@@ -249,6 +256,9 @@ class VeloxListenerApi extends ListenerApi with Logging {
private def shutdown(): Unit = {
// TODO shutdown implementation in velox to release resources
+VeloxBroadcastBuildSideCache.cleanAll()
+
+GlutenExecutorEndpoint.executorEndpoint.stop()
}
Review Comment:
The GlutenExecutorEndpoint.executorEndpoint may be null if no executor has
been started or initialized ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3294584657 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
JkSelf commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2348348270
##
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##
@@ -306,6 +308,29 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
rightNode,
getJoinOutputType(leftNode, rightNode, joinType));
+ } else if (
+ sJoin.has_advanced_extension() &&
+ SubstraitParser::configSetInOptimization(sJoin.advanced_extension(),
"isBHJ=")) {
+std::string hashTableId = sJoin.hashtableid();
+void* hashTableAddress = nullptr;
+try {
+ hashTableAddress =
ObjectStore::retrieve(getJoin(hashTableId)).get();
Review Comment:
@WangGuangxin We will store the hash table in the ObjectStore after building
it, as shown
[here](https://github.com/apache/incubator-gluten/pull/8931/files#diff-88393a5ad9ef79692811a9bf475305f4b514c0d3e5610ef96cd29e6b95dea49eR884)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3291129873 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhouyuan commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3273969188 @JkSelf it seems there is a small conflict, could you please do a rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2287365279 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: I meant we are free to pass the Spark context to the listener when it's registered so avoid this replacement. No? @JkSelf > The Spark community is supportive of this fix and is preparing to merge it into the main branch. Yes it's reasonable to move to a vanilla solution but before that let's check whether we have to apply such a hack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2287365279 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: I meant we are free to pass the Spark context to the listener so avoid this replacement. No? @JkSelf > The Spark community is supportive of this fix and is preparing to merge it into the main branch. Yes it's reasonable to move to a vanilla solution but before that let's check whether we have to apply such a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2287365279 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: I meant we are free to pass the Spark context to the listener when it's registered so avoid this replacement. No? @JkSelf > The Spark community is supportive of this fix and is preparing to merge it into the main branch. Yes it's reasonable to move to a vanilla solution but before that let's check whether we have to apply such a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
FelixYBW commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2286887071 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: Since it's an important spark file. Can we comment somehow in the file which lines of code are changes? Or most of the files are changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
FelixYBW commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2286814513 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: Even it's merged, we still need to back port to 4.0, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
JkSelf commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2286825579 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: @FelixYBW Yes. Also need to backport to 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
JkSelf commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2286806999 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: @zhztheplayer @FelixYBW This is indeed a bug affecting Spark versions 3.5 and 4.0. The Spark community is supportive of this fix and is preparing to merge it into the main branch. Once merged, I will backport the fix to Spark 3.5. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2284741993 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: It could be super dangerous to replace this file especially when it's the driver side code. Worth checking whether the Spark context can be stored in the listener so you can access it when needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
FelixYBW commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2282790931 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: Do we still need to hack the file for Spark4.0? If so we may add it starting from 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2281706572 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: @JkSelf Is there a way to do the cancelation in the listener code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
JkSelf commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2281580072 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: @zhztheplayer You can refer https://github.com/apache/spark/pull/52039#issue-3324633743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhztheplayer commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2281569419 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: We may avoid such class overriding for newer Spark versions... Let's summarize what's needed here and see if we can come up with an alternative solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3195522657 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3195510173 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3195494225 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3190309065 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3187401523 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3187215788 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3187026132 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
zhouyuan commented on code in PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2269270517 ## shims/spark35/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution Review Comment: It seems this Spark object is introduced, could you please also make a note what is the required change here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3177810455 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3177732307 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3177672445 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3177640015 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3177498022 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3169653085 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
PHILO-HE commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2999085483 @JkSelf, you can just specify the upstream PR ID to apply the patch. See https://github.com/apache/incubator-gluten/pull/10043. It needs code rebase to include it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2954550640 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2947974423 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2942935054 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2942921080 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2942844047 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2942795830 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2938590933 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2938154450 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2918350293 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2915724094 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2915264115 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2865140530 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2862327386 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2838033351 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837827771 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837724160 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837643129 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837451105 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837351150 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837265005 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837260050 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837251513 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2837047547 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2834902597 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2834538431 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2834066513 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2833907231 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2833762912 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2833399204 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-7548][VL] Optimize BHJ in velox backend [incubator-gluten]
github-actions[bot] commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-2833306855 Run Gluten Clickhouse CI on x86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
