Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
CodiumAI-Agent commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2910893217 **[Persistent review](https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2892830613)** updated to latest commit https://github.com/apache/incubator-gluten/commit/5e445baf4cfbddf89edea055ec16c6daced289fd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
lgbo-ustc merged PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
CodiumAI-Agent commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2910868999 **[Persistent review](https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2892830613)** updated to latest commit https://github.com/apache/incubator-gluten/commit/419394ef2c0c20a2a0b794d9df0fb7f58fd2a465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
lgbo-ustc commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2910868171 @CodiumAI-Agent /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
lgbo-ustc commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2910854303 @CodiumAI-Agent /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
CodiumAI-Agent commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2909321863 **[Persistent review](https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2892830613)** updated to latest commit https://github.com/apache/incubator-gluten/commit/2b4b84acfac4ed8807addc511f12b272366d4ec6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
lgbo-ustc commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2909318380 Hi @zhztheplayer , could you review this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
CodiumAI-Agent commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2903617552 **[Persistent review](https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2892830613)** updated to latest commit https://github.com/apache/incubator-gluten/commit/e0b7dfcbb64e8e2dfd8eb4890f60bdd1d82a632e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
lgbo-ustc commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2903615041 @CodiumAI-Agent /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
CodiumAI-Agent commented on PR #9683:
URL:
https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2892830613
## PR Reviewer Guide 🔍
Here are some key observations to aid the review process:
**🎫 Ticket compliance analysis ✅**
**[9682](https://github.com/apache/incubator-gluten/issues/9682) - Fully
compliant**
Compliant requirements:
- Add `DoubleType` handling in `LogicalTypeConverter#toVLType`.
- Add `double` support in `FlinkRowToVLVectorConvertor.fromRowData`.
- Extend `toRowData` with `VectorGenericRowAccessor` for `double`.
- Provide unit tests covering `double` scanning.
⏱️ Estimated effort to review: 2
🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Missing
Import
The new `else if (logicalType instanceof VarCharType)` branch uses
`VarCharType` without importing it, which will cause a compilation error.
```java
else if (logicalType instanceof VarCharType) {
return new io.github.zhztheplayer.velox4j.type.VarCharType();
```
Formatting
Glitch
There is an extra space in `new
io.github.zhztheplayer.velox4j.type.DoubleType()` that violates code style
conventions.
```java
} else if (logicalType instanceof DoubleType) {
return new io.github.zhztheplayer.velox4j.type.DoubleType();
```
Null
Handling
The `double` branch always calls `setSafe` on `Float8Vector` without
handling nulls; confirm how to represent NULL values for `double`.
```java
} else if (fieldType instanceof DoubleType) {
Float8Vector doubleVector = new Float8Vector(rowType.getNames().get(i),
allocator);
doubleVector.setSafe(0, row.getDouble(i));
doubleVector.setValueCount(1);
arrowVectors.add(i, doubleVector);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
zhanglistar commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2892829282 @CodiumAI-Agent /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [GLUTEN-9682][Flink] Support double in vector-to-row conversion [incubator-gluten]
github-actions[bot] commented on PR #9683: URL: https://github.com/apache/incubator-gluten/pull/9683#issuecomment-2890093203 https://github.com/apache/incubator-gluten/issues/9682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
