Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
beliefer commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3471534405 @PHILO-HE @FelixYBW @wForget Thank you all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
FelixYBW merged PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
FelixYBW commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3471096223 > If this sounds good to you, I can help enable clang-tidy in another PR. It can also cover some other code styles checks. Thank you, @PHILO-HE good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
PHILO-HE commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3471093078 @FelixYBW, I feel that using sed command may cause unintentional replacement issue. I just investigated Velox. It uses clang-tidy to check code style based on a configuration file, where we can set to replace NULL with nullptr, see https://github.com/facebookincubator/velox/blob/8a5a520fba06ab1fc10f124f3eb000bab886cd5d/.clang-tidy#L102. If this sounds good to you, I can help enable clang-tidy in another PR. It can also cover some other code styles checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
FelixYBW commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3468994860 > @FelixYBW, it seems clang-format doesn't support the check for using nullptr. I mean to add a sed like `sed -i 's/NULL/nullptr/g'` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
FelixYBW commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3466384505 Can we add it to the https://github.com/apache/incubator-gluten/blob/main/dev/format-cpp-code.sh? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
beliefer commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3455525150 @wForget Thanks ! I think https://github.com/jemalloc/jemalloc/wiki/Use-Case%3A-Heap-Profiling just give us an use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL][MINOR] Replace NULL with nullptr [incubator-gluten]
wForget commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3455402370 The original code is referenced from https://github.com/jemalloc/jemalloc/wiki/Use-Case%3A-Heap-Profiling. If `NULL` and `nullptr` are equivalent, this change looks good to me. @PHILO-HE Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
