Re: [PR] [VL] Add page load time metric [incubator-gluten]
FelixYBW merged PR #10294: URL: https://github.com/apache/incubator-gluten/pull/10294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL] Add page load time metric [incubator-gluten]
FelixYBW commented on PR #10294: URL: https://github.com/apache/incubator-gluten/pull/10294#issuecomment-3430017636 @rui-mo can you rebase the PR since https://github.com/facebookincubator/velox/pull/14587 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL] Add page load time metric [incubator-gluten]
FelixYBW commented on PR #10294: URL: https://github.com/apache/incubator-gluten/pull/10294#issuecomment-3321682009 depends on https://github.com/facebookincubator/velox/pull/14587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL] Add page load time metric [incubator-gluten]
FelixYBW commented on PR #10294: URL: https://github.com/apache/incubator-gluten/pull/10294#issuecomment-3321618197 @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [VL] Add page load time metric [incubator-gluten]
FelixYBW commented on PR #10294: URL: https://github.com/apache/incubator-gluten/pull/10294#issuecomment-3321619459 @rui-mo can you split the PR and add the two metrics in adance? ```java "dataSourceAddSplitTime" -> SQLMetrics.createNanoTimingMetric( sparkContext, "data source add split time"), "dataSourceReadTime" -> SQLMetrics.createNanoTimingMetric( sparkContext, "data source read time"), ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
