[14/50] incubator-gobblin git commit: [GOBBLIN-401] Provide a constructor for CombineSelectionPolicy with only the selection config as argument[]

2018-03-21 Thread abti 
[GOBBLIN-401] Provide a constructor for CombineSelectionPolicy with only the 
selection config as argument[]

Closes #2275 from sv2000/gobblin-401


Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/8879cdec
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/8879cdec
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/8879cdec

Branch: refs/heads/0.12.0
Commit: 8879cdec2680e9e748d7e89f5cef5d72110c1c07
Parents: fd3a547
Author: suvasude 
Authored: Fri Feb 2 07:54:44 2018 -0800
Committer: Hung Tran 
Committed: Fri Feb 2 07:54:44 2018 -0800

--
 .../policy/CombineSelectionPolicy.java  | 24 
 1 file changed, 14 insertions(+), 10 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/8879cdec/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
--
diff --git 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
index b6377a0..c3c70f8 100644
--- 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
+++ 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
@@ -71,13 +71,17 @@ public class CombineSelectionPolicy implements 
VersionSelectionPolicy> selectionPolicies;
   private final CombineOperation combineOperation;
 
+  public CombineSelectionPolicy(Config config)
+  throws IOException {
+this(config, new Properties());
+  }
+
   public CombineSelectionPolicy(List> 
selectionPolicies,
   CombineOperation combineOperation) {
 this.combineOperation = combineOperation;
@@ -85,17 +89,18 @@ public class CombineSelectionPolicy implements 
VersionSelectionPolicy> builder = 
ImmutableList.builder();
 
 for (String combineClassName : 
config.getStringList(VERSION_SELECTION_POLICIES_PREFIX)) {
   try {
-builder.add((VersionSelectionPolicy) 
GobblinConstructorUtils.invokeFirstConstructor(
-Class.forName(combineClassName), ImmutableList. 
of(config), ImmutableList. of(jobProps)));
-  } catch (NoSuchMethodException | IllegalAccessException | 
InvocationTargetException | InstantiationException
-  | ClassNotFoundException e) {
+builder.add((VersionSelectionPolicy) 
GobblinConstructorUtils
+.invokeFirstConstructor(Class.forName(combineClassName), 
ImmutableList.of(config),
+ImmutableList.of(jobProps)));
+  } catch (NoSuchMethodException | IllegalAccessException | 
InvocationTargetException | InstantiationException | ClassNotFoundException e) {
 throw new IllegalArgumentException(e);
   }
 }
@@ -109,9 +114,9 @@ public class CombineSelectionPolicy implements 
VersionSelectionPolicy

incubator-gobblin git commit: [GOBBLIN-401] Provide a constructor for CombineSelectionPolicy with only the selection config as argument[]

2018-02-02 Thread hutran 
Repository: incubator-gobblin
Updated Branches:
  refs/heads/master fd3a547ec -> 8879cdec2


[GOBBLIN-401] Provide a constructor for CombineSelectionPolicy with only the 
selection config as argument[]

Closes #2275 from sv2000/gobblin-401


Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/8879cdec
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/8879cdec
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/8879cdec

Branch: refs/heads/master
Commit: 8879cdec2680e9e748d7e89f5cef5d72110c1c07
Parents: fd3a547
Author: suvasude 
Authored: Fri Feb 2 07:54:44 2018 -0800
Committer: Hung Tran 
Committed: Fri Feb 2 07:54:44 2018 -0800

--
 .../policy/CombineSelectionPolicy.java  | 24 
 1 file changed, 14 insertions(+), 10 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/8879cdec/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
--
diff --git 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
index b6377a0..c3c70f8 100644
--- 
a/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
+++ 
b/gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/CombineSelectionPolicy.java
@@ -71,13 +71,17 @@ public class CombineSelectionPolicy implements 
VersionSelectionPolicy> selectionPolicies;
   private final CombineOperation combineOperation;
 
+  public CombineSelectionPolicy(Config config)
+  throws IOException {
+this(config, new Properties());
+  }
+
   public CombineSelectionPolicy(List> 
selectionPolicies,
   CombineOperation combineOperation) {
 this.combineOperation = combineOperation;
@@ -85,17 +89,18 @@ public class CombineSelectionPolicy implements 
VersionSelectionPolicy> builder = 
ImmutableList.builder();
 
 for (String combineClassName : 
config.getStringList(VERSION_SELECTION_POLICIES_PREFIX)) {
   try {
-builder.add((VersionSelectionPolicy) 
GobblinConstructorUtils.invokeFirstConstructor(
-Class.forName(combineClassName), ImmutableList. 
of(config), ImmutableList. of(jobProps)));
-  } catch (NoSuchMethodException | IllegalAccessException | 
InvocationTargetException | InstantiationException
-  | ClassNotFoundException e) {
+builder.add((VersionSelectionPolicy) 
GobblinConstructorUtils
+.invokeFirstConstructor(Class.forName(combineClassName), 
ImmutableList.of(config),
+ImmutableList.of(jobProps)));
+  } catch (NoSuchMethodException | IllegalAccessException | 
InvocationTargetException | InstantiationException | ClassNotFoundException e) {
 throw new IllegalArgumentException(e);
   }
 }
@@ -109,9 +114,9 @@ public class CombineSelectionPolicy implements 
VersionSelectionPolicy