Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley merged PR #29:
URL: https://github.com/apache/grails-profiles/pull/29


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2067182665


##
rest-api/profile.yml:
##
@@ -8,43 +8,43 @@ features:
 build:
 plugins:
 - war
-- org.grails.grails-web
+- org.apache.grails.gradle.grails-web
 excludes:
-- org.grails.grails-core
+- org.apache.grails.gradle.grails-app
 dependencies:
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-actuator"
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-tomcat"
 - scope: implementation
-  coords: "org.grails:grails-plugin-url-mappings"
+  coords: "org.apache.grails:grails-url-mappings"
 - scope: implementation
-  coords: "org.grails:grails-plugin-rest"
+  coords: "org.apache.grails:grails-rest-transforms "
 - scope: implementation
-  coords: "org.grails:grails-plugin-codecs"
+  coords: "org.apache.grails:grails-codecs"
 - scope: implementation
-  coords: "org.grails:grails-plugin-interceptors"
+  coords: "org.apache.grails:grails-interceptors"
 - scope: implementation
-  coords: "org.grails:grails-plugin-services"
+  coords: "org.apache.grails:grails-services"
 - scope: implementation
-  coords: "org.grails:grails-plugin-datasource"
+  coords: "org.apache.grails:grails-datasource"
 - scope: implementation
-  coords: "org.grails:grails-plugin-databinding"
+  coords: "org.apache.grails:grails-databinding"
 - scope: implementation
-  coords: "org.grails:grails-web-boot"
+  coords: "org.apache.grails.web:grails-web-boot"
 - scope: implementation
-  coords: "org.grails:grails-logging"
+  coords: "org.apache.grails:grails-logging"
 - scope: implementation
-  coords: "org.grails.plugins:cache"
+  coords: "org.apache.grails:grails-cache"
 - scope: implementation
-  coords: "org.grails.plugins:async"
+  coords: "org.apache.grails:grails-async"
 - scope: testImplementation
   coords: "io.micronaut:micronaut-http-client"
 - scope: testImplementation
-  coords: "org.grails:grails-web-testing-support"
+  coords: "org.apache.grails:grails-testing-support-web"
 - scope: testImplementation
-  coords: "org.grails:grails-gorm-testing-support"
+  coords: "org.apache.grails:grails-testing-support-datamapping"
 - scope: testImplementation
-  coords: "org.grails:views-json-testing-support"
+  coords: "org.apache.grails: grails-testing-support-views-gson"

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2067182153


##
rest-api/profile.yml:
##
@@ -8,43 +8,43 @@ features:
 build:
 plugins:
 - war
-- org.grails.grails-web
+- org.apache.grails.gradle.grails-web
 excludes:
-- org.grails.grails-core
+- org.apache.grails.gradle.grails-app
 dependencies:
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-actuator"
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-tomcat"
 - scope: implementation
-  coords: "org.grails:grails-plugin-url-mappings"
+  coords: "org.apache.grails:grails-url-mappings"
 - scope: implementation
-  coords: "org.grails:grails-plugin-rest"
+  coords: "org.apache.grails:grails-rest-transforms "

Review Comment:
   Fixed in 3 locations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2067181135


##
build.gradle:
##
@@ -42,5 +44,4 @@ subprojects { Project subproject ->
 if ( subproject.name != "base" ) {

Review Comment:
   Updated



##
plugin/profile.yml:
##
@@ -3,9 +3,9 @@ build:
 plugins:
 - org.grails.grails-plugin
 excludes:
-- org.grails.grails-core
+- org.apache.grails.gradle.grails-app
 dependencies:
 - scope: implementation
-  coords: "org.grails:grails-core"
+  coords: "org.apache.grails.gradle:grails-app"

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2067181562


##
profile/skeleton/build.gradle:
##
@@ -2,26 +2,29 @@ buildscript {
 repositories {
 gradlePluginPortal()
 mavenCentral()
-maven { url "https://repo.grails.org/grails/core"; }
+maven { url = 'https://repository.apache.org/content/groups/snapshots' 
}
+maven { url = 'https://repo.grails.org/grails/core' }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+classpath "org.apache.grails:grails-gradle-plugins"
 }
 }
 
-apply plugin: "org.grails.grails-profile"
+apply plugin: "org.apache.grails.gradle.grails-profile"
 
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
 version '1.0.0-SNAPSHOT'

Review Comment:
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2067180892


##
build.gradle:
##
@@ -1,31 +1,33 @@
 buildscript {
 repositories {
 mavenCentral()
-maven { url "https://repo.grails.org/grails/core"; }
+maven { url = 'https://repository.apache.org/content/groups/snapshots' 
}
+maven { url = 'https://repo.grails.org/grails/core' }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+classpath "org.apache.grails:grails-gradle-plugins"
 classpath "org.apache.groovy:groovy-jmx"
+classpath "org.apache.grails:grails-shell-cli"
 }
 }
 
 allprojects {
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
 version project.projectVersion
 }
 
-
 subprojects { Project subproject ->

Review Comment:
   Removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2067179580


##
build.gradle:
##
@@ -1,31 +1,33 @@
 buildscript {
 repositories {
 mavenCentral()
-maven { url "https://repo.grails.org/grails/core"; }
+maven { url = 'https://repository.apache.org/content/groups/snapshots' 
}
+maven { url = 'https://repo.grails.org/grails/core' }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+classpath "org.apache.grails:grails-gradle-plugins"
 classpath "org.apache.groovy:groovy-jmx"
+classpath "org.apache.grails:grails-shell-cli"
 }
 }
 
 allprojects {
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
 version project.projectVersion

Review Comment:
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r206717


##
base/profile.yml:
##
@@ -29,8 +31,8 @@ dependencies:
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter"
 - scope: implementation
-  coords: "org.grails:grails-core"
+  coords: "org.apache.grails.gradle:grails-app"

Review Comment:
   Fixed.  Mixed that up with the plugin change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-29 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2067172003


##
.github/workflows/gradle.yml:
##
@@ -16,10 +16,10 @@ jobs:
   GRAILS_PUBLISH_RELEASE: 'false'
   WORKSPACE: ${{ github.workspace }}
   GRADLE_OPTS: -Xmx1500m -Dfile.encoding=UTF-8
-  GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
-  MAVEN_PUBLISH_USERNAME: ${{ secrets.MAVEN_PUBLISH_USERNAME }}
-  MAVEN_PUBLISH_PASSWORD: ${{ secrets.MAVEN_PUBLISH_PASSWORD }}
-  MAVEN_PUBLISH_URL: 'https://repo.grails.org/grails/libs-snapshots-local'
+  develocity-access-key: ${{ secrets.GRAILS_DEVELOCITY_ACCESS_KEY }}

Review Comment:
   Updated



##
.github/workflows/release.yml:
##


Review Comment:
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-20 Thread via GitHub


matrei commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2051646507


##
.github/workflows/gradle.yml:
##
@@ -16,10 +16,10 @@ jobs:
   GRAILS_PUBLISH_RELEASE: 'false'
   WORKSPACE: ${{ github.workspace }}
   GRADLE_OPTS: -Xmx1500m -Dfile.encoding=UTF-8
-  GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
-  MAVEN_PUBLISH_USERNAME: ${{ secrets.MAVEN_PUBLISH_USERNAME }}
-  MAVEN_PUBLISH_PASSWORD: ${{ secrets.MAVEN_PUBLISH_PASSWORD }}
-  MAVEN_PUBLISH_URL: 'https://repo.grails.org/grails/libs-snapshots-local'
+  develocity-access-key: ${{ secrets.GRAILS_DEVELOCITY_ACCESS_KEY }}

Review Comment:
   We should use a `setup-gradle` step and set `develocity-access-key`.



##
build.gradle:
##
@@ -1,31 +1,33 @@
 buildscript {
 repositories {
 mavenCentral()
-maven { url "https://repo.grails.org/grails/core"; }
+maven { url = 'https://repository.apache.org/content/groups/snapshots' 
}
+maven { url = 'https://repo.grails.org/grails/core' }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+classpath "org.apache.grails:grails-gradle-plugins"
 classpath "org.apache.groovy:groovy-jmx"
+classpath "org.apache.grails:grails-shell-cli"
 }
 }
 
 allprojects {
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
 version project.projectVersion

Review Comment:
   Use setter syntax?
   Do we need the project reference?



##
.github/workflows/release.yml:
##


Review Comment:
   There is still usage of `DEVELOCITY_ACCESS_KEY` (missing `GRAILS_`-prefix) 
in this file.



##
rest-api/profile.yml:
##
@@ -8,43 +8,43 @@ features:
 build:
 plugins:
 - war
-- org.grails.grails-web
+- org.apache.grails.gradle.grails-web
 excludes:
-- org.grails.grails-core
+- org.apache.grails.gradle.grails-app
 dependencies:
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-actuator"
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-tomcat"
 - scope: implementation
-  coords: "org.grails:grails-plugin-url-mappings"
+  coords: "org.apache.grails:grails-url-mappings"
 - scope: implementation
-  coords: "org.grails:grails-plugin-rest"
+  coords: "org.apache.grails:grails-rest-transforms "

Review Comment:
   Extra space at the end?



##
profile/skeleton/build.gradle:
##
@@ -2,26 +2,29 @@ buildscript {
 repositories {
 gradlePluginPortal()
 mavenCentral()
-maven { url "https://repo.grails.org/grails/core"; }
+maven { url = 'https://repository.apache.org/content/groups/snapshots' 
}
+maven { url = 'https://repo.grails.org/grails/core' }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+classpath "org.apache.grails:grails-gradle-plugins"
 }
 }
 
-apply plugin: "org.grails.grails-profile"
+apply plugin: "org.apache.grails.gradle.grails-profile"
 
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
 version '1.0.0-SNAPSHOT'

Review Comment:
   Use setter syntax?



##
web/profile.yml:
##
@@ -9,33 +9,33 @@ features:
 build:
 plugins:
 - war
-- org.grails.grails-web
+- org.apache.grails.gradle.grails-web
 excludes:
-- org.grails.grails-core
+- org.apache.grails.gradle.grails-app
 dependencies:
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-actuator"
 - scope: implementation
   coords: "org.springframework.boot:spring-boot-starter-tomcat"
 - scope: implementation
-  coords: "org.grails:grails-web-boot"
+  coords: "org.apache.grails.web:grails-web-boot"
 - scope: implementation
-  coords: "org.grails:grails-logging"
+  coords: "org.apache.grails:grails-logging"
 - scope: implementation
-  coords: "org.grails:grails-plugin-rest"
+  coords: "org.apache.grails:grails-rest-transforms "

Review Comment:
   Ending space?



##
plugin/profile.yml:
##
@@ -3,9 +3,9 @@ build:
 plugins:
 - org.grails.grails-plugin
 excludes:
-- org.grails.grails-core
+- org.apache.grails.gradle.grails-app
 dependencies:
 - scope: implementation
-  coords: "org.grails:grails-core"
+  coords: "org.apache.grails.gra

Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-19 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2051592014


##
profile/skeleton/build.gradle:
##
@@ -3,25 +3,27 @@ buildscript {
 gradlePluginPortal()
 mavenCentral()
 maven { url "https://repo.grails.org/grails/core"; }
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+classpath "org.apache.grails:grails-gradle-plugins"
 }
 }
 
-apply plugin: "org.grails.grails-profile"
+apply plugin: "org.apache.grails.gradle.grails-profile"
 
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
 version '1.0.0-SNAPSHOT'
 
 repositories {
 mavenCentral()
 maven { url "https://repo.grails.org/grails/core"; }
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }  
 
 dependencies {
-profileRuntimeOnly "org.grails.profiles:base:$baseProfileVersion"
+profileRuntimeOnly "org.apache.grails.profiles:base:$baseProfileVersion"

Review Comment:
   I applied grails-bom here so that  $baseProfileVersion could be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-19 Thread via GitHub


jdaugherty commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2051591983


##
build.gradle:
##
@@ -1,30 +1,32 @@
 buildscript {
 repositories {
 mavenCentral()
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 maven { url "https://repo.grails.org/grails/core"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")

Review Comment:
   The shell is in the non-gradle repos.  Why is the shell on the classpath of 
gradle? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-19 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2051590945


##
base/skeleton/build.gradle:
##
@@ -4,7 +4,7 @@ buildscript {
 mavenCentral()
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")

Review Comment:
   see https://github.com/apache/grails-profiles/pull/29#discussion_r2051590560 
which I think will apply to `build.gradle` in the skeleton.



##
profile/skeleton/build.gradle:
##
@@ -3,25 +3,27 @@ buildscript {
 gradlePluginPortal()
 mavenCentral()
 maven { url "https://repo.grails.org/grails/core"; }
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")

Review Comment:
   see https://github.com/apache/grails-profiles/pull/29#discussion_r2051590560 
which I think will apply to `build.gradle` in the skeleton.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-19 Thread via GitHub


jamesfredley commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2051590560


##
build.gradle:
##
@@ -1,30 +1,32 @@
 buildscript {
 repositories {
 mavenCentral()
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 maven { url "https://repo.grails.org/grails/core"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")

Review Comment:
   No luck here
   
   ```
   A problem occurred configuring root project 'grails-profiles'.
   > Could not resolve all artifacts for configuration 'classpath'.
  > Could not find org.apache.groovy:groovy-jmx:.
Required by:
root project :
  > Could not find org.apache.grails:grails-shell-cli:.
Required by:
root project :
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Apache maven coordinate changes and back to version 7.0.x [grails-profiles]

2025-04-18 Thread via GitHub


jdaugherty commented on code in PR #29:
URL: https://github.com/apache/grails-profiles/pull/29#discussion_r2051320748


##
base/skeleton/build.gradle:
##
@@ -4,7 +4,7 @@ buildscript {
 mavenCentral()
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")

Review Comment:
   this should be grails-gradle-bom



##
profile/skeleton/build.gradle:
##
@@ -3,25 +3,27 @@ buildscript {
 gradlePluginPortal()
 mavenCentral()
 maven { url "https://repo.grails.org/grails/core"; }
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")
+classpath "org.apache.grails:grails-gradle-plugins"
 }
 }
 
-apply plugin: "org.grails.grails-profile"
+apply plugin: "org.apache.grails.gradle.grails-profile"
 
-group 'org.grails.profiles'
+group 'org.apache.grails.profiles'
 version '1.0.0-SNAPSHOT'
 
 repositories {
 mavenCentral()
 maven { url "https://repo.grails.org/grails/core"; }
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }  
 
 dependencies {
-profileRuntimeOnly "org.grails.profiles:base:$baseProfileVersion"
+profileRuntimeOnly "org.apache.grails.profiles:base:$baseProfileVersion"

Review Comment:
   If this is in the bom, why hard code the version?



##
build.gradle:
##
@@ -1,30 +1,32 @@
 buildscript {
 repositories {
 mavenCentral()
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 maven { url "https://repo.grails.org/grails/core"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")

Review Comment:
   this should be the gradle bom



##
profile/skeleton/build.gradle:
##
@@ -3,25 +3,27 @@ buildscript {
 gradlePluginPortal()
 mavenCentral()
 maven { url "https://repo.grails.org/grails/core"; }
+maven { url "https://repository.apache.org/content/groups/snapshots/"; }
 // mavenLocal()  // for local testing, do not commit uncommented
 }
 dependencies {
-classpath platform("org.grails:grails-bom:$grailsVersion")
-classpath "org.grails:grails-gradle-plugin"
+classpath platform("org.apache.grails:grails-bom:$grailsVersion")

Review Comment:
   gradle bom



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]