Re: [PR] Buildscript Repository config consolidation for Tests [grails-core]
jdaugherty commented on PR #14720:
URL: https://github.com/apache/grails-core/pull/14720#issuecomment-2867295498
> The reason I submitted this PR was to consolidate the buildscript{}
repository configuration into a smaller number of locations. Given we were
already setting repositories{} under allprojects {}, I added it there. There
are a few conversations about adding repositories (gradle libs and spring
milestones) and that currently would require changes in a large number of
locations.
>
>
>
> I am wide open to thinking about other solutions. The gradle plugin e2e
tests also all currently include a repository list.
The e2e tests should not be consolidated since we are testing our gradle
plugin independently of Grails. The only dependency is groovy since we need to
compile source files. These files are constructed to test specific scenarios
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Buildscript Repository config consolidation for Tests [grails-core]
jamesfredley commented on code in PR #14720:
URL: https://github.com/apache/grails-core/pull/14720#discussion_r2082101255
##
build.gradle:
##
@@ -52,6 +52,16 @@ allprojects {
maven { url = 'https://repository.apache.org/content/groups/snapshots'
}
// mavenLocal() // Keep, this will be uncommented and used by CI
(groovy-joint-workflow)
}
+
+buildscript {
+repositories {
+mavenCentral()
+maven { url = 'https://repo.grails.org/grails/core' }
+maven { url =
'https://oss.sonatype.org/content/repositories/snapshots' }
+maven { url =
'https://repository.apache.org/content/groups/snapshots' }
Review Comment:
agreed
##
build.gradle:
##
@@ -52,6 +52,16 @@ allprojects {
maven { url = 'https://repository.apache.org/content/groups/snapshots'
}
Review Comment:
agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Buildscript Repository config consolidation for Tests [grails-core]
jamesfredley commented on PR #14720:
URL: https://github.com/apache/grails-core/pull/14720#issuecomment-2867281041
The reason I submitted this PR was to consolidate the buildscript{}
repository configuration into a smaller number of locations. Given we were
already setting repositories{} under allprojects {}, I added it there. There
are a few conversations about adding repositories (gradle libs and spring
milestones) and that currently would require changes in a large number of
locations.
I am wide open to thinking about other solutions. The gradle plugin e2e
tests also all currently include a repository list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Buildscript Repository config consolidation for Tests [grails-core]
matrei commented on code in PR #14720:
URL: https://github.com/apache/grails-core/pull/14720#discussion_r2081202131
##
build.gradle:
##
@@ -52,6 +52,16 @@ allprojects {
maven { url = 'https://repository.apache.org/content/groups/snapshots'
}
// mavenLocal() // Keep, this will be uncommented and used by CI
(groovy-joint-workflow)
}
+
+buildscript {
+repositories {
+mavenCentral()
+maven { url = 'https://repo.grails.org/grails/core' }
+maven { url =
'https://oss.sonatype.org/content/repositories/snapshots' }
+maven { url =
'https://repository.apache.org/content/groups/snapshots' }
Review Comment:
It think the Apache Snapshot repo will have to be defined below mavenLocal()
if the locally built Groovy Snapshot is to be used in the Groovy Joint Workflow.
##
build.gradle:
##
@@ -52,6 +52,16 @@ allprojects {
maven { url = 'https://repository.apache.org/content/groups/snapshots'
}
Review Comment:
It think the Apache Snapshot repo will have to be defined below mavenLocal()
if the locally built Groovy Snapshot is to be used in the Groovy Joint Workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Buildscript Repository config consolidation for Tests [grails-core]
jdaugherty commented on code in PR #14720:
URL: https://github.com/apache/grails-core/pull/14720#discussion_r2080429549
##
build.gradle:
##
@@ -52,6 +52,16 @@ allprojects {
maven { url = 'https://repository.apache.org/content/groups/snapshots'
}
// mavenLocal() // Keep, this will be uncommented and used by CI
(groovy-joint-workflow)
}
+
+buildscript {
+repositories {
+mavenCentral()
+maven { url = 'https://repo.grails.org/grails/core' }
Review Comment:
I do not agree with pulling into the entire repo grails org. we need to
know where our core dependencies come from and I intentionally had added the
expanded scope on test apps, while leaving the core code isolated. The intent
longer term is to adopt isolated builds for tests and thus we need to maintain
what others keep in their build files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
