Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
jamesfredley merged PR #14759: URL: https://github.com/apache/grails-core/pull/14759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
jamesfredley commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098813889
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
implementation project(':grails-gradle-model'), {
-exclude group: 'org.apache.groovy'
exclude group: 'org.spockframework'
Review Comment:
`exclude group: 'org.spockframework'` on `implementation
project(':grails-gradle-model')` does not appear to be needed any longer based
on the generated POM for grails-gradle-model. Pushing a commit that removes it
from two locations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
jamesfredley commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098806321
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
Review Comment:
I am adding an exclude on grails-gradle-plugins to limit any pollution. It
might be a good idea to experiment with them all using Groovy 4 prior to RC1,
but this will limit the scope of the change for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
jdaugherty commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098773242
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
implementation project(':grails-gradle-model'), {
-exclude group: 'org.apache.groovy'
exclude group: 'org.spockframework'
Review Comment:
(we need to confirm this exclude doesn't need moved to the plugins import of
this though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
jdaugherty commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098771647
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
Review Comment:
have you done a dependency check on the plugins project? we may need to
exclude this there to make sure there isn't pollution in the dependency graph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
jdaugherty commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098770301
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
implementation project(':grails-gradle-model'), {
-exclude group: 'org.apache.groovy'
exclude group: 'org.spockframework'
Review Comment:
this was originally because it used spock that was compatible with groovy 4
only and this code was from the plugins project which was including the 3
compatible version. I think the exclude can be removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
matrei commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098760941
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
implementation project(':grails-gradle-model'), {
-exclude group: 'org.apache.groovy'
exclude group: 'org.spockframework'
Review Comment:
Why are we excluding `spock` here?
Is `spock` a transitive dependency of `grails-gradle-model`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
Copilot commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098686701
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
Review Comment:
Consider adding a brief comment explaining that this update is intended to
align with Groovy 4 and that the version is managed via the BOM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Use groovy 4 for grails-gradle-tasks [grails-core]
Copilot commented on code in PR #14759:
URL: https://github.com/apache/grails-core/pull/14759#discussion_r2098686701
##
grails-gradle/tasks/build.gradle:
##
@@ -29,10 +29,9 @@ group = 'org.apache.grails'
dependencies {
implementation platform(project(':grails-gradle-bom'))
-implementation "org.codehaus.groovy:groovy"
+implementation
"org.apache.groovy:groovy:${bomDependencyVersions['groovy.version']}"
Review Comment:
Consider adding a brief comment explaining that this update is intended to
align with Groovy 4 and that the version is managed via the BOM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
